From: Victor Stinner <vstinner@python.org>
Date: Wed, 28 Apr 2021 13:47:10 +0000 (+0200)
Subject: bpo-43961: Fix test_logging.test_namer_rotator_inheritance() (GH-25684)
X-Git-Tag: v3.10.0b1~119
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fe52eb62191e640e720d184a9a1a04e965b8a062;p=thirdparty%2FPython%2Fcpython.git

bpo-43961: Fix test_logging.test_namer_rotator_inheritance() (GH-25684)

Fix test_logging.test_namer_rotator_inheritance() on Windows: use
os.replace() rather than os.rename().
---

diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index bb31e29ca769..1d061e4993ce 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -5219,7 +5219,7 @@ class RotatingFileHandlerTest(BaseFileTest):
 
             def rotator(self, source, dest):
                 if os.path.exists(source):
-                    os.rename(source, dest + ".rotated")
+                    os.replace(source, dest + ".rotated")
 
         rh = HandlerWithNamerAndRotator(
             self.fn, encoding="utf-8", backupCount=2, maxBytes=1)
diff --git a/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst b/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst
new file mode 100644
index 000000000000..e56572f51709
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst
@@ -0,0 +1,2 @@
+Fix test_logging.test_namer_rotator_inheritance() on Windows: use
+:func:`os.replace` rather than :func:`os.rename`. Patch by Victor Stinner.