From: Quanah Gibson-Mount <quanah@openldap.org>
Date: Wed, 20 Jan 2021 23:41:22 +0000 (+0000)
Subject: ITS#9440 - Don't set control to NULL before it's used for output.
X-Git-Tag: OPENLDAP_REL_ENG_2_5_1ALPHA~11^2~10
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fe7b161bb2a7fc8f03bf0aef4604e6b79c5cd6d8;p=thirdparty%2Fopenldap.git

ITS#9440 - Don't set control to NULL before it's used for output.
---

diff --git a/clients/tools/common.c b/clients/tools/common.c
index a22949720b..1395e69a4a 100644
--- a/clients/tools/common.c
+++ b/clients/tools/common.c
@@ -730,8 +730,6 @@ tool_args( int argc, char **argv )
 				}
 				unknown_ctrls = tmpctrls;
 				ctrl.ldctl_oid = control;
-				/* don't free it */
-				control = NULL;
 				ctrl.ldctl_value.bv_val = NULL;
 				ctrl.ldctl_value.bv_len = 0;
 				ctrl.ldctl_iscritical = crit;
@@ -758,6 +756,8 @@ tool_args( int argc, char **argv )
 					ctrl.ldctl_value = bv;
 				}
 
+				/* don't free it */
+				control = NULL;
 				unknown_ctrls[ unknown_ctrls_num ] = ctrl;
 				unknown_ctrls_num++;