From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 9 Feb 2009 03:13:05 +0000 (+0000)
Subject: Remove some deadcode and use tor_inet_aton uniformly.
X-Git-Tag: tor-0.2.1.12-alpha~4
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=fe987d3a1796c91bc6482874896c5912099d6d73;p=thirdparty%2Ftor.git

Remove some deadcode and use tor_inet_aton uniformly.

svn:r18422
---

diff --git a/src/common/compat.c b/src/common/compat.c
index ea8cbf97d8..fa6967289d 100644
--- a/src/common/compat.c
+++ b/src/common/compat.c
@@ -97,12 +97,6 @@
 #include "strlcat.c"
 #endif
 
-#ifndef INADDR_NONE
-/* This is used by inet_addr, but apparently Solaris doesn't define it
- * anyplace. */
-#define INADDR_NONE ((unsigned long) -1)
-#endif
-
 #ifdef HAVE_SYS_MMAN_H
 /** Try to create a memory mapping for <b>filename</b> and return it.  On
  * failure, return NULL.  Sets errno properly, using ERANGE to mean
@@ -1274,25 +1268,6 @@ tor_inet_aton(const char *str, struct in_addr* addr)
   if (d < 0 || d > 255) return 0;
   addr->s_addr = htonl((a<<24) | (b<<16) | (c<<8) | d);
   return 1;
-
-#if 0
-#ifdef HAVE_INET_ATON
-  return inet_aton(c, addr);
-#else
-  uint32_t r;
-  tor_assert(c);
-  tor_assert(addr);
-  if (strcmp(c, "255.255.255.255") == 0) {
-    addr->s_addr = 0xFFFFFFFFu;
-    return 1;
-  }
-  r = inet_addr(c);
-  if (r == INADDR_NONE)
-    return 0;
-  addr->s_addr = r;
-  return 1;
-#endif
-#endif
 }
 
 /** Given <b>af</b>==AF_INET and <b>src</b> a struct in_addr, or
diff --git a/src/or/eventdns.c b/src/or/eventdns.c
index 9ce4c392f7..6d19c01a29 100644
--- a/src/or/eventdns.c
+++ b/src/or/eventdns.c
@@ -355,20 +355,7 @@ error_is_eagain(int err)
 {
 	return err == EAGAIN || err == WSAEWOULDBLOCK;
 }
-static int
-inet_aton(const char *c, struct in_addr *addr)
-{
-	uint32_t r;
-	if (strcmp(c, "255.255.255.255") == 0) {
-		addr->s_addr = 0xffffffffu;
-	} else {
-		r = inet_addr(c);
-		if (r == INADDR_NONE)
-			return 0;
-		addr->s_addr = r;
-	}
-	return 1;
-}
+#define inet_aton(c, addr) tor_inet_aton((c), (addr))
 #define CLOSE_SOCKET(x) closesocket(x)
 #else
 #define last_error(sock) (errno)