From: terencez <texvnars@gmail.com>
Date: Wed, 9 Oct 2019 15:55:57 +0000 (+0800)
Subject: fix(reactivity): avoid triggering effect when deleting property returns false (#168)
X-Git-Tag: v3.0.0-alpha.0~540
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ff68db46ea6f6e693600bf24b22d9504fb82de03;p=thirdparty%2Fvuejs%2Fcore.git

fix(reactivity): avoid triggering effect when deleting property returns false (#168)
---

diff --git a/packages/reactivity/src/baseHandlers.ts b/packages/reactivity/src/baseHandlers.ts
index fe07600d9f..005cb3ddb8 100644
--- a/packages/reactivity/src/baseHandlers.ts
+++ b/packages/reactivity/src/baseHandlers.ts
@@ -70,7 +70,7 @@ function deleteProperty(target: any, key: string | symbol): boolean {
   const hadKey = hasOwn(target, key)
   const oldValue = target[key]
   const result = Reflect.deleteProperty(target, key)
-  if (hadKey) {
+  if (result && hadKey) {
     /* istanbul ignore else */
     if (__DEV__) {
       trigger(target, OperationTypes.DELETE, key, { oldValue })