From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Mon, 24 May 2021 20:49:56 +0000 (+0200)
Subject: systemctl: avoid crash when pattern expands to empty unit list
X-Git-Tag: v249-rc1~162
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=ffcd68385226d4b499dbff0123271e1d3fb8f516;p=thirdparty%2Fsystemd.git

systemctl: avoid crash when pattern expands to empty unit list

Fixes #19652.
---

diff --git a/src/systemctl/systemctl-edit.c b/src/systemctl/systemctl-edit.c
index 6e7c67ef2f2..87650850fe3 100644
--- a/src/systemctl/systemctl-edit.c
+++ b/src/systemctl/systemctl-edit.c
@@ -526,6 +526,8 @@ int edit(int argc, char *argv[], void *userdata) {
         r = expand_unit_names(bus, strv_skip(argv, 1), NULL, &names, NULL);
         if (r < 0)
                 return log_error_errno(r, "Failed to expand names: %m");
+        if (strv_isempty(names))
+                return log_error_errno(SYNTHETIC_ERRNO(ENOENT), "No units matched the specified patterns.");
 
         STRV_FOREACH(tmp, names) {
                 r = unit_is_masked(bus, &lp, *tmp);