From: Arvin Schnell <aschnell@suse.de>
Date: Fri, 23 Jan 2026 18:11:14 +0000 (+0100)
Subject: - added const
X-Git-Tag: v0.13.1~48^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1092%2Fhead;p=thirdparty%2Fsnapper.git

- added const
---

diff --git a/client/snbk/GlobalOptions.h b/client/snbk/GlobalOptions.h
index 6147c268..d72f42a5 100644
--- a/client/snbk/GlobalOptions.h
+++ b/client/snbk/GlobalOptions.h
@@ -50,7 +50,7 @@ namespace snapper
 	bool quiet() const { return _quiet; }
 	bool verbose() const { return _verbose; }
 	bool debug() const { return _debug; }
-	const boost::optional<BackupConfig::TargetMode>& target_mode() { return _target_mode; }
+	const boost::optional<BackupConfig::TargetMode>& target_mode() const { return _target_mode; }
 	bool automatic() const { return _automatic; }
 	bool utc() const { return _utc; }
 	bool iso() const { return _iso; }
diff --git a/client/snbk/cmd-delete.cc b/client/snbk/cmd-delete.cc
index e51ca7bb..84475cba 100644
--- a/client/snbk/cmd-delete.cc
+++ b/client/snbk/cmd-delete.cc
@@ -90,7 +90,7 @@ namespace snapper
 
 
     void
-    command_delete(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
+    command_delete(const GlobalOptions& global_options, GetOpts& get_opts, const BackupConfigs& backup_configs,
 		   ProxySnappers* snappers)
     {
 	SnapshotDelete snapshot_operation(global_options, get_opts, backup_configs,
diff --git a/client/snbk/cmd-list-configs.cc b/client/snbk/cmd-list-configs.cc
index 9106ee83..bdd6da55 100644
--- a/client/snbk/cmd-list-configs.cc
+++ b/client/snbk/cmd-list-configs.cc
@@ -279,7 +279,7 @@ namespace snapper
 
 
     void
-    command_list_configs(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
+    command_list_configs(const GlobalOptions& global_options, GetOpts& get_opts, const BackupConfigs& backup_configs,
 			 ProxySnappers* snappers)
     {
 	ParsedOpts opts = get_opts.parse("list-configs", GetOpts::no_options);
diff --git a/client/snbk/cmd-list.cc b/client/snbk/cmd-list.cc
index f6760f64..2923627e 100644
--- a/client/snbk/cmd-list.cc
+++ b/client/snbk/cmd-list.cc
@@ -354,7 +354,7 @@ namespace snapper
 
 
     void
-    command_list(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
+    command_list(const GlobalOptions& global_options, GetOpts& get_opts, const BackupConfigs& backup_configs,
 		 ProxySnappers* snappers)
     {
 	ParsedOpts opts = get_opts.parse("list", GetOpts::no_options);
diff --git a/client/snbk/cmd-restore.cc b/client/snbk/cmd-restore.cc
index 74452b77..ffb97e52 100644
--- a/client/snbk/cmd-restore.cc
+++ b/client/snbk/cmd-restore.cc
@@ -106,7 +106,7 @@ namespace snapper
 
     void
     command_restore(const GlobalOptions& global_options, GetOpts& get_opts,
-		    BackupConfigs& backup_configs, ProxySnappers* snappers)
+		    const BackupConfigs& backup_configs, ProxySnappers* snappers)
     {
 	SnapshotRestore snapshot_operation(global_options, get_opts, backup_configs,
 	                                   snappers);
diff --git a/client/snbk/cmd-transfer-and-delete.cc b/client/snbk/cmd-transfer-and-delete.cc
index 64927b9a..1b76f1c3 100644
--- a/client/snbk/cmd-transfer-and-delete.cc
+++ b/client/snbk/cmd-transfer-and-delete.cc
@@ -106,8 +106,8 @@ namespace snapper
 
 
     void
-    command_transfer_and_delete(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
-				ProxySnappers* snappers)
+    command_transfer_and_delete(const GlobalOptions& global_options, GetOpts& get_opts,
+				const BackupConfigs& backup_configs, ProxySnappers* snappers)
     {
 	SnapshotTransferAndDelete snapshot_operation(global_options, get_opts,
 	                                             backup_configs, snappers);
diff --git a/client/snbk/cmd-transfer.cc b/client/snbk/cmd-transfer.cc
index facd8a67..578c8a00 100644
--- a/client/snbk/cmd-transfer.cc
+++ b/client/snbk/cmd-transfer.cc
@@ -90,7 +90,7 @@ namespace snapper
 
 
     void
-    command_transfer(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
+    command_transfer(const GlobalOptions& global_options, GetOpts& get_opts, const BackupConfigs& backup_configs,
 		     ProxySnappers* snappers)
     {
 	SnapshotTransfer snapshot_operation(global_options, get_opts, backup_configs,
diff --git a/client/snbk/cmd-visualize.cc b/client/snbk/cmd-visualize.cc
index b3e6af66..16f2ba3f 100644
--- a/client/snbk/cmd-visualize.cc
+++ b/client/snbk/cmd-visualize.cc
@@ -79,7 +79,7 @@ namespace snapper
     }
 
     void command_visualize(const GlobalOptions& global_options, GetOpts& get_opts,
-                           BackupConfigs& backup_configs, ProxySnappers* snappers)
+                           const BackupConfigs& backup_configs, ProxySnappers* snappers)
     {
 	// Drawing a graph for multiple backup configs is not supported.
 	if (backup_configs.size() != 1)
@@ -88,7 +88,7 @@ namespace snapper
 	                                "command.")));
 	}
 
-	BackupConfig& backup_config = backup_configs.front();
+	const BackupConfig& backup_config = backup_configs.front();
 
 	// Check and parse arguments
 	const vector<Option> options = { Option("rankdir", required_argument, 'r') };
diff --git a/client/snbk/cmd.h b/client/snbk/cmd.h
index a4b0451a..9f6ae793 100644
--- a/client/snbk/cmd.h
+++ b/client/snbk/cmd.h
@@ -33,7 +33,7 @@ namespace snapper
     help_list_configs();
 
     void
-    command_list_configs(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
+    command_list_configs(const GlobalOptions& global_options, GetOpts& get_opts, const BackupConfigs& backup_configs,
 			 ProxySnappers* snappers);
 
 
@@ -41,7 +41,7 @@ namespace snapper
     help_list();
 
     void
-    command_list(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
+    command_list(const GlobalOptions& global_options, GetOpts& get_opts, const BackupConfigs& backup_configs,
 		 ProxySnappers* snappers);
 
 
@@ -49,7 +49,7 @@ namespace snapper
     help_transfer();
 
     void
-    command_transfer(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
+    command_transfer(const GlobalOptions& global_options, GetOpts& get_opts, const BackupConfigs& backup_configs,
 		     ProxySnappers* snappers);
 
 
@@ -57,7 +57,7 @@ namespace snapper
     help_restore();
 
     void
-    command_restore(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
+    command_restore(const GlobalOptions& global_options, GetOpts& get_opts, const BackupConfigs& backup_configs,
 		     ProxySnappers* snappers);
 
 
@@ -65,7 +65,7 @@ namespace snapper
     help_delete();
 
     void
-    command_delete(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
+    command_delete(const GlobalOptions& global_options, GetOpts& get_opts, const BackupConfigs& backup_configs,
 		   ProxySnappers* snappers);
 
 
@@ -73,13 +73,13 @@ namespace snapper
     help_transfer_and_delete();
 
     void
-    command_transfer_and_delete(const GlobalOptions& global_options, GetOpts& get_opts, BackupConfigs& backup_configs,
-				ProxySnappers* snappers);
+    command_transfer_and_delete(const GlobalOptions& global_options, GetOpts& get_opts,
+				const BackupConfigs& backup_configs, ProxySnappers* snappers);
 
 
     void help_visualize();
 
     void command_visualize(const GlobalOptions& global_options, GetOpts& get_opts,
-                           BackupConfigs& backup_configs, ProxySnappers* snappers);
+                           const BackupConfigs& backup_configs, ProxySnappers* snappers);
 
 }
diff --git a/client/snbk/snbk.cc b/client/snbk/snbk.cc
index 7a70f60f..423c9c93 100644
--- a/client/snbk/snbk.cc
+++ b/client/snbk/snbk.cc
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) [2024-2025] SUSE LLC
+ * Copyright (c) [2024-2026] SUSE LLC
  *
  * All Rights Reserved.
  *
@@ -42,10 +42,10 @@ using namespace snapper;
 
 struct Cmd
 {
-    typedef void (*cmd_func_t)(const GlobalOptions& global_options, GetOpts& get_opts,
-			       BackupConfigs& backup_configs, ProxySnappers* snappers);
+    using cmd_func_t = void (*)(const GlobalOptions& global_options, GetOpts& get_opts,
+				const BackupConfigs& backup_configs, ProxySnappers* snappers);
 
-    typedef void (*help_func_t)();
+    using help_func_t = void (*)();
 
     Cmd(const string& name, cmd_func_t cmd_func, help_func_t help_func, bool needs_snapper)
 	: name(name), cmd_func(cmd_func), help_func(help_func), needs_snapper(needs_snapper)
@@ -91,7 +91,7 @@ help(const vector<Cmd>& cmds, GetOpts& get_opts)
 
 
 vector<string>
-get_backup_configs(const GlobalOptions& global_options, const Cmd* cmd)
+get_backup_config_names(const GlobalOptions& global_options, const Cmd* cmd)
 {
     if (cmd->name == "list-configs")
 	return read_backup_config_names();
@@ -107,6 +107,29 @@ get_backup_configs(const GlobalOptions& global_options, const Cmd* cmd)
 }
 
 
+BackupConfigs
+get_backup_configs(const GlobalOptions& global_options, const vector<string>& names)
+{
+    BackupConfigs backup_configs;
+
+    for (const string& name : names)
+    {
+	BackupConfig backup_config(name);
+
+	if (global_options.target_mode() &&
+	    backup_config.target_mode != global_options.target_mode().value())
+	    continue;
+
+	if (global_options.automatic() && !backup_config.automatic)
+	    continue;
+
+	backup_configs.push_back(backup_config);
+    }
+
+    return backup_configs;
+}
+
+
 int
 main(int argc, char** argv)
 {
@@ -173,23 +196,8 @@ main(int argc, char** argv)
 
 	try
 	{
-	    const vector<string> names = get_backup_configs(global_options, &*cmd);
-
-	    BackupConfigs backup_configs;
-
-	    for (const string& name : names)
-	    {
-		BackupConfig backup_config(name);
-
-		if (global_options.target_mode() &&
-		    backup_config.target_mode != global_options.target_mode().value())
-		    continue;
-
-		if (global_options.automatic() && !backup_config.automatic)
-		    continue;
-
-		backup_configs.push_back(backup_config);
-	    }
+	    const vector<string> names = get_backup_config_names(global_options, &*cmd);
+	    const BackupConfigs backup_configs = get_backup_configs(global_options, names);
 
 	    unique_ptr<ProxySnappers> snappers;