From: Alexey Bogdanenko Date: Sat, 8 Dec 2018 08:02:30 +0000 (+0300) Subject: udev-test: fix test skip condition X-Git-Tag: v240~90^2~1 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F11098%2Fhead;p=thirdparty%2Fsystemd.git udev-test: fix test skip condition When there is a failure to setup the environment, the following happens: 1. Command "./test-udev check" exits with non-zero code. 2. Perl function "system" returns the code. 3. The code is evaluated as true by Perl. Then we stop the test. --- diff --git a/test/udev-test.pl b/test/udev-test.pl index aa38bae0b1c..3517feab155 100755 --- a/test/udev-test.pl +++ b/test/udev-test.pl @@ -1661,7 +1661,7 @@ if (!udev_setup()) { exit($EXIT_TEST_SKIP); } -if (!system($udev_bin, "check")) { +if (system($udev_bin, "check")) { warn "$udev_bin failed to set up the environment, skipping the test"; exit($EXIT_TEST_SKIP); }