From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Thu, 25 Apr 2019 08:41:59 +0000 (+0200)
Subject: network: drop "return 1" when the return value is ignored by all callers
X-Git-Tag: v243-rc1~508^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F12407%2Fhead;p=thirdparty%2Fsystemd.git

network: drop "return 1" when the return value is ignored by all callers

The reader is tricked into thinking that this has some meaning...
---

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index d3928e2862f..ec2190fd13c 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -3365,7 +3365,7 @@ static int link_initialized_and_synced(Link *link) {
         /* We may get called either from the asynchronous netlink callback,
          * or directly for link_add() if running in a container. See link_add(). */
         if (!IN_SET(link->state, LINK_STATE_PENDING, LINK_STATE_INITIALIZED))
-                return 1;
+                return 0;
 
         log_link_debug(link, "Link state is up-to-date");
         link_set_state(link, LINK_STATE_INITIALIZED);
@@ -3383,7 +3383,7 @@ static int link_initialized_and_synced(Link *link) {
                                 &link->mac, &network);
                 if (r == -ENOENT) {
                         link_enter_unmanaged(link);
-                        return 1;
+                        return 0;
                 } else if (r == 0 && network->unmanaged) {
                         link_enter_unmanaged(link);
                         return 0;
@@ -3420,7 +3420,7 @@ static int link_initialized_and_synced(Link *link) {
         if (r < 0)
                 return r;
 
-        return 1;
+        return 0;
 }
 
 static int link_initialized_handler(sd_netlink *rtnl, sd_netlink_message *m, Link *link) {