From: David Maciejak <david.maciejak@gmail.com>
Date: Sun, 8 Feb 2015 02:27:03 +0000 (+0800)
Subject: Fix Unit ID check
X-Git-Tag: suricata-2.1beta4~54
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1435%2Fhead;p=thirdparty%2Fsuricata.git

Fix Unit ID check
---

diff --git a/src/app-layer-modbus.c b/src/app-layer-modbus.c
index 873423184a..6442b821e9 100644
--- a/src/app-layer-modbus.c
+++ b/src/app-layer-modbus.c
@@ -451,8 +451,8 @@ static void ModbusCheckHeader(ModbusState       *modbus,
         ModbusSetEvent(modbus, MODBUS_DECODER_EVENT_INVALID_LENGTH);
 
     /* Check Unit Identifier field that is not in invalid range */
-    if ((header->length > MODBUS_MIN_INVALID_UNIT_ID)   &&
-        (header->length < MODBUS_MAX_INVALID_UNIT_ID)   )
+    if ((header->unitId > MODBUS_MIN_INVALID_UNIT_ID)   &&
+        (header->unitId < MODBUS_MAX_INVALID_UNIT_ID)   )
         ModbusSetEvent(modbus, MODBUS_DECODER_EVENT_INVALID_UNIT_IDENTIFIER);
 
     SCReturn;