From: Topi Miettinen <toiwoton@gmail.com>
Date: Wed, 18 Dec 2019 18:25:03 +0000 (+0200)
Subject: analyze: badness if neither of RootImage and RootDirectory exists
X-Git-Tag: v245-rc1~231^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F14382%2Fhead;p=thirdparty%2Fsystemd.git

analyze: badness if neither of RootImage and RootDirectory exists

Instead of requiring both RootImage and RootDirectory directives, give badness
points if neither is present. Fixes conversion in d737b451f.
---

diff --git a/src/analyze/analyze-security.c b/src/analyze/analyze-security.c
index 79b099a4093..20c14013900 100644
--- a/src/analyze/analyze-security.c
+++ b/src/analyze/analyze-security.c
@@ -306,7 +306,7 @@ static int assess_root_directory(
         assert(ret_description);
 
         *ret_badness =
-                empty_or_root(info->root_directory) ||
+                empty_or_root(info->root_directory) &&
                 empty_or_root(info->root_image);
         *ret_description = NULL;