From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 2 Apr 2020 14:38:27 +0000 (+0200)
Subject: string-util: make clear that split() + FOREACH_WORD() should die
X-Git-Tag: v246-rc1~658^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F15309%2Fhead;p=thirdparty%2Fsystemd.git

string-util: make clear that split() + FOREACH_WORD() should die
---

diff --git a/src/basic/string-util.h b/src/basic/string-util.h
index f98fbddddad..2a344b996f9 100644
--- a/src/basic/string-util.h
+++ b/src/basic/string-util.h
@@ -112,8 +112,10 @@ typedef enum SplitFlags {
         SPLIT_RELAX                      = 0x01 << 1,
 } SplitFlags;
 
+/* Smelly. Do not use this anymore. Use extract_first_word() instead! */
 const char* split(const char **state, size_t *l, const char *separator, SplitFlags flags);
 
+/* Similar, don't use this anymore */
 #define FOREACH_WORD(word, length, s, state)                            \
         _FOREACH_WORD(word, length, s, WHITESPACE, 0, state)