From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 14 Oct 2025 13:39:53 +0000 (+0200)
Subject: dnsdist: Fix a performance inefficiency reported by Coverity
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F16260%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Fix a performance inefficiency reported by Coverity

As CID 490492 (`AUTO_CAUSES_COPY`).

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dnsdistdist/dnsdist-lua.cc b/pdns/dnsdistdist/dnsdist-lua.cc
index 24af5ce78b..1099ac3f16 100644
--- a/pdns/dnsdistdist/dnsdist-lua.cc
+++ b/pdns/dnsdistdist/dnsdist-lua.cc
@@ -2074,7 +2074,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
 
   luaCtx.writeFunction("showPoolServerPolicy", [](const std::string& pool) {
     setLuaSideEffect();
-    auto poolObj = getPool(pool);
+    const auto& poolObj = getPool(pool);
     if (poolObj.policy == nullptr) {
       g_outputBuffer = dnsdist::configuration::getCurrentRuntimeConfiguration().d_lbPolicy->getName() + "\n";
     }