From: Miod Vallat <miod.vallat@powerdns.com>
Date: Mon, 27 Oct 2025 06:33:56 +0000 (+0100)
Subject: Be sure to not leak a socket if tcpConnectionHandler() throws.
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F16374%2Fhead;p=thirdparty%2Fpdns.git

Be sure to not leak a socket if tcpConnectionHandler() throws.

Fixes: #16365

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/pdns/dumresp.cc b/pdns/dumresp.cc
index 96565a025e..225d8f4c7d 100644
--- a/pdns/dumresp.cc
+++ b/pdns/dumresp.cc
@@ -100,6 +100,7 @@ try
 }
 catch(const std::exception& e) {
   cerr<<"TCP connection handler got an exception: "<<e.what()<<endl;
+  close(sock);
 }
 
 static void tcpAcceptor(const ComboAddress local)