From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Fri, 19 Feb 2021 08:50:09 +0000 (+0100)
Subject: xdg-autostart-generator: ignore DBusActivatable=true
X-Git-Tag: v248-rc1~36^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F18695%2Fhead;p=thirdparty%2Fsystemd.git

xdg-autostart-generator: ignore DBusActivatable=true

See https://wiki.gnome.org/HowDoI/DBusApplicationLaunching and
https://wiki.gnome.org/Initiatives/GnomeGoals/DBusActivatable for a description
of this key:
> Instead of the typical UNIX-style fork()/exec() approach to process creation,
> launching an application is done by sending a D-Bus message to the well-known
> name of that application, causing a D-Bus activation.
>
> Starting processes with D-Bus activation ensures that each application gets
> started in its own pristine environment, as a direct descendent of the
> session -- not in the environment of whatever its parent happened to be. This
> is important for ensuring the app ends up in the correct cgroup, for example.

So this motivation is not important for us: we launch stuff ourselves better.

This fixes warnings during boot:
systemd-xdg-autostart-generator[2274]: /etc/xdg/autostart/org.freedesktop.problems.applet.desktop:92: Unknown key name 'DBusActivatable' in section 'Desktop Entry', ignoring.
---

diff --git a/src/xdg-autostart-generator/xdg-autostart-service.c b/src/xdg-autostart-generator/xdg-autostart-service.c
index ffc09fa931e..1528432f433 100644
--- a/src/xdg-autostart-generator/xdg-autostart-service.c
+++ b/src/xdg-autostart-generator/xdg-autostart-service.c
@@ -336,6 +336,7 @@ XdgAutostartService *xdg_autostart_service_parse_desktop(const char *path) {
                 /* Common entries that we do not use currently. */
                 { "Desktop Entry", "Categories",                NULL, 0, NULL},
                 { "Desktop Entry", "Comment",                   NULL, 0, NULL},
+                { "Desktop Entry", "DBusActivatable",           NULL, 0, NULL},
                 { "Desktop Entry", "Encoding",                  NULL, 0, NULL},
                 { "Desktop Entry", "GenericName",               NULL, 0, NULL},
                 { "Desktop Entry", "Icon",                      NULL, 0, NULL},