From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 23 Feb 2021 14:43:19 +0000 (+0100)
Subject: core: fix memory leak in error path
X-Git-Tag: v248-rc2~1^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F18763%2Fhead;p=thirdparty%2Fsystemd.git

core: fix memory leak in error path

Coverity 1431998
---

diff --git a/src/core/execute.c b/src/core/execute.c
index d27adbbba54..e5c80fb183a 100644
--- a/src/core/execute.c
+++ b/src/core/execute.c
@@ -3202,11 +3202,16 @@ static int apply_mount_namespace(
 
         if (MANAGER_IS_SYSTEM(u->manager)) {
                 propagate_dir = path_join("/run/systemd/propagate/", u->id);
-                if (!propagate_dir)
-                        return -ENOMEM;
+                if (!propagate_dir) {
+                        r = -ENOMEM;
+                        goto finalize;
+                }
+
                 incoming_dir = strdup("/run/systemd/incoming");
-                if (!incoming_dir)
-                        return -ENOMEM;
+                if (!incoming_dir) {
+                        r = -ENOMEM;
+                        goto finalize;
+                }
         }
 
         r = setup_namespace(root_dir, root_image, context->root_image_options,