From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 26 Aug 2022 08:37:59 +0000 (+0200)
Subject: test: don't accept failure as succes
X-Git-Tag: v252-rc1~331^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F24457%2Fhead;p=thirdparty%2Fsystemd.git

test: don't accept failure as succes
---

diff --git a/src/test/test-condition.c b/src/test/test-condition.c
index 6cb889c8d69..882b376f6f2 100644
--- a/src/test/test-condition.c
+++ b/src/test/test-condition.c
@@ -362,13 +362,13 @@ TEST(condition_test_firmware_smbios_field) {
         expression = strjoina("smbios-field(bios_vendor =$ ", quote,  bios_vendor, quote, ")");
         condition = condition_new(CONDITION_FIRMWARE, expression, false, false);
         assert_se(condition);
-        assert_se(condition_test(condition, environ));
+        assert_se(condition_test(condition, environ) > 0);
         condition_free(condition);
 
         expression = strjoina("smbios-field(bios_vendor=$", quote, bios_vendor, quote, ")");
         condition = condition_new(CONDITION_FIRMWARE, expression, false, false);
         assert_se(condition);
-        assert_se(condition_test(condition, environ));
+        assert_se(condition_test(condition, environ) > 0);
         condition_free(condition);
 
         expression = strjoina("smbios-field(bios_vendor !=$ ", quote, bios_vendor, quote, ")");
@@ -386,7 +386,7 @@ TEST(condition_test_firmware_smbios_field) {
         expression = strjoina("smbios-field(bios_vendor =$ ", quote,  bios_vendor, "*", quote, ")");
         condition = condition_new(CONDITION_FIRMWARE, expression, false, false);
         assert_se(condition);
-        assert_se(condition_test(condition, environ));
+        assert_se(condition_test(condition, environ) > 0);
         condition_free(condition);
 
         /* Test version comparison with bios_version, if available */
@@ -402,7 +402,7 @@ TEST(condition_test_firmware_smbios_field) {
         expression = strjoina("smbios-field(bios_version = ", quote, bios_version, quote, ")");
         condition = condition_new(CONDITION_FIRMWARE, expression, false, false);
         assert_se(condition);
-        assert_se(condition_test(condition, environ));
+        assert_se(condition_test(condition, environ) > 0);
         condition_free(condition);
 
         expression = strjoina("smbios-field(bios_version != ", quote, bios_version, quote, ")");
@@ -414,19 +414,19 @@ TEST(condition_test_firmware_smbios_field) {
         expression = strjoina("smbios-field(bios_version <= ", quote, bios_version, quote, ")");
         condition = condition_new(CONDITION_FIRMWARE, expression, false, false);
         assert_se(condition);
-        assert_se(condition_test(condition, environ));
+        assert_se(condition_test(condition, environ) > 0);
         condition_free(condition);
 
         expression = strjoina("smbios-field(bios_version >= ", quote, bios_version, quote, ")");
         condition = condition_new(CONDITION_FIRMWARE, expression, false, false);
         assert_se(condition);
-        assert_se(condition_test(condition, environ));
+        assert_se(condition_test(condition, environ) > 0);
         condition_free(condition);
 
         expression = strjoina("smbios-field(bios_version < ", quote, bios_version, ".1", quote, ")");
         condition = condition_new(CONDITION_FIRMWARE, expression, false, false);
         assert_se(condition);
-        assert_se(condition_test(condition, environ));
+        assert_se(condition_test(condition, environ) > 0);
         condition_free(condition);
 
         expression = strjoina("smbios-field(bios_version > ", quote, bios_version, ".1", quote, ")");