From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Wed, 14 Sep 2022 02:48:16 +0000 (+0900)
Subject: dissect-image: lazily deactivate decrypted DM volumes
X-Git-Tag: v252-rc1~159
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F24667%2Fhead;p=thirdparty%2Fsystemd.git

dissect-image: lazily deactivate decrypted DM volumes

The DM block device may be still used by other processes.
---

diff --git a/src/shared/dissect-image.c b/src/shared/dissect-image.c
index 5eaff64f87f..5e4883a7a7c 100644
--- a/src/shared/dissect-image.c
+++ b/src/shared/dissect-image.c
@@ -1567,7 +1567,8 @@ DecryptedImage* decrypted_image_unref(DecryptedImage* d) {
                 DecryptedPartition *p = d->decrypted + i;
 
                 if (p->device && p->name && !p->relinquished) {
-                        r = sym_crypt_deactivate_by_name(p->device, p->name, 0);
+                        /* Let's deactivate lazily, as the dm volume may be already/still used by other processes. */
+                        r = sym_crypt_deactivate_by_name(p->device, p->name, CRYPT_DEACTIVATE_DEFERRED);
                         if (r < 0)
                                 log_debug_errno(r, "Failed to deactivate encrypted partition %s", p->name);
                 }