From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Thu, 16 Mar 2023 02:34:14 +0000 (+0900)
Subject: exec-util: introduce EXEC_DIR_SKIP_REMAINING flag
X-Git-Tag: v254-rc1~990^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F26861%2Fhead;p=thirdparty%2Fsystemd.git

exec-util: introduce EXEC_DIR_SKIP_REMAINING flag

Will be used in later commits.
---

diff --git a/src/shared/exec-util.c b/src/shared/exec-util.c
index 29f83818833..ac68cbc4cb1 100644
--- a/src/shared/exec-util.c
+++ b/src/shared/exec-util.c
@@ -30,6 +30,8 @@
 #include "terminal-util.h"
 #include "tmpfile-util.h"
 
+#define EXIT_SKIP_REMAINING 77
+
 /* Put this test here for a lack of better place */
 assert_cc(EAGAIN == EWOULDBLOCK);
 
@@ -145,11 +147,22 @@ static int do_execute(
                                 return log_oom();
                         t = NULL;
                 } else {
-                        r = wait_for_terminate_and_check(t, pid, WAIT_LOG);
+                        bool skip_remaining = false;
+
+                        r = wait_for_terminate_and_check(t, pid, WAIT_LOG_ABNORMAL);
                         if (r < 0)
                                 return r;
-                        if (!FLAGS_SET(flags, EXEC_DIR_IGNORE_ERRORS) && r > 0)
-                                return r;
+                        if (r > 0) {
+                                if (FLAGS_SET(flags, EXEC_DIR_SKIP_REMAINING) && r == EXIT_SKIP_REMAINING) {
+                                        log_info("%s succeeded with exit status %i, not executing remaining executables.", *path, r);
+                                        skip_remaining = true;
+                                } else if (FLAGS_SET(flags, EXEC_DIR_IGNORE_ERRORS))
+                                        log_warning("%s failed with exit status %i, ignoring.", *path, r);
+                                else {
+                                        log_error("%s failed with exit status %i.", *path, r);
+                                        return r;
+                                }
+                        }
 
                         if (callbacks) {
                                 if (lseek(fd, 0, SEEK_SET) < 0)
@@ -159,6 +172,9 @@ static int do_execute(
                                 if (r < 0)
                                         return log_error_errno(r, "Failed to process output from %s: %m", *path);
                         }
+
+                        if (skip_remaining)
+                                break;
                 }
         }
 
@@ -202,6 +218,8 @@ int execute_strv(
         pid_t executor_pid;
         int r;
 
+        assert(!FLAGS_SET(flags, EXEC_DIR_PARALLEL | EXEC_DIR_SKIP_REMAINING));
+
         if (strv_isempty(paths))
                 return 0;
 
diff --git a/src/shared/exec-util.h b/src/shared/exec-util.h
index a18c108e1bd..91dbe3f3b40 100644
--- a/src/shared/exec-util.h
+++ b/src/shared/exec-util.h
@@ -19,6 +19,7 @@ typedef enum {
         EXEC_DIR_PARALLEL             = 1 << 0, /* Execute scripts in parallel, if possible */
         EXEC_DIR_IGNORE_ERRORS        = 1 << 1, /* Ignore non-zero exit status of scripts */
         EXEC_DIR_SET_SYSTEMD_EXEC_PID = 1 << 2, /* Set $SYSTEMD_EXEC_PID environment variable */
+        EXEC_DIR_SKIP_REMAINING       = 1 << 3, /* Ignore remaining executions when one exit with 77. */
 } ExecDirFlags;
 
 typedef enum ExecCommandFlags {