From: Mike Yuan <me@yhndnzj.com>
Date: Thu, 4 Jan 2024 09:02:17 +0000 (+0800)
Subject: TEST-35-LOGIN: enable FileDescriptorStorePreserve= for coldplug test
X-Git-Tag: v256-rc1~1305^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F30610%2Fhead;p=thirdparty%2Fsystemd.git

TEST-35-LOGIN: enable FileDescriptorStorePreserve= for coldplug test
---

diff --git a/test/units/testsuite-35.sh b/test/units/testsuite-35.sh
index b250a5c18fb..8ea801ee96e 100755
--- a/test/units/testsuite-35.sh
+++ b/test/units/testsuite-35.sh
@@ -25,14 +25,22 @@ setup_test_user() {
     trap cleanup_test_user EXIT
 }
 
-test_enable_debug() {
-    mkdir -p /run/systemd/system/systemd-logind.service.d
-    cat >/run/systemd/system/systemd-logind.service.d/debug.conf <<EOF
+test_write_dropin() {
+    systemctl edit --runtime --stdin systemd-logind.service --drop-in=debug.conf <<EOF
 [Service]
 Environment=SYSTEMD_LOG_LEVEL=debug
 EOF
-    systemctl daemon-reload
-    systemctl stop systemd-logind.service
+
+    # We test "coldplug" (completely stop and start logind) here. So we need to preserve
+    # the fdstore, which might contain session leader pidfds. This is extremely rare use case
+    # and shall not be considered fully supported.
+    # See also: https://github.com/systemd/systemd/pull/30610#discussion_r1440507850
+    systemctl edit --runtime --stdin systemd-logind.service --drop-in=fdstore-preserve.conf <<EOF
+[Service]
+FileDescriptorStorePreserve=yes
+EOF
+
+    systemctl restart systemd-logind.service
 }
 
 testcase_properties() {
@@ -673,7 +681,7 @@ EOF
 }
 
 setup_test_user
-test_enable_debug
+test_write_dropin
 run_testcases
 
 touch /testok