From: Thierry Fournier <thierry.fournier@ozon.io>
Date: Sat, 7 Mar 2020 13:48:31 +0000 (+0100)
Subject: [Minor] Segfault for some configuration.
X-Git-Tag: 2.5~75^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F3292%2Fhead;p=thirdparty%2Frspamd.git

[Minor] Segfault for some configuration.

When the configuration file contains only these two lines, rspamd
try to send log which announce that it can bind the soket, but
"bind_conf" is NULL and it is dereferenced, so we have a segfault.

   worker "normal" {
   }

This patch fix the segfault.
---

diff --git a/src/rspamd.c b/src/rspamd.c
index 12f0cae2c7..dee990c419 100644
--- a/src/rspamd.c
+++ b/src/rspamd.c
@@ -706,8 +706,13 @@ spawn_workers (struct rspamd_main *rspamd_main, struct ev_loop *ev_base)
 					spawn_worker_type (rspamd_main, ev_base, cf);
 				}
 				else {
-					msg_err_main ("cannot create listen socket for %s at %s",
-							g_quark_to_string (cf->type), cf->bind_conf->name);
+					if (cf->bind_conf == NULL) {
+						msg_err_main ("cannot create listen socket for %s",
+								g_quark_to_string (cf->type));
+					} else {
+						msg_err_main ("cannot create listen socket for %s at %s",
+								g_quark_to_string (cf->type), cf->bind_conf->name);
+					}
 
 					rspamd_hard_terminate (rspamd_main);
 					g_assert_not_reached ();