From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Wed, 7 Aug 2024 18:48:09 +0000 (+0200)
Subject: crash-handler: Drop 10s sleep before we spawn the crash shell
X-Git-Tag: v257-rc1~721^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F33959%2Fhead;p=thirdparty%2Fsystemd.git

crash-handler: Drop 10s sleep before we spawn the crash shell

It pointlessly delays getting to the crash shell so let's drop the
10s sleep.
---

diff --git a/man/systemd.xml b/man/systemd.xml
index af3d57b6578..58e76eecb27 100644
--- a/man/systemd.xml
+++ b/man/systemd.xml
@@ -843,9 +843,8 @@
 
         <listitem><para>Takes a boolean argument or enables the option if specified
         without an argument. If enabled, the system manager (PID 1) spawns a shell
-        when it crashes, after a 10s delay. Otherwise, no shell is spawned. Defaults
-        to disabled, for security reasons, as the shell is not protected by password
-        authentication.</para>
+        when it crashes. Otherwise, no shell is spawned. Defaults to disabled, for
+        security reasons, as the shell is not protected by password authentication.</para>
 
         <xi:include href="version-info.xml" xpointer="v233"/></listitem>
       </varlistentry>
diff --git a/src/core/crash-handler.c b/src/core/crash-handler.c
index 26e59b92d25..a9425c07909 100644
--- a/src/core/crash-handler.c
+++ b/src/core/crash-handler.c
@@ -155,9 +155,6 @@ _noreturn_ static void crash(int sig, siginfo_t *siginfo, void *context) {
         (void) sigaction(SIGCHLD, &sa, NULL);
 
         if (arg_crash_shell) {
-                log_notice("Executing crash shell in 10s...");
-                (void) sleep(10);
-
                 pid = raw_clone(SIGCHLD);
                 if (pid < 0)
                         log_struct_errno(LOG_EMERG, errno,