From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Sat, 21 Dec 2024 16:34:04 +0000 (+0900)
Subject: varlink: invert uid check to reduce call of getuid()
X-Git-Tag: v258-rc1~1716^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F35733%2Fhead;p=thirdparty%2Fsystemd.git

varlink: invert uid check to reduce call of getuid()
---

diff --git a/src/shared/varlink-io.systemd.service.c b/src/shared/varlink-io.systemd.service.c
index 62cfc9b637e..06e32f9bf61 100644
--- a/src/shared/varlink-io.systemd.service.c
+++ b/src/shared/varlink-io.systemd.service.c
@@ -56,7 +56,7 @@ int varlink_method_set_log_level(sd_varlink *link, sd_json_variant *parameters,
         if (r < 0)
                 return r;
 
-        if (uid != getuid() && uid != 0)
+        if (uid != 0 && uid != getuid())
                 return sd_varlink_error(link, SD_VARLINK_ERROR_PERMISSION_DENIED, parameters);
 
         log_debug("Received io.systemd.service.SetLogLevel(%i)", level);