From: Luca Boccassi <luca.boccassi@gmail.com>
Date: Thu, 30 Jan 2025 01:19:59 +0000 (+0000)
Subject: ukify: do not fail if pefile complains about hardcoded 256MB limit
X-Git-Tag: v258-rc1~1389^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F36181%2Fhead;p=thirdparty%2Fsystemd.git

ukify: do not fail if pefile complains about hardcoded 256MB limit

pefile has an hardcoded limit to 256MB per section:

https://github.com/erocarrera/pefile/issues/396

When building an initrd with large firmware files and
lots of kernel modules, this limit can be reached.
Skip over those warnings.
---

diff --git a/src/ukify/ukify.py b/src/ukify/ukify.py
index af1b1b4a448..7a6ffd29956 100755
--- a/src/ukify/ukify.py
+++ b/src/ukify/ukify.py
@@ -953,8 +953,14 @@ def pe_add_sections(opts: UkifyConfig, uki: UKI, output: str) -> None:
     )
     pe = pefile.PE(data=pe.write(), fast_load=True)
 
+    # pefile has an hardcoded limit of 256MB, which is not enough when building an initrd with large firmware
+    # files and all kernel modules. See: https://github.com/erocarrera/pefile/issues/396
     warnings = pe.get_warnings()
-    if warnings:
+    for w in warnings:
+        if 'VirtualSize is extremely large' in w:
+            continue
+        if 'VirtualAddress is beyond' in w:
+            continue
         raise PEError(f'pefile warnings treated as errors: {warnings}')
 
     # When attaching signatures we are operating on an existing UKI which might be signed