From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Tue, 11 Mar 2025 21:46:36 +0000 (+0900)
Subject: hostname-setup: use strchr() to find wildcard character
X-Git-Tag: v258-rc1~1103^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F36707%2Fhead;p=thirdparty%2Fsystemd.git

hostname-setup: use strchr() to find wildcard character

Addresses https://github.com/systemd/systemd/pull/36647#discussion_r1990048751.
---

diff --git a/src/shared/hostname-setup.c b/src/shared/hostname-setup.c
index af89f92bdc4..33b6a05ad86 100644
--- a/src/shared/hostname-setup.c
+++ b/src/shared/hostname-setup.c
@@ -268,9 +268,10 @@ int hostname_substitute_wildcards(char *name) {
          * Note that this does not directly use the machine ID, because that's not necessarily supposed to be
          * public information to be broadcast on the network, while the hostname certainly is. */
 
-        for (char *n = name; *n; n++) {
-                if (*n != '?')
-                        continue;
+        for (char *n = name; ; n++) {
+                n = strchr(n, '?');
+                if (!n)
+                        return 0;
 
                 if (left_bits <= 0) {
                         if (sd_id128_is_null(mid)) {
@@ -293,8 +294,6 @@ int hostname_substitute_wildcards(char *name) {
                 h >>= 4;
                 left_bits -= 4;
         }
-
-        return 0;
 }
 
 char* get_default_hostname(void) {