From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Wed, 17 Sep 2025 07:45:47 +0000 (+0200)
Subject: efivars: drop unused "optimization"
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F38864%2Fhead;p=thirdparty%2Fsystemd.git

efivars: drop unused "optimization"

This was added in c242a082793df77a1dc0bce7f470660ab0a86fe5, and AFAICT, the
code was never exercised, not even in the tests. With this chunk gone, if
anyone ever calls the function without any output params, we'll do open + fstat
instead of access, which will work just fine too.
---

diff --git a/src/basic/efivars.c b/src/basic/efivars.c
index c30469d136f..86544d1de26 100644
--- a/src/basic/efivars.c
+++ b/src/basic/efivars.c
@@ -38,15 +38,6 @@ int efi_get_variable(
 
         const char *p = strjoina("/sys/firmware/efi/efivars/", variable);
 
-        if (!ret_value && !ret_size && !ret_attribute) {
-                /* If caller is not interested in anything, just check if the variable exists and is
-                 * readable. */
-                if (access(p, R_OK) < 0)
-                        return -errno;
-
-                return 0;
-        }
-
         if (DEBUG_LOGGING) {
                 log_debug("Reading EFI variable %s.", p);
                 begin = now(CLOCK_MONOTONIC);