From: sanjana <sanjana0796@gmail.com>
Date: Wed, 13 Feb 2019 06:08:00 +0000 (+0530)
Subject: Fixes: #4485 Adding setter to should_evaluate_none property
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F4496%2Fhead;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Fixes: #4485 Adding setter to should_evaluate_none property
---

diff --git a/lib/sqlalchemy/sql/sqltypes.py b/lib/sqlalchemy/sql/sqltypes.py
index 8798f5ad77..d23d696437 100644
--- a/lib/sqlalchemy/sql/sqltypes.py
+++ b/lib/sqlalchemy/sql/sqltypes.py
@@ -2216,6 +2216,10 @@ class JSON(Indexable, TypeEngine):
     def should_evaluate_none(self):
         return not self.none_as_null
 
+    @should_evaluate_none.setter
+    def should_evaluate_none(self, value):
+        self.none_as_null = value
+
     @util.memoized_property
     def _str_impl(self):
         return String(_expect_unicode=True)
diff --git a/test/sql/test_types.py b/test/sql/test_types.py
index dc75e1b14a..fdd3f594df 100644
--- a/test/sql/test_types.py
+++ b/test/sql/test_types.py
@@ -249,6 +249,9 @@ class AdaptTest(fixtures.TestBase):
                         or t1.__dict__[k] is None
                     )
 
+            eval_none = t1.should_evaluate_none
+            eq_(t1.evaluates_none().should_evaluate_none, not eval_none)
+
     def test_python_type(self):
         eq_(types.Integer().python_type, int)
         eq_(types.Numeric().python_type, decimal.Decimal)