From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 7 Dec 2016 18:03:22 +0000 (+0100)
Subject: core: add a note clarifying that we should be careful when adding new specifiers
X-Git-Tag: v233~339^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F4835%2Fhead;p=thirdparty%2Fsystemd.git

core: add a note clarifying that we should be careful when adding new specifiers
---

diff --git a/src/core/unit-printf.c b/src/core/unit-printf.c
index 8f7eb84c615..746e1a46efd 100644
--- a/src/core/unit-printf.c
+++ b/src/core/unit-printf.c
@@ -257,6 +257,10 @@ int unit_full_printf(Unit *u, const char *format, char **ret) {
          * %s: the shell of the running user
          *
          * %v: `uname -r` of the running system
+         *
+         * NOTICE: When you add new entries here, please be careful: specifiers which depend on settings of the unit
+         * file itself are broken by design, as they would resolve differently depending on whether they are used
+         * before or after the relevant configuration setting. Hence: don't add them.
          */
 
         const Specifier table[] = {