From: Zbigniew Jędrzejewski-Szmek Date: Tue, 21 Feb 2017 04:21:26 +0000 (-0500) Subject: test-env-util: add more tests for "extended syntax" X-Git-Tag: v233~59^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F5131%2Fhead;p=thirdparty%2Fsystemd.git test-env-util: add more tests for "extended syntax" This is only the tip of the iceberg. It would be great to test all kinds of nesting, handling of invalid syntax, etc., but I'm leaving that for later. --- diff --git a/src/test/test-env-util.c b/src/test/test-env-util.c index dfcd9cb7244..4f44cf87113 100644 --- a/src/test/test-env-util.c +++ b/src/test/test-env-util.c @@ -167,6 +167,34 @@ static void test_replace_env(bool braceless) { assert_se(streq(p, braceless ? "waldowaldowaldo" : "waldo$BAR$BAR")); } +static void test_replace_env2(bool extended) { + const char *env[] = { + "FOO=foo", + "BAR=bar", + NULL + }; + _cleanup_free_ char *t = NULL, *s = NULL, *q = NULL, *r = NULL, *p = NULL, *x = NULL; + unsigned flags = REPLACE_ENV_ALLOW_EXTENDED*extended; + + t = replace_env("FOO=${FOO:-${BAR}}", (char**) env, flags); + assert_se(streq(t, extended ? "FOO=foo" : "FOO=${FOO:-bar}")); + + s = replace_env("BAR=${XXX:-${BAR}}", (char**) env, flags); + assert_se(streq(s, extended ? "BAR=bar" : "BAR=${XXX:-bar}")); + + q = replace_env("XXX=${XXX:+${BAR}}", (char**) env, flags); + assert_se(streq(q, extended ? "XXX=" : "XXX=${XXX:+bar}")); + + r = replace_env("FOO=${FOO:+${BAR}}", (char**) env, flags); + assert_se(streq(r, extended ? "FOO=bar" : "FOO=${FOO:+bar}")); + + p = replace_env("FOO=${FOO:-${BAR}post}", (char**) env, flags); + assert_se(streq(p, extended ? "FOO=foo" : "FOO=${FOO:-barpost}")); + + x = replace_env("XXX=${XXX:+${BAR}post}", (char**) env, flags); + assert_se(streq(x, extended ? "XXX=" : "XXX=${XXX:+barpost}")); +} + static void test_replace_env_argv(void) { const char *env[] = { "FOO=BAR BAR", @@ -295,6 +323,8 @@ int main(int argc, char *argv[]) { test_env_strv_get_n(); test_replace_env(false); test_replace_env(true); + test_replace_env2(false); + test_replace_env2(true); test_replace_env_argv(); test_env_clean(); test_env_name_is_valid();