From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 28 Feb 2017 15:08:40 +0000 (+0100)
Subject: service: refuse using PID 1 as MAINPID for a service
X-Git-Tag: v233~15^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F5493%2Fhead;p=thirdparty%2Fsystemd.git

service: refuse using PID 1 as MAINPID for a service
---

diff --git a/src/core/service.c b/src/core/service.c
index 5bc8df3e1c1..74054887b94 100644
--- a/src/core/service.c
+++ b/src/core/service.c
@@ -3093,6 +3093,8 @@ static void service_notify_message(Unit *u, pid_t pid, char **tags, FDSet *fds)
                         log_unit_warning(u, "Failed to parse MAINPID= field in notification message: %s", e);
                 else if (pid == s->control_pid)
                         log_unit_warning(u, "A control process cannot also be the main process");
+                else if (pid == getpid() || pid == 1)
+                        log_unit_warning(u, "Service manager can't be main process, ignoring sd_notify() MAINPID= field");
                 else {
                         service_set_main_pid(s, pid);
                         unit_watch_pid(UNIT(s), pid);