From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Sat, 25 Nov 2017 10:11:57 +0000 (+0900)
Subject: firstboot: do not write vconsole.conf when arg_keymap is empty
X-Git-Tag: v236~117^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F7449%2Fhead;p=thirdparty%2Fsystemd.git

firstboot: do not write vconsole.conf when arg_keymap is empty
---

diff --git a/src/firstboot/firstboot.c b/src/firstboot/firstboot.c
index afbfa3743d6..207ddeb70f1 100644
--- a/src/firstboot/firstboot.c
+++ b/src/firstboot/firstboot.c
@@ -346,13 +346,15 @@ static int process_keymap(void) {
         if (r < 0)
                 return r;
 
-        if (!isempty(arg_keymap))
-                keymap = STRV_MAKE(strjoina("KEYMAP=", arg_keymap));
-
-        if (!keymap)
+        if (isempty(arg_keymap))
                 return 0;
 
-        mkdir_parents(etc_vconsoleconf, 0755);
+        keymap = STRV_MAKE(strjoina("KEYMAP=", arg_keymap));
+
+        r = mkdir_parents(etc_vconsoleconf, 0755);
+        if (r < 0)
+                return log_error_errno(r, "Failed to create the parent directory of %s: %m", etc_vconsoleconf);
+
         r = write_env_file(etc_vconsoleconf, keymap);
         if (r < 0)
                 return log_error_errno(r, "Failed to write %s: %m", etc_vconsoleconf);