From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Sat, 23 Dec 2017 10:16:49 +0000 (+0900)
Subject: load-fragment: simplify list insertion logic
X-Git-Tag: v237~183^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F7695%2Fhead;p=thirdparty%2Fsystemd.git

load-fragment: simplify list insertion logic

LIST_FIND_TAIL and LIST_INSERT_AFTER can work for empty list.
---

diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c
index e1e8333c8d2..f9c2acc53a9 100644
--- a/src/core/load-fragment.c
+++ b/src/core/load-fragment.c
@@ -434,11 +434,9 @@ int config_parse_socket_listen(const char *unit,
         p->n_auxiliary_fds = 0;
         p->socket = s;
 
-        if (s->ports) {
-                LIST_FIND_TAIL(port, s->ports, tail);
-                LIST_INSERT_AFTER(port, s->ports, tail, p);
-        } else
-                LIST_PREPEND(port, s->ports, p);
+        LIST_FIND_TAIL(port, s->ports, tail);
+        LIST_INSERT_AFTER(port, s->ports, tail, p);
+
         p = NULL;
 
         return 0;