]> git.ipfire.org Git - thirdparty/Python/cpython.git/log
thirdparty/Python/cpython.git
6 years ago[3.8] Update interpreter.rst (GH-17059) (GH-17060)
Jules Lasne (jlasne) [Tue, 5 Nov 2019 13:51:48 +0000 (14:51 +0100)] 
[3.8] Update interpreter.rst (GH-17059) (GH-17060)

Fixed what seemed to be a weird phrasing.

(cherry picked from commit 5e01a6542a1beb552a17e16b71dc0ba9fc6adcfb)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
6 years ago[3.8] bpo-38159: Clarify documentation of PyState_AddModule (GH-16101) (GH-17026)
Miss Islington (bot) [Tue, 5 Nov 2019 13:35:56 +0000 (05:35 -0800)] 
[3.8] bpo-38159: Clarify documentation of PyState_AddModule (GH-16101) (GH-17026)

This was never intented to be called manually from PyInit_*.

Also, clarify PyState_RemoveModule return value.
(cherry picked from commit 9bc94eca0c69a551f928692364a99e9b67c4a45b)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
https://bugs.python.org/issue38159

Automerge-Triggered-By: @encukou
6 years agoConvert argument to snake_case (GH-16990) (GH-17033)
Miss Islington (bot) [Tue, 5 Nov 2019 07:07:24 +0000 (23:07 -0800)] 
Convert argument to snake_case (GH-16990) (GH-17033)

(cherry picked from commit 99b7701978d1fdc81e10c31d1ad8cce2c0c2d848)

Co-authored-by: Борис Верховский <boris.verk@gmail.com>
6 years agocloses bpo-37633: Reëxport some function compatibility wrappers for macros in ``pytho...
Miss Islington (bot) [Tue, 5 Nov 2019 05:52:59 +0000 (21:52 -0800)] 
closes bpo-37633: Reëxport some function compatibility wrappers for macros in ``pythonrun.h``. (GH-17056)

(cherry picked from commit 62161ce989d7d4fe2b0e6899a54da20feeddc798)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
6 years agoFix a typo in wave module docstring (GH-17009)
Miss Islington (bot) [Tue, 5 Nov 2019 05:09:48 +0000 (21:09 -0800)] 
Fix a typo in wave module docstring (GH-17009)

s/pathing/patching/
(cherry picked from commit 25fa3ecb98f2c038a422b19c53641fa8e3ef8e52)

Co-authored-by: Michael Haas <micha2718l@gmail.com>
6 years agobpo-37759: Show output from var_access_benchmark (GH-17040) (GH-17041)
Miss Skeleton (bot) [Mon, 4 Nov 2019 05:55:22 +0000 (21:55 -0800)] 
bpo-37759:  Show output from var_access_benchmark (GH-17040) (GH-17041)

(cherry picked from commit 1cdadf414b9934bba9294efa1f4b8d97eef08434)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
6 years agobpo-38388: Document pickle protocol version 5 (GH-16639)
Miss Skeleton (bot) [Sun, 3 Nov 2019 12:03:16 +0000 (04:03 -0800)] 
bpo-38388: Document pickle protocol version 5 (GH-16639)

(cherry picked from commit d0e0f5bf0c07ca025f54df21fd1df55ee430d9fc)

Co-authored-by: Dima Tisnek <dimaqq@gmail.com>
6 years agobpo-38422: Clarify docstrings of pathlib suffix(es) (GH-16679)
Miss Skeleton (bot) [Sat, 2 Nov 2019 17:04:10 +0000 (10:04 -0700)] 
bpo-38422: Clarify docstrings of pathlib suffix(es) (GH-16679)

Whenever I use `path.suffix` I have to check again whether it includes the dot or not. I decided to add it to the docstring so I won't have to keep checking.

https://bugs.python.org/issue38422

Automerge-Triggered-By: @pitrou
(cherry picked from commit 8d4fef4ee2a318097f429cf6cbd4fb2e430bb9da)

Co-authored-by: Ram Rachum <ram@rachum.com>
6 years ago[3.8] Slightly improve plistlib test coverage. (GH-17025) (GH-17028)
Jon Janzen [Sat, 2 Nov 2019 14:48:22 +0000 (09:48 -0500)] 
[3.8] Slightly improve plistlib test coverage. (GH-17025) (GH-17028)

* Add missing test class (mistake in GH-4455)

* Increase coverage with 4 more test cases

* Rename neg_uid to huge_uid in test_modified_uid_huge

* Replace test_main() with unittest.main()

* Update plistlib docs.
(cherry picked from commit d0d9f7cfa36bafa4e1d9e73eb08835180d376df1)

Co-authored-by: Jon Janzen <jjjonjanzen@gmail.com>
6 years ago[3.8] bpo-16575: Add checks for unions passed by value to functions. (GH-16799) ...
Vinay Sajip [Thu, 31 Oct 2019 13:34:05 +0000 (13:34 +0000)] 
[3.8] bpo-16575: Add checks for unions passed by value to functions. (GH-16799) (GH-17016)

(cherry picked from commit 79d4ed102a5069c6cebaed2627cb1645637f0429)

6 years agoAdd docstring for shlex.split (GH-16740) (GH-17013)
Miss Skeleton (bot) [Thu, 31 Oct 2019 12:50:04 +0000 (05:50 -0700)] 
Add docstring for shlex.split (GH-16740) (GH-17013)

(cherry picked from commit 65c7382c47af07aea5c1ce86b76cf7f4b6acaaa2)

Co-authored-by: MaT1g3R <peijun.ma@protonmail.com>
6 years agoUpdate the URL for the requests package (GH-17006)
Miss Skeleton (bot) [Thu, 31 Oct 2019 12:12:23 +0000 (05:12 -0700)] 
Update the URL for the requests package (GH-17006)

Change the url from docs.python-requests.org to requests.readthedocs.io
(cherry picked from commit 112f2b805bc83429e8a66a54d088bbefc921abb7)

Co-authored-by: Simon Legner <Simon.Legner@gmail.com>
6 years ago[3.8] bpo-38600: NULL -> ``NULL``. (GH-17001) (GH-17003)
Serhiy Storchaka [Wed, 30 Oct 2019 20:44:55 +0000 (22:44 +0200)] 
[3.8] bpo-38600: NULL -> ``NULL``. (GH-17001) (GH-17003)

Also fix some other formatting.
(cherry picked from commit e835b31d2b212c3c7820364398979cae2a9740b2)

6 years ago[3.8] bpo-38600: Change the mark up of NULL in the C API documentation. (GH-16950...
Serhiy Storchaka [Wed, 30 Oct 2019 19:36:33 +0000 (21:36 +0200)] 
[3.8] bpo-38600: Change the mark up of NULL in the C API documentation. (GH-16950) (GH-16999)

Replace all *NULL* with ``NULL``.
(cherry picked from commit 25fc088607c855060ed142296dc1bd0125fad1af)

6 years agobpo-38640: Allow break and continue in always false while loops (GH-16992)
Miss Skeleton (bot) [Wed, 30 Oct 2019 12:11:41 +0000 (05:11 -0700)] 
bpo-38640: Allow break and continue in always false while loops (GH-16992)

(cherry picked from commit 6c3e66a34b95fff07df0ad5086104dd637a091ce)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
6 years agobpo-37330: open(): "U" mode is removed in Python 3.9 (GH-16972)
Victor Stinner [Tue, 29 Oct 2019 09:32:39 +0000 (10:32 +0100)] 
bpo-37330: open(): "U" mode is removed in Python 3.9 (GH-16972)

Update open() documentation.

6 years agobpo-36993: Improve error reporting for zipfiles with bad zip64 extra data. (GH-14656)
Miss Skeleton (bot) [Tue, 29 Oct 2019 07:44:07 +0000 (00:44 -0700)] 
bpo-36993: Improve error reporting for zipfiles with bad zip64 extra data. (GH-14656)

(cherry picked from commit da6ce58dd5ac109485af45878fca6bfd265b43e9)

Co-authored-by: Daniel Hillier <daniel.hillier@gmail.com>
6 years agoFix asyncio.wait() 3.8 whatsnew entry (GH-16975)
Miss Skeleton (bot) [Tue, 29 Oct 2019 02:00:26 +0000 (19:00 -0700)] 
Fix asyncio.wait() 3.8 whatsnew entry (GH-16975)

(cherry picked from commit 457306bddbc0021396504b7349fe0c322b65f7a7)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
6 years agobpo-38589: Fixes HTML Help shortcut when Windows is not installed to C drive (GH...
Miss Skeleton (bot) [Mon, 28 Oct 2019 21:55:10 +0000 (14:55 -0700)] 
bpo-38589: Fixes HTML Help shortcut when Windows is not installed to C drive (GH-16968)

(cherry picked from commit 0ac6137dd3d1e2c8f9558153ad63021f57e05e73)

Co-authored-by: Steve Dower <steve.dower@python.org>
6 years agobpo-38534: Replace wrong KB number references (GH-16955)
Miss Skeleton (bot) [Mon, 28 Oct 2019 18:15:24 +0000 (11:15 -0700)] 
bpo-38534: Replace wrong KB number references (GH-16955)

(cherry picked from commit 794616f837c254c68d8384ab48fb78123a3c8a8b)

Co-authored-by: benedwards14 <53377856+benedwards14@users.noreply.github.com>
6 years agobpo-38519: Internal include files missing on Windows (GH-16921)
Miss Skeleton (bot) [Mon, 28 Oct 2019 17:23:07 +0000 (10:23 -0700)] 
bpo-38519: Internal include files missing on Windows (GH-16921)

(cherry picked from commit edb172a87296d9359593a23cd9a09f5867ea1f0e)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
6 years agobpo-38592 Add pt-br switcher to Python Docs website (GH-16924) (GH-16953)
Miss Skeleton (bot) [Sun, 27 Oct 2019 10:11:14 +0000 (03:11 -0700)] 
bpo-38592 Add pt-br switcher to Python Docs website (GH-16924) (GH-16953)

(cherry picked from commit 85c6f8c65cd4f7219522c1f304bdfff19f785e7a)
Co-authored-by: Marco Rougeth <marco@rougeth.com>
6 years agobpo-38334: Fix seeking backward on an encrypted zipfile.ZipExtFile. (GH-16937)
Miss Skeleton (bot) [Sun, 27 Oct 2019 08:40:44 +0000 (01:40 -0700)] 
bpo-38334: Fix seeking backward on an encrypted zipfile.ZipExtFile. (GH-16937)

Test by Daniel Hillier.
(cherry picked from commit 5c32af7522d908e8c7da0243af37618433289cc5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
6 years ago[3.8] bpo-37309: First idlelib/NEWS.txt for 3.8.1 (GH-16947)
Terry Jan Reedy [Sun, 27 Oct 2019 05:25:27 +0000 (01:25 -0400)] 
[3.8] bpo-37309: First idlelib/NEWS.txt for 3.8.1 (GH-16947)

6 years agobpo-34162: Last idlelib/NEWS.txt items for 3.8.0. (GH-16943)
Miss Skeleton (bot) [Sun, 27 Oct 2019 02:37:25 +0000 (19:37 -0700)] 
bpo-34162: Last idlelib/NEWS.txt items for 3.8.0. (GH-16943)

(cherry picked from commit e31a79a5b44357b409d71949dc5308889970f9ab)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
6 years agobpo-38598: Do not try to compile IDLE shell or output windows (GH-16939)
Miss Skeleton (bot) [Sun, 27 Oct 2019 01:41:26 +0000 (18:41 -0700)] 
bpo-38598: Do not try to compile IDLE shell or output windows (GH-16939)

(cherry picked from commit e3f90b217a5152275b180b466bd503658a734462)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
6 years agobpo-38434: Fixes some audit event documentation (GH-16932)
Miss Skeleton (bot) [Sat, 26 Oct 2019 20:09:35 +0000 (13:09 -0700)] 
bpo-38434: Fixes some audit event documentation (GH-16932)

(cherry picked from commit 894e30ce0bcc1c509eb01c8ffa9ba6d7701aeaaf)

Co-authored-by: Steve Dower <steve.dower@python.org>
6 years agobpo-38557: Improve documentation for list and tuple C API. (GH-16925)
Miss Skeleton (bot) [Sat, 26 Oct 2019 20:06:34 +0000 (13:06 -0700)] 
bpo-38557: Improve documentation for list and tuple C API. (GH-16925)

(cherry picked from commit d898d20e8c228229eb68e545f544db13f246f216)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
6 years agobpo-38535: Fix positions for AST nodes for calls without arguments in decorators...
Miss Skeleton (bot) [Sat, 26 Oct 2019 14:06:40 +0000 (07:06 -0700)] 
bpo-38535: Fix positions for AST nodes for calls without arguments in decorators. (GH-16861)

(cherry picked from commit 26ae9f6d3d755734c9f371b9356325afe5764813)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
6 years agobpo-38558: Mention `:=` in conditions tutorial (GH-16919)
Miss Skeleton (bot) [Fri, 25 Oct 2019 22:27:07 +0000 (15:27 -0700)] 
bpo-38558: Mention `:=` in conditions tutorial (GH-16919)

(cherry picked from commit cb2cf06b0aad1851f54999497c1b50c381d1fdd8)

Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
6 years agoFix typo in formatter_unicode (GH-16831)
Miss Skeleton (bot) [Fri, 25 Oct 2019 17:03:23 +0000 (10:03 -0700)] 
Fix typo in formatter_unicode (GH-16831)

numbers's -> number's
(cherry picked from commit 7320ec05f72fc27b25789fe76f8297644e7e7e0a)

Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
6 years agobpo-33348: parse expressions after * and ** in lib2to3 (GH-6586)
Miss Skeleton (bot) [Thu, 24 Oct 2019 06:37:21 +0000 (23:37 -0700)] 
bpo-33348: parse expressions after * and ** in lib2to3 (GH-6586)

These are valid even in python 2.7

https://bugs.python.org/issue33348

Automerge-Triggered-By: @gpshead
(cherry picked from commit 96b06aefe23521b61e4e9cdd44f5d30b00c7eb95)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
6 years agoAdd missing asyncio changes from 3.8 whatsnew (GH-16911)
Miss Skeleton (bot) [Thu, 24 Oct 2019 04:22:06 +0000 (21:22 -0700)] 
Add missing asyncio changes from 3.8 whatsnew (GH-16911)

(cherry picked from commit 3bbb6db545eff73ba4031bd9b8f2ef71b84c906e)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
6 years agoUpdate URL in macOS installer copy of license (GH-16905)
Miss Skeleton (bot) [Wed, 23 Oct 2019 20:31:22 +0000 (13:31 -0700)] 
Update URL in macOS installer copy of license (GH-16905)

(cherry picked from commit 01659ca62c4508518478a74615ac91c0009427ad)

Co-authored-by: Ned Deily <nad@python.org>
6 years agobpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread (GH-16901)
Miss Skeleton (bot) [Wed, 23 Oct 2019 15:43:57 +0000 (08:43 -0700)] 
bpo-34679: ProactorEventLoop only uses set_wakeup_fd() in main thread (GH-16901)

bpo-34679, bpo-38563: asyncio.ProactorEventLoop.close() now only calls
signal.set_wakeup_fd() in the main thread.
(cherry picked from commit 1b53a24fb4417c764dd5933bce505f5c94249ca6)

Co-authored-by: Victor Stinner <vstinner@python.org>
6 years agoSpell Bitbucket correctly. (GH-16862) (GH-16898)
Miss Skeleton (bot) [Wed, 23 Oct 2019 12:18:10 +0000 (05:18 -0700)] 
Spell Bitbucket correctly. (GH-16862) (GH-16898)

(cherry picked from commit d34ac305327420bd68f05e201b63d2a665b073f8)

Co-authored-by: Peter Bittner <django@bittner.it>
6 years agobpo-38555: Fix an undefined behavior. (GH-16883)
Miss Skeleton (bot) [Wed, 23 Oct 2019 12:07:23 +0000 (05:07 -0700)] 
bpo-38555: Fix an undefined behavior. (GH-16883)

(cherry picked from commit 2e3d873d3bd0ef4708c4fa06b6cd6972574cb9af)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
6 years agoFix Zope URL (GH-16880)
Miss Skeleton (bot) [Tue, 22 Oct 2019 22:55:12 +0000 (15:55 -0700)] 
Fix Zope URL (GH-16880)

(cherry picked from commit dfe726b1ace03f206f45253b93ed7610473ae20f)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
6 years agobpo-38466: Fix threading.excepthook doc (GH-16891)
Miss Skeleton (bot) [Tue, 22 Oct 2019 20:44:45 +0000 (13:44 -0700)] 
bpo-38466: Fix threading.excepthook doc (GH-16891)

(cherry picked from commit 91528f40c30717563a478920861c81d18da5bf63)

Co-authored-by: Daniel Baskal <MagnificentUrukHai@users.noreply.github.com>
6 years agobpo-37415: Fix stdatomic.h header check for ICC compiler (GH-16717)
Miss Skeleton (bot) [Tue, 22 Oct 2019 20:19:32 +0000 (13:19 -0700)] 
bpo-37415: Fix stdatomic.h header check for ICC compiler (GH-16717)

Fix stdatomic.h header check for ICC compiler: the ICC implementation
lacks atomic_uintptr_t type which is needed by Python.

Test:

* atomic_int and atomic_uintptr_t types
* atomic_load_explicit() and atomic_store_explicit()
* memory_order_relaxed and memory_order_seq_cst constants

But don't test ATOMIC_VAR_INIT(): it's not used in Python.
(cherry picked from commit 028f7349a0f6eaea0fec31becb587fcdf6e3cb28)

Co-authored-by: Victor Stinner <vstinner@python.org>
6 years agobpo-31202: Preserve case of literal parts in Path.glob() on Windows. (GH-16860)
Miss Skeleton (bot) [Mon, 21 Oct 2019 18:17:57 +0000 (11:17 -0700)] 
bpo-31202: Preserve case of literal parts in Path.glob() on Windows. (GH-16860)

(cherry picked from commit 10ecbadb799ddf3393d1fc80119a3db14724d381)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
6 years agobpo-38540: Fix possible leak in PyArg_Parse for "esGH-" and "etGH-". (GH-16869)
Miss Skeleton (bot) [Mon, 21 Oct 2019 09:12:37 +0000 (02:12 -0700)] 
bpo-38540: Fix possible leak in PyArg_Parse for "esGH-" and "etGH-". (GH-16869)

(cherry picked from commit 5bc6a7c06eda20ba131ecba6752be0506d310181)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
6 years agobpo-38531: document extend action's added version (GH-16865) (GH-16868)
Miss Islington (bot) [Sun, 20 Oct 2019 20:25:25 +0000 (13:25 -0700)] 
bpo-38531: document extend action's added version (GH-16865) (GH-16868)

(cherry picked from commit 74142078b3b78fea7b4cd791e5c577c0c0964eb7)

Co-authored-by: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
6 years agobpo-37759: More updates to Whatsnew 3.8 (GH-16854) (GH-16867)
Miss Islington (bot) [Sun, 20 Oct 2019 18:35:28 +0000 (11:35 -0700)] 
bpo-37759: More updates to Whatsnew 3.8 (GH-16854) (GH-16867)

* math.perm() and math.comb()

* math.isqrt()

* Add singledispatchmethod()

* itertools.accumulate()

* Optional headers for xmlrpc.client.ServerProxy

* IDLE non-BMP characters

* import collections.abc directly

* @coroutine is deprecated

* pprint.pp()

* New options for object.__reduce__()

* DictReader no longer returns OrderedDicts

* "force" option for logging.basicConfig()

* Fix spelling

* cProfile context manager

* Various markup/grammar fixes from Kyle Stanley.
Other minor fixes as well.
Also, dedup the __reduce__ entry.

* Fix markup

* Fix grammar nits found by MS Word
(cherry picked from commit c93883c6afbd99929516764263fc49c3e996b10a)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
6 years agobpo-38525: Fix a segmentation fault when using reverse iterators of empty dict (GH...
Miss Islington (bot) [Sat, 19 Oct 2019 20:20:51 +0000 (13:20 -0700)] 
bpo-38525: Fix a segmentation fault when using reverse iterators of empty dict (GH-16846)

The reverse iterator for empty dictionaries was not handling correctly shared-key dictionaries.
(cherry picked from commit 24dc2f8c56697f9ee51a4887cf0814b6600c1815)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
6 years agoRemove doc reference to unmaitained Nose package (GH-16849)
Miss Islington (bot) [Sat, 19 Oct 2019 19:30:28 +0000 (12:30 -0700)] 
Remove doc reference to unmaitained Nose package (GH-16849)

The Nose package is no longer maintained.
(cherry picked from commit 88eeda6311a8e3bf57136da5f73c70bc91ad79f3)

Co-authored-by: Jon Dufresne <jon.dufresne@gmail.com>
6 years agobpo-38521: Fix error in NormalDist.__eq__() (GH-16840) (GH-16842)
Miss Islington (bot) [Fri, 18 Oct 2019 21:41:19 +0000 (14:41 -0700)] 
bpo-38521: Fix error in NormalDist.__eq__() (GH-16840) (GH-16842)

(cherry picked from commit 5eabec022b9a10734fcf58faad02c4d233592f64)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
6 years agobpo-38418: Fixes audit event for os.system to be named 'os.system' (GH-16670)
Miss Islington (bot) [Fri, 18 Oct 2019 16:32:14 +0000 (09:32 -0700)] 
bpo-38418: Fixes audit event for os.system to be named 'os.system' (GH-16670)

https://bugs.python.org/issue38418

Automerge-Triggered-By: @zooba
(cherry picked from commit fbe3c76c7ce1eec887d332d801d3784212cc0f73)

Co-authored-by: Steve Dower <steve.dower@python.org>
6 years ago[3.8] bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839)
Senthil Kumaran [Fri, 18 Oct 2019 15:23:14 +0000 (08:23 -0700)] 
[3.8] bpo-27657: Fix urlparse() with numeric paths (GH-661) (#16839)

* bpo-27657: Fix urlparse() with numeric paths

Revert parsing decision from bpo-754016 in favor of the documented
consensus in bpo-16932 of how to treat strings without a // to
designate the netloc.

* bpo-22891: Remove urlsplit() optimization for 'http' prefixed inputs.
(cherry picked from commit 5a88d50ff013a64fbdb25b877c87644a9034c969)

Co-authored-by: Tim Graham <timograham@gmail.com>
6 years agoFix minor typos in What's New in Python 3.8. (GH-16770)
Miss Islington (bot) [Fri, 18 Oct 2019 07:55:22 +0000 (00:55 -0700)] 
Fix minor typos in What's New in Python 3.8. (GH-16770)

Added periods at the end of the sentences.
(cherry picked from commit b1fa72a5b7e8666a40b6899d5d54778a2a42c3e8)

Co-authored-by: Jero Bado <tokidokitalkyou@gmail.com>
6 years agoDoc: Add missing entry for functools.cached_property (GH-16803)
Miss Islington (bot) [Fri, 18 Oct 2019 07:21:05 +0000 (00:21 -0700)] 
Doc: Add missing entry for functools.cached_property (GH-16803)

(cherry picked from commit 93b81e1fcbeb61c1b49ac2fa52c5a0dff929940b)

Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
6 years agobpo-33604: Raise TypeError on missing hmac arg. (GH-16805)
Miss Islington (bot) [Fri, 18 Oct 2019 03:48:42 +0000 (20:48 -0700)] 
bpo-33604: Raise TypeError on missing hmac arg. (GH-16805)

Also updates the documentation to clarify the situation surrounding
the digestmod parameter that is required despite its position in the
argument list as of 3.8.0 as well as removing old python2 era
references to "binary strings".

We indavertently had this raise ValueError in 3.8.0 for the missing
arg.  This is not considered an API change as no reasonable code would
be catching this missing argument error in order to handle it.
(cherry picked from commit f33c57d5c780da1500619f548585792bb5b750ee)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
6 years agobpo-38492: Remove pythonw.exe dependency on the Microsoft C++ runtime (GH-16824)
Miss Islington (bot) [Wed, 16 Oct 2019 17:46:29 +0000 (10:46 -0700)] 
bpo-38492: Remove pythonw.exe dependency on the Microsoft C++ runtime (GH-16824)

(cherry picked from commit 7aebbd1182bc818324656b2fb764679faf51fdff)

Co-authored-by: Steve Dower <steve.dower@python.org>
6 years agobpo-35998: Fix test_asyncio.test_start_tls_server_1() (GH-16815)
Miss Islington (bot) [Wed, 16 Oct 2019 08:36:57 +0000 (01:36 -0700)] 
bpo-35998: Fix test_asyncio.test_start_tls_server_1() (GH-16815)

main() is now responsible to send the ANSWER, rather than
ServerProto. main() now waits until it got the HELLO before sending
the ANSWER over the new transport.

Previously, there was a race condition between main() replacing the
protocol and the protocol sending the ANSWER once it gets the HELLO.

TLSv1.3 was disabled for the test: reenable it.
(cherry picked from commit fab4ef2df0857ab0c97f3058ac5ec3280c4eb891)

Co-authored-by: Victor Stinner <vstinner@python.org>
6 years agoUpdate doc switcher list for 3.8.0 (GH-16809)
Miss Islington (bot) [Tue, 15 Oct 2019 21:33:34 +0000 (14:33 -0700)] 
Update doc switcher list for 3.8.0 (GH-16809)

(cherry picked from commit 3f36043db22361500f52634f2b8de49dde0e7da9)

Co-authored-by: Ned Deily <nad@python.org>
6 years agoTypo fix - implemention should be implementation (GH-16806)
Miss Islington (bot) [Tue, 15 Oct 2019 21:09:19 +0000 (14:09 -0700)] 
Typo fix - implemention should be implementation (GH-16806)

(cherry picked from commit 2798b60c55619d8981288b69c20ba4a09efc7b0b)

Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
6 years agobpo-38478: Correctly handle keyword argument with same name as positional-only parame...
Miss Islington (bot) [Tue, 15 Oct 2019 12:02:34 +0000 (05:02 -0700)] 
bpo-38478: Correctly handle keyword argument with same name as positional-only parameter (GH-16800)

(cherry picked from commit f3ef06a7cb347ab7bd3cc2b0b3dcebe4f9ff36f9)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
6 years ago[3.8] bpo-36389: Backport debug enhancements from master (GH-16796)
Victor Stinner [Tue, 15 Oct 2019 01:06:16 +0000 (03:06 +0200)] 
[3.8] bpo-36389: Backport debug enhancements from master (GH-16796)

* bpo-36389: _PyObject_CheckConsistency() available in release mode (GH-16612)

bpo-36389, bpo-38376: The _PyObject_CheckConsistency() function is
now also available in release mode. For example, it can be used to
debug a crash in the visit_decref() function of the GC.

Modify the following functions to also work in release mode:

* _PyDict_CheckConsistency()
* _PyObject_CheckConsistency()
* _PyType_CheckConsistency()
* _PyUnicode_CheckConsistency()

Other changes:

* _PyMem_IsPtrFreed(ptr) now also returns 1 if ptr is NULL
  (equals to 0).
* _PyBytesWriter_CheckConsistency() now returns 1 and is only used
  with assert().
* Reorder _PyObject_Dump() to write safe fields first, and only
  attempt to render repr() at the end.

(cherry picked from commit 6876257eaabdb30f27ebcbd7d2557278ce2e5705)

* bpo-36389: Fix _PyBytesWriter in release mode (GH-16624)

Fix _PyBytesWriter API when Python is built in release mode with
assertions.

(cherry picked from commit 60ec6efd96d95476fe5e38c491491add04f026e5)

* bpo-38070: Enhance visit_decref() debug trace (GH-16631)

subtract_refs() now pass the parent object to visit_decref() which
pass it to _PyObject_ASSERT(). So if the "is freed" assertion fails,
the parent is used in debug trace, rather than the freed object. The
parent object is more likely to contain useful information. Freed
objects cannot be inspected are are displayed as "<object at xxx is
freed>" with no other detail.

(cherry picked from commit 4d5f94b8cd20f804c7868c5395a15aa6032f874c)

* Fix also a typo in PYMEM_DEADBYTE macro comment

* bpo-36389: Add newline to _PyObject_AssertFailed() (GH-16629)

Add a newline between the verbose object dump and the Py_FatalError()
logs for readability.

(cherry picked from commit 7775349895088a7ae68cecf0c74cf817f15e2c74)

6 years agobpo-38133: Update docs to reflect fixes to py.exe launcher (GH-16791)
Miss Islington (bot) [Mon, 14 Oct 2019 22:52:47 +0000 (15:52 -0700)] 
bpo-38133: Update docs to reflect fixes to py.exe launcher (GH-16791)

(cherry picked from commit 4d202281c128e2026e78fc5f4cc752b1dafbf3ad)

Co-authored-by: Steve Dower <steve.dower@python.org>
6 years agoDoc: 3.8 is now stable. (GH-16790)
Miss Islington (bot) [Mon, 14 Oct 2019 22:21:32 +0000 (15:21 -0700)] 
Doc: 3.8 is now stable. (GH-16790)

(cherry picked from commit 4504b4500d2a1a80c26b27b0bfff8b624d5ce06c)

Co-authored-by: Julien Palard <julien@palard.fr>
6 years ago[3.8] bpo-38456: Use /bin/true in test_subprocess (GH-16737)
Gregory P. Smith [Mon, 14 Oct 2019 20:40:32 +0000 (13:40 -0700)] 
[3.8] bpo-38456: Use /bin/true in test_subprocess (GH-16737)

* [3.8] bpo-38456: Use /bin/true in test_subprocess (GH-16736)

Instead of sys.executable, "-c", "pass" or "import sys; sys.exit(0)"
use /bin/true when it is available.  On a reasonable machine this
shaves up to two seconds wall time off the otherwise ~40sec execution
on a --with-pydebug build.  It should be more notable on many
buildbots or overloaded slower I/O systems (CI, etc)..
(cherry picked from commit 67b93f80c764bca01c81c989d74a99df208bea4d)

* Handle when there is no 'true' command

backport of 46113e0cf32748f66cf64cd633984d143b433cd1 by Pablo Galindo.

6 years agoPost v3.8.0
Łukasz Langa [Mon, 14 Oct 2019 20:02:48 +0000 (22:02 +0200)] 
Post v3.8.0

6 years agoMerge tag 'v3.8.0' into 3.8
Łukasz Langa [Mon, 14 Oct 2019 20:02:08 +0000 (22:02 +0200)] 
Merge tag 'v3.8.0' into 3.8

Python 3.8.0

6 years agoRemove draft status. Add asyncio REPL example (GH-16785) (GH-16786)
Miss Islington (bot) [Mon, 14 Oct 2019 16:08:30 +0000 (09:08 -0700)] 
Remove draft status.  Add asyncio REPL example (GH-16785) (GH-16786)

(cherry picked from commit 274bd013da707f9fb4a6f9e531fdc4288a9dd1ca)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
6 years agobpo-38453: Resolve test directories before chdir to them (GH-16723)
Miss Islington (bot) [Mon, 14 Oct 2019 16:01:29 +0000 (09:01 -0700)] 
bpo-38453: Resolve test directories before chdir to them (GH-16723)

(cherry picked from commit d83fc2702951f56a7339aa95d62414ed6e0fb40d)

Co-authored-by: Steve Dower <steve.dower@python.org>
6 years agov3.8.0 v3.8.0
Łukasz Langa [Mon, 14 Oct 2019 13:34:47 +0000 (15:34 +0200)] 
v3.8.0

6 years ago[3.8] bpo-37759: Polish What's New in Python 3.8. (GH-16769) (#16777)
Łukasz Langa [Mon, 14 Oct 2019 13:25:46 +0000 (15:25 +0200)] 
[3.8] bpo-37759: Polish What's New in Python 3.8. (GH-16769) (#16777)

(cherry picked from commit 298439ce3fb01de6c3110cc4847e6afe3253ba7a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
6 years agoMake 3.8 README link to 3.8 doc pages, not master (GH-16776)
Ned Deily [Mon, 14 Oct 2019 13:14:21 +0000 (09:14 -0400)] 
Make 3.8 README link to 3.8 doc pages, not master (GH-16776)

6 years agoUpdate build docs for macOS (GH-16771)
Miss Islington (bot) [Mon, 14 Oct 2019 12:35:28 +0000 (05:35 -0700)] 
Update build docs for macOS (GH-16771)

(cherry picked from commit 19d6842c15c145f65178f806048ac1a8ae7d05f6)

Co-authored-by: Ned Deily <nad@python.org>
6 years agobpo-38469: Handle named expression scope with global/nonlocal keywords (GH-16755...
Miss Islington (bot) [Mon, 14 Oct 2019 11:40:15 +0000 (04:40 -0700)] 
bpo-38469: Handle named expression scope with global/nonlocal keywords (GH-16755) (#16760)

The symbol table handing of PEP572's assignment expressions is not resolving correctly the scope of some variables in presence of global/nonlocal keywords in conjunction with comprehensions.
(cherry picked from commit fd5c414880b2e05720b9cf14ab0b0d7ae2b7d925)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
6 years ago[3.8] Update macOS installer display files for 3.8.0 (GH-16766)
Ned Deily [Mon, 14 Oct 2019 08:36:34 +0000 (04:36 -0400)] 
[3.8] Update macOS installer display files for 3.8.0 (GH-16766)

6 years agobpo-37759: Add examples for the new typing features (GH-16763) (GH-16764)
Miss Islington (bot) [Mon, 14 Oct 2019 06:45:45 +0000 (23:45 -0700)] 
bpo-37759: Add examples for the new typing features (GH-16763) (GH-16764)

(cherry picked from commit a3291531ea51455cfa5989119db496267425323c)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
6 years agobpo-38461 and bpo-38463: Minor fixes to Whatsnew 3.8 (GH-16761) (GH-16762)
Miss Islington (bot) [Mon, 14 Oct 2019 04:54:05 +0000 (21:54 -0700)] 
bpo-38461 and bpo-38463: Minor fixes to Whatsnew 3.8 (GH-16761) (GH-16762)

* bpo-38461: ncurses misspelled as curses

* bpo-38463: Fix broken link
(cherry picked from commit 61a6db5e79921b89b9e2a154990f01f5f3150213)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
6 years agoFix minor typos in Whatsnew (GH-16759)
Raymond Hettinger [Mon, 14 Oct 2019 03:35:11 +0000 (20:35 -0700)] 
Fix minor typos in Whatsnew (GH-16759)

6 years agobpo-38464: Document parameter for NormalDist.quantiles() (GH-16757) (GH-16758)
Miss Islington (bot) [Mon, 14 Oct 2019 03:04:29 +0000 (20:04 -0700)] 
bpo-38464: Document parameter for NormalDist.quantiles() (GH-16757) (GH-16758)

(cherry picked from commit 8a6cbf8adb68aa2c43a48769af92e50d5ca1539d)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
6 years agoFix strict-aliasing rules errors on gcc 4.8.5. (GH-16714)
Miss Islington (bot) [Mon, 14 Oct 2019 02:14:27 +0000 (19:14 -0700)] 
Fix strict-aliasing rules errors on gcc 4.8.5. (GH-16714)

(cherry picked from commit c39d1ddc012987e2159a997e27665d2d579c0ce0)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
6 years agoRebased version of what's new PR (GH-16745) (#16748)
Miss Islington (bot) [Sun, 13 Oct 2019 20:35:10 +0000 (13:35 -0700)] 
Rebased version of what's new PR (GH-16745) (#16748)

* Use Unicode character for accent
* Various grammar fixes
* Sort library modules alphabetically; remove duplicated idlelib/IDLE section
(cherry picked from commit bb78f6cfa6f2b84fa4611d39c35baf1c7dce7f8d)

Co-authored-by: Andrew Kuchling <amk@amk.ca>
6 years agobpo-38467: Fix argument name of typing functions (GH-16753)
Miss Islington (bot) [Sun, 13 Oct 2019 18:38:45 +0000 (11:38 -0700)] 
bpo-38467: Fix argument name of typing functions (GH-16753)

(cherry picked from commit fdfe2833ace93021278fe4c41c40e1d08d70abf9)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
6 years agobpo-28556: Remove another mention of metaclass of Generic in typing docs (GH-16743)
Miss Islington (bot) [Sun, 13 Oct 2019 17:00:19 +0000 (10:00 -0700)] 
bpo-28556: Remove another mention of metaclass of Generic in typing docs (GH-16743)

Metaclass was removed in Python 3.7 (there is already a `versionchanged` item about this).

https://bugs.python.org/issue28556
(cherry picked from commit 8144095707f87bdee6f3e1bbb15283ea61381be6)

Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
6 years agoCorrect signature of __build_class__ (GH-16735)
Miss Islington (bot) [Sun, 13 Oct 2019 15:53:54 +0000 (08:53 -0700)] 
Correct signature of __build_class__ (GH-16735)

(cherry picked from commit e3babbd03cd2bcb3c85deabae3bc6976aa95a3c3)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
6 years agobpo-38431: Fix __repr__ method of InitVar to work with typing objects. (GH-16702)
Miss Islington (bot) [Sun, 13 Oct 2019 12:04:05 +0000 (05:04 -0700)] 
bpo-38431: Fix __repr__ method of InitVar to work with typing objects. (GH-16702)

(cherry picked from commit 793cb85437299a3da3d74fe65480d720af330cbb)

Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
6 years agobpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POSIX_C_SOURCE...
Miss Islington (bot) [Sat, 12 Oct 2019 19:32:48 +0000 (12:32 -0700)] 
bpo-37731: Reorder includes in xmltok.c to avoid redefinition of _POSIX_C_SOURCE (GH-16733)

(cherry picked from commit 8177404d520e81f16324a900f093adf3856d33f8)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
6 years agoAnnounce the change in the CancelledError inheritance (GH-16730)
Miss Islington (bot) [Sat, 12 Oct 2019 17:53:32 +0000 (10:53 -0700)] 
Announce the change in the CancelledError inheritance (GH-16730)

This is a fairly noticeable change that requires adjustments in
existing asyncio code. It should therefore be announced.
(cherry picked from commit e634da27471a76f4abe685e86e6e302e0ed6b553)

Co-authored-by: Phil Jones <philip.graham.jones@googlemail.com>
6 years agobpo-38332: Catch KeyError from unknown cte in encoded-word. (GH-16503)
Miss Islington (bot) [Sat, 12 Oct 2019 17:03:24 +0000 (10:03 -0700)] 
bpo-38332: Catch KeyError from unknown cte in encoded-word. (GH-16503)

KeyError should cause a failure in parsing the encoded word and should be caught and raised as a _InvalidEWError instead.
(cherry picked from commit 65dcc8a8dc41d3453fd6b987073a5f1b30c5c0fd)

Co-authored-by: Andrei Troie <andreitroie90@gmail.com>
6 years ago[3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing...
Abhilash Raj [Sat, 12 Oct 2019 16:58:11 +0000 (09:58 -0700)] 
[3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs" (GH-16724) (GH-16728)

This reverts commit 87bd2071c756188b6cd577889fb1682831142ceb.

The reason for revert is a regression caused by the change in 3.8.0rc1, see bpo-38449 for more details.

https://bugs.python.org/issue38449
(cherry picked from commit 19a3d873005e5730eeabdc394c961e93f2ec02f0)

Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
6 years agobpo-38341: Add SMTPNotSupportedError in the exports of smtplib (GH-16525)
Miss Islington (bot) [Sat, 12 Oct 2019 16:08:24 +0000 (09:08 -0700)] 
bpo-38341: Add SMTPNotSupportedError in the exports of smtplib (GH-16525)

Add SMTPNotSupportedError in the exports of smtplib

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 3faf826e5879536d2272f1a51c58965a16827f81)

Co-authored-by: nde <denayer.norman@gmail.com>
6 years agoFix typo in the "Porting to Python 3.8" section. (GH-16435)
Miss Islington (bot) [Fri, 11 Oct 2019 21:09:44 +0000 (14:09 -0700)] 
Fix typo in the "Porting to Python 3.8" section. (GH-16435)

(cherry picked from commit dd6117c6d7859fee57751593cd56f0862131de8b)

Co-authored-by: bariod <35639254+bariod@users.noreply.github.com>
6 years agoUpdate badges in README.rst (GH-16709)
Zachary Ware [Fri, 11 Oct 2019 16:30:03 +0000 (11:30 -0500)] 
Update badges in README.rst (GH-16709)

We no longer use AppVeyor on 3.x, and others were still pointed at master.

6 years agobpo-38347: find pathfix for Python scripts whose name contain a '-' (GH-16536)
Miss Islington (bot) [Fri, 11 Oct 2019 13:56:49 +0000 (06:56 -0700)] 
bpo-38347: find pathfix for Python scripts whose name contain a '-' (GH-16536)

 pathfix.py: Assume all files that end on '.py' are Python scripts when working recursively.
(cherry picked from commit 2b7dc40b2af6578181808ba73c1533fc114e55df)

Co-authored-by: Ruediger Pluem <r.pluem@gmx.de>
6 years ago[3.8] Typo fix: "throuhgh" should be "through". (GH-16713)
Benjamin Peterson [Fri, 11 Oct 2019 04:02:38 +0000 (21:02 -0700)] 
[3.8] Typo fix: "throuhgh" should be "through". (GH-16713)

(cherry picked from commit a8e0d3141e271b3c0fbb7399a911f0c3aa567e30)

Co-authored-by: Hansraj Das <raj.das.136@gmail.com>
6 years agodocs: Add asyncio source code links (GH-16640)
Miss Islington (bot) [Thu, 10 Oct 2019 23:25:28 +0000 (16:25 -0700)] 
docs: Add asyncio source code links (GH-16640)

(cherry picked from commit f900064ac4b35226caad7502abc8a7e64f1c0e9d)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
6 years agoRe-enable the OverflowError test for test_truediv on test_complex (GH-16591)
Miss Islington (bot) [Thu, 10 Oct 2019 17:11:07 +0000 (10:11 -0700)] 
Re-enable the OverflowError test for test_truediv on test_complex (GH-16591)

(cherry picked from commit 1dbe5373851acb85ba91f0be7b83c69563acd68d)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
6 years agobpo-38109: Add missing constants to Lib/stat.py (GH-16665) (GH-16690)
Miss Islington (bot) [Thu, 10 Oct 2019 13:50:32 +0000 (06:50 -0700)] 
bpo-38109: Add missing constants to Lib/stat.py (GH-16665) (GH-16690)

Add missing stat.S_IFDOOR, stat.S_IFPORT, stat.S_IFWHT,
stat.S_ISDOOR, stat.S_ISPORT, and stat.S_ISWHT values to
the Python implementation of the stat module.
(cherry picked from commit 7bb14316b8ceddb813f31040a299af94a57ab339)

Co-authored-by: Ronan Lamy <ronan.lamy@gmail.com>
6 years agobpo-32996: Documentation fix-up. (GH-16646)
Miss Islington (bot) [Thu, 10 Oct 2019 11:19:03 +0000 (04:19 -0700)] 
bpo-32996: Documentation fix-up. (GH-16646)

PR GH-4906 changed the typing.Generic class hierarchy, leaving an
outdated comment in the library reference. User-defined Generic ABCs now
must get a abc.ABCMeta metaclass from something other than typing.Generic
inheritance.
(cherry picked from commit d47f0dd2e85ce032aebfedbde18cdb2e728fa79f)

Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>
6 years agobpo-38425: Fix ‘res’ may be used uninitialized warning (GH-16688)
Miss Islington (bot) [Thu, 10 Oct 2019 08:00:19 +0000 (01:00 -0700)] 
bpo-38425: Fix ‘res’ may be used uninitialized warning (GH-16688)

(cherry picked from commit a05fcd3c7adf6e3a0944da8cf80a3346882e9b3b)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
6 years agobpo-38409: Fix grammar in str.strip() docstring (GH-16682) (GH-16684)
Miss Islington (bot) [Wed, 9 Oct 2019 21:55:39 +0000 (14:55 -0700)] 
bpo-38409: Fix grammar in str.strip() docstring (GH-16682) (GH-16684)

(cherry picked from commit 09895c27cd8ff60563a794016e8c099bc897cc74)

6 years ago[3.8] bpo-38379: don't claim objects are collected when they aren't (GH-16658)...
Pablo Galindo [Wed, 9 Oct 2019 21:25:06 +0000 (22:25 +0100)] 
[3.8] bpo-38379:  don't claim objects are collected when they aren't  (GH-16658) (GH-16683)

* [bpo-38379](https://bugs.python.org/issue38379):  when a finalizer resurrects an object,
nothing is actually collected in this run of gc.
Change the stats to relect that truth.
(cherry picked from commit ecbf35f9335b0420cb8adfda6f299d6747a16515)

Co-authored-by: Tim Peters <tim.peters@gmail.com>
https://bugs.python.org/issue38379

Automerge-Triggered-By: @pablogsal
6 years agobpo-37531: regrtest ignores output on timeout (GH-16659)
Miss Islington (bot) [Wed, 9 Oct 2019 14:02:15 +0000 (07:02 -0700)] 
bpo-37531: regrtest ignores output on timeout (GH-16659)

bpo-37531, bpo-38207: On timeout, regrtest no longer attempts to call
`popen.communicate() again: it can hang until all child processes
using stdout and stderr pipes completes. Kill the worker process and
ignores its output.

Reenable test_regrtest.test_multiprocessing_timeout().

bpo-37531: Change also the faulthandler timeout of the main process
from 1 minute to 5 minutes, for Python slowest buildbots.
(cherry picked from commit 0ec618af98ac250a91ee9c91f8569e6df6772758)

Co-authored-by: Victor Stinner <vstinner@python.org>
6 years agobpo-38368: Added fix for ctypes crash when handling arrays in structs/unions. (GH...
Vinay Sajip [Wed, 9 Oct 2019 05:47:57 +0000 (06:47 +0100)] 
bpo-38368: Added fix for ctypes crash when handling arrays in structs/unions. (GH-16589) (GH-16671)

(cherry picked from commit e8bedbddadaa86be6bd86dc32dbdbd53933a4988)

6 years agoTypo fix: "empy" should be "empty". (GH-16666)
Miss Islington (bot) [Wed, 9 Oct 2019 02:42:22 +0000 (19:42 -0700)] 
Typo fix: "empy" should be "empty". (GH-16666)

(cherry picked from commit 01171ebd966b0cd6352057799ad876dd1e07942e)

Co-authored-by: Hansraj Das <raj.das.136@gmail.com>