]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/log
thirdparty/openembedded/openembedded-core-contrib.git
13 years agoknotty2: return exit code
Enrico Scholz [Sat, 19 May 2012 09:59:53 +0000 (11:59 +0200)] 
knotty2: return exit code

'bitbake -u knotty2' never failed which was caused by main() not
propagating the exit code.

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch: Spell out which fetcher backends support and recommend checksums
Richard Purdie [Tue, 15 May 2012 19:49:36 +0000 (19:49 +0000)] 
bitbake/fetch: Spell out which fetcher backends support and recommend checksums

There were some hardcoded behaviours in the system for which backends
support checksums verses which backends recommend them verses which
don't recommend them.

This moves the functionality into specific fetchers and then makes the
general code generic. This cleans up the codebase and fixes some corner
cases such as trying to checksum directories returned by the git fetcher.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch: If checksums are available, check them for any file, local or remote
Richard Purdie [Sun, 13 May 2012 12:31:01 +0000 (12:31 +0000)] 
bitbake/fetch: If checksums are available, check them for any file, local or remote

Currently, checksums are only checked for remote files. This changes
the check to apply to any file we have checksum data for. A mismatch
against a file is fatal but in the local case, no warnings are shown
about missing checksums.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2: Improve visibility of checksum warnings when fetching from mirrors
Richard Purdie [Sun, 13 May 2012 12:00:45 +0000 (12:00 +0000)] 
bitbake/fetch2: Improve visibility of checksum warnings when fetching from mirrors

When fetching from mirrors, checksum errors would get buried in the
logs. This raises their profile so a warning is logged on the console
when fetcher checksum issues are encountered, even if other attempts
are made to get the file (which may or may not have the same issue).

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2: Improve stamp creation in mirror code
Richard Purdie [Sun, 13 May 2012 07:40:42 +0000 (07:40 +0000)] 
bitbake/fetch2: Improve stamp creation in mirror code

Under certain contitions such as local file:// mirrors of all files,
bitbake might not check checksums. This is not desirable and we should
always check the checksum where possible.

This only exception to this is the git mirror tarball case where the
checksum is unknown but we need to create the .done stamp for other
reasons. This patch preserves thta functionality but in a more specific
section of code where this doesn't interfere in normal checksums.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2: Remove hardcoded file removal and use clean method
Richard Purdie [Sun, 13 May 2012 07:38:13 +0000 (07:38 +0000)] 
bitbake/fetch2: Remove hardcoded file removal and use clean method

Under certain circumstances, bitbake could remove files which were
outside its control since it unconditionally removes ud.localpath.
In the file:// case this can point at external paths.

This patch converts it to use the clean() method which will remove
files when its safe to do so but not in the file:// case since the
file:// handler has an empty clean method. This means bitbake no
longer removes files outside its control and is generally much safer.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agosetup.py: fix path for bitbake-selftest
Martin Jansa [Sat, 12 May 2012 06:57:47 +0000 (08:57 +0200)] 
setup.py: fix path for bitbake-selftest

* currently fails with:
  running build_scripts
  creating build/scripts-2.7
  copying and adjusting bin/bitbake -> build/scripts-2.7
  copying and adjusting bin/bitbake-layers -> build/scripts-2.7
  copying and adjusting bin/bitbake-diffsigs -> build/scripts-2.7
  copying and adjusting bin/bitbake-prserv -> build/scripts-2.7
  error: file '/tmp/tmpfs/portage/dev-embedded/bitbake-9999/work/bitbake-9999/bitbake-selftest' does not exist

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agolib/bb/siggen.py: ensure dumped signatures have group R/W
Joshua Lock [Sat, 12 May 2012 01:21:51 +0000 (18:21 -0700)] 
lib/bb/siggen.py: ensure dumped signatures have group R/W

We anticipate signatures being shared amongst peers in a group so ensure
they have rw-rw-r-- permissions to facilitate this.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agolib/bb/siggen: use open() rather than the file constructor
Joshua Lock [Sat, 12 May 2012 00:58:57 +0000 (17:58 -0700)] 
lib/bb/siggen: use open() rather than the file constructor

The Python documentation states:
 "When opening a file, it’s preferable to use open() instead of invoking
the file constructor directly." [1]

Further in Python 3 direct use of the file constructor is no longer
possible.

1. http://docs.python.org/library/functions.html#open

Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/tests: Add test of the git fetcher
Richard Purdie [Fri, 11 May 2012 17:16:01 +0000 (18:16 +0100)] 
bitbake/tests: Add test of the git fetcher

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2/git: Set a default for the GITDIR variable
Richard Purdie [Fri, 11 May 2012 17:15:16 +0000 (18:15 +0100)] 
bitbake/fetch2/git: Set a default for the GITDIR variable

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2/git: Don't set the branch name to None, that makes no sense
Richard Purdie [Fri, 11 May 2012 17:14:40 +0000 (18:14 +0100)] 
bitbake/fetch2/git: Don't set the branch name to None, that makes no sense

With floating revisions and no specified branch, the fetcher could fail
with some obtuse errors. This was due to the branch name being set to None
which makes no sense. This patch reworks some conditions to avoid this.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/runqueue: Drop check_stamp_fn, it's obsolete and should not be used
Richard Purdie [Thu, 10 May 2012 08:23:11 +0000 (09:23 +0100)] 
bitbake/runqueue: Drop check_stamp_fn, it's obsolete and should not be used

This function was used by old code such as packaged staging but is thankfully
obsolete now and replaced with better mechanisms. Its time to remove it and
the horrible internal only variables associated with it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/runqueue: Drop check_stamps function, it is obsolete and unused
Richard Purdie [Thu, 10 May 2012 08:22:22 +0000 (09:22 +0100)] 
bitbake/runqueue: Drop check_stamps function, it is obsolete and unused

This was originally used to check the consistency of the stamps in one function
call. This turns out to be inefficient, unnecessary and if it were necessary,
check_stamp_task() could be called in a loop. The function has been unmodified
for a while and likely contains bugs. Its best simply removed.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/runqueue: Fix 'full' stamp checking to be more efficient and cache results
Richard Purdie [Thu, 10 May 2012 08:21:41 +0000 (09:21 +0100)] 
bitbake/runqueue: Fix 'full' stamp checking to be more efficient and cache results

This should fix issues where bitbake would seemingly lock up when checking
certain configurations of stampfiles.

The cache is kept within the runqueue since that feels like the right
place to associate this cache data.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agorunqueue: drop unnecessary keys() in runqueue_process_waitpid
Christopher Larson [Wed, 9 May 2012 23:35:48 +0000 (18:35 -0500)] 
runqueue: drop unnecessary keys() in runqueue_process_waitpid

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agorunqueue: handle task exit due to signal/stop
Christopher Larson [Wed, 9 May 2012 23:32:20 +0000 (18:32 -0500)] 
runqueue: handle task exit due to signal/stop

- for a normal exit, use WEXITSTATUS, rather than manually shifting
- for exit via signal, set the exit code to 128+N, per shell convention
- if a process was stopped, return and don't handle it, as the process can yet
  be continued

This should fix the case where bitbake says a task failed with an exit code of
0 (we assumed failure based on the overall status, but didn't pass all the
information along to task_fail).

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: change the workflow about click 'Run Image' to run directly after builded a...
Liming An [Tue, 8 May 2012 11:48:08 +0000 (19:48 +0800)] 
Hob: change the workflow about click 'Run Image' to run directly after builded a qemu image

[YOCTO #2155]

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: add group number show and 'bold' visible effect for Package view
Liming An [Tue, 8 May 2012 11:48:07 +0000 (19:48 +0800)] 
Hob: add group number show and 'bold' visible effect for Package view

as ui design, add number of packages for each group, and make the
text font to 'bold' when row be selected

[YOCTO #2195]

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: add original url show function with the tooltip hyperlink for user
Liming An [Tue, 8 May 2012 11:48:06 +0000 (19:48 +0800)] 
Hob: add original url show function with the tooltip hyperlink for user

When case about No browser, such as running in 'Build Appliance', user can't open
the hyper link, so add this work around for user. (Checking the browser is avaiable
or not is hard by different system and browser type)

[YOCTO #2340]

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: change the refresh icon speed to make it view clear
Liming An [Tue, 8 May 2012 11:48:05 +0000 (19:48 +0800)] 
Hob: change the refresh icon speed to make it view clear

Because the arrow icon refresh so fast as the go backward by illusion, so adjust it slow.

[YOCTO #2335]

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Clear the building status if command failed
Dongxiao Xu [Mon, 7 May 2012 06:08:35 +0000 (14:08 +0800)] 
Hob: Clear the building status if command failed

We may meet certain command failure during build time, for example,
out of memory. In this case, we need to clear the "building" status.

This fixes [YOCTO #2371]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/tests/fetch: Add simple http fetcher tests
Richard Purdie [Fri, 4 May 2012 17:28:21 +0000 (18:28 +0100)] 
bitbake/tests/fetch: Add simple http fetcher tests

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2/wget: Add fallback/default wget commands
Richard Purdie [Fri, 4 May 2012 17:27:31 +0000 (18:27 +0100)] 
bitbake/fetch2/wget: Add fallback/default wget commands

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2/wget: Remove unneeded function indirection and reindent
Richard Purdie [Fri, 4 May 2012 17:26:40 +0000 (18:26 +0100)] 
bitbake/fetch2/wget: Remove unneeded function indirection and reindent

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2/wget: Remove unnecessary use of OVERRIDES
Richard Purdie [Fri, 4 May 2012 17:26:00 +0000 (18:26 +0100)] 
bitbake/fetch2/wget: Remove unnecessary use of OVERRIDES

This allows some simplifications of the function and is slightly faster.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2: When unpacking, only use PATH variable if its set
Richard Purdie [Fri, 4 May 2012 17:25:13 +0000 (18:25 +0100)] 
bitbake/fetch2: When unpacking, only use PATH variable if its set

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2: Remove WORKDIR reference, should use passed parameter
Richard Purdie [Fri, 4 May 2012 17:24:32 +0000 (18:24 +0100)] 
bitbake/fetch2: Remove WORKDIR reference, should use passed parameter

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/tests: Add missing __init__.py file
Richard Purdie [Fri, 4 May 2012 16:42:28 +0000 (17:42 +0100)] 
bitbake/tests: Add missing __init__.py file

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake: Add start of bitbake regression/self testing
Richard Purdie [Fri, 4 May 2012 15:18:55 +0000 (16:18 +0100)] 
bitbake: Add start of bitbake regression/self testing

This adds some basic unit testing for the codeparser and data store code. Many of
the actual test cases were taken from work by Chris Larson's OE-Signatures work but with
changes to adapt to the current bitbake APIs we need to test.

I also imported CoW tests written by Holger Freyther from the original bitbake-test
codebase: http://svn.berlios.de/wsvn/bitbake/trunk/bitbake-tests/tests/ and
some tests from the doctests that were removed in commit:
http://git.openembedded.org/bitbake/commit?id=3a11c2807972bbbddffde2fa67fc380d159da467

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/utils: Convert vercmp_string() to use vercmp internally
Richard Purdie [Fri, 4 May 2012 14:03:33 +0000 (15:03 +0100)] 
bitbake/utils: Convert vercmp_string() to use vercmp internally

Having two different version comparision algorithms in bitbake has never seemed
like a sensible idea. Worryingly, they also return different results to each other.

The vercmp_string API is relatively unused with no users in OE-Core or BitBake
itself for example. This patch converts it to use vercmp internalls, bringing
consitency to the comparisions which is easy now we have other recently added
functions. Yes, this changes behaviour but in this case I'd prefer we were
consistent than having two different comparisions.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake/fetch2: Fix spelling error in network access error message
Jeff Polk [Fri, 4 May 2012 14:05:15 +0000 (08:05 -0600)] 
bitbake/fetch2: Fix spelling error in network access error message

Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agofetch2/git: Allow file:// URLs without checking for network access
Jeff Polk [Fri, 4 May 2012 14:05:14 +0000 (08:05 -0600)] 
fetch2/git: Allow file:// URLs without checking for network access

Don't check for network access before grabbing the the current head,
cloning, or updating a clone when the protocol is 'file'.

Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoUpdate version to 1.15.2 (correspdoning to Yocto 1.2 release)
Richard Purdie [Tue, 1 May 2012 15:07:50 +0000 (16:07 +0100)] 
Update version to 1.15.2 (correspdoning to Yocto 1.2 release)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Issue sanity check after parse is completed
Dongxiao Xu [Tue, 24 Apr 2012 08:16:12 +0000 (16:16 +0800)] 
Hob: Issue sanity check after parse is completed

In original scheme, sanity check is part of the parsing process. If a
sanity check fails, it means the parsing is failed and values in Hob
GUI may not correct.

With this commit, Hob will actively issue sanity_check() after the
parsing is completed.

This fixes [YOCTO #2361]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Add proxy setting into setting's md5
Dongxiao Xu [Tue, 24 Apr 2012 08:16:11 +0000 (16:16 +0800)] 
Hob: Add proxy setting into setting's md5

If user changed the proxy setting, we will reparse configuration because
it may need sanity check.

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoevent.py: Add SanityCheck and SanityCheckPassed events
Dongxiao Xu [Tue, 24 Apr 2012 08:16:10 +0000 (16:16 +0800)] 
event.py: Add SanityCheck and SanityCheckPassed events

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agohob: enable sanity checks after launch
Joshua Lock [Mon, 23 Apr 2012 21:35:44 +0000 (14:35 -0700)] 
hob: enable sanity checks after launch

To ensure the users configuration is sanity tested enable the sanity
checks after the GUI has started but before any parsing is done.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agolib/bb/ui/crumbs/recipeselectionpage: fix type availabel->available
Joshua Lock [Tue, 17 Apr 2012 15:19:05 +0000 (08:19 -0700)] 
lib/bb/ui/crumbs/recipeselectionpage: fix type availabel->available

Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobitbake-layers: hide deprecation warnings
Paul Eggleton [Mon, 16 Apr 2012 22:31:58 +0000 (23:31 +0100)] 
bitbake-layers: hide deprecation warnings

There are a number of DeprecationWarnings within BitBake code which
bitbake itself filters out; bitbake-layers was not doing this, resulting
in a stream of warnings printed out when used with Python < 2.7 (these
warnings default to disabled on version 2.7 and above.)

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agohoblistmodel.py: description for selfcreated image
Beth Flanagan [Mon, 16 Apr 2012 23:13:08 +0000 (16:13 -0700)] 
hoblistmodel.py: description for selfcreated image

The current description is empty. This adds a default
description for hob's dummy_image.

Signed-off-by: Beth Flanagan <elizabeth.flanagan@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Set the "stop" button insensitive before hide it
Dongxiao Xu [Tue, 17 Apr 2012 08:21:39 +0000 (16:21 +0800)] 
Hob: Set the "stop" button insensitive before hide it

If user stops a build, we need to firstly set the button insensitive and
then hide it. This ensures the button's init status is "insensitive" in
next build.

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Enlarge the upper value of image size
Dongxiao Xu [Tue, 17 Apr 2012 08:21:38 +0000 (16:21 +0800)] 
Hob: Enlarge the upper value of image size

Originally the upper value for image size and extra size is 1024M, which
is relatively small. Enlarge it to 64GB.

Besides, fix tooltip for toolchain build.

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agodata_smart: Improve the calculation of config hash
Dongxiao Xu [Tue, 17 Apr 2012 08:21:37 +0000 (16:21 +0800)] 
data_smart: Improve the calculation of config hash

For config hash, we put the keys in structure of "set()", which is not
order sensitive. Therefore when calculating the md5 value for config
hash, we need to identify the order of the keys.

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: fixed a little view issue about package selection page
Liming An [Mon, 16 Apr 2012 10:09:48 +0000 (18:09 +0800)] 
Hob: fixed a little view issue about package selection page

In package selection page, treeview cell data callback function not cover the 'else' case, so parent item will render the pervious value.

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: add the parent window to 'binb' popup window for managing it
Liming An [Mon, 16 Apr 2012 08:53:28 +0000 (16:53 +0800)] 
Hob: add the parent window to 'binb' popup window for managing it

The 'binb' popup window should be "set transient for" the main application
window which they were spawned from.

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: fixed the issue that the notebook overlay-scrollbar is overlapped
Liming An [Mon, 16 Apr 2012 08:53:27 +0000 (16:53 +0800)] 
Hob: fixed the issue that the notebook overlay-scrollbar is overlapped

In those systems which had use gtk overlay-scrollbar feature,such as
Ubuntu 11.10, we have the issue with the multiple overlaped scrollbar in
'Recipe View' notebook or 'Package View' notebook, this patch is going to
fix it.

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Fix contents in imagedetailsscreen
Dongxiao Xu [Mon, 16 Apr 2012 07:51:43 +0000 (15:51 +0800)] 
Hob: Fix contents in imagedetailsscreen

This commit fixes the contents in imagedetailsscreen, which lacks some
kind of image types, e.x., iso and hddimg.

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: add exception handling
Shane Wang [Sun, 15 Apr 2012 16:09:25 +0000 (00:09 +0800)] 
Hob: add exception handling

Create a wrapper with exception handling to call self.server.runCommand() safely.
Again, add exception handling to load_template() and save_template()

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Simplify the init process
Dongxiao Xu [Sun, 15 Apr 2012 07:26:38 +0000 (15:26 +0800)] 
Hob: Simplify the init process

This commit merges some functionalities together and avoid unnecessary
signal handling. This can help to speed up the Hob startup.

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Handle NoProvider event in runningbuild module
Dongxiao Xu [Sun, 15 Apr 2012 07:26:37 +0000 (15:26 +0800)] 
Hob: Handle NoProvider event in runningbuild module

If NoProvider event is received, we will handle it in runningbuild
module and send notification to Hob instance, avoiding stepping into the
final page with no image built out.

This fixes [YOCTO #2249]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: reset user recipe selection and package selection after settings are changed
Shane Wang [Sat, 14 Apr 2012 18:58:59 +0000 (02:58 +0800)] 
Hob: reset user recipe selection and package selection after settings are changed

Reset user recipe list and package list after the user changes the settings and
triggers recipe reparsing.

This is to continue to fix the bug [Yocto #2255]

[Yocto #2255]

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: remember layers and settings between Hob sessions
Shane Wang [Sat, 14 Apr 2012 18:58:58 +0000 (02:58 +0800)] 
Hob: remember layers and settings between Hob sessions

This patch is to remember layers and settings between Hob sessions, which
includes:
 - Put some variables for the build details screen from Configuration to
   Parameters because they are not actually for build but for show
 - We create a dummy Configuration instance and a dummy Parameters instance
   in __init__ of builder
 - The two instances will be assigned the real values by
   update_configuration_parameters() after parsing (in the event callback)
 - When it is the first time to launch Hob in a build directory, nothing is
   remembered since everything is fresh.
 - The feature is implemented with templates, and based on the hook for Hob.
 - When the user changes the layers or the settings, a default template file
   is saved into ".hob/".
 - Later on, the layers and the settings are remembered by loading the default
   template automatically.

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Use BB_DEFAULT_TASK as build task instead of hardcoded "build"
Dongxiao Xu [Thu, 12 Apr 2012 17:14:14 +0000 (01:14 +0800)] 
Hob: Use BB_DEFAULT_TASK as build task instead of hardcoded "build"

Originally we use hardcoded "build" as the default task. This commit
fixes it by using BB_DEFAULT_TASK.

This fixes [YOCTO #2283]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
13 years agoHob: Build selected image if not customized
Dongxiao Xu [Thu, 12 Apr 2012 17:04:50 +0000 (01:04 +0800)] 
Hob: Build selected image if not customized

If user selected a base image and didn't customize it, Hob will still
build the selected image instead of hob-image.

This fixes [YOCTO #2253]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
13 years agoHob: Save the original image name into template
Dongxiao Xu [Fri, 13 Apr 2012 13:51:36 +0000 (21:51 +0800)] 
Hob: Save the original image name into template

Previously we use the template file name as the image name. This commit
changes to use the original selected image into template file.

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
13 years agoHob: A minor fix on tooltip
Richard Purdie [Thu, 12 Apr 2012 09:30:27 +0000 (17:30 +0800)] 
Hob: A minor fix on tooltip

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
13 years agoHob: Added required packages for toolchain.
Lianhao Lu [Fri, 13 Apr 2012 08:37:18 +0000 (16:37 +0800)] 
Hob: Added required packages for toolchain.

Added the requried packages task-core-standalone-sdk-target(-dbg) for
building toolchain.

Fixed bug [YOCTO #2274]

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobb.utils: Modifed vercmp() to meet Debian rules.
Lianhao Lu [Thu, 12 Apr 2012 09:28:01 +0000 (17:28 +0800)] 
bb.utils: Modifed vercmp() to meet Debian rules.

The version compare function vercmp() was not exatcly conforming to
Debian rules, e.g. it reported 'r1' > 'r1.1' but the Debian rules says
'r1' < 'r1.1'; it didn't support the "~" either.

Modified the vercmp() to meet Debian rules, so that it's compatible to
the rules used in opkg.

This part of the buf fixing of [YOCTO #2233].

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: forbid users to exit Hob directly when Hob is busy
Shane Wang [Thu, 12 Apr 2012 14:22:44 +0000 (22:22 +0800)] 
Hob: forbid users to exit Hob directly when Hob is busy

When Hob is busy with generating data, exiting Hob is not allowed.
That should be reasonable because at that time the mouse cursor is not a pointer.
If users want to exit, they can click "Stop" first and then do exit.

That is also a walkaround for [Yocto #2142]

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Implement Hob config parse hook
Dongxiao Xu [Thu, 12 Apr 2012 15:46:26 +0000 (23:46 +0800)] 
Hob: Implement Hob config parse hook

To make Hob's specific variable settings take effect, we add a Hob
config hook at the end of parsing for each configuration file, and in
the hook function, Hob will set its own variables to the data store.

This fixes:
[YOCTO #2210]
[YOCTO #2254]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoConfHandler.py: Add a hook for config parsing
Richard Purdie [Fri, 13 Apr 2012 10:51:17 +0000 (11:51 +0100)] 
ConfHandler.py: Add a hook for config parsing

To make the UI settings take effect, we need to hook at the end of each
config file parsing and set UI specific values.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
13 years agoHob: fix the missing functions
Shane Wang [Thu, 12 Apr 2012 14:22:43 +0000 (22:22 +0800)] 
Hob: fix the missing functions

The patch is to correct 7e5d41ab223b73c1c7b2cf7e4dd13289a2dc2e8b
(Bitbake rev: b6e68019494044305ab28492a517d1eafea851c3) to fix the
missing functions.

[Yocto #2281]

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agopackageselectionpage: add missing method
Joshua Lock [Thu, 12 Apr 2012 01:54:17 +0000 (18:54 -0700)] 
packageselectionpage: add missing method

This is just a copy of the same method from the recipeselectionpage so
that we can actually run hob again.

Fixes [YOCTO #2281]

Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agobuilder: fix missing \ for if continuation
Saul Wold [Thu, 12 Apr 2012 02:02:15 +0000 (19:02 -0700)] 
builder: fix missing \ for if continuation

Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agohig/builder: use the new which_terminal() function
Saul Wold [Wed, 11 Apr 2012 00:57:15 +0000 (17:57 -0700)] 
hig/builder: use the new which_terminal() function

Also adjusted the cmdline ordering to work correctly
with both xterm and vte.

Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoui/crumbs/utils.py: new file for choosing terminals
Saul Wold [Wed, 11 Apr 2012 00:57:08 +0000 (17:57 -0700)] 
ui/crumbs/utils.py: new file for choosing terminals

Adding this simple version of a terminal selector for use
hob since it's needed. Moving forward in the 1.3 release
the existing code in meta/lib/oe/termnial.py will be migrated
to core bitbake code and this will use that code.

Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob:Fixed some incorrect values of Build configuration tab
Liming An [Mon, 9 Apr 2012 14:13:51 +0000 (22:13 +0800)] 
Hob:Fixed some incorrect values of Build configuration tab

Because some variables not be updated when building started, so add them
to the updating function of configuration class, and add reset function of
configurate treeview of building detail page

[YOCTO #2244]

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: show those appliable buttons on the image details page only
Shane Wang [Mon, 9 Apr 2012 14:13:50 +0000 (22:13 +0800)] 
Hob: show those appliable buttons on the image details page only

We don't use "grayed out" but use "show/hide" for those appliable buttons
in the image details page.

[Yocto #2143]

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: forget selected_recipes and selected_packages after users change the machine
Shane Wang [Mon, 9 Apr 2012 14:13:49 +0000 (22:13 +0800)] 
Hob: forget selected_recipes and selected_packages after users change the machine

The patch is to fix [Yocto #2255]. Now the logic is:

- If users change the machine, the image combo is empty for users to select.
- If users load the template, the image combo should set the value of
  selected_image specified in the template.
- After loading a template, if users change the machine, the selected_image
  specified in the template should be removed from the image combo because
  it is probably invalid for a new machine.
- If users customize the recipe/package list, and change the settings which
  causes reparsing, selected_recipes and selected_packages should be remembered.
- If users add more layers, selected_recipes and selected_packages should be
  remembered.

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: add tooltips into image details screen
Shane Wang [Mon, 9 Apr 2012 14:13:48 +0000 (22:13 +0800)] 
Hob: add tooltips into image details screen

[Yocto #2243]

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: tooltip change for "Build image" button
Shane Wang [Mon, 9 Apr 2012 14:13:47 +0000 (22:13 +0800)] 
Hob: tooltip change for "Build image" button

[Yocto #2242]

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up and reword stop_parse()
Shane Wang [Mon, 9 Apr 2012 14:13:46 +0000 (22:13 +0800)] 
Hob: clean up and reword stop_parse()

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up generate_configuration()
Shane Wang [Mon, 9 Apr 2012 14:13:45 +0000 (22:13 +0800)] 
Hob: clean up generate_configuration()

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up cancel_build()
Shane Wang [Mon, 9 Apr 2012 14:13:44 +0000 (22:13 +0800)] 
Hob: clean up cancel_build()

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up request_package_info_async()
Shane Wang [Mon, 9 Apr 2012 14:13:43 +0000 (22:13 +0800)] 
Hob: clean up request_package_info_async()

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up and unify get_parameters() to be get_parameters_sync()
Shane Wang [Mon, 9 Apr 2012 14:13:42 +0000 (22:13 +0800)] 
Hob: clean up and unify get_parameters() to be get_parameters_sync()

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up to call clear_busy() in hobeventhandler.py
Shane Wang [Mon, 9 Apr 2012 14:13:41 +0000 (22:13 +0800)] 
Hob: clean up to call clear_busy() in hobeventhandler.py

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up and unify the steps for IMAGE_GENERATING to call generate_image_async()
Shane Wang [Mon, 9 Apr 2012 14:13:40 +0000 (22:13 +0800)] 
Hob: clean up and unify the steps for IMAGE_GENERATING to call generate_image_async()

For the steps in IMAGE_GENERATING, the patch consolidates them into
generate_image_async() to call.

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up and unify the steps for PACKAGE_GENERATING and FAST_IMAGE_GENERATING...
Shane Wang [Mon, 9 Apr 2012 14:13:39 +0000 (22:13 +0800)] 
Hob: clean up and unify the steps for PACKAGE_GENERATING and FAST_IMAGE_GENERATING to call generate_packages_async() and fast_generate_image_async()

For the steps in PACKAGE_GENERATING, the patch consolidates them into
generate_packages_async() to call.

For the steps in FAST_IMAGE_GENERATING, the patch also consolidates them
into fast_generate_image_async() to call.

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up and unify the steps for RCPPKGINFO_POPULATING to call populate_recipe_p...
Shane Wang [Mon, 9 Apr 2012 14:13:38 +0000 (22:13 +0800)] 
Hob: clean up and unify the steps for RCPPKGINFO_POPULATING to call populate_recipe_package_info_async()

For the steps in RCPPKGINFO_POPULATING, This patch consolidates them into
populate_recipe_package_info_async() to call.

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up and unify the steps for CONFIG_UPDATE to call update_config_async()
Shane Wang [Mon, 9 Apr 2012 14:13:37 +0000 (22:13 +0800)] 
Hob: clean up and unify the steps for CONFIG_UPDATE to call update_config_async()

For the steps in CONFIG_UPDATE, the patch consolidates them into
update_config_async() to call.
consequently remove CONFIG_UPDATE since MACHINE_SELECTION covers it.

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: clean up and unify the steps for new build to call initiate_new_build_async()
Shane Wang [Mon, 9 Apr 2012 14:13:36 +0000 (22:13 +0800)] 
Hob: clean up and unify the steps for new build to call initiate_new_build_async()

initiate_new_build() (changed the function name into initiate_new_build_async()
to indicate it is an async function) or the similar sub-functions are called at
different places.

This patch is unify to call initiate_new_build_async().

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: correct indent
Shane Wang [Mon, 9 Apr 2012 14:13:35 +0000 (22:13 +0800)] 
Hob: correct indent

Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Add the tooltips for recipe view page as request
Liming An [Mon, 9 Apr 2012 14:13:34 +0000 (22:13 +0800)] 
Hob: Add the tooltips for recipe view page as request

[YOCTO #2229]

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: add fadeout display effection for package view include page
Liming An [Mon, 9 Apr 2012 14:13:33 +0000 (22:13 +0800)] 
Hob: add fadeout display effection for package view include page

[YOCTO #2100]

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: add fadeout display effection for recipe view include page
Liming An [Mon, 9 Apr 2012 14:13:32 +0000 (22:13 +0800)] 
Hob: add fadeout display effection for recipe view include page

As UI request, in recipes selection page, if user exclude a item,
the related depends recipes will be excluded together,so the view
clearly to add it.

[YOCTO #2100]

Signed-off-by: Liming An <limingx.l.an@intel.com>
Signed-off-by: Shane Wang <shane.wang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Add an extra 50M space if zypper is selected
Dongxiao Xu [Mon, 9 Apr 2012 08:42:02 +0000 (16:42 +0800)] 
Hob: Add an extra 50M space if zypper is selected

If zypper is selected, RPM packaging will add extra 50M free space to
the final image. We need to reflect it in package selection page.

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Fix tooltips in Settings dialog
Dongxiao Xu [Mon, 9 Apr 2012 08:42:01 +0000 (16:42 +0800)] 
Hob: Fix tooltips in Settings dialog

This fixes [YOCTO #2229]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Fix tooltips in image configuration page
Dongxiao Xu [Mon, 9 Apr 2012 08:42:00 +0000 (16:42 +0800)] 
Hob: Fix tooltips in image configuration page

This fixes [YOCTO #2228]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Fix the pattern patch for image name
Dongxiao Xu [Mon, 9 Apr 2012 08:41:59 +0000 (16:41 +0800)] 
Hob: Fix the pattern patch for image name

Sometimes, users may open an image that is not built by Hob, therefore
its image name is not started with "hob-image-". This commit sets a
looser rule for runnable image matching.

This fixes [YOCTO #2240]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoHob: Change base image to "Create your own image" if customized
Dongxiao Xu [Mon, 9 Apr 2012 08:41:57 +0000 (16:41 +0800)] 
Hob: Change base image to "Create your own image" if customized

Once user did customization to his base image, we change the base image
to be "Create your own image" to avoid some issues caused by the
relationship between base image and its default recipes and packages.

This fixes [YOCTO #2211]

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
13 years agoselectionpage: show persistent tooltips on click
Joshua Lock [Thu, 5 Apr 2012 22:32:28 +0000 (15:32 -0700)] 
selectionpage: show persistent tooltips on click

Requiring a double click to show the tooltips isn't very intuitive, add
a callback to show the persistent tooltips on button release.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
13 years agolib/bb/ui/crumbs/[recipe|package]selectionpage: fixed width Included col
Joshua Lock [Fri, 6 Apr 2012 23:02:22 +0000 (16:02 -0700)] 
lib/bb/ui/crumbs/[recipe|package]selectionpage: fixed width Included col

Set the expand property on all columns other than the 'Included' column
so that the included column remains at the max size set.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
13 years agolib/bb/ui/crumbs/recipeselectionpage: include 'Group' in 'Included' view
Joshua Lock [Thu, 5 Apr 2012 23:37:23 +0000 (16:37 -0700)] 
lib/bb/ui/crumbs/recipeselectionpage: include 'Group' in 'Included' view

The 'Included' tab of the notebook should show the 'Group' a recipe
belongs to, per the design.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
13 years agolib/bb/ui/crumbs: only display one 'Brought in by' item in Hob trees
Joshua Lock [Thu, 5 Apr 2012 21:39:50 +0000 (14:39 -0700)] 
lib/bb/ui/crumbs: only display one 'Brought in by' item in Hob trees

The design calls for a single 'Brought in by' item to be shown in the
tree views with any extra items to be shown in the tooltip.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
13 years agohob: update required versions of (py)gtk et al
Joshua Lock [Thu, 5 Apr 2012 17:56:43 +0000 (10:56 -0700)] 
hob: update required versions of (py)gtk et al

With the previous two changes we now work on Gtk+ 2.18 and PyGtk 2.16

Signed-off-by: Joshua Lock <josh@linux.intel.com>
13 years agolib/bb/ui/crumbs/hobwidget: replace new API
Joshua Lock [Thu, 5 Apr 2012 17:17:57 +0000 (10:17 -0700)] 
lib/bb/ui/crumbs/hobwidget: replace new API

The gtk.Widget.get_sensitive() convenience method is only available
in Gtk+ 2.22 or later, instead use the sensitive property of the
gobject to determine whether the widget is sensitive or not.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
13 years agolib/bb/ui/crumbs/persistenttooltip: replace 2.22 API
Joshua Lock [Wed, 4 Apr 2012 23:07:45 +0000 (16:07 -0700)] 
lib/bb/ui/crumbs/persistenttooltip: replace 2.22 API

CentOS 6.x doesn't ship with new enough pygtk for this API.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
13 years agodiskspace monitor: assign a default value when only of the interval is set
Robert Yang [Thu, 5 Apr 2012 12:58:57 +0000 (20:58 +0800)] 
diskspace monitor: assign a default value when only of the interval is set

Assign a default value to the other one when either disk space interval
or amount of inodes interval value is set for example:

BB_DISKMON_WARNINTERVAL = "50M,"
or
BB_DISKMON_WARNINTERVAL = ",5K"

The diskspace monitor would not enable in the past, that seemed
unreasonable, assign a default value to the other one currently, so the
monitor will be enabled, and will warn both of diskspace and free
amount of inode if they have been set in BB_DISKMON_DIRS.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>