]> git.ipfire.org Git - thirdparty/Python/cpython.git/log
thirdparty/Python/cpython.git
4 years agoPut contextvars docs into the concurrency category (GH-24760)
Miss Islington (bot) [Sat, 6 Mar 2021 16:48:12 +0000 (08:48 -0800)] 
Put contextvars docs into the concurrency category (GH-24760)

(cherry picked from commit 5eb7796b7f3aae91b145ccea51b528662f3b5ce1)

Co-authored-by: Brett Cannon <brett@python.org>
4 years ago[3.9] bpo-43406: Fix possible race condition where ``PyErr_CheckSignals`` tries to...
Miss Islington (bot) [Sat, 6 Mar 2021 15:07:46 +0000 (07:07 -0800)] 
[3.9] bpo-43406: Fix possible race condition where ``PyErr_CheckSignals`` tries to execute a non-Python signal handler (GH-24756) (GH-24761)

We can receive signals (at the C level, in `trip_signal()` in signalmodule.c) while `signal.signal` is being called to modify the corresponding handler.  Later when `PyErr_CheckSignals()` is called to handle the given signal, the handler may be a non-callable object and would raise a cryptic asynchronous exception.
(cherry picked from commit 68245b7a1030287294c65c298975ab9026543fd2)

Co-authored-by: Antoine Pitrou <antoine@python.org>
4 years agobpo-43407: Clarify comparisons of time.monotonic() et al results (GH-24757)
Miss Islington (bot) [Sat, 6 Mar 2021 01:48:33 +0000 (17:48 -0800)] 
bpo-43407: Clarify comparisons of time.monotonic() et al results (GH-24757)

Previous wording implied that only the result of call N and N+1 could be
meaningfully compared, whereas comparing call N and N+M is fine.
(cherry picked from commit ff5f05934db241dfafc604989b2de3487b09ca82)

Co-authored-by: Alex Willmer <alex@moreati.org.uk>
4 years agobpo-43400: Remove "easy to use" from mock docs (GH-24752) (GH-24758)
Miss Islington (bot) [Fri, 5 Mar 2021 00:35:43 +0000 (16:35 -0800)] 
bpo-43400: Remove "easy to use" from mock docs (GH-24752) (GH-24758)

4 years agobpo-43396: Normalise naming in sqlite3 doc examples (GH-24746)
Miss Islington (bot) [Thu, 4 Mar 2021 17:11:40 +0000 (09:11 -0800)] 
bpo-43396: Normalise naming in sqlite3 doc examples (GH-24746)

(cherry picked from commit 40d1b831ecd1b5b6a4fce9a908a6e61b50b360a0)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
4 years ago[3.9] bpo-37193: Remove thread objects which finished process its request (GH-23127...
Miss Islington (bot) [Thu, 4 Mar 2021 16:36:41 +0000 (08:36 -0800)] 
[3.9] bpo-37193: Remove thread objects which finished process its request (GH-23127) (GH-24750)

This reverts commit aca67da4fe68d5420401ac1782203d302875eb27.
(cherry picked from commit b5711c940f70af89f2b4cf081a3fcd83924f3ae7)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Automerge-Triggered-By: GH:jaraco
4 years agoAdd an attribution to the Green Tree Snakes in the AST docs (GH-24727)
Miss Islington (bot) [Wed, 3 Mar 2021 18:48:56 +0000 (10:48 -0800)] 
Add an attribution to the Green Tree Snakes in the AST docs (GH-24727)

(cherry picked from commit 62e3b6370cf9aa990485d9c7c3ea3f6f150daa47)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
4 years ago[3.9] bpo-42782: Fail fast for permission errors in shutil.move() (GH-24001) (#24725)
Senthil Kumaran [Wed, 3 Mar 2021 16:04:00 +0000 (08:04 -0800)] 
[3.9] bpo-42782: Fail fast for permission errors in shutil.move() (GH-24001) (#24725)

* Fail fast in shutil.move() to avoid creating destination directories on failure.

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
(cherry picked from commit 132131b404e06ee1a19b040a1f96cd1118abed0c)

Co-authored-by: Winson Luk <winson.luk@gmail.com>
Co-authored-by: Winson Luk <winson.luk@gmail.com>
4 years agoPin test runner to Ubuntu 18 to un-break CI (GH-24715)
Miss Islington (bot) [Wed, 3 Mar 2021 09:56:36 +0000 (01:56 -0800)] 
Pin test runner to Ubuntu 18 to un-break CI (GH-24715)

(cherry picked from commit 94894dd45e4bad6efb27eac4497b24cdc18b3e2d)

Co-authored-by: Brandt Bucher <brandt@python.org>
4 years agobpo-42500: Fix recursion in or after except (GH-23568) (#24501)
Mark Shannon [Tue, 2 Mar 2021 10:36:38 +0000 (10:36 +0000)] 
bpo-42500: Fix recursion in or after except (GH-23568) (#24501)

* Use counter, rather boolean state when handling soft overflows.

(cherry picked from commit 4e7a69bdb63a104587759d7784124492dcdd496e)

4 years agoDoc: Improve library/json document. (GH-24390)
Miss Islington (bot) [Tue, 2 Mar 2021 02:15:05 +0000 (18:15 -0800)] 
Doc: Improve library/json document. (GH-24390)

(cherry picked from commit a347bc0b35c982e9600838d5a545e244bb76a4bf)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
4 years agoFixed linenumber missing when audit hook has an error (GH-24692)
Miss Islington (bot) [Mon, 1 Mar 2021 22:23:21 +0000 (14:23 -0800)] 
Fixed linenumber missing when audit hook has an error (GH-24692)

See https://github.com/sphinx-doc/sphinx/issues/8932

Co-authored-by: tk0miya <i.tkomiya@gmail.com>
(cherry picked from commit dbfabcc0c306742e34b9b0e162c63ccebe9d2b05)

Co-authored-by: Jules Lasne <jules.lasne@gmail.com>
4 years agoFix grammar in enum documentation. (GH-24689)
Miss Islington (bot) [Mon, 1 Mar 2021 19:21:05 +0000 (11:21 -0800)] 
Fix grammar in enum documentation. (GH-24689)

There is an extra `s` in the singular word `method`.
Reported in docs mailing list by Steven Nguyen.

Automerge-Triggered-By: GH:Mariatta
(cherry picked from commit f193874056fb185305084b79b32d2745ce9be7cf)

Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
4 years agobpo-41837: Update macOS installer build to use OpenSSL 1.1.1j. (GH-24677)
Miss Islington (bot) [Mon, 1 Mar 2021 08:01:43 +0000 (00:01 -0800)] 
bpo-41837: Update macOS installer build to use OpenSSL 1.1.1j. (GH-24677)

(cherry picked from commit 0242494a156970186cbc4121ccf03aefbddea716)

Co-authored-by: Ned Deily <nad@python.org>
4 years agobpo-43335: Update macro to check gcc version (GH-24662)
Miss Islington (bot) [Sun, 28 Feb 2021 00:51:36 +0000 (16:51 -0800)] 
bpo-43335: Update macro to check gcc version (GH-24662)

(cherry picked from commit bf9de7ab24d9d7068645b202bc47146b9a4f2726)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
4 years agobpo-43144: Mark unicodedata's test_normalization as requiring network (GH-24650)
Miss Islington (bot) [Fri, 26 Feb 2021 05:44:17 +0000 (21:44 -0800)] 
bpo-43144: Mark unicodedata's test_normalization as requiring network (GH-24650)

Co-authored-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
(cherry picked from commit c6ccdfb479cb0a4a491575ef0bafaa0d29daae1a)

Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
4 years agobpo-43316: gzip: Fix sys.exit() usage. (GH-24652)
Miss Islington (bot) [Fri, 26 Feb 2021 02:36:27 +0000 (18:36 -0800)] 
bpo-43316: gzip: Fix sys.exit() usage. (GH-24652)

(cherry picked from commit 9525a18b5bb317d9fb206c992ab62aa41559b0c8)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
4 years agobpo-43316: gzip: CLI uses non-zero return code on error. (GH-24647)
Miss Islington (bot) [Fri, 26 Feb 2021 01:13:17 +0000 (17:13 -0800)] 
bpo-43316:  gzip: CLI uses non-zero return code on error. (GH-24647)

Exit code is now 1 instead of 0. A message is printed to stderr instead of stdout. This is
the proper behaviour for a tool that can be used in scripts.
(cherry picked from commit cc3df6368d4f3f6c9c9b716876c7e7b79c7abf3f)

Co-authored-by: Ruben Vorderman <r.h.p.vorderman@lumc.nl>
4 years agobpo-43293: Doc: move note about GIL to top of threading module (GH-24622)
Miss Islington (bot) [Wed, 24 Feb 2021 19:01:33 +0000 (11:01 -0800)] 
bpo-43293: Doc: move note about GIL to top of threading module (GH-24622)

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelizing their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility.
(cherry picked from commit 32181be6081f6c70a1e0bd0540050805c8e88e83)

Co-authored-by: Guanzhong Chen <quantum2048@gmail.com>
4 years ago[3.9] bpo-41841: revise header (GH-24634)
Terry Jan Reedy [Wed, 24 Feb 2021 02:32:20 +0000 (21:32 -0500)] 
[3.9] bpo-41841: revise header (GH-24634)

4 years agobpo-43283: Add IDLE doc paragraph about print speed (GH-24615)
Miss Islington (bot) [Wed, 24 Feb 2021 01:03:37 +0000 (17:03 -0800)] 
bpo-43283: Add IDLE doc paragraph about print speed (GH-24615)

Printing to IDLE's Shell is often slower than printing to a system
terminal, but it can be made faster by pre-formatting a single
string before printing.
(cherry picked from commit 2827e8a177c2a6584fada594bca6829c53a2872f)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
4 years agobpo-36346: Document removal schedule of deprecate APIs (GH-20879)
Miss Islington (bot) [Mon, 22 Feb 2021 23:30:52 +0000 (15:30 -0800)] 
bpo-36346: Document removal schedule of deprecate APIs (GH-20879)

We will remove wstr cache in Python 3.12. See PEP 623.
(cherry picked from commit 2d6f2eed14ff5d89155b52771cc8ef957e8145b4)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
4 years agobpo-23882: Doc: Clarify unittest discovery document (GH-21560)
Miss Islington (bot) [Mon, 22 Feb 2021 06:37:18 +0000 (22:37 -0800)] 
bpo-23882: Doc: Clarify unittest discovery document (GH-21560)

Unittest discovery support namespace package as start
directory. But it doesn't find namespace package in
the start directory automatically.

Otherwise, unittest discovery search into unexpected
directories like `vendor/` or `node_modules/`.
(cherry picked from commit 5a4aa4c03e27ca5007b86c9c1ee62c77ad08a120)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
4 years agobpo-43260: io: Prevent large data remains in textio buffer. (GH-24592)
Inada Naoki [Mon, 22 Feb 2021 01:32:55 +0000 (10:32 +0900)] 
bpo-43260: io: Prevent large data remains in textio buffer. (GH-24592)

When very large data remains in TextIOWrapper, flush() may fail forever.

So prevent that data larger than chunk_size is remained in TextIOWrapper internal
buffer.

Co-Authored-By: Eryk Sun
(cherry picked from commit 01806d5)

4 years ago[3.9] bpo-43288: Fix bug in test_importlib test. (GH-24616)
Neil Schemenauer [Sun, 21 Feb 2021 23:24:41 +0000 (15:24 -0800)] 
[3.9] bpo-43288: Fix bug in test_importlib test. (GH-24616)

* bpo-43288: Fix bug in test_importlib test. (GH-24612)
* Fix failed merge of bpo-43288. (GH-24614)

4 years agobpo-43283: Rearrange some IDLE doc paragraphs. (GH-24604)
Miss Islington (bot) [Sun, 21 Feb 2021 08:07:33 +0000 (00:07 -0800)] 
bpo-43283: Rearrange some IDLE doc paragraphs. (GH-24604)

In the Running User Code section, gather together paragraphs about two
processes and the sys.stdstream replacements, preparing to add another.
(cherry picked from commit 4cf7bb8e22bf37e6d65bf4cb5618d09c4a8ad612)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
4 years agobpo-27646: Say that 'yield from' expression can be any iterable (GH-24595)
Miss Islington (bot) [Sun, 21 Feb 2021 02:55:49 +0000 (18:55 -0800)] 
bpo-27646: Say that 'yield from' expression can be any iterable (GH-24595)

Previously, the doc at least strongly implied that it had to be an iterator.
(cherry picked from commit 2f9ef514fb24b6a95bd3272885f197752810c107)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
4 years agoFix typo in dis module doc (GH-24509)
Miss Islington (bot) [Sat, 20 Feb 2021 04:46:34 +0000 (20:46 -0800)] 
Fix typo in dis module doc (GH-24509)

(cherry picked from commit 292f23186c6573bc1c3fa4f6e91116e8ee444cf4)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
4 years ago[3.9] bpo-43272: Fix old parser test failures for backported grammar constructs ...
Pablo Galindo [Sat, 20 Feb 2021 01:36:15 +0000 (01:36 +0000)] 
[3.9] bpo-43272: Fix old parser test failures for backported grammar constructs (GH-24591)

4 years agobpo-43042: Augment tutorial sentence (GH-24514)
Miss Islington (bot) [Sat, 20 Feb 2021 00:46:57 +0000 (16:46 -0800)] 
bpo-43042: Augment tutorial sentence (GH-24514)

Calling same function also gets new local namespace.
(cherry picked from commit b30fcba3a8abaabd1087f2392ae8aec4c1b1f210)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
4 years agocloses bpo-43266: Improve array formatting. (GH-24573)
Miss Islington (bot) [Fri, 19 Feb 2021 15:55:44 +0000 (07:55 -0800)] 
closes bpo-43266: Improve array formatting. (GH-24573)

(cherry picked from commit 2d3e463e4a5aa109d1c15c86f9631580f5ef7a7e)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
4 years agoPost 3.9.2
Łukasz Langa [Fri, 19 Feb 2021 12:32:44 +0000 (13:32 +0100)] 
Post 3.9.2

4 years agoPython 3.9.2 v3.9.2
Łukasz Langa [Fri, 19 Feb 2021 12:31:44 +0000 (13:31 +0100)] 
Python 3.9.2

4 years agocloses bpo-43254: Fix *snprintf() man page refs. (GH-24563)
Miss Islington (bot) [Fri, 19 Feb 2021 02:16:30 +0000 (18:16 -0800)] 
closes bpo-43254: Fix *snprintf() man page refs. (GH-24563)

(cherry picked from commit e92d67dfbb4790df37aa6a0961fb6dc7e8d2fbbf)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
4 years agoRemove all links to mingw.org (GH-24552)
Miss Islington (bot) [Thu, 18 Feb 2021 20:07:30 +0000 (12:07 -0800)] 
Remove all links to mingw.org (GH-24552)

This lease on this domain has lapsed. This not only makes these dead links, but a potential attack vector for readers of python.org as the domain can be obtained by an untrustworthy party.

I considered redirecting these links to http://mingw-w64.org/ which is a maintained fork of mingw, but beyond my unfamiliarity with the exact level of compatibility, at the time of this PR that site had an expired cert and so is not much of a vulnerability fix.

Automerge-Triggered-By: GH:Mariatta
(cherry picked from commit 743932d50815edbe4ffd530ae091c53ae47dd34b)

Co-authored-by: Jeremy Paige <ucodery@gmail.com>
4 years agobpo-43155: Add PyCMethod_New to PC/python3.def (GH-24500) (GH-24554)
Zackery Spytz [Wed, 17 Feb 2021 10:53:45 +0000 (03:53 -0700)] 
bpo-43155: Add PyCMethod_New to PC/python3.def (GH-24500) (GH-24554)

(cherry picked from commit 8a8b5df93f379f561aab4f2fc5b2ad54f5009f7a)

4 years agoPost 3.9.2rc1
Łukasz Langa [Tue, 16 Feb 2021 21:34:29 +0000 (22:34 +0100)] 
Post 3.9.2rc1

4 years agoPython 3.9.2rc1 v3.9.2rc1
Łukasz Langa [Tue, 16 Feb 2021 20:10:19 +0000 (21:10 +0100)] 
Python 3.9.2rc1

4 years agobpo-42819, readline: Disable bracketed paste (GH-24108) (GH-24545)
Miss Islington (bot) [Tue, 16 Feb 2021 00:18:07 +0000 (16:18 -0800)] 
bpo-42819, readline: Disable bracketed paste (GH-24108) (GH-24545)

(cherry picked from commit 755f3c1521b422bc2177013d289f5439975fdc4f)

Co-authored-by: Dustin Rodrigues <dust.rod@gmail.com>
Co-authored-by: Dustin Rodrigues <dust.rod@gmail.com>
4 years ago[3.9] Minor improvements to the convolve() recipe (GH-24520)
Pablo Galindo [Mon, 15 Feb 2021 23:02:41 +0000 (23:02 +0000)] 
[3.9] Minor improvements to the convolve() recipe (GH-24520)

4 years ago[3.9] bpo-42967: only use '&' as a query string separator (GH-24297) (#24528)
Senthil Kumaran [Mon, 15 Feb 2021 18:03:31 +0000 (10:03 -0800)] 
[3.9] bpo-42967: only use '&' as a query string separator (GH-24297) (#24528)

(cherry picked from commit fcbe0cb04d35189401c0c880ebfb4311e952d776)

* [3.9] bpo-42967: only use '&' as a query string separator (GH-24297)

bpo-42967: [security] Address a web cache-poisoning issue reported in urllib.parse.parse_qsl().

urllib.parse will only us "&" as query string separator by default instead of both ";" and "&" as allowed in earlier versions. An optional argument seperator with default value "&" is added to specify the separator.

Co-authored-by: Éric Araujo <merwok@netwok.org>
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Co-authored-by: Adam Goldschmidt <adamgold7@gmail.com>
4 years agobpo-43200: Fix link to shutil.copy() in the shutil doc (GH-24505)
Miss Islington (bot) [Sat, 13 Feb 2021 05:20:24 +0000 (21:20 -0800)] 
bpo-43200: Fix link to shutil.copy() in the shutil doc (GH-24505)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 762fe7deed34a1d5294bf82071d318c8427b4893)

4 years agobpo-43204: Fix LibTomCrypt URL in md5module.c and sha*module.c comments (GH-24507)
Miss Islington (bot) [Fri, 12 Feb 2021 11:18:38 +0000 (03:18 -0800)] 
bpo-43204: Fix LibTomCrypt URL in md5module.c and sha*module.c comments (GH-24507)

Automerge-Triggered-By: GH:tiran
(cherry picked from commit 5ec7d535581bc99918e032891167a96abd224ed6)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
4 years agobpo-43174: Windows: Use /utf-8 compiler option. (GH-24498)
Miss Islington (bot) [Fri, 12 Feb 2021 04:33:35 +0000 (20:33 -0800)] 
bpo-43174: Windows: Use /utf-8 compiler option. (GH-24498)

(cherry picked from commit fedd86df2448370cdf62a229fd6f31dc92daf379)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
4 years agobpo-41824: Add versionadded for typing.ForwardRef docs (#24224) (#24493)
Ken Jin [Tue, 9 Feb 2021 16:55:03 +0000 (00:55 +0800)] 
bpo-41824: Add versionadded for typing.ForwardRef docs (#24224) (#24493)

4 years agobpo-16781: In 'exec' doc, add 'nonlocal' to 'yield' and 'return' (GH-2446)
Miss Islington (bot) [Sun, 7 Feb 2021 14:14:16 +0000 (06:14 -0800)] 
bpo-16781: In 'exec' doc, add 'nonlocal' to 'yield' and 'return' (GH-2446)

These 3 statements cannot be used at module scope -- nor in exec with one namespace.
(cherry picked from commit 0ec57e25c918b859b9f8d464e34e0ac859c2f8b3)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
4 years agoSimple typo fix (GH-24448)
Miss Islington (bot) [Fri, 5 Feb 2021 18:44:23 +0000 (10:44 -0800)] 
Simple typo fix (GH-24448)

(cherry picked from commit 5f18c223391eef8c7d01241b51a7b2429609dd84)

Co-authored-by: Andrew Tennikoff <atenni@users.noreply.github.com>
4 years agobpo-43132: Fix incorrect handling of PyObject_RichCompareBool() in _zoneinfo (GH...
Miss Islington (bot) [Fri, 5 Feb 2021 17:13:40 +0000 (09:13 -0800)] 
bpo-43132: Fix incorrect handling of PyObject_RichCompareBool() in _zoneinfo (GH-24450) (GH-24457)

PyObject_RichCompareBool() returns -1 on error, but this case is
not handled by the find_in_strong_cache() function.  Any exception
raised by PyObject_RichCompareBool() should be propagated.
(cherry picked from commit effaec0bb54f381db8ccfa62514bc26b00946b40)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
4 years agobpo-35295: Remove outdated comment. (GH-24453)
Miss Islington (bot) [Fri, 5 Feb 2021 04:44:17 +0000 (20:44 -0800)] 
bpo-35295: Remove outdated comment. (GH-24453)

(cherry picked from commit d938816acf71a74f1bd13fdf0534b3d9ea962e44)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
4 years agobpo-43102: Set namedtuple __new__'s internal builtins to a dict. (GH-24439) (GH...
Miss Islington (bot) [Fri, 5 Feb 2021 00:12:34 +0000 (16:12 -0800)] 
bpo-43102:  Set namedtuple __new__'s internal builtins to a dict. (GH-24439) (GH-24452)

4 years agobuild(deps): bump actions/upload-artifact from v2.2.1 to v2.2.2 (GH-24411)
Miss Islington (bot) [Thu, 4 Feb 2021 19:21:37 +0000 (11:21 -0800)] 
build(deps): bump actions/upload-artifact from v2.2.1 to v2.2.2 (GH-24411)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from v2.2.1 to v2.2.2.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v2.2.1...e448a9b857ee2131e752b06002bf0e093c65e571)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit aa4caf9887944ab280a87712460e2dd49b55fe5e)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 years agobpo-42773: fix tests not being run on pushes (GH-24004)
Miss Islington (bot) [Wed, 3 Feb 2021 23:38:55 +0000 (15:38 -0800)] 
bpo-42773: fix tests not being run on pushes (GH-24004)

There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 4ac923f2756f835f512339ee181348cc535ab07f)

Co-authored-by: Filipe Laíns <lains@riseup.net>
4 years agoFix typo (GH-23019)
Miss Islington (bot) [Wed, 3 Feb 2021 21:48:22 +0000 (13:48 -0800)] 
Fix typo (GH-23019)

Fixed possible typo in comment
(cherry picked from commit bfe544d2f2c2e7a7c03a764bed3276a1e27a0f5c)

Co-authored-by: Harry <harry.lees@gmail.com>
4 years agobpo-43108: Fix a reference leak in the curses module (GH-24420)
Miss Islington (bot) [Wed, 3 Feb 2021 13:41:09 +0000 (05:41 -0800)] 
bpo-43108: Fix a reference leak in the curses module (GH-24420)

(cherry picked from commit bb739ec922c6992a2be38f9fd3c544c2cc322dde)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
4 years agobpo-43082: Remove redundant 'the' in Descriptor howto (GH-24394) (GH-24427)
Miss Islington (bot) [Wed, 3 Feb 2021 03:33:35 +0000 (19:33 -0800)] 
bpo-43082: Remove redundant 'the' in Descriptor howto (GH-24394) (GH-24427)

4 years agoAdd link to Microsoft docs for limitations in Windows Store package (GH-24422)
Miss Islington (bot) [Wed, 3 Feb 2021 01:35:55 +0000 (17:35 -0800)] 
Add link to Microsoft docs for limitations in Windows Store package (GH-24422)

(cherry picked from commit 1ba08a121a25fcf7c947d8d37e72e46dae59168c)

Co-authored-by: Steve Dower <steve.dower@python.org>
4 years agobpo-41748: Handles unquoted attributes with commas (GH-24072)
Miss Islington (bot) [Mon, 1 Feb 2021 20:54:43 +0000 (12:54 -0800)] 
bpo-41748: Handles unquoted attributes with commas (GH-24072)

* bpo-41748: Adds tests for unquoted attributes with comma

* bpo-41748: Handles unquoted attributes with comma

* bpo-41748: Addresses review comments

* bpo-41748: Addresses review comments

* Adds more test cases
* Simplifies the regex for handling spaces

* bpo-41748: Moves attributes tests under the right class

* bpo-41748: Addresses review about duplicate attributes

* bpo-41748: Adds NEWS.d entry for this patch
(cherry picked from commit 9eb11a139fac5514d8456626806a68b3e3b7eafb)

Co-authored-by: Karl Dubost <karl+github@la-grange.net>
4 years agobpo-43016: Fix test_curses on platform without cursesw (GH-24405) (GH-24407)
Miss Islington (bot) [Mon, 1 Feb 2021 07:37:29 +0000 (23:37 -0800)] 
bpo-43016: Fix test_curses on platform without cursesw (GH-24405) (GH-24407)

(cherry picked from commit a1e9a1e120a11c563e166c15721169184c802f8b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
4 years agobpo-42688: Fix ffi alloc/free when using external libffi on macos (GH-23868) (GH...
Miss Islington (bot) [Mon, 1 Feb 2021 05:15:23 +0000 (21:15 -0800)] 
bpo-42688: Fix ffi alloc/free when using external libffi on macos (GH-23868) (GH-23888)

Automerge-Triggered-By: GH:ronaldoussoren
(cherry picked from commit b3c77ecbbe0ad3e3cc6dbd885792203e9e6ec858)

Co-authored-by: erykoff <erykoff@stanford.edu>
4 years agobpo-42504: Ensure that get_config_var('MACOSX_DEPLOYMENT_TARGET') is a string (GH...
Miss Islington (bot) [Mon, 1 Feb 2021 04:22:48 +0000 (20:22 -0800)] 
bpo-42504: Ensure that get_config_var('MACOSX_DEPLOYMENT_TARGET') is a string (GH-24341) (GH-24410)

* bpo-42504: Ensure that get_config_var('MACOSX_DEPLOYMENT_TARGET') is a string
(cherry picked from commit 49926cf2bcc8b44d9b8f148d81979ada191dd9d5)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
4 years ago[3.9] bpo-41604: Don't decrement the reference count of the previous user_ptr when...
Serhiy Storchaka [Sun, 31 Jan 2021 19:44:31 +0000 (21:44 +0200)] 
[3.9] bpo-41604: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails (GH-21933). (GH-24403)

(cherry picked from commit 3243e8a4b4b4cf321f9b28335d565742a34b1976)

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
4 years ago[3.9] bpo-43016: Rewrite tests for curses (GH-24312). (GH-24399)
Serhiy Storchaka [Sun, 31 Jan 2021 16:11:13 +0000 (18:11 +0200)] 
[3.9] bpo-43016: Rewrite tests for curses (GH-24312). (GH-24399)

(cherry picked from commit d64fd4bb5bb4fd2e3277f39d3ad99b5a8d193e1b)

4 years agobpo-43083: Fix error handling in _sqlite3 (GH-24395)
Miss Islington (bot) [Sun, 31 Jan 2021 16:06:15 +0000 (08:06 -0800)] 
bpo-43083: Fix error handling in _sqlite3 (GH-24395)

(cherry picked from commit 9073180db521dc83e6216ff0da1479d00167f643)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
4 years agobpo-43030: Fixed a compiler warning in Py_UNICODE_ISSPACE with signed wchar_t (GH...
Miss Islington (bot) [Sun, 31 Jan 2021 14:20:14 +0000 (06:20 -0800)] 
bpo-43030: Fixed a compiler warning in Py_UNICODE_ISSPACE with signed wchar_t (GH-24350)

(cherry picked from commit 42b1806af90b86ec393ca7da14e99ce95ec6c53b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
4 years agobpo-43059: Remove reference to legacy external sqlite3 repository (GH-24364)
Miss Islington (bot) [Sun, 31 Jan 2021 05:21:28 +0000 (21:21 -0800)] 
bpo-43059: Remove reference to legacy external sqlite3 repository (GH-24364)

(cherry picked from commit e60344364245a23a7a1b25d5ebce6833652a656c)

Co-authored-by: L <3177243+LukeLR@users.noreply.github.com>
4 years ago[doc] Document VIRTUAL_ENV environment variable (GH-21970)
Miss Islington (bot) [Sat, 30 Jan 2021 10:38:44 +0000 (02:38 -0800)] 
[doc] Document VIRTUAL_ENV environment variable (GH-21970)

(cherry picked from commit 3584d4b64a5373440f78237eac734831cfd83f79)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
4 years agoFixing typos in turtle.rst (GH-24376)
Miss Islington (bot) [Fri, 29 Jan 2021 22:03:18 +0000 (14:03 -0800)] 
Fixing typos in turtle.rst (GH-24376)

Automerge-Triggered-By: GH:JulienPalard
(cherry picked from commit 6baaae589d596ed3bb668448f2a22c5f62fc5fdf)

Co-authored-by: Jules Lasne <jules.lasne@gmail.com>
4 years agoFixed typo in turtle.rst (GH-24371)
Miss Islington (bot) [Fri, 29 Jan 2021 21:38:16 +0000 (13:38 -0800)] 
Fixed typo in turtle.rst (GH-24371)

Found it while translating it to french 🤷

Automerge-Triggered-By: GH:JulienPalard
(cherry picked from commit 6372a4ceba126aa0a9f00eee0f8023308f13e77b)

Co-authored-by: Jules Lasne <jules.lasne@gmail.com>
4 years agobpo-43008: Add 'Patch by Ken Hilton' (GH-24370) (#24374)
Miss Islington (bot) [Fri, 29 Jan 2021 18:51:46 +0000 (10:51 -0800)] 
bpo-43008: Add 'Patch by Ken Hilton' (GH-24370) (#24374)

(cherry picked from commit 11d75ec807f05eff1148c049e38b808d11c23b8a)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
4 years agobpo-23544: Disable IDLE Stack Viewer when running user code (GH-17163)
Miss Islington (bot) [Thu, 28 Jan 2021 23:38:19 +0000 (15:38 -0800)] 
bpo-23544: Disable IDLE Stack Viewer when running user code (GH-17163)

Starting stack viewer when user code is running, including when Debugger is active, hangs or crashes IDLE.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 23a567c11ca36eedde0e119443c85cc16075deaf)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
4 years agobpo-29076: Add fish support to macOS installer (GH-23302) (GH-23937)
Miss Islington (bot) [Thu, 28 Jan 2021 14:54:03 +0000 (06:54 -0800)] 
bpo-29076: Add fish support to macOS installer (GH-23302) (GH-23937)

(cherry picked from commit 7f162e867c674f57c308a87fffcdcca3540c8933)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
4 years agobpo-42979: _zoneinfo exec function checks for PyDateTime_IMPORT failure (GH-24333...
Miss Islington (bot) [Wed, 27 Jan 2021 11:08:45 +0000 (03:08 -0800)] 
bpo-42979: _zoneinfo exec function checks for PyDateTime_IMPORT failure (GH-24333) (GH-24351)

Importing datetime can fail.
(cherry picked from commit eeb701adc0fc29ba803fddf133d917ff45639a00)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
Co-authored-by: Hai Shi <shihai1992@gmail.com>
4 years agobpo-43033: Fix the handling of PyObject_SetAttrString() in _zoneinfo.c (GH-24345...
Miss Islington (bot) [Wed, 27 Jan 2021 09:40:31 +0000 (01:40 -0800)] 
bpo-43033: Fix the handling of PyObject_SetAttrString() in _zoneinfo.c (GH-24345) (GH-24349)

(cherry picked from commit 5327f370344a627f1578d8183d197feb286371c6)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
4 years agobpo-43008: Make IDLE respect sys.excepthook (GH-24302)
Miss Islington (bot) [Wed, 27 Jan 2021 00:24:14 +0000 (16:24 -0800)] 
bpo-43008: Make IDLE respect sys.excepthook (GH-24302)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 7a34380ad788886f5ad50d4175ceb2d5715b8cff)

Co-authored-by: Ken <kenny2minecraft@gmail.com>
4 years ago[3.9] bpo-41841: Prepare IDLE NEWS for 3.9.2 (#GH-4343)
Terry Jan Reedy [Tue, 26 Jan 2021 18:59:18 +0000 (13:59 -0500)] 
[3.9] bpo-41841: Prepare IDLE NEWS for 3.9.2 (#GH-4343)

4 years ago[3.9] bpo-42383: pdb: do not fail to restart the target if the current directory...
Andrey Bienkowski [Tue, 26 Jan 2021 15:57:58 +0000 (15:57 +0000)] 
[3.9] bpo-42383: pdb: do not fail to restart the target if the current directory changed (GH-23412) (#24322)

4 years ago[3.9] bpo-42384: pdb: correctly populate sys.path[0] (GH-23338) (#24321)
Andrey Bienkowski [Mon, 25 Jan 2021 21:08:41 +0000 (21:08 +0000)] 
[3.9] bpo-42384: pdb: correctly populate sys.path[0] (GH-23338) (#24321)

4 years agobpo-43013: Fix old tkinter module names in idlelib (GH-24326)
Miss Islington (bot) [Mon, 25 Jan 2021 13:25:39 +0000 (05:25 -0800)] 
bpo-43013: Fix old tkinter module names in idlelib (GH-24326)

Lowercase 'tkColorChooser', 'tkFileDialog', 'tkSimpleDialog', and
'tkMessageBox' and remove 'tk'.  Just lowercase 'tkFont' as 'font'
is already used.  Adjust import.
(cherry picked from commit 879986d8a932c4524cb6ff822afc9537de16e28d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
4 years ago[3.9] bpo-33289: Return RGB triplet of ints instead of floats from tkinter.colorchoos...
Serhiy Storchaka [Mon, 25 Jan 2021 09:45:30 +0000 (11:45 +0200)] 
[3.9] bpo-33289: Return RGB triplet of ints instead of floats from tkinter.colorchooser (GH-6578). (GH-24318)

(cherry picked from commit 6713e869c4989c04318158b406c30a147ea52904)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
4 years agobpo-43013: Update idlelib code to 3.x (GH-24315)
Miss Islington (bot) [Sun, 24 Jan 2021 23:36:02 +0000 (15:36 -0800)] 
bpo-43013: Update idlelib code to 3.x  (GH-24315)

Remove 9 remaining '(object)' occurrences in class headers in idlelib
and 25 '()' occurrences in idlelib.idle_test class headers.
(cherry picked from commit 8dfe15625e6ea4357a13fec7989a0e6ba2bf1359)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
4 years agocloses bpo-43011: Fix DeprecationWarnings in test_ctypes (GH-24305)
Miss Islington (bot) [Sat, 23 Jan 2021 16:56:08 +0000 (08:56 -0800)] 
closes bpo-43011: Fix DeprecationWarnings in test_ctypes (GH-24305)

(cherry picked from commit f7fa64f0e87edc61d990ed51b4da722906a10928)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
4 years agobpo-40304: Correct type(name, bases, dict) doc (GH-19553)
Miss Islington (bot) [Fri, 22 Jan 2021 06:09:50 +0000 (22:09 -0800)] 
bpo-40304: Correct type(name, bases, dict) doc (GH-19553)

Co-authored-by: Éric Araujo <merwok@netwok.org>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
(cherry picked from commit 644d52818a6391535e5838fd57d58ffcb1163056)

Co-authored-by: Борис Верховский <boris.verk@gmail.com>
4 years agobpo-42780: Fix set_inheritable() for O_PATH file descriptors on Linux (GH-24172)...
cptpcrd [Thu, 21 Jan 2021 10:46:35 +0000 (05:46 -0500)] 
bpo-42780: Fix set_inheritable() for O_PATH file descriptors on Linux (GH-24172) (GH-24278)

(cherry picked from commit 7dc71c425cf6aa6a4070a418dce5d95ca435c79f)

4 years agobpo-42005: profile and cProfile catch BrokenPipeError (GH-22643)
Miss Islington (bot) [Wed, 20 Jan 2021 09:19:08 +0000 (01:19 -0800)] 
bpo-42005: profile and cProfile catch BrokenPipeError (GH-22643)

(cherry picked from commit 3554fa4abecfb77ac5fcaa5ce8310eeca5683960)

Co-authored-by: Zhiming Wang <i@zhimingwang.org>
4 years agobpo-41995: Handle allocation failure in _tracemalloc and _zoneinfo (GH-22635)
Miss Islington (bot) [Wed, 20 Jan 2021 09:03:28 +0000 (01:03 -0800)] 
bpo-41995: Handle allocation failure in _tracemalloc and _zoneinfo (GH-22635)

(cherry picked from commit f1ff800db1f9fa5ff8f2fa2863796a46bfa9ee46)

Co-authored-by: Yunlongs <lylgood@foxmail.com>
4 years agocloses bpo-42938: Replace snprintf with Python unicode formatting in ctypes param...
Miss Islington (bot) [Mon, 18 Jan 2021 21:29:31 +0000 (13:29 -0800)] 
closes bpo-42938: Replace snprintf with Python unicode formatting in ctypes param reprs. (GH-24247)

(cherry picked from commit 916610ef90a0d0761f08747f7b0905541f0977c7)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
Co-authored-by: Benjamin Peterson <benjamin@python.org>
4 years agobpo-42944 Fix Random.sample when counts is not None (GH-24235) (GH-24243)
Miss Islington (bot) [Mon, 18 Jan 2021 18:36:07 +0000 (10:36 -0800)] 
bpo-42944 Fix Random.sample when counts is not None (GH-24235) (GH-24243)

4 years ago[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but...
Jason R. Coombs [Sat, 16 Jan 2021 19:45:30 +0000 (14:45 -0500)] 
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but processor) (GH-23010) (#24232)

* Add test capturing missed expectation with uname_result._replace.

* bpo-42163: Override uname_result._make to allow uname_result._replace to work (for everything but 'processor'.

* Replace hard-coded length with one derived from the definition.

* Add test capturing missed expectation with copy/deepcopy on namedtuple (bpo-42189).

* bpo-42189: Exclude processor parameter when constructing uname_result.

* In _make, rely on __new__ to strip processor.

* Add blurb.

* iter is not necessary here.

* Rely on num_fields in __new__

* Add test for slices on uname

* Add test for copy and pickle.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
* import pickle

* Fix equality test after pickling.

* Simply rely on __reduce__ for pickling.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
4 years agobpo-42931: randbytes missing from random.__all__ (GH-24219) (GH-24225)
Miss Islington (bot) [Fri, 15 Jan 2021 18:21:52 +0000 (10:21 -0800)] 
bpo-42931: randbytes missing from random.__all__ (GH-24219) (GH-24225)

4 years agoDocs: Remove stray semicolon in init.rst (GH-23974)
Miss Islington (bot) [Thu, 14 Jan 2021 16:17:44 +0000 (08:17 -0800)] 
Docs: Remove stray semicolon in init.rst (GH-23974)

Removed stray semicolon which was causing the docs to render weirdly (it's the function right under the one [here](https://docs.python.org/3/c-api/init.htmlGH-c._PyInterpreterState_GetEvalFrameFunc)).
(cherry picked from commit 971235827754eee6c0d9f7d39b52fecdfd4cb7b4)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
4 years agobpo-33065: Fix problem debugging user classes with __repr__ method (GH-24183)
Miss Islington (bot) [Sun, 10 Jan 2021 07:30:43 +0000 (23:30 -0800)] 
bpo-33065: Fix problem debugging user classes with __repr__ method (GH-24183)

If __repr__ uses instance attributes, as normal, and one steps
through the __init__ method, debugger may try to get repr before
the instance attributes exist.  reprlib.repr handles the error.
(cherry picked from commit 81f87bbf9f65702062021a78abd9b8f82c98a414)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
4 years ago[3.9] bpo-42851: [Enum] remove brittle __init_subclass__ support (GH-24154) (GH-24155)
Ethan Furman [Thu, 7 Jan 2021 21:55:59 +0000 (13:55 -0800)] 
[3.9] bpo-42851: [Enum] remove brittle __init_subclass__ support (GH-24154) (GH-24155)

Solution to support calls to `__init_subclass__` with members defined is too brittle and breaks with certain mixins..
(cherry picked from commit a581a868d97f649aedf868a1d27865a10925c73a)

4 years ago[3.9] bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent...
Yair Frid [Thu, 7 Jan 2021 18:06:13 +0000 (20:06 +0200)] 
[3.9] bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent (GH-24100) (GH-24149)

This is a backport of
https://github.com/python/cpython/pull/24100

Automerge-Triggered-By: GH:brettcannon
4 years agobpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159)
Vladimir [Wed, 6 Jan 2021 20:57:24 +0000 (12:57 -0800)] 
bpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159)

(cherry picked from commit f9949f82e17c88609adb53eff3a7d5cd63a645bd)

4 years agobpo-42528: Improve the docs of most Py*_Check{,Exact} API calls (GH-23602) (GH-24139)
Miss Islington (bot) [Wed, 6 Jan 2021 12:54:18 +0000 (04:54 -0800)] 
bpo-42528: Improve the docs of most Py*_Check{,Exact} API calls (GH-23602) (GH-24139)

I think that none of these API calls can fail, but only few of them are
documented as such. Add the sentence "This function always succeeds" (which is
the same already used e.g. by PyNumber_Check) to all of them.
(cherry picked from commit 315fc52db17b19fe30aa9193f26adf69e18d8844)

Co-authored-by: Antonio Cuni <anto.cuni@gmail.com>
Co-authored-by: Antonio Cuni <anto.cuni@gmail.com>
4 years agobpo-14014: Clarify StreamWriter.reset() documentation (GH-13716)
Miss Islington (bot) [Wed, 6 Jan 2021 02:27:30 +0000 (18:27 -0800)] 
bpo-14014: Clarify StreamWriter.reset() documentation (GH-13716)

(cherry picked from commit 1a9f51ed12feb4d95ad6d0faf610a030c05b9f5e)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
4 years agobpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)
Steve Dower [Wed, 6 Jan 2021 00:09:08 +0000 (00:09 +0000)] 
bpo-42584: Update Windows installer to use SQLite 3.34.0 (GH-23675)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
4 years agobpo-41837: Updated Windows installer to include OpenSSL 1.1.1i (GH-24125)
Steve Dower [Tue, 5 Jan 2021 23:37:29 +0000 (23:37 +0000)] 
bpo-41837: Updated Windows installer to include OpenSSL 1.1.1i (GH-24125)

4 years ago[3.9] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674) (GH-24130)
Erlend Egeberg Aasland [Tue, 5 Jan 2021 22:52:55 +0000 (23:52 +0100)] 
[3.9] bpo-42584: Update macOS installer to use SQLite 3.34.0 (GH-23674) (GH-24130)

(cherry picked from commit c94ee13ad596d26d1859078bc09806aa59bb0000)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Automerge-Triggered-By: GH:ned-deily
4 years ago[3.9] bpo-40052: Fix alignment issue in PyVectorcall_Function() (GH-23999) (GH-24005)
Miss Islington (bot) [Tue, 5 Jan 2021 15:46:58 +0000 (07:46 -0800)] 
[3.9] bpo-40052: Fix alignment issue in PyVectorcall_Function() (GH-23999) (GH-24005)

```
In file included from /usr/include/python3.8/Python.h:147:
In file included from /usr/include/python3.8/abstract.h:837:
/usr/include/python3.8/cpython/abstract.h:91:11: error: cast from 'char *' to 'vectorcallfunc *'
(aka 'struct _object *(**)(struct _object *, struct _object *const *, unsigned long, struct _object *)')
increases required alignment from 1 to 8 [-Werror,-Wcast-align]

    ptr = (vectorcallfunc*)(((char *)callable) + offset);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-Authored-By: Andreas Schneider <asn@cryptomilk.org>
Co-Authored-By: Antoine Pitrou <antoine@python.org>
(cherry picked from commit 056c08211b402b4dbc1530a9de9d00ad5309909f)