]> git.ipfire.org Git - thirdparty/tor.git/log
thirdparty/tor.git
12 years agoFix two pre-coffee typos
Peter Palfrader [Mon, 15 Jul 2013 13:08:35 +0000 (15:08 +0200)] 
Fix two pre-coffee typos

12 years agoAnd a changes file for #9258
Peter Palfrader [Mon, 15 Jul 2013 08:55:11 +0000 (10:55 +0200)] 
And a changes file for #9258

12 years agoReject relative control socket paths and emit a warning.
Peter Palfrader [Mon, 15 Jul 2013 08:46:22 +0000 (10:46 +0200)] 
Reject relative control socket paths and emit a warning.

Previously we would accept relative paths, but only if they contained a
slash somewhere (not at the end).

Otherwise we would silently not work.  Closes: #9258.  Bugfix on
0.2.3.16-alpha.

12 years agoDocument get_parent_directory more
Peter Palfrader [Mon, 15 Jul 2013 08:46:11 +0000 (10:46 +0200)] 
Document get_parent_directory more

12 years agocosmetic cleanups
Roger Dingledine [Sun, 14 Jul 2013 06:49:34 +0000 (02:49 -0400)] 
cosmetic cleanups

12 years agoput sandbox.h in the tarball, so the tarball builds
Roger Dingledine [Sun, 14 Jul 2013 00:31:18 +0000 (20:31 -0400)] 
put sandbox.h in the tarball, so the tarball builds

12 years agoMerge remote-tracking branch 'public/gsoc-ctoader-cap-phase1-squashed'
Nick Mathewson [Fri, 12 Jul 2013 21:12:43 +0000 (17:12 -0400)] 
Merge remote-tracking branch 'public/gsoc-ctoader-cap-phase1-squashed'

12 years agoRemove a bogus semicolon spotted by Gisle Vanem
Nick Mathewson [Thu, 11 Jul 2013 19:53:35 +0000 (15:53 -0400)] 
Remove a bogus semicolon spotted by Gisle Vanem

12 years agoAdd a basic seccomp2 syscall filter on Linux
Cristian Toader [Mon, 17 Jun 2013 10:07:14 +0000 (13:07 +0300)] 
Add a basic seccomp2 syscall filter on Linux

It's controlled by the new Sandbox argument.  Right now, it's rather
coarse-grained, it's Linux-only, and it may break some features.

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Mon, 8 Jul 2013 15:35:48 +0000 (11:35 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMerge branch 'bug9200' into maint-0.2.4
Nick Mathewson [Mon, 8 Jul 2013 15:35:25 +0000 (11:35 -0400)] 
Merge branch 'bug9200' into maint-0.2.4

12 years agoAdd a comment and a check for why flag indices will be <= 63
Nick Mathewson [Mon, 8 Jul 2013 15:35:06 +0000 (11:35 -0400)] 
Add a comment and a check for why flag indices will be <= 63

12 years agoMerge remote-tracking branch 'karsten/geoip-manual-update-jul2013'
Nick Mathewson [Mon, 8 Jul 2013 13:23:39 +0000 (09:23 -0400)] 
Merge remote-tracking branch 'karsten/geoip-manual-update-jul2013'

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Mon, 8 Jul 2013 13:23:09 +0000 (09:23 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMerge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4
Nick Mathewson [Mon, 8 Jul 2013 13:22:49 +0000 (09:22 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4

12 years agoMerge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3
Nick Mathewson [Mon, 8 Jul 2013 13:22:00 +0000 (09:22 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.2' into maint-0.2.3

12 years agoUpdate to the July 2013 GeoIP database.
Karsten Loesing [Mon, 8 Jul 2013 08:21:28 +0000 (10:21 +0200)] 
Update to the July 2013 GeoIP database.

12 years agoAdd 2 new manual A1 substitutions.
Karsten Loesing [Mon, 8 Jul 2013 08:14:42 +0000 (10:14 +0200)] 
Add 2 new manual A1 substitutions.

12 years agoFIx undefined behavior in dirvote.c
Nick Mathewson [Wed, 3 Jul 2013 16:01:37 +0000 (12:01 -0400)] 
FIx undefined behavior in dirvote.c

 Fix a bug in the voting algorithm that could yield incorrect results
 when a non-naming authority declared too many flags. Fixes bug 9200;
 bugfix on 0.2.0.3-alpha.

Found by coverity scan.

12 years agoMerge remote-tracking branch 'linus/bug8530'
Nick Mathewson [Sat, 29 Jun 2013 20:02:13 +0000 (16:02 -0400)] 
Merge remote-tracking branch 'linus/bug8530'

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Sat, 29 Jun 2013 07:51:53 +0000 (03:51 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMerge branch 'bug9147' into maint-0.2.4
Nick Mathewson [Sat, 29 Jun 2013 07:50:37 +0000 (03:50 -0400)] 
Merge branch 'bug9147' into maint-0.2.4

12 years agoGive a warning when bufferevents are enabled.
Nick Mathewson [Sat, 29 Jun 2013 07:45:40 +0000 (03:45 -0400)] 
Give a warning when bufferevents are enabled.

Ticket 9147.

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Mon, 24 Jun 2013 16:55:29 +0000 (12:55 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoFix bug 9122: don't allow newdefaultoptions to be NULL
Nick Mathewson [Mon, 24 Jun 2013 13:56:25 +0000 (09:56 -0400)] 
Fix bug 9122: don't allow newdefaultoptions to be NULL

(This caused a crash that was reported as bug 9122, but the underlying
behavior has been wrong for a while.)

Fix on 0.2.3.9-alpha.

12 years agoFix #5584 - raise awareness of safer logging - warn about potentially unsafe config...
Marek Majkowski [Thu, 13 Jun 2013 16:29:14 +0000 (17:29 +0100)] 
Fix #5584 - raise awareness of safer logging - warn about potentially unsafe config options

12 years agoForward-port the 0.2.4.14-alpha changelog
Nick Mathewson [Tue, 18 Jun 2013 20:25:56 +0000 (16:25 -0400)] 
Forward-port the 0.2.4.14-alpha changelog

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Tue, 18 Jun 2013 18:47:15 +0000 (14:47 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMerge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4
Nick Mathewson [Tue, 18 Jun 2013 18:45:29 +0000 (14:45 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4

12 years agoCheck more return values in the unit tests
Nick Mathewson [Tue, 18 Jun 2013 16:31:03 +0000 (12:31 -0400)] 
Check more return values in the unit tests

12 years agoFix some problems with the bug9002 fix.
Nick Mathewson [Tue, 18 Jun 2013 15:54:57 +0000 (11:54 -0400)] 
Fix some problems with the bug9002 fix.

Fixes bug 9090; bug not in any released Tor.

12 years agoAttempt to un-confuse coverity about (false) double-free in bench_onion_ntor.
Nick Mathewson [Tue, 18 Jun 2013 15:33:15 +0000 (11:33 -0400)] 
Attempt to un-confuse coverity about (false) double-free in bench_onion_ntor.

12 years agoFix a couple of resource leaks in test_config.c
Nick Mathewson [Tue, 18 Jun 2013 15:28:30 +0000 (11:28 -0400)] 
Fix a couple of resource leaks in test_config.c

Spotted by Coverity Scan. Not in any released Tor.

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Tue, 18 Jun 2013 14:25:30 +0000 (10:25 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoTweak bug9063_redux patch: {n_p}_chan_cells, not {n,p}_conn_cells
Nick Mathewson [Tue, 18 Jun 2013 14:25:10 +0000 (10:25 -0400)] 
Tweak bug9063_redux patch: {n_p}_chan_cells, not {n,p}_conn_cells

12 years agoMerge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4
Nick Mathewson [Tue, 18 Jun 2013 14:23:03 +0000 (10:23 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4

Conflicts:
src/or/config.c
src/or/relay.c

12 years agoMerge branch 'bug9063_redux_023_squashed' into maint-0.2.3
Nick Mathewson [Tue, 18 Jun 2013 14:16:47 +0000 (10:16 -0400)] 
Merge branch 'bug9063_redux_023_squashed' into maint-0.2.3

12 years agoImplement a real OOM-killer for too-long circuit queues.
Nick Mathewson [Sun, 16 Jun 2013 13:55:44 +0000 (09:55 -0400)] 
Implement a real OOM-killer for too-long circuit queues.

This implements "algorithm 1" from my discussion of bug #9072: on OOM,
find the circuits with the longest queues, and kill them.  It's also a
fix for #9063 -- without the side-effects of bug #9072.

The memory bounds aren't perfect here, and you need to be sure to
allow some slack for the rest of Tor's usage.

This isn't a perfect fix; the rest of the solutions I describe on
codeable.

12 years agoInvoke binaries in $PATH rather than by absolute path.
Linus Nordberg [Wed, 5 Jun 2013 13:48:57 +0000 (15:48 +0200)] 
Invoke binaries in $PATH rather than by absolute path.

That security measure costs more than it gives.
So, keep your PATH sane and we can run this script on more than
one system.

12 years agoMerge remote-tracking branch 'public/bug9082'
Nick Mathewson [Mon, 17 Jun 2013 15:57:55 +0000 (11:57 -0400)] 
Merge remote-tracking branch 'public/bug9082'

12 years agoFix bug 9082: avoid leak when freeing destroy cell queues
Nick Mathewson [Mon, 17 Jun 2013 15:30:56 +0000 (11:30 -0400)] 
Fix bug 9082: avoid leak when freeing destroy cell queues

In my #7912 fix, there wasn't any code to remove entries from the
(channel, circuit ID)->circuit map corresponding to queued but un-sent
DESTROYs.

Spotted by skruffy. Fixes bug 9082; bug not in any released Tor.

12 years agoLimit hidden service descriptors to at most 10 guard nodes.
Nick Mathewson [Mon, 17 Jun 2013 00:23:33 +0000 (20:23 -0400)] 
Limit hidden service descriptors to at most 10 guard nodes.

Fixes bug 9002; bugfix on 0.1.1.11-alpha (which introduced guard
nodes), or on 0.0.6pre1 (which introduced hidden services).

12 years agoforward-port 0.2.4.13-alpha changelog
Roger Dingledine [Sun, 16 Jun 2013 19:12:23 +0000 (15:12 -0400)] 
forward-port 0.2.4.13-alpha changelog

12 years agoMerge branch 'bug9072-024' into bug9072-025
Andrea Shepard [Sat, 15 Jun 2013 09:27:23 +0000 (02:27 -0700)] 
Merge branch 'bug9072-024' into bug9072-025

12 years agoMerge branch 'bug9072-023' into bug9072-024
Andrea Shepard [Sat, 15 Jun 2013 09:20:19 +0000 (02:20 -0700)] 
Merge branch 'bug9072-023' into bug9072-024

12 years agoDisable middle relay queue overfill detection code due to possible guard discovery...
Andrea Shepard [Sat, 15 Jun 2013 09:16:00 +0000 (02:16 -0700)] 
Disable middle relay queue overfill detection code due to possible guard discovery attack

12 years agoInstead of testing for __GNUC__, use CHECK_SCANF, like CHECK_PRINTF.
dana koch [Thu, 13 Jun 2013 12:04:01 +0000 (22:04 +1000)] 
Instead of testing for __GNUC__, use CHECK_SCANF, like CHECK_PRINTF.

This lets us have the possibility of fine-tuning the check in the tor_sscanf test cases at a later date.

12 years agoUse CHUTNEY_PATH to find Chutney.
Linus Nordberg [Wed, 5 Jun 2013 13:48:57 +0000 (15:48 +0200)] 
Use CHUTNEY_PATH to find Chutney.

12 years agoMerge branch 'circuit_queue_cap-0.2.5-squashed'
Nick Mathewson [Fri, 14 Jun 2013 05:50:17 +0000 (01:50 -0400)] 
Merge branch 'circuit_queue_cap-0.2.5-squashed'

Conflicts:
src/or/relay.c

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Fri, 14 Jun 2013 05:48:16 +0000 (01:48 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

Using "ours" strategy to avoid taking commits

12 years agoMerge branch 'circuit_queue_cap-0.2.4-squashed' into maint-0.2.4
Nick Mathewson [Fri, 14 Jun 2013 05:45:46 +0000 (01:45 -0400)] 
Merge branch 'circuit_queue_cap-0.2.4-squashed' into maint-0.2.4

12 years agoMerge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4
Nick Mathewson [Fri, 14 Jun 2013 05:45:35 +0000 (01:45 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4

Using "ours" strategy to avoid taking changes.

12 years agoMerge branch 'circuit_queue_cap-0.2.3-squashed' into maint-0.2.3
Nick Mathewson [Fri, 14 Jun 2013 05:44:46 +0000 (01:44 -0400)] 
Merge branch 'circuit_queue_cap-0.2.3-squashed' into maint-0.2.3

12 years agoFix signed/unsigned comparison warning
Nick Mathewson [Fri, 14 Jun 2013 05:41:53 +0000 (01:41 -0400)] 
Fix signed/unsigned comparison warning

12 years agoIncrease the limit so leaky pipe might work
Nick Mathewson [Fri, 14 Jun 2013 05:40:35 +0000 (01:40 -0400)] 
Increase the limit so leaky pipe might work

12 years agoIncrease the limit so leaky pipe might work
Nick Mathewson [Fri, 14 Jun 2013 05:37:22 +0000 (01:37 -0400)] 
Increase the limit so leaky pipe might work

12 years agoIncrease the limit so leaky pipe might work
Nick Mathewson [Fri, 14 Jun 2013 05:35:21 +0000 (01:35 -0400)] 
Increase the limit so leaky pipe might work

12 years agoDon't queue more cells as a middle relay than the spec allows to be in flight
Andrea Shepard [Fri, 14 Jun 2013 03:32:31 +0000 (20:32 -0700)] 
Don't queue more cells as a middle relay than the spec allows to be in flight

12 years agoDon't queue more cells as a middle relay than the spec allows to be in flight
Andrea Shepard [Fri, 14 Jun 2013 03:49:01 +0000 (20:49 -0700)] 
Don't queue more cells as a middle relay than the spec allows to be in flight

12 years agoDon't queue more cells as a middle relay than the spec allows to be in flight
Andrea Shepard [Fri, 14 Jun 2013 03:41:00 +0000 (20:41 -0700)] 
Don't queue more cells as a middle relay than the spec allows to be in flight

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Fri, 14 Jun 2013 01:59:27 +0000 (21:59 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMerge branch 'bug9047' into maint-0.2.4
Nick Mathewson [Fri, 14 Jun 2013 01:58:36 +0000 (21:58 -0400)] 
Merge branch 'bug9047' into maint-0.2.4

12 years agoDefine SEEK_SET for platforms that lack it.
Nick Mathewson [Fri, 14 Jun 2013 01:56:35 +0000 (21:56 -0400)] 
Define SEEK_SET for platforms that lack it.

12 years agoRename networkstatus_dl_interval() -> networkstatus_dl_check_interval()
Nick Mathewson [Thu, 13 Jun 2013 16:44:46 +0000 (12:44 -0400)] 
Rename networkstatus_dl_interval() -> networkstatus_dl_check_interval()

12 years agoMerge remote-tracking branch 'linus/bug8532'
Nick Mathewson [Thu, 13 Jun 2013 16:42:49 +0000 (12:42 -0400)] 
Merge remote-tracking branch 'linus/bug8532'

12 years agoIf we write the annotation but not the microdescriptor, rewind.
Nick Mathewson [Thu, 13 Jun 2013 16:29:01 +0000 (12:29 -0400)] 
If we write the annotation but not the microdescriptor, rewind.

This fixes bug 9047 (and some parts of 9031, 8922, 8883 that weren't
fixed in 8822).  Bugfix on 0.2.2.6-alpha.

12 years agoAdd make target test-network running traffic tests in a Chutney network.
Linus Nordberg [Wed, 5 Jun 2013 13:48:57 +0000 (15:48 +0200)] 
Add make target test-network running traffic tests in a Chutney network.

This implements ticket #8530.

12 years agoMerge remote-tracking branch 'public/bug7912_squashed'
Nick Mathewson [Thu, 13 Jun 2013 14:31:02 +0000 (10:31 -0400)] 
Merge remote-tracking branch 'public/bug7912_squashed'

12 years agoFix compile warnings wrt printf formating of int64_t
Nick Mathewson [Thu, 13 Jun 2013 14:30:34 +0000 (10:30 -0400)] 
Fix compile warnings wrt printf formating of int64_t

12 years agoAdd a changes file for bug 7912
Nick Mathewson [Thu, 13 Jun 2013 14:20:30 +0000 (10:20 -0400)] 
Add a changes file for bug 7912

I'm calling it a bugfix on 0.2.0.1-alpha, since that's where cell
queues were first introduced.

12 years agoAdd destroy balance tracking and logging to circuitmux
Andrea Shepard [Thu, 13 Jun 2013 05:22:21 +0000 (22:22 -0700)] 
Add destroy balance tracking and logging to circuitmux

12 years agoImplementation of a fix for bug 7912
Nick Mathewson [Thu, 21 Mar 2013 18:51:27 +0000 (14:51 -0400)] 
Implementation of a fix for bug 7912

I added the code to pass a destroy cell to a queueing function rather
than writing it immediately, and the code to remember that we
shouldn't reuse the circuit id until the destroy is actually sent, and
the code to release the circuit id once the destroy has been sent...
and then I finished by hooking destroy_cell_queue into the rest of
Tor.

12 years agoCode to track on a circuit whether it has a "pending" delete cell
Nick Mathewson [Fri, 15 Mar 2013 14:45:48 +0000 (10:45 -0400)] 
Code to track on a circuit whether it has a "pending" delete cell

This will be used in a fix for bug7912.

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Thu, 13 Jun 2013 13:43:53 +0000 (09:43 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMerge remote-tracking branch 'public/bug8822' into maint-0.2.4
Nick Mathewson [Thu, 13 Jun 2013 13:40:32 +0000 (09:40 -0400)] 
Merge remote-tracking branch 'public/bug8822' into maint-0.2.4

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Thu, 13 Jun 2013 01:28:09 +0000 (21:28 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoFix the biggest errors in doc/HACKING
Nick Mathewson [Thu, 13 Jun 2013 01:27:30 +0000 (21:27 -0400)] 
Fix the biggest errors in doc/HACKING

We can wait for 0.2.5 for a full rewrite.  #8964

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Thu, 13 Jun 2013 01:14:31 +0000 (21:14 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoRemove various outdated documents.
Nick Mathewson [Thu, 13 Jun 2013 01:07:27 +0000 (21:07 -0400)] 
Remove various outdated documents.

doc/TODO and doc/spec/README were placeholders to tell people where to
look for the real TODO and README stuff -- we replaced them years ago,
though.

authority-policy, v3-authority-howto, and torel-design.txt belong in
torspec.  I'm putting them in attic there since I think they may be in
large part obsolete, but someone can rescue them if they're not.

translations.txt is outdated, and refers to lots of programs other
than Tor.  We have much better translation resources on the website
now.

tor-win32-mingw-creation.txt is pending review of a revised version
for 0.2.5 (see ticket #4520), but there's no reason to ship this one
while we're waiting for an accurate version.

the tor-rpm-creation.txt isn't obsolete AFAIK, but it belongs in
doc/contrib if anywhere.

Resolves bug #8965.

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Thu, 13 Jun 2013 00:55:53 +0000 (20:55 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMerge remote-tracking branch 'andrea/bug8639_v3' into maint-0.2.4
Nick Mathewson [Thu, 13 Jun 2013 00:55:35 +0000 (20:55 -0400)] 
Merge remote-tracking branch 'andrea/bug8639_v3' into maint-0.2.4

12 years agoIssue #9043 - changelog entry
Marek Majkowski [Tue, 11 Jun 2013 11:17:39 +0000 (12:17 +0100)] 
Issue #9043 - changelog entry

12 years agoFix #9043 - simplyfy the code and use EVP_PKEY_cmp instead of pkey_eq / tor_tls_evp_p...
Marek Majkowski [Mon, 10 Jun 2013 19:30:57 +0000 (20:30 +0100)] 
Fix #9043 - simplyfy the code and use EVP_PKEY_cmp instead of pkey_eq / tor_tls_evp_pkey_eq

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Wed, 12 Jun 2013 17:01:14 +0000 (13:01 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMake all consumers of microdesc_t.body tolerate NULL
Nick Mathewson [Wed, 12 Jun 2013 16:12:11 +0000 (12:12 -0400)] 
Make all consumers of microdesc_t.body tolerate NULL

This is another fix to try to mitigate recurrences of 8031/8822.

12 years agoUnmap the microdescriptor cache before replacing it.
Nick Mathewson [Wed, 12 Jun 2013 16:04:33 +0000 (12:04 -0400)] 
Unmap the microdescriptor cache before replacing it.

This is a reprise of the fix in bdff7e3299d786905c1f6 reintroduced
that bug.  Briefly: windows doesn't seem to like deleting a mapped
file.  I tried adding the PROT_SHARED_DELETE flag to the createfile
all, but that didn't actually fix this issue.  Fortunately, the unit
test I added in 4f4fc63fea0589a4fa03f3859dc27860cdde75af should
prevent us from making this particular screw-up again.

This patch also tries to limit the crash potential of a failure to
write by a little bit, although it could do a better job of retaining
microdescriptor bodies.

Fix for bug 8822, bugfix on 0.2.4.12-alpha.

12 years agoRevert "Use the FILE_SHARE_DELETE flag for CreateFile on a mapping"
Nick Mathewson [Wed, 12 Jun 2013 14:45:48 +0000 (10:45 -0400)] 
Revert "Use the FILE_SHARE_DELETE flag for CreateFile on a mapping"

This reverts commit 884a0e269c382f9e927d8c8b1ef4ef9d2d48379d.

I'm reverting this because it doesn't actually make the problem go
away.  It appears that instead we need to do unmap-then-replace.

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Wed, 12 Jun 2013 14:01:10 +0000 (10:01 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMerge remote-tracking branch 'public/bug2077_share_delete' into maint-0.2.4
Nick Mathewson [Wed, 12 Jun 2013 14:00:33 +0000 (10:00 -0400)] 
Merge remote-tracking branch 'public/bug2077_share_delete' into maint-0.2.4

12 years agoUse the FILE_SHARE_DELETE flag for CreateFile on a mapping
Nick Mathewson [Wed, 12 Jun 2013 13:53:46 +0000 (09:53 -0400)] 
Use the FILE_SHARE_DELETE flag for CreateFile on a mapping

A comment by rransom on #8795 taken together with a comment by doorss
recorded on #2077 suggest that *every* attempt to replace the md cache
will fail on Vista/Win7 if we don't have the FILE_SHARE_DELETE flag
passed to CreateFile, and if we try to replace the file ourselves
before unmapping it.  I'm adding the FILE_SHARE_DELETE, since that's
this simplest fix.  Broken indexers (the favored #2077 hypothesis)
could still cause trouble here, but at least this patch should make us
stop stepping on our own feet.

Likely fix for #2077 and its numerous duplicates. Bugfix on
0.2.2.6-alpha, which first had a microdescriptor cache that would get
replaced before remapping it.

12 years agoExpand microdesc cache tests
Nick Mathewson [Wed, 12 Jun 2013 13:30:09 +0000 (09:30 -0400)] 
Expand microdesc cache tests

Is it possible that *every* attempt to replace the microdesc cache on
windows 7 is going to fail because of our lack of FILE_SHARE_DELETE
while opening the file?  If so, this test will catch #2077 and let us
know when it's fixed.

12 years agoUse double-quotes for regular_mans, not brackets.
dana koch [Wed, 12 Jun 2013 12:35:46 +0000 (22:35 +1000)] 
Use double-quotes for regular_mans, not brackets.

This is a bashism; on systems where sh is not bash (eg., non-Linux, or
Ubuntu using dash), this breaks with a syntax error. This also doesn't
work properly in bash: only the first item is iterated on.

12 years agoHide consensus download interval, depending on TestingTorNetwork, in a macro.
Linus Nordberg [Wed, 5 Jun 2013 13:48:57 +0000 (15:48 +0200)] 
Hide consensus download interval, depending on TestingTorNetwork, in a macro.

12 years agoFix tor-fw-helper exit code.
Arlo Breault [Fri, 7 Jun 2013 18:24:39 +0000 (11:24 -0700)] 
Fix tor-fw-helper exit code.

It's returning the number of initialized backends.

(changes file added by nickm; this is a fix for bug #9030)

12 years agoFix "make check-spaces"
Nick Mathewson [Mon, 10 Jun 2013 17:51:53 +0000 (13:51 -0400)] 
Fix "make check-spaces"

12 years agoMake OPENSSL_free(dh_string_repr) conditional.
Nick Mathewson [Mon, 10 Jun 2013 17:49:13 +0000 (13:49 -0400)] 
Make OPENSSL_free(dh_string_repr) conditional.

12 years agoMerge remote-tracking branch 'majek/bug5170'
Nick Mathewson [Mon, 10 Jun 2013 17:47:57 +0000 (13:47 -0400)] 
Merge remote-tracking branch 'majek/bug5170'

12 years agoMerge remote-tracking branch 'origin/maint-0.2.4'
Nick Mathewson [Mon, 10 Jun 2013 16:28:30 +0000 (12:28 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.4'

12 years agoMerge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4
Nick Mathewson [Mon, 10 Jun 2013 16:26:39 +0000 (12:26 -0400)] 
Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4

12 years agoMerge branch 'bug9017' into maint-0.2.3
Nick Mathewson [Mon, 10 Jun 2013 16:25:14 +0000 (12:25 -0400)] 
Merge branch 'bug9017' into maint-0.2.3