]> git.ipfire.org Git - thirdparty/tor.git/log
thirdparty/tor.git
10 years agoMerge remote-tracking branch 'origin/maint-0.2.5'
Nick Mathewson [Mon, 12 Jan 2015 05:59:48 +0000 (00:59 -0500)] 
Merge remote-tracking branch 'origin/maint-0.2.5'

10 years agoMerge remote-tracking branch 'public/bug14129_024' into maint-0.2.5
Nick Mathewson [Mon, 12 Jan 2015 05:59:29 +0000 (00:59 -0500)] 
Merge remote-tracking branch 'public/bug14129_024' into maint-0.2.5

10 years agoActually remove LOCALSTATEDIR@/run/tor line from tor.service.in
Nick Mathewson [Mon, 12 Jan 2015 01:49:19 +0000 (20:49 -0500)] 
Actually remove LOCALSTATEDIR@/run/tor line from tor.service.in

10 years agoFix build on systemdless systems
Nick Mathewson [Mon, 12 Jan 2015 01:47:15 +0000 (20:47 -0500)] 
Fix build on systemdless systems

Fixes bug 14170.

10 years agochanges file for bug13805
Nick Mathewson [Sun, 11 Jan 2015 16:27:33 +0000 (11:27 -0500)] 
changes file for bug13805

10 years agosystemd changes for 13805 as recommened by Tomasz on that ticket.
Nick Mathewson [Sun, 11 Jan 2015 16:26:08 +0000 (11:26 -0500)] 
systemd changes for 13805 as recommened by Tomasz on that ticket.

10 years agoMerge remote-tracking branch 'candrews/issue13805'
Nick Mathewson [Sun, 11 Jan 2015 16:24:48 +0000 (11:24 -0500)] 
Merge remote-tracking branch 'candrews/issue13805'

10 years agoFix unused-parameter warning in systemd_watchdog_callback
Nick Mathewson [Sun, 11 Jan 2015 16:19:51 +0000 (11:19 -0500)] 
Fix unused-parameter warning in systemd_watchdog_callback

10 years agochanges file for 14141
Nick Mathewson [Sun, 11 Jan 2015 16:19:12 +0000 (11:19 -0500)] 
changes file for 14141

10 years agofix and enable systemd watchdog
Tomasz Torcz [Fri, 9 Jan 2015 22:42:16 +0000 (23:42 +0100)] 
fix and enable systemd watchdog

  There were following problems:
  - configure.ac wrongly checked for defined HAVE_SYSTEMD; this
    wasn't working, so the watchdog code was not compiled in.
    Replace library search with explicit version check
  - sd_notify() watchdog call was unsetting NOTIFY_SOCKET from env;
    this means only first "watchdog ping" was delivered, each
    subsequent one did not have socket to be sent to and systemd
    was killing service
  - after those fixes, enable Watchdog in systemd unit with one
    minute intervals

10 years agosend more details about daemon status to supervisor
Tomasz Torcz [Fri, 9 Jan 2015 21:44:00 +0000 (22:44 +0100)] 
send more details about daemon status to supervisor

  If running under systemd, send back information when reloading
configuration and gracefully shutting down.  This gives administator
more information about current Tor daemon state.

10 years agosend PID of the main daemon to supervisor
Tomasz Torcz [Fri, 9 Jan 2015 21:17:50 +0000 (22:17 +0100)] 
send PID of the main daemon to supervisor

  If running under systemd, notify the supervisor about current PID
of Tor daemon.  This makes systemd unit simpler and more robust:
it will do the right thing regardless of RunAsDaemon settings.

10 years agoMerge remote-tracking branch 'teor/nickm-bug13401'
Nick Mathewson [Sun, 11 Jan 2015 16:10:23 +0000 (11:10 -0500)] 
Merge remote-tracking branch 'teor/nickm-bug13401'

10 years agoMerge remote-tracking branch 'origin/maint-0.2.5'
Nick Mathewson [Sun, 11 Jan 2015 16:05:31 +0000 (11:05 -0500)] 
Merge remote-tracking branch 'origin/maint-0.2.5'

10 years agoDon't crash on torrc Vi[rtualAddrNetworkIPv[4|6]] with no option value
teor [Sun, 11 Jan 2015 08:33:04 +0000 (19:33 +1100)] 
Don't crash on torrc Vi[rtualAddrNetworkIPv[4|6]] with no option value

Check for a missing option value in parse_virtual_addr_network
before asserting on the NULL in tor_addr_parse_mask_ports.
This avoids crashing on torrc lines like Vi[rtualAddrNetworkIPv[4|6]]
when no value follows the option.

Bugfix on 0.2.3 (de4cc126cbb5 on 24 November 2012), fixes #14142.

10 years agoFix tortls.c build with GCC<4.6
Nick Mathewson [Sat, 10 Jan 2015 22:25:16 +0000 (17:25 -0500)] 
Fix tortls.c build with GCC<4.6

apparantly, "pragma GCC diagnostic push/pop" don't exist with older versions.

Fixes bug in 740e592790f570c446cbb5e6d4a77f842f75; bug not in any
released Tor.

10 years agoBetter workaround for CFLAGS issues from #14072; fixes #14162
Nick Mathewson [Sat, 10 Jan 2015 22:21:11 +0000 (17:21 -0500)] 
Better workaround for CFLAGS issues from #14072; fixes #14162

When I applied patch fcc78e5f8a3249eadfea31db, I somehow broke
stack trace symbols on Linux.  I'll leave it to others to figure out
why that happens.  This should be better.  Really.

Fixes bug 14162; bug not in any released version of Tor.

10 years agoIgnore warning for redundant decl in openssl/srtp.h
Nick Mathewson [Sat, 10 Jan 2015 21:06:25 +0000 (16:06 -0500)] 
Ignore warning for redundant decl in openssl/srtp.h

10 years agoMerge remote-tracking branch 'teor/fix-typos'
Nick Mathewson [Sat, 10 Jan 2015 21:00:12 +0000 (16:00 -0500)] 
Merge remote-tracking branch 'teor/fix-typos'

10 years agoSpeed up hidden service bootstrap by reducing the initial post delay
teor [Sat, 10 Jan 2015 11:20:29 +0000 (22:20 +1100)] 
Speed up hidden service bootstrap by reducing the initial post delay

Drop the MIN_REND_INITIAL_POST_DELAY on a testing network to 5 seconds,
but keep the default at 30 seconds.

Reduces the hidden service bootstrap to 25 seconds from around 45 seconds.
Change the default src/test/test-network.sh delay to 25 seconds.

Closes ticket 13401.

10 years agoCreate TestingDirAuthVoteHSDir like TestingDirAuthVoteExit/Guard
teor [Sat, 10 Jan 2015 10:43:31 +0000 (21:43 +1100)] 
Create TestingDirAuthVoteHSDir like TestingDirAuthVoteExit/Guard

TestingDirAuthVoteHSDir ensures that authorities vote the HSDir flag
for the listed relays regardless of uptime or ORPort connectivity.
Respects the value of VoteOnHidServDirectoriesV2.

Partial fix for bug 14067.

10 years agoSmaller RendPostPeriod on test networks
Nick Mathewson [Mon, 5 Jan 2015 01:10:53 +0000 (20:10 -0500)] 
Smaller RendPostPeriod on test networks

This patch makes the minimum 5 seconds, and the default 2 minutes.

Closes 13401.

10 years agoFix a minor misspelling in util.c
teor [Sat, 10 Jan 2015 04:52:55 +0000 (15:52 +1100)] 
Fix a minor misspelling in util.c

10 years agoAllow two ISO times to appear in EntryGuardDownSince.
Nick Mathewson [Fri, 9 Jan 2015 13:50:56 +0000 (08:50 -0500)] 
Allow two ISO times to appear in EntryGuardDownSince.

When I made time parsing more strict, I broke the
EntryGuardDownSince line, which relied on two concatenated ISO times
being parsed as a single time.

Fixes bug 14136. Bugfix on 7984fc153112baa5. Bug not in any released
version of Tor.

10 years agoAvoid attempts to double-remove edge connections from the DNS resolver.
Nick Mathewson [Thu, 8 Jan 2015 16:00:21 +0000 (11:00 -0500)] 
Avoid attempts to double-remove edge connections from the DNS resolver.

Also, avoid crashing when we attempt to double-remove an edge
connection from the DNS resolver: just log a bug warning instead.

Fixes bug 14129.  Bugfix on 0d20fee2fbd48978, which was in 0.0.7rc1.

jowr found the bug.  cypherpunks wrote the fix.  I added the log
message and removed the assert.

10 years agofix new mingw64 compilation warnings
Nick Mathewson [Thu, 8 Jan 2015 15:44:30 +0000 (10:44 -0500)] 
fix new mingw64 compilation warnings

10 years agoUnconfuse coverity when it sees the systemd headers
Nick Mathewson [Thu, 8 Jan 2015 02:09:41 +0000 (21:09 -0500)] 
Unconfuse coverity when it sees the systemd headers

10 years agoMerge branch 'ticket14128_squashed'
Nick Mathewson [Wed, 7 Jan 2015 18:19:57 +0000 (13:19 -0500)] 
Merge branch 'ticket14128_squashed'

10 years agoGETINFO bw-event-cache to get information on recent BW events
Nick Mathewson [Wed, 7 Jan 2015 16:37:23 +0000 (11:37 -0500)] 
GETINFO bw-event-cache to get information on recent BW events

Closes 14128; useful to regain functionality lost because of 13988.

10 years agoMerge remote-tracking branch 'public/bug12985_025'
Nick Mathewson [Wed, 7 Jan 2015 16:55:50 +0000 (11:55 -0500)] 
Merge remote-tracking branch 'public/bug12985_025'

10 years agoMerge remote-tracking branch 'public/bug12985_024' into bug12985_025
Nick Mathewson [Wed, 7 Jan 2015 16:54:33 +0000 (11:54 -0500)] 
Merge remote-tracking branch 'public/bug12985_024' into bug12985_025

10 years agoClarify why bug12985 is a thing
Nick Mathewson [Wed, 7 Jan 2015 16:52:24 +0000 (11:52 -0500)] 
Clarify why bug12985 is a thing

10 years agoMerge remote-tracking branch 'public/bug13988_025'
Nick Mathewson [Wed, 7 Jan 2015 16:45:24 +0000 (11:45 -0500)] 
Merge remote-tracking branch 'public/bug13988_025'

10 years agoappease "make check-spaces"
Nick Mathewson [Wed, 7 Jan 2015 15:09:09 +0000 (10:09 -0500)] 
appease "make check-spaces"

10 years agoMerge branch 'bug9286_v3_squashed'
Nick Mathewson [Wed, 7 Jan 2015 15:06:50 +0000 (10:06 -0500)] 
Merge branch 'bug9286_v3_squashed'

10 years agoStop accepting milliseconds in various directory contexts
Nick Mathewson [Fri, 19 Jul 2013 03:45:40 +0000 (23:45 -0400)] 
Stop accepting milliseconds in various directory contexts

Have clients and authorities both have new behavior, since the
fix for bug 11243 has gone in.  But make clients still accept
accept old bogus HSDir descriptors, to avoid fingerprinting trickery.

Fixes bug 9286.

10 years agoMerge remote-tracking branch 'origin/maint-0.2.5'
Nick Mathewson [Wed, 7 Jan 2015 12:50:14 +0000 (07:50 -0500)] 
Merge remote-tracking branch 'origin/maint-0.2.5'

10 years agoEnlarge the buffer for a line in a bw file
Sebastian Hahn [Wed, 7 Jan 2015 11:43:21 +0000 (12:43 +0100)] 
Enlarge the buffer for a line in a bw file

10 years agoSpelling -- readyness->readiness.
Nick Mathewson [Tue, 6 Jan 2015 22:10:27 +0000 (17:10 -0500)] 
Spelling -- readyness->readiness.

10 years agoFix obsolete usage of test_{str_},eq macros
Nick Mathewson [Tue, 6 Jan 2015 20:25:20 +0000 (15:25 -0500)] 
Fix obsolete usage of test_{str_},eq macros

10 years agoMerge remote-tracking branch 'public/bug13661_025'
Nick Mathewson [Tue, 6 Jan 2015 20:16:28 +0000 (15:16 -0500)] 
Merge remote-tracking branch 'public/bug13661_025'

10 years agoMerge branch 'exitnode_10067_squashed'
Nick Mathewson [Tue, 6 Jan 2015 20:15:18 +0000 (15:15 -0500)] 
Merge branch 'exitnode_10067_squashed'

Conflicts:
src/or/or.h

10 years agochanges file for 10067
Nick Mathewson [Thu, 13 Nov 2014 15:50:37 +0000 (10:50 -0500)] 
changes file for 10067

10 years agoAdd an ExitRelay option to override ExitPolicy
Nick Mathewson [Thu, 13 Nov 2014 15:48:15 +0000 (10:48 -0500)] 
Add an ExitRelay option to override ExitPolicy

If we're not a relay, we ignore it.

If it's set to 1, we obey ExitPolicy.

If it's set to 0, we force ExitPolicy to 'reject *:*'

And if it's set to auto, then we warn the user if they're running an
exit, and tell them how they can stop running an exit if they didn't
mean to do that.

Fixes ticket 10067

10 years agoMerge remote-tracking branch 'public/bug14116_025'
Nick Mathewson [Tue, 6 Jan 2015 19:28:02 +0000 (14:28 -0500)] 
Merge remote-tracking branch 'public/bug14116_025'

10 years agoMerge remote-tracking branch 'public/bug12509_025'
Nick Mathewson [Tue, 6 Jan 2015 19:15:08 +0000 (14:15 -0500)] 
Merge remote-tracking branch 'public/bug12509_025'

10 years agoUse package-config output for -lsystemd correctly
Nick Mathewson [Tue, 6 Jan 2015 19:05:35 +0000 (14:05 -0500)] 
Use package-config output for -lsystemd correctly

In systemd 209, they deprecated -lsystemd-daemon in favor of
-lsystemd.  So we'd better actually look at the pkg-config output,
or we'll get warnings on newer distributions.

For some as-yet-unknown-to-me reason, setting CFLAGS so early makes
it so -O2 -g doesn't get added to it later.  So, adding it myself
later.  Perhaps a better fix here can be found.

Fixes 14072; bugfix on 0.2.6.2-alpha.  Based on a patch from h.venev

10 years agoMerge remote-tracking branch 'public/feature11791'
Nick Mathewson [Tue, 6 Jan 2015 18:52:54 +0000 (13:52 -0500)] 
Merge remote-tracking branch 'public/feature11791'

10 years agochanges file for 4385211caf6ad4cf34c0a3a
Nick Mathewson [Tue, 6 Jan 2015 18:45:57 +0000 (13:45 -0500)] 
changes file for 4385211caf6ad4cf34c0a3a

10 years agoMerge remote-tracking branch 'tvdw/from-the-archive'
Nick Mathewson [Tue, 6 Jan 2015 18:44:13 +0000 (13:44 -0500)] 
Merge remote-tracking branch 'tvdw/from-the-archive'

10 years agoWhitespace fix
Tom van der Woerdt [Tue, 6 Jan 2015 18:41:29 +0000 (19:41 +0100)] 
Whitespace fix

10 years agoMinor IPv6-related memory leak fixes
Tom van der Woerdt [Tue, 6 Jan 2015 18:40:23 +0000 (19:40 +0100)] 
Minor IPv6-related memory leak fixes

10 years agoMinor documentation fixes
Tom van der Woerdt [Tue, 6 Jan 2015 18:39:52 +0000 (19:39 +0100)] 
Minor documentation fixes

10 years agoMake test_cmdline_args.py work on Windows
Nick Mathewson [Tue, 6 Jan 2015 18:26:52 +0000 (13:26 -0500)] 
Make test_cmdline_args.py work on Windows

Patch from Gisle Vanem on tor-dev ml

10 years agohave 'make {clean,reset_gcov}' remove gcov files in subdirectories
Nick Mathewson [Tue, 6 Jan 2015 14:01:59 +0000 (09:01 -0500)] 
have 'make {clean,reset_gcov}' remove gcov files in subdirectories

10 years agomake "make test-stem" run stem tests on tor
Nick Mathewson [Mon, 5 Jan 2015 16:52:36 +0000 (11:52 -0500)] 
make "make test-stem" run stem tests on tor

Closes ticket 14107.

10 years agoDon't crash on malformed EXTENDCIRCUIT.
Nick Mathewson [Tue, 6 Jan 2015 13:49:57 +0000 (08:49 -0500)] 
Don't crash on malformed EXTENDCIRCUIT.

Fixes 14116; bugfix on ac68704f in 0.2.2.9-alpha.

10 years agoTolerate starting up with missing hidden service directory
Nick Mathewson [Mon, 5 Jan 2015 16:39:38 +0000 (11:39 -0500)] 
Tolerate starting up with missing hidden service directory

Fixes bug 14106; bugfix on 0.2.6.2-alpha

Found by stem tests.

10 years agoPrevent changes to other options from removing . from AutomapHostsSuffixes
Nick Mathewson [Sun, 4 Jan 2015 22:28:54 +0000 (17:28 -0500)] 
Prevent changes to other options from removing . from AutomapHostsSuffixes

This happened because we changed AutomapHostsSuffixes to replace "."
with "", since a suffix of "" means "match everything."  But our
option handling code for CSV options likes to remove empty entries
when it re-parses stuff.

Instead, let "." remain ".", and treat it specially when we're
checking for a match.

Fixes bug 12509; bugfix on 0.2.0.1-alpha.

10 years agoCommit the update-copyrights script.
Nick Mathewson [Fri, 2 Jan 2015 19:28:21 +0000 (14:28 -0500)] 
Commit the update-copyrights script.

(I'm tired of rewriting this by hand every January)

10 years agoBump copyright dates to 2015, in case someday this matters.
Nick Mathewson [Fri, 2 Jan 2015 19:27:39 +0000 (14:27 -0500)] 
Bump copyright dates to 2015, in case someday this matters.

10 years agoBump version to 0.2.6.2-alpha-dev
Nick Mathewson [Wed, 31 Dec 2014 18:24:12 +0000 (13:24 -0500)] 
Bump version to 0.2.6.2-alpha-dev

10 years agoedit the changelog one last time tor-0.2.6.2-alpha
Nick Mathewson [Wed, 31 Dec 2014 18:09:09 +0000 (13:09 -0500)] 
edit the changelog one last time

10 years agotweak changelog usage
Nick Mathewson [Wed, 31 Dec 2014 16:24:47 +0000 (11:24 -0500)] 
tweak changelog usage

10 years agoFix a changelog typo
Nick Mathewson [Wed, 31 Dec 2014 15:35:32 +0000 (10:35 -0500)] 
Fix a changelog typo

10 years agobump the version to 0.2.6.2-alpha
Nick Mathewson [Wed, 31 Dec 2014 13:58:26 +0000 (08:58 -0500)] 
bump the version to 0.2.6.2-alpha

10 years agoPick a date, write a blurb.
Nick Mathewson [Wed, 31 Dec 2014 13:45:01 +0000 (08:45 -0500)] 
Pick a date, write a blurb.

10 years agoFix a memory leak in tor-resolve
Nick Mathewson [Tue, 30 Dec 2014 17:35:01 +0000 (12:35 -0500)] 
Fix a memory leak in tor-resolve

Resolves bug 14050

10 years agoRemove a logically dead check to please coverity
Nick Mathewson [Tue, 30 Dec 2014 17:10:30 +0000 (12:10 -0500)] 
Remove a logically dead check to please coverity

10 years agoCoalesce v0 and v1 fields of rend_intro_cell_t
Nick Mathewson [Tue, 30 Dec 2014 17:07:28 +0000 (12:07 -0500)] 
Coalesce v0 and v1 fields of rend_intro_cell_t

This saves a tiny bit of code, and makes a longstanding coverity
false positive go away.

10 years agoMerge remote-tracking branch 'yawning/bug13315_fixup'
Nick Mathewson [Tue, 30 Dec 2014 16:46:56 +0000 (11:46 -0500)] 
Merge remote-tracking branch 'yawning/bug13315_fixup'

10 years agoNote fix for bug 12831
Nick Mathewson [Tue, 30 Dec 2014 16:45:01 +0000 (11:45 -0500)] 
Note fix for bug 12831

10 years agoAllow IPv4 and IPv6 addresses in SOCKS5 FQDN requests.
Yawning Angel [Tue, 30 Dec 2014 16:36:16 +0000 (16:36 +0000)] 
Allow IPv4 and IPv6 addresses in SOCKS5 FQDN requests.

Supposedly there are a decent number of applications that "support"
IPv6 and SOCKS5 using the FQDN address type.  While said applications
should be using the IPv6 address type, allow the connection if
SafeSocks is not set.

Bug not in any released version.

10 years agoMissing semicolon; my bad
Nick Mathewson [Tue, 30 Dec 2014 15:00:11 +0000 (10:00 -0500)] 
Missing semicolon; my bad

10 years agoFold more things into the 0.2.6.2-alpha changelog
Nick Mathewson [Tue, 30 Dec 2014 14:53:13 +0000 (09:53 -0500)] 
Fold more things into the 0.2.6.2-alpha changelog

10 years agoLintchanges some more.
Nick Mathewson [Tue, 30 Dec 2014 14:39:12 +0000 (09:39 -0500)] 
Lintchanges some more.

10 years agoMerge branch 'no-exit-bootstrap-squashed'
Nick Mathewson [Tue, 30 Dec 2014 14:06:47 +0000 (09:06 -0500)] 
Merge branch 'no-exit-bootstrap-squashed'

10 years agoFix Reachability self-tests in test networks
teor [Sat, 20 Dec 2014 10:44:16 +0000 (21:44 +1100)] 
Fix Reachability self-tests in test networks

Stop assuming that private addresses are local when checking
reachability in a TestingTorNetwork. Instead, when testing, assume
all OR connections are remote. (This is necessary due to many test
scenarios running all nodes on localhost.)

This assists in bootstrapping a testing Tor network.

Fixes bugs 13718 & 13924.

10 years agoAdd "internal" to some bootstrap statuses when no exits are available.
teor [Thu, 25 Dec 2014 13:43:58 +0000 (00:43 +1100)] 
Add "internal" to some bootstrap statuses when no exits are available.

If the consensus does not contain Exits, Tor will only build internal
circuits. In this case, relevant statuses will contain the word "internal"
as indicated in the Tor control-spec.txt. When bootstrap completes,
Tor will be ready to handle an application requesting an internal
circuit to hidden services at ".onion" addresses.

If a future consensus contains Exits, exit circuits may become available.

Tor already notifies the user at "notice" level if they have no exits in
the consensus, and can therefor only build internal paths.

Consequential change from #13718.

10 years agoAvoid building exit circuits from a consensus with no exits
teor [Thu, 25 Dec 2014 13:31:16 +0000 (00:31 +1100)] 
Avoid building exit circuits from a consensus with no exits

Tor can now build circuits from a consensus with no exits.
But if it tries to build exit circuits, they fail and flood the logs.

The circuit types in the Exit Circuits list below will only be
built if the current consensus has exits. If it doesn't,
only the Internal Circuits will be built. (This can change
with each new consensus.)
Fixes bug #13814, causes fewer path failures due to #13817.

Exit Circuits:
    Predicted Exit Circuits
    User Traffic Circuits
    Most AP Streams
    Circuits Marked Exit
    Build Timeout Circuits (with exits)

Internal Circuits:
    Hidden Service Server Circuits
    Hidden Service Client Circuits
    Hidden Service AP Streams
    Hidden Service Intro Point Streams
    Circuits Marked Internal
    Build Timeout Circuits (with no exits)
    Other Circuits?

10 years agoAllow tor to build circuits using a consensus with no exits
teor [Thu, 25 Dec 2014 13:17:08 +0000 (00:17 +1100)] 
Allow tor to build circuits using a consensus with no exits

If the consensus has no exits (typical of a bootstrapping
test network), allow tor to build circuits once enough
descriptors have been downloaded.

When there are no exits, we always have "enough"
exit descriptors. (We treat the proportion of available
exit descriptors as 100%.)

This assists in bootstrapping a testing Tor network.

Fixes bug 13718.
Makes bug 13161's TestingDirAuthVoteExit non-essential.
(But still useful for speeding up a bootstrap.)

10 years agoCheck if there are exits in the consensus
teor [Thu, 25 Dec 2014 13:10:40 +0000 (00:10 +1100)] 
Check if there are exits in the consensus

Add router_have_consensus_path() which reports whether
the consensus has exit paths, internal paths, or whether it
just doesn't know.

Used by #13718 and #13814.

10 years agoRefactor count_usable_descriptors to use named enums for exit_only
teor [Thu, 25 Dec 2014 12:15:38 +0000 (23:15 +1100)] 
Refactor count_usable_descriptors to use named enums for exit_only

count_usable_descriptors now uses named exit_only values:
  USABLE_DESCRIPTOR_ALL
  USABLE_DESCRIPTOR_EXIT_ONLY

Add debug logging code for descriptor counts.

This (hopefully) resolves nickm's request in bug 13718 to improve
argument readability in nodelist.c.

10 years agoAvoid excluding guards from path building in minimal test networks
teor [Thu, 25 Dec 2014 12:42:38 +0000 (23:42 +1100)] 
Avoid excluding guards from path building in minimal test networks

choose_good_entry_server() now excludes current entry
guards and their families, unless we're in a test network,
and excluding guards would exclude all nodes.

This typically occurs in incredibly small tor networks,
and those using TestingAuthVoteGuard *

This is an incomplete fix, but is no worse than the previous
behaviour, and only applies to minimal, testing tor networks
(so it's no less secure).

Discovered as part of #13718.

10 years agoMake lintChanges happier
Nick Mathewson [Tue, 30 Dec 2014 13:54:01 +0000 (08:54 -0500)] 
Make lintChanges happier

10 years agoMerge remote-tracking branch 'dgoulet/bug13667_025_v4'
Nick Mathewson [Tue, 30 Dec 2014 13:34:48 +0000 (08:34 -0500)] 
Merge remote-tracking branch 'dgoulet/bug13667_025_v4'

10 years agoFix: mitigate as much as we can HS port scanning
David Goulet [Tue, 25 Nov 2014 15:37:55 +0000 (10:37 -0500)] 
Fix: mitigate as much as we can HS port scanning

Make hidden service port scanning harder by sending back REASON_DONE which
does not disclose that it was in fact an exit policy issue. After that, kill
the circuit immediately to avoid more bad requests on it.

This means that everytime an hidden service exit policy does match, the user
(malicious or not) needs to build a new circuit.

Fixes #13667.

Signed-off-by: David Goulet <dgoulet@ev0ke.net>
10 years agoWipe all of the target space in tor_addr_{to,from}_sockaddr()
Nick Mathewson [Mon, 29 Dec 2014 15:06:12 +0000 (10:06 -0500)] 
Wipe all of the target space in tor_addr_{to,from}_sockaddr()

Otherwise we risk a subsequent memdup or memcpy copying
uninitialized RAM into some other place that might eventually expose
it.  Let's make sure that doesn't happen.

Closes ticket 14041

10 years agoMerge branch 'resolvemyaddr_squashed'
Nick Mathewson [Mon, 29 Dec 2014 15:00:34 +0000 (10:00 -0500)] 
Merge branch 'resolvemyaddr_squashed'

10 years agochanges file for resolvemyaddr tests
Nick Mathewson [Mon, 29 Dec 2014 14:44:28 +0000 (09:44 -0500)] 
changes file for resolvemyaddr tests

10 years agoMake the resolvemyaddr unit tests pass when local dns is hijacked
Nick Mathewson [Mon, 29 Dec 2014 14:41:37 +0000 (09:41 -0500)] 
Make the resolvemyaddr unit tests pass when local dns is hijacked

If you are in a coffee shop that returns a helpful redirect page for
"onionrouter", or on an ISP that does the same, the test as written
would fail.

10 years agoFix memory leaks in resolvemyaddr tests
Nick Mathewson [Mon, 29 Dec 2014 14:33:36 +0000 (09:33 -0500)] 
Fix memory leaks in resolvemyaddr tests

10 years agoFix compilation errors in resolvemyaddr tests
Nick Mathewson [Mon, 29 Dec 2014 14:29:32 +0000 (09:29 -0500)] 
Fix compilation errors in resolvemyaddr tests

10 years agoAdding comprehensive test cases for resolve_my_address.
rl1987 [Mon, 28 Apr 2014 20:20:58 +0000 (23:20 +0300)] 
Adding comprehensive test cases for resolve_my_address.

Also, improve comments on resolve_my_address to explain what it
actually does.

10 years agoFix a few comments
rl1987 [Sat, 26 Apr 2014 13:53:28 +0000 (16:53 +0300)] 
Fix a few comments

10 years agoTweak 13913 fix: clarify that the behavior is not promised
Nick Mathewson [Mon, 29 Dec 2014 13:41:30 +0000 (08:41 -0500)] 
Tweak 13913 fix: clarify that the behavior is not promised

Also, it's->its.  The apostrophe is used if and only if it's a
contraction for "it is".

10 years agoMerge remote-tracking branch 'rl1987/ticket13913'
Nick Mathewson [Mon, 29 Dec 2014 13:39:13 +0000 (08:39 -0500)] 
Merge remote-tracking branch 'rl1987/ticket13913'

10 years agoAdd another cellintptr use; fixes 14031
Nick Mathewson [Sat, 27 Dec 2014 00:17:24 +0000 (19:17 -0500)] 
Add another cellintptr use; fixes 14031

10 years agoImprove a notice message in dirvote.c. (Roger asked for this.)
Nick Mathewson [Sat, 27 Dec 2014 00:14:56 +0000 (19:14 -0500)] 
Improve a notice message in dirvote.c. (Roger asked for this.)

10 years agoFix grammar in comment on running_long_enough_to_decide_unreachable
teor [Thu, 25 Dec 2014 10:34:54 +0000 (21:34 +1100)] 
Fix grammar in comment on running_long_enough_to_decide_unreachable