]>
git.ipfire.org Git - thirdparty/krb5.git/log
Kevin Wasserman [Sat, 28 Jul 2012 12:14:24 +0000 (08:14 -0400)]
Put athena-specific krb5.ini in athena subdir
The installer only picks it up if MIT_INTERNAL is defined in
the environment; otherwise it uses the now-empty krb5.ini in
the base directory.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7323 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 27 Jul 2012 20:41:06 +0000 (16:41 -0400)]
CCAPI client rpc fixes
On Windows XP, cci_os_ipc_thread_init() causes additional threads to be
spawned immediately, which results in a vicious cycle until Windows
resources are exhausted. Instead, defer thread_init() until it is really
needed.
Also, use the MSDN-recommended defaults for RPC calls instead of random
constants.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7322 (new)
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 27 Jul 2012 01:08:14 +0000 (21:08 -0400)]
Handle missing autocomplete object gracefully
Don't crash if we can't create a CLSID_AutoComplete instance.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7321 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 26 Jul 2012 18:50:40 +0000 (14:50 -0400)]
Add both x86 and x64 msm's to x64 installer
Since we have x86 dlls, we need the x86 msm's.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7320 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 26 Jul 2012 10:57:35 +0000 (06:57 -0400)]
Use env to determine config in installer build
Use NODEBUG and DEBUG_SYMBOL from the environment to determine whether or
not to define Debug and DebugSyms for the installer build.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7319 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 26 Jul 2012 10:53:50 +0000 (06:53 -0400)]
Use release MFC lib for NODEBUG builds
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7318 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 26 Jul 2012 10:37:47 +0000 (06:37 -0400)]
Don't require pdbs for make install
When NODEBUG is defined and DEBUG_SYMBOL is not, no pdbs are generated.
This should not cause make install to fail.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7316 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 25 Jul 2012 12:32:46 +0000 (08:32 -0400)]
Add MIT krb5.ini to wix install directory
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7315 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 24 Jul 2012 10:10:11 +0000 (06:10 -0400)]
Fix installer UI field sizes
Increase title control height to make all text visible.
Adjust position of description controls accordingly.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7314 (new)
queue: kfw
target_version: 1.10.4
tags:pullup
Kevin Wasserman [Tue, 24 Jul 2012 18:26:33 +0000 (14:26 -0400)]
Fix ribbon label hotkeys
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7311 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 24 Jul 2012 16:35:18 +0000 (12:35 -0400)]
Fix menu text change breakage
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7310 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 23 Jul 2012 20:43:06 +0000 (16:43 -0400)]
Help -- remove principal drop-down refs
Also a couple of minor fixups.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7309 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 19 Jul 2012 01:53:29 +0000 (21:53 -0400)]
Disable import/export buttons and checkbox
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7308 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 19 Jul 2012 01:14:30 +0000 (21:14 -0400)]
Update kfw installer OS version checks
Require XP SP3 or Vista SP2 or Windows 7 or Server 2003 or Server 2008
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7307 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 18 Jul 2012 21:32:31 +0000 (17:32 -0400)]
Call CWinAppEx::InitInstance()
Without this, AfxGlobalsAddRef() is never called, so AfxGlobalsRelease()
does nothing, causing many leaks and a crash on exit in GdiplusShutdown()
on Vista.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7306 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 17 Jul 2012 19:49:06 +0000 (15:49 -0400)]
Remove unused leashdll functions
-not_an_API_LeashKRB5GetTickets
-not_an_API_LeashKRB5FreeTickets
and supporting routines. Also remove the unused support routine one_addr.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
[kaduk@mit.edu: adjust commit message]
ticket: 7305 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 16 Jul 2012 18:22:23 +0000 (14:22 -0400)]
'Destroy tickets on exit' destroys all tickets
Previously destroyed only default ccache and used obsolete functions.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7304 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 17 Jul 2012 17:51:46 +0000 (13:51 -0400)]
Use cc_user_set_default_name to 'make default'
In addition to calling krb5_cc_switch(), use
krb5int_cc_user_set_default_name() in CLeashView::OnMakeDefault()
to set the default ccache for all processes for the current user.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7303 (new)
queue: kfw
subject: 'Make default' should apply to all processes of the user
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 10 Jul 2012 22:56:10 +0000 (18:56 -0400)]
Minor 'Get Tickets' dialog fixes
-Move 'Remember this principal' and keep visible even when 'advanced'
options are hidden.
-Increase size of 'Forwardable and Proxiable' checkbox.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7301 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Sat, 5 May 2012 14:53:44 +0000 (10:53 -0400)]
Help updates for kfw 4.0
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
[kaduk@mit.edu: Squash commits, a couple of grammar fixes, and also turn
a few instances of "Leash" into "MIT Kerberos". Trim trailing whitespace
and other whitespace tweaks to pass the commit hooks.]
ticket: 7300 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
Kevin Wasserman [Tue, 3 Jul 2012 16:45:18 +0000 (12:45 -0400)]
Reduce 'get tickets' dialog height
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7299 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 3 Jul 2012 14:19:40 +0000 (10:19 -0400)]
Add 'Remember this principal' checkbox
Added to the 'Get Tickets' dialog.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7298 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 2 Jul 2012 01:06:46 +0000 (21:06 -0400)]
Update kfw change password dialog
Use combined username/realm principal edit control.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7297 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Sun, 1 Jul 2012 02:42:12 +0000 (22:42 -0400)]
KfW rename lacFoo -> Leash_pec_
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7294 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 29 Jun 2012 19:15:08 +0000 (15:15 -0400)]
KfW make 64-bit MSI include 32-bit dlls
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7293 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 29 Jun 2012 17:07:48 +0000 (13:07 -0400)]
Rename "Leash" to "MIT Kerberos"
In the executable name and many GUI elements.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7292 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 22:16:21 +0000 (18:16 -0400)]
KfW GUI -- clean up 'About' dialog
By default, hide the debug list of loaded modules; change LeashView.cpp
and recompile to get the list.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7291 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 18:53:25 +0000 (14:53 -0400)]
KfW update copyright date (2012) for all modules
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7290 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 18:51:12 +0000 (14:51 -0400)]
KfW WiX installer update copyright notice
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7289 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 16:30:40 +0000 (12:30 -0400)]
Remove copyright/version from Get Tickets dialog
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7288 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 12:28:09 +0000 (08:28 -0400)]
KfW GUI -- add 'Options' category
Move 'View' and 'Options' panels from Home to Options category.
Rename to 'View Options' and 'Ticket Options' respectively.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7287 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 11:43:06 +0000 (07:43 -0400)]
Use bold for entire row for default principal
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7286 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 01:54:31 +0000 (21:54 -0400)]
Rename 'Get Ticket' to 'MIT Kerberos: Get Ticket'
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7284
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 01:46:04 +0000 (21:46 -0400)]
KfW GUI -- abbreviate durations
Map days -> d; hours -> h; minutes -> m
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7285 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 01:31:33 +0000 (21:31 -0400)]
Change 'Get Ticket' to 'MIT Kerberos: Get Ticket'
Also improve string copy safety.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7284 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 01:04:27 +0000 (21:04 -0400)]
Rename and move 'Clear Principal History'
Move it closer to the Principal edit box and rename to 'Clear History'
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7283 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 28 Jun 2012 00:14:39 +0000 (20:14 -0400)]
Merge forwardable/proxiable in Get Tickets dialog
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7282 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 27 Jun 2012 23:48:29 +0000 (19:48 -0400)]
Update kfw ribbon button graphics
Integrate bmp's from ui team.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7281 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 27 Jun 2012 23:05:22 +0000 (19:05 -0400)]
KfW GUI -- show ticket flags
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7280 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 25 Jun 2012 10:03:32 +0000 (06:03 -0400)]
KfW GUI -- update expand/collapse icon rendering
Use DrawThemeBackground() to draw the icons from the explorer treeview.
ticket: 7279 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 17 Jul 2012 17:17:46 +0000 (13:17 -0400)]
Fix leashdll code to search for existing tickets
When we have a desired principal, search the entire credential cache
collection for existing tickets for that principal before using a prompter.
If no principal is specified, check only the default cache.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7278 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 21 Jun 2012 19:30:24 +0000 (15:30 -0400)]
Use file mapping to marshall message data
GlobalAlloc() is no longer supported for this purpose.
Also split out leash message marshalling code into a separate function
acquire_tkt_send_message_leash and improve string copy safety.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7276 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 21 Jun 2012 17:27:27 +0000 (13:27 -0400)]
Set kfw GUI read-only princ flag when appropriate
When receiving a request to obtain tickets (from another process), if a
particular principal is requested, set the read-only flag to prevent
the user from changing the principal.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7275 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 21 Jun 2012 17:22:39 +0000 (13:22 -0400)]
Add 'read-only principal' flag
Reserve the high-order 16 bits of dlgtype for flags.
Add DLGFLAG_READONLY_PRINC. When specified, the get tickets dialog
does not allow the user to change the principal.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7274 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 15 Jun 2012 02:57:59 +0000 (22:57 -0400)]
Send kfw 'obtain ticket' messages to main frame
Previous versions of kfw would attempt to send 'obtain tickets' messages
directly to the 'view' window by sending to the first child of the main
frame. But with the ribbon UI, the ribbon toolbar is now the first child,
so that method no longer works. Instead we now send the message to the
main frame and the main frame forwards to the active view.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7273 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 15 Jun 2012 02:46:40 +0000 (22:46 -0400)]
Fix 'renewable' checkbox text
fix 'renwable' typo and pad size.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7272 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 15 Jun 2012 02:44:49 +0000 (22:44 -0400)]
Fix ribbon breakage
Controls were accidentally broken when moved
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7271 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 8 Jun 2012 12:06:01 +0000 (08:06 -0400)]
Add Forget Principals to Get Tickets dialog
And remove remnants of it from the "more" panel.
Clear the registry key that stores the principal list.
Also clear the autocomplete strings on the active control.
[kaduk@mit.edu: squashed commits and rewrote commit message.]
ticket: 7269 (new)
subject: forget principals functionality
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 7 Jun 2012 01:17:21 +0000 (21:17 -0400)]
KfW GUI -- add 'More' Panel
'Import Tickets', 'Export Tickets', and 'Forget Principals' buttons.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7268 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 6 Jun 2012 18:30:58 +0000 (14:30 -0400)]
Combine username and realm in get tickets dialog
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7266 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 5 Jun 2012 17:03:21 +0000 (13:03 -0400)]
Fix NSIS uninstall to work with UAC
Use ShellExecuteEx() to elevate privilege if CreateProcess() fails.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7265 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Sat, 2 Jun 2012 14:34:09 +0000 (10:34 -0400)]
KfW auto-complete support
Use the registry to store and retrieve principals for auto-complete.
Remember principals from successful autentications.
TODO: combine realm/username in principal; 'remember principal' checkbox;
reset button; add to support 'change password' dialog as well.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
[kaduk@mit.edu: style cleanup, copyright/license on new file.]
ticket: 7264 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 13 Jun 2012 15:23:31 +0000 (11:23 -0400)]
C++ safety for leashdll.h
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7270 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Sat, 9 Jun 2012 18:21:13 +0000 (14:21 -0400)]
Minor fixes for leashwin.h
-explicitly include krb5.h (for krb5_timestamp)
-add extern "C" scope for c++ compatibility
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7267 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 1 Jun 2012 23:29:34 +0000 (19:29 -0400)]
Remove psapi.dll from installer
psapi.dll is a standard windows component; no need for kfw to redistribute.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7263 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Thu, 19 Jul 2012 15:18:13 +0000 (11:18 -0400)]
KfW GUI -- renew selected principals
The renew button should act on the current selection.
-auto-renew still only renews default ccache
-renew doesn't work for UAC-limited MSLSA
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7262 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Ben Kaduk [Fri, 24 Aug 2012 19:54:30 +0000 (15:54 -0400)]
Update ribbon tooltip text
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7261 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 21 May 2012 12:12:43 +0000 (08:12 -0400)]
Add leak tracking support to Leash
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7260 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 21 May 2012 12:09:05 +0000 (08:09 -0400)]
Add defines for debug builds in win-pre.in
define DEBUG and _CRTDBG_MAP_ALLOC except for NODEBUG builds
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7259 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Sat, 21 Jul 2012 20:26:16 +0000 (16:26 -0400)]
Remove ID_ABOUT, add ID_IMPORT_TICKETS
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7258 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Sat, 21 Jul 2012 20:24:14 +0000 (16:24 -0400)]
Fix tooltips for ribbon
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7257 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Sat, 21 Jul 2012 20:22:58 +0000 (16:22 -0400)]
Tooltip text fixes
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7256 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 16 Jul 2012 15:48:55 +0000 (11:48 -0400)]
Set fCachesTicket=TRUE when no credentials
It is not really clear this is correct, but neither was the
previous behavior.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7255 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 14 May 2012 16:14:20 +0000 (12:14 -0400)]
Do not be over-restrictive in the presence of UAC
We used to explicitly check if a process was UAC-limited and deny all
access to the TGT in that case; however, this makes the MSLSA cache
effectively useless.
Do not try to outsmart UAC, and let it do its own checking -- this allows
UAC-limited access to the MSLSA ccache, which should mean read-write
access to service tickets, and write-only access to the TGT.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
[kaduk@mit.edu: delete instead of comment out, move comment.]
ticket: 7254 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 23 Jul 2012 08:30:27 +0000 (04:30 -0400)]
kfw support for multiple identities
We need a sense of what the default identity is, then, with a way
to set it and list it.
The memory management model changes some, as well.
Use a bold font to indicate the current default identity in the
GUI; while here use an italic font for expired credentials.
In the process, rip out some krb4 remenants, and remove ancient
code conditional on the lack of KRB5_TC_NOTICKET.
Define USE_MESSAGE_BOX when building leash and use MessageBox().
[kaduk@mit.edu: adjust for style, flesh out commit message.]
ticket: 7253 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 18 Apr 2012 12:12:58 +0000 (08:12 -0400)]
kfw get tickets dialog tweaks
"Options" button -> "Advanced Settings"
"Renew Till" -> "Renew Until"
"Kerberos 5 Options" -> "Flag this ticket as"
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7252 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Sat, 21 Jul 2012 23:52:20 +0000 (19:52 -0400)]
kfw remove status bar
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7251 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 16 Apr 2012 18:48:43 +0000 (14:48 -0400)]
Only create toolbar when not using ribbon UI
When we do create the toolbar, dock it.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7250 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Sat, 21 Jul 2012 12:52:50 +0000 (08:52 -0400)]
Use ListView; add ViewColumn abstraction
Punting FormView since we really only need ListCtrl and using
ListView makes the header column and window resizing work.
The ViewColumn abstraction eliminates some copy/paste code blocks.
HDN_ITEMCHANGED tracks user changes to column widths.
Remove CTreeCtrl-related code.
Also remove some unused code that was generating warnings.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7249 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 1 Aug 2012 16:19:12 +0000 (12:19 -0400)]
kfw implement ribbon UI
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7248 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 18 Apr 2012 10:49:21 +0000 (06:49 -0400)]
kfw "Initialize Ticket" -> "Get Ticket"
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7247 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Wed, 15 Aug 2012 16:17:54 +0000 (12:17 -0400)]
MSVC-generated updates to support ribbon UI
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
[kaduk@mit.edu: manually tweak to remove gratuitious churn]
ticket: 7246 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 25 Jun 2012 09:43:40 +0000 (05:43 -0400)]
Update leash icon and button graphics
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
[kaduk@mit.edu: While here, remove now-unused doghead icons.]
ticket: 7245 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 3 Apr 2012 11:02:43 +0000 (07:02 -0400)]
Prep for KfW conversion to ribbon toolbar
Upgrade classes: CWinApp->CWinAppEx, CFrameWnd->CFrameWndEx,
CStatusBar->CMFCStatusBar, CToolBar->CMFCToolBar.
Call AfxOleInit() from CLeashApp::InitInstance()
Do not call LoadBarState() (crashes)
or GetToolBarCtrl() (no longer exists)
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7244 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Greg Hudson [Fri, 24 Aug 2012 15:51:31 +0000 (11:51 -0400)]
Fix portability, printf bugs in preauth_otp.c
unistd.h is not available on Windows and isn't needed for this file,
so don't include it. Two arguments to asprintf in choose_token() were
reversed.
Zhanna Tsitkov [Thu, 23 Aug 2012 20:14:53 +0000 (16:14 -0400)]
Doc newly introduced padata types for OTP support
Remove KRB5_PADATA_OTP_CONFIRM pre-authentication data (padata) type
as it is marked as OBSOLETE in RFC 6560.
Kevin Wasserman [Tue, 3 Apr 2012 16:36:44 +0000 (12:36 -0400)]
Leash UI menu updates
Eliminate Action menu:
-move Ticket manipulation to File menu
-eliminate "Reset Window Size/Pos", "Synchronize Time", and "Update Display"
Update Options menu:
-eliminate all the "Properties" items:
"Leash ", "Kerberos ", "Kerberos v4 ", "Kerberos v5 ", and "AFS"
TODO: move functionality to advanced install/registry keys.
Update View menu:
-add "Time Issued", "Renewable Until", "Flags", "Encryption Type",
and "Valid Until"
-remove "Large Icons", "Toolbar", "Status Bar", and "Debug Window"
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7243 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 20 Jul 2012 15:33:51 +0000 (11:33 -0400)]
allow multiple Leash options; add -noribbon
Change option parsing to allow more than one option to be given.
Use the ribbon UI by default; -noribbon reverts to the old UI.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7241 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 3 Apr 2012 16:33:34 +0000 (12:33 -0400)]
Target Windows Vista in leash/stdafx.h
Define WINVER and _WIN32_WINNT, to target Vista+ -- required for
ribbon ui.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7240 (new)
queue: kfw
subject: Support the Ribbon UI for Leash
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Fri, 20 Jul 2012 15:07:48 +0000 (11:07 -0400)]
Change kfw destroy ticket confirmation message
OKCANCEL -> YESNO
Add MB_ICONEXCLAMATION
Change text
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7239 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 17 Jul 2012 18:25:39 +0000 (14:25 -0400)]
Load additional krb5 and come_err funcs
Required for multiple identity management and for migration of code from
leashdll to leash proper.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7238 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Tue, 15 May 2012 18:09:57 +0000 (14:09 -0400)]
Fix leak in cci_os_ipc_thread_init()
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7237 (new)
subject: CCAPI cleanup and bugfixes
target_version: 1.10.4
tags: pullup
Kevin Wasserman [Mon, 16 Jul 2012 15:43:00 +0000 (11:43 -0400)]
Remove unused struct and switch_to stubs
Only one mslsa ccache is supported, so switch_to is not needed.
Likewise, struct krb5int_lcc_iterator is unneccesary.
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7236 (new)
target_version: 1.10.4
tags: pullup
Tom Yu [Thu, 23 Aug 2012 19:13:54 +0000 (15:13 -0400)]
Run "make depend"
Tom Yu [Thu, 23 Aug 2012 19:11:32 +0000 (15:11 -0400)]
Fix minor Makefile.in typos for make depend
Fix minor typos in lib/krb5/krb/Makefile.in and
tests/gssapi/Makefile.in so that "make depend" will work.
Kevin Wasserman [Thu, 28 Jun 2012 18:50:13 +0000 (14:50 -0400)]
Fix version info for Leash.exe
Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
ticket: 7235 (new)
queue: kfw
target_version: 1.10.4
tags: pullup
Nathaniel McCallum [Mon, 20 Aug 2012 20:49:54 +0000 (16:49 -0400)]
Add otp client preauth plugin
Implements the client side of RFC 6560. Not all features are
implemented, but it should work for the most common cases.
ticket: 7242 (new)
Greg Hudson [Fri, 27 Jul 2012 15:51:18 +0000 (11:51 -0400)]
Add ASN.1 support for OTP
Add encoders and decoders for the OTP-TOKENINFO, PA-OTP-CHALLENGE,
PA-OTP-REQUEST, and PA-OTP-ENC-REQUEST types from RFC 6560. For more
thorough testing, add support for generating test encodings using
asn1c for sample objects (currently only for the OTP types).
Greg Hudson [Thu, 23 Aug 2012 16:58:29 +0000 (12:58 -0400)]
Clean up k5buf_to_gss helper
k5buf_to_gss was used in only one place (generic_gss_oid_to_str),
where we want to include the terminating null byte in the GSS buffer.
Remove that assumption from the helper, and instead explicitly append
the null byte to the buffer before translating.
Zhanna Tsitkov [Wed, 22 Aug 2012 17:05:25 +0000 (13:05 -0400)]
Document preference order of enctypes in krb5.conf
Zhanna Tsitkov [Wed, 22 Aug 2012 14:26:24 +0000 (10:26 -0400)]
Remove dead code in do_as_req.c
Commit r21692 removed the KRB5_KDB_NON_MS_PRINCIPAL flag.
Zhanna Tsitkov [Tue, 21 Aug 2012 15:10:49 +0000 (11:10 -0400)]
Updated Supported Versions document
Greg Hudson [Wed, 15 Aug 2012 19:12:12 +0000 (15:12 -0400)]
Fix apply_keysalt_policy bug
If apply_keysalt_policy is called with null result arguments (as from
kadm5_setkey_principal_3), we would dereference a null pointer if the
principal has no policy or no policy allowed_keysalts field, due to an
incorrect optimization. Reported by Nico.
ticket: 7223
Zhanna Tsitkov [Wed, 15 Aug 2012 16:54:43 +0000 (12:54 -0400)]
Cross-reference documents in mitK5defaults.rst
Greg Hudson [Wed, 15 Aug 2012 16:19:30 +0000 (12:19 -0400)]
Edit rcache_def.rst for spelling and grammar
Zhanna Tsitkov [Wed, 15 Aug 2012 16:08:27 +0000 (12:08 -0400)]
New Replay Cache rst documentation
Zhanna Tsitkov [Tue, 14 Aug 2012 14:28:46 +0000 (10:28 -0400)]
Remove obsolete function krb5_secure_config_files
Greg Hudson [Mon, 13 Aug 2012 02:50:33 +0000 (22:50 -0400)]
Silence a gcc warning in t_export_name
gcc warnings that nametype may be used uninitialized, presumably
failing to deduce that usage() never returns. Initialize nametype to
make it build.
Greg Hudson [Sat, 11 Aug 2012 22:18:51 +0000 (18:18 -0400)]
Add test coverage for gss_export_name
Exercise gss_export_name and importing of exported name tokens in
t_gssapi.py.
Greg Hudson [Sat, 11 Aug 2012 22:17:42 +0000 (18:17 -0400)]
Use gssalloc in krb5_gss_export_name
krb5_gss_export_name uses malloc to construct a gss_buffer_desc value,
and should use gssalloc_malloc instead.
ticket: 7233