Sami Kerola [Mon, 25 Jul 2011 19:33:39 +0000 (21:33 +0200)]
hwclock: fix compiler warnings
hwclock.c: In function 'manipulate_epoch':
hwclock.c:1299:29: warning: unused parameter 'getepoch' [-Wunused-parameter]
hwclock.c:1299:50: warning: unused parameter 'setepoch' [-Wunused-parameter]
hwclock.c:1300:14: warning: unused parameter 'epoch_opt' [-Wunused-parameter]
hwclock.c:1300:36: warning: unused parameter 'testing' [-Wunused-parameter]
hwclock.c: In function 'usage':
hwclock.c:1373:1: warning: embedding a directive within macro arguments is not portable [enabled by default]
hwclock.c:1377:1: warning: embedding a directive within macro arguments is not portable [enabled by default]
hwclock.c:1383:1: warning: embedding a directive within macro arguments is not portable [enabled by default]
hwclock.c:1385:1: warning: embedding a directive within macro arguments is not portable [enabled by default]
cmos.c: In function 'outb':
cmos.c:84:15: warning: unused parameter 'a' [-Wunused-parameter]
cmos.c:84:22: warning: unused parameter 'b' [-Wunused-parameter]
cmos.c: In function 'inb':
cmos.c:88:13: warning: unused parameter 'c' [-Wunused-parameter]
cmos.c: In function 'atomic':
cmos.c:265:20: warning: unused parameter 'name' [-Wunused-parameter]
cmos.c: In function 'i386_iopl':
cmos.c:544:32: warning: unused parameter 'level' [-Wunused-parameter]
cmos.c: In function 'get_permissions_cmos':
cmos.c:565:8: warning: unused variable 'errsv' [-Wunused-variable]
Karel Zak [Fri, 22 Jul 2011 09:15:28 +0000 (11:15 +0200)]
ionice: improve command line interpretation
ionice : print the current I/O prio.
ionice COMMAND : exec command with default (best-effort) class
ionice -p PID [...] : return info about the PID(s)
ionice -c CLASS COMMAND : exec command with the class
ionice -c CLASS -p PID [...] : modify PID(s) class
This should be backwardly compatible and also compatible with nice(1)
from coreutils.
Milan Broz [Thu, 21 Jul 2011 20:56:20 +0000 (22:56 +0200)]
lsblk: ignore device if disappear while processing
If lsblk runing on system where many devices appears and disappears
during lsblk run, lsblk should not fail or crash but just ignore
disappeared device.
Let's detect context initialization failures and skip device
instead of failing.
Also fix possible dereferencing of NULL parent pointer and
properly handle some error paths.
Signed-off-by: Milan Broz <mbroz@redhat.com> Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 21 Jul 2011 09:26:42 +0000 (11:26 +0200)]
Merge branch 'minix' of https://github.com/kerolasa/lelux-utiliteetit
* 'minix' of https://github.com/kerolasa/lelux-utiliteetit:
libblkid: move MINIX_MAXPARTITIONS to minix.h
minix: move globals and inline functions to minix_programs.h
libblkid: use MINIX_BLOCK_SIZE from minix.h
libblkid: use superblock structure from minix.h
include: move minix.h to include directory
include: remove kernel headers from minix.h
include: minix.h: use data types from stdint.h
Karel Zak [Wed, 20 Jul 2011 19:24:20 +0000 (21:24 +0200)]
libmount: fix mtab update for "none" source
tab_parse.c:mnt_parse_mountinfo_line parses "none" in src as NULL,
tab_update.c:fprintf_mtab_fs sets m1 to NULL instead of "none" and
returns -ENOMEM
tab_update.c:update_table says "write entry failed: Success", as errno
hasn't been set, and gotos to leave, leaving mtab not updated.
Addresses-debian-bug: 634871 Reported-by: Tomas Janousek <tomi@nomi.cz> Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Wed, 20 Jul 2011 18:28:55 +0000 (20:28 +0200)]
minix: move globals and inline functions to minix_programs.h
Global variables and inline functions are moved from minix.h to
minix_programs.h which is included in mkfs.minix and fsck.minix.
The minix.h will have only struct definitions etc generic
contents which is reasonable to share with utilities and
libraries.
An element declared as size_t cannot be detected as negative (len < 0)
is always false.
This can lead to an infinite loop causing a segmentation fault.
Check if len is equal to -1 or -2 instead
Karel Zak [Mon, 18 Jul 2011 15:00:52 +0000 (17:00 +0200)]
Merge remote-tracking branch 'sami/mkfs.bfs'
* sami/mkfs.bfs:
docs: add long options to mkfs.bfs.8
mkfs.bfs: coding style fix
mkfs.bfs: include-what-you-use header check
mkfs.bfs: validate numeric user inputs
mkfs.bfs: use xstrdup from xalloc.h
mkfs.bfs: add long options
mkfs.bfs: use libc error facilities
Karel Zak [Mon, 18 Jul 2011 14:43:51 +0000 (16:43 +0200)]
Merge remote-tracking branch 'sami/isosize'
* sami/isosize:
docs: isosize.8 add long options
isosize: fix coding style
isosize: include-what-you-use header check
isosize: check user input to be numeric
isosize: use long options
isosize: remove global variables
This patch adds support for books in cpu topology output. Books are
currently only present on the s390 architecture, however it looks like
others will follow to use the extra scheduling domain of the kernel.
Books are logically between sockets and nodes. In order to not break
any existing tools that might parse the output of lscpu the output
is changed so that books will follow nodes:
CPU,Core,Socket,Node,Book
In addition the readable output is changed from
"CPU socket(s):" to "Socket(s) per book:" or simply "Socket(s):" in the
absence of books.
Petr Uzel [Fri, 1 Jul 2011 13:51:44 +0000 (15:51 +0200)]
mount: make the error message clear
Reported-by: Micah Anderson <micah@debian.org>
Addresses: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=558653 Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Fri, 1 Jul 2011 13:51:43 +0000 (15:51 +0200)]
mount: fix typo in mount.8
Reported-by: Reuben Thomas <rrt@sc3d.org>
Addresses: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603096 Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Fri, 1 Jul 2011 13:51:42 +0000 (15:51 +0200)]
mount: fix typo in mount.8
Reported-by: Lars Wirzenius <liw@liw.fi>
Addresses: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=605007 Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Fri, 1 Jul 2011 13:51:41 +0000 (15:51 +0200)]
mount: remove accidental extra word in ext4 documentation in mount.8
Reported-by: Francis Russell <francis+dbts@unchartedbackwaters.co.uk>
Addresses: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=599550 Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Davidlohr Bueso [Wed, 29 Jun 2011 16:55:49 +0000 (12:55 -0400)]
mkfs.minix: add minix v3 support
We can now create minix v3 filesystems. Support for this fs was added a few
years ago in the Linux kernel. One of the most important benefits is the
ability to handle file names up to 60 characters long. With this change we
also introduce the -3 option which naturally indicates which version to create.
Version 1 is still left as the default one for backwards compatibility reasons.
[kzak@redhat.com: - fix gcc warnings:
mkfs.minix.c: In function ‘super_set_state_ptr’:
mkfs.minix.c:174:1: warning: no return statement in function returning non-void [-Wreturn-type]
mkfs.minix.c: In function ‘write_tables’:
mkfs.minix.c:182:7: warning: unused variable ‘state’ [-Wunused-variable]
mkfs.minix.c: At top level:
mkfs.minix.c:111:27: warning: ‘blksz’ defined but not used [-Wunused-variable]
]
Signed-off-by: Davidlohr Bueso <dave@gnu.org> Signed-off-by: Karel Zak <kzak@redhat.com>