]>
git.ipfire.org Git - thirdparty/util-linux.git/log
Karel Zak [Thu, 27 Oct 2011 12:48:49 +0000 (14:48 +0200)]
build-sys: move type checks before --enable-*
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 12:44:30 +0000 (14:44 +0200)]
build-sys: move gettext check before --enable-*
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 12:40:00 +0000 (14:40 +0200)]
build-sys: cleanup BUILD_{LS,CH}CPU
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 12:31:34 +0000 (14:31 +0200)]
build-sys: cleanup BUILD_MOUNTPOINT
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 12:28:59 +0000 (14:28 +0200)]
build-sys: cleanup misc-utils/Makefile.am
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 12:28:27 +0000 (14:28 +0200)]
docs: add note about BUILD_* macros
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 12:20:35 +0000 (14:20 +0200)]
build-sys: cleanup BUILD_LSBLK
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 12:17:00 +0000 (14:17 +0200)]
build-sys: cleanup BUILD_UUIDD
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 11:45:42 +0000 (13:45 +0200)]
build-sys: cleanup BUILD_LIBMOUNT
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 10:55:05 +0000 (12:55 +0200)]
build-sys: use $build_libblkid
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 10:52:01 +0000 (12:52 +0200)]
build-sys: cleanup BUILD_PARTX
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 10:44:06 +0000 (12:44 +0200)]
build-sys: cleanup BUILD_FSCK
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 10:39:30 +0000 (12:39 +0200)]
build-sys: cleanup BUILD_MOUNT
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 10:08:01 +0000 (12:08 +0200)]
build-sys: cleanup BUILD_RAW
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 09:10:53 +0000 (11:10 +0200)]
build-sys: remove unnecessary perl check
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 09:06:08 +0000 (11:06 +0200)]
docs: add howto-build-sys.txt
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 08:45:04 +0000 (10:45 +0200)]
build-sys: add UL_REQUIRES_* macros
UL_REQUIRES_{LINUX,BUILD,HAVE} macros check for dependence between
--enable-* state and OS type, another build (e.g. libblkid), function
or library.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 27 Oct 2011 08:32:24 +0000 (10:32 +0200)]
build-sys: move --enable-lib{mount,uuid,blkid} before others --enable-*
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 25 Oct 2011 15:00:32 +0000 (17:00 +0200)]
build-sys: rename and move macros
- use m4/ul.m4 for util-linux macros
- use UL_ prefix for all util-linux macros
Signed-off-by: Karel Zak <kzak@redhat.com>
Petr Uzel [Tue, 1 Nov 2011 15:29:42 +0000 (16:29 +0100)]
dmesg: fix printing of multibyte characters
Also make it compile if HAVE_WIDECHAR is not defined.
Addresses: https://bugzilla.novell.com/show_bug.cgi?id=725993
Reported-by: Harald Koenig <koenig@linux.de>
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Davidlohr Bueso [Wed, 26 Oct 2011 14:26:49 +0000 (16:26 +0200)]
docs: update TODO file
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Davidlohr Bueso [Wed, 2 Nov 2011 15:22:44 +0000 (16:22 +0100)]
partx: use USAGE_ macros
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Davidlohr Bueso [Wed, 26 Oct 2011 13:58:18 +0000 (15:58 +0200)]
lsblk: remove __NCOLUMNS
We use ARRAY_SIZE() instead to define the amount of available columns.
[kzak@redhat.com: - fix compiler warnings [-Wsign-compare]]
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Davidlohr Bueso [Wed, 26 Oct 2011 13:57:38 +0000 (15:57 +0200)]
partx: remove __NCOLUMNS
We use ARRAY_SIZE() instead to define the amount of available columns.
[kzak@redhat.com: - fix compiler warnings [-Wsign-compare]]
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 2 Nov 2011 14:51:45 +0000 (15:51 +0100)]
fsck: use FS blacklist for non-all mode too
Reported-by: Lennart Poettering <lennart@poettering.net>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 7 Oct 2011 15:56:27 +0000 (17:56 +0200)]
login: cosmetic changes in docs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 22:56:32 +0000 (00:56 +0200)]
login: use ENV_PATH and ENV_{ROOT,SU}PATH from login.defs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 22:56:32 +0000 (00:56 +0200)]
login: add -H option for compatibility with Suse
Note that our login(1) uses hostname without domain, so:
"foo login: "
this is compatible with the default agetty(8) behavior.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 22:30:45 +0000 (00:30 +0200)]
login: use LOG_UNKFAIL_ENAB from login.defs, improve logging
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 21:50:12 +0000 (23:50 +0200)]
login: use DEFAULT_HOME from login.defs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 21:39:14 +0000 (23:39 +0200)]
login: use HUSHLOGIN_FILE from login.defs
Note that Suse login(1) does not use any default for HUSHLOGIN_FILE.
We use /etc/hushlogins and ~/.hushlogin as default.
The another difference is that *empty* global (e.g. /etc/hushlogins)
means that hushed mode will be enabled for all accounts.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 21:07:45 +0000 (23:07 +0200)]
login: use TTYGROUP from login.defs
Note that Suse login(1) does not use any default for TTYGROUP, it
means that TTYGROUP has to be explicitly defined otherwise user\'s
primary group is used.
The util-linux login(1) uses 'tty' group name as a default value.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 11:56:09 +0000 (13:56 +0200)]
login: use TTYPERM from login.defs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 11:41:40 +0000 (13:41 +0200)]
login: use FAIL_DELAY from login.defs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 11:38:15 +0000 (13:38 +0200)]
login: use LOGIN_TIMEOUT from login.defs
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 11:30:52 +0000 (13:30 +0200)]
login: rewrite motd(), use MOTD_FILE from login.defs
Note that Suse login(1) does not use any default for MOTD_FILE, so
MOTD_FILE item in login.defs is required otherwise nothing is printed.
We use (for backward compatibility) /etc/motd as default.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 11:16:30 +0000 (13:16 +0200)]
login: remove obsolete info from man page
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 10:15:50 +0000 (12:15 +0200)]
tests: remove obsolete checktty test
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 5 Oct 2011 10:10:26 +0000 (12:10 +0200)]
login: add login.defs code and tests
The new logindefs.c file contains /etc/login.defs parser and functions
for searching in the list of the login default variables. The patch
also contains a new regression test for the code.
Based on pam_login-4.0 from Suse.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 4 Oct 2011 21:45:45 +0000 (23:45 +0200)]
tests: cleanup islocal test
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 3 Oct 2011 15:45:36 +0000 (17:45 +0200)]
login: host{name,address} initialization refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 3 Oct 2011 15:28:57 +0000 (17:28 +0200)]
login: remove unnecessary variables
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 3 Oct 2011 15:23:43 +0000 (17:23 +0200)]
login: move signal stuff to the one place
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 3 Oct 2011 15:21:04 +0000 (17:21 +0200)]
login: log good logins refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 3 Oct 2011 15:06:08 +0000 (17:06 +0200)]
login: use xalloc.h
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 3 Oct 2011 15:04:05 +0000 (17:04 +0200)]
login: env initialization refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 3 Oct 2011 14:41:10 +0000 (16:41 +0200)]
login: fork & session initialization refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 13 Sep 2011 10:51:55 +0000 (12:51 +0200)]
login: remove pam_handle_t from main()
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 13 Sep 2011 10:45:48 +0000 (12:45 +0200)]
login: PAM session initialization refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 13 Sep 2011 10:40:58 +0000 (12:40 +0200)]
login: PAM account checks refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 13 Sep 2011 10:32:24 +0000 (12:32 +0200)]
login: PAM auth refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 13 Sep 2011 10:04:18 +0000 (12:04 +0200)]
login: PAM initialization refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 13 Sep 2011 09:37:32 +0000 (11:37 +0200)]
login: remove unused code and tests
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 29 Aug 2011 08:30:42 +0000 (10:30 +0200)]
login: improve hushed mode (merge suse changes)
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 26 Aug 2011 12:41:03 +0000 (14:41 +0200)]
login: use setgroups(0, NULL) for root
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 26 Aug 2011 11:25:13 +0000 (13:25 +0200)]
login: tty chown.chmod refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 26 Aug 2011 10:56:07 +0000 (12:56 +0200)]
login: use getpwnam_r() rather than manually copy passwd struct
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 26 Aug 2011 10:15:09 +0000 (12:15 +0200)]
login: utmp code refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 16:05:33 +0000 (18:05 +0200)]
login: lastlog code refactoring
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 15:54:59 +0000 (17:54 +0200)]
login: use login_context struct in audit stuff
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 15:49:00 +0000 (17:49 +0200)]
login: add username to login_context struct
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 15:41:00 +0000 (17:41 +0200)]
login: add pid to login_context struct
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 15:38:16 +0000 (17:38 +0200)]
login: add hostname to login_context struct
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 14:13:36 +0000 (16:13 +0200)]
login: add struct login_context, consolidate tty code
- move all tty_* variables to struct login_context
- move all tty initialization code to init_tty()
- LOG_ERR on failed tty ch{mod,own}
[based on SUSE pam_login - note that we don't write any this error to stderr]
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 10:38:47 +0000 (12:38 +0200)]
login: indent -linux
Yeah, this patch is horrible, but necessary before a real changes to
the code...
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 10:27:40 +0000 (12:27 +0200)]
login: remove obsolete code, clean up macros names
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 10:09:38 +0000 (12:09 +0200)]
login: cleanup begin of the login.c file
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 10:07:12 +0000 (12:07 +0200)]
lib: cleanup setproctitle.c
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 25 Aug 2011 09:48:06 +0000 (11:48 +0200)]
login: remove PAM_FAIL_CHECK and PAM_END macros
* use function rather than horrible macros
* rename get_pam_username -> loginpam_get_username
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 15 Aug 2011 10:45:20 +0000 (12:45 +0200)]
build-sys: require PAM for login-utils
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 12 Aug 2011 12:07:18 +0000 (14:07 +0200)]
login: remove non-PAM code
If you need non-PAM login(1) then use shadow-utils or busybox.
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 12 Aug 2011 10:30:17 +0000 (12:30 +0200)]
login: move _PATH_BTMP to pathnames.h
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 12 Aug 2011 10:28:28 +0000 (12:28 +0200)]
login: remove dead code and comments
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 12 Aug 2011 09:18:03 +0000 (11:18 +0200)]
login: remove kerberos specific code
The code has not been used ever. If you want to use kerberos then us
PAM...
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Fri, 5 Aug 2011 11:47:22 +0000 (13:47 +0200)]
agetty: pass hostname to login(1)
Signed-off-by: Karel Zak <kzak@redhat.com>
Davidlohr Bueso [Wed, 19 Oct 2011 20:02:35 +0000 (16:02 -0400)]
prlimit: new command
This program uses the prlimit() system call to get and/or set resource limits
for a given process.
[kzak@redhat,com: - improve <soft:hard> parsing,
- use short cmdline options compatible with ulimits
- add --verbose mode
- fix gcc warnings]
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Thu, 20 Oct 2011 22:12:47 +0000 (00:12 +0200)]
blkid: print ID_PART_ENTRY_* for small devices
The current optimization for small devices (1.4MiB) is broken. It
checks for partition table, but if nothing is detected then details
(ID_PART_ENTRY_*) about the current partition are not gathered.
The optimization should be enabled for small *whole* disks only.
Reported-by: David Zeuthen <davidz@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Harald Hoyer [Thu, 20 Oct 2011 08:05:20 +0000 (10:05 +0200)]
switch_root: handle /run and do not mount over existing mounts
Handle /run just like /dev, /sys and /proc
Do not mount move, if there is already something mounted on the
destination folder.
Signed-off-by: Harald Hoyer <harald@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 17 Oct 2011 16:58:03 +0000 (18:58 +0200)]
mount: remounting tmpfs read-write hangs (selinux)
Reported-by: Petr Pisar <ppisar@redhat.com>
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=746705
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Mon, 17 Oct 2011 11:27:21 +0000 (13:27 +0200)]
libmount: unable to umount nfs shares using the force option
Reported-by: Federico Simoncelli <fsimonce@redhat.com>
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=745746
Signed-off-by: Karel Zak <kzak@redhat.com>
Davidlohr Bueso [Fri, 14 Oct 2011 20:32:15 +0000 (16:32 -0400)]
lib,strutils: add default value to parse_range()
This function currently sets the low or high values to 0 when the string doesn't
contain a value, like '123:' or ':123'. In order to make it more flexible, we allow it
to be passed an arbitrary value.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Petr Uzel [Thu, 13 Oct 2011 13:10:45 +0000 (15:10 +0200)]
fstrim: fix section number in referral to manpage
Reported-by: Roeland Jansen <roeland@linux-it.nl>
Addresses: https://bugzilla.novell.com/show_bug.cgi?id=723877
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Petr Uzel [Thu, 13 Oct 2011 12:40:31 +0000 (14:40 +0200)]
rtcwake: fix crash (invalid free)
~ $ rtcwake -d X -s 10
*** glibc detected *** rtcwake: munmap_chunk(): invalid pointer: 0x00007fff839253c3 ***
======= Backtrace: =========
/lib64/libc.so.6(+0x733b6)[0x7f582677a3b6]
rtcwake[0x4022d5]
/lib64/libc.so.6(__libc_start_main+0xfd)[0x7f5826725bfd]
rtcwake[0x4016b9]
======= Memory map: ========
<SNIP>
Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Karel Zak [Wed, 12 Oct 2011 08:15:58 +0000 (10:15 +0200)]
fdisk: don't shorten long path to disk device
Reported-by: Petr Uzel <petr.uzel@suse.cz>
Signed-off-by: Karel Zak <kzak@redhat.com>
Davidlohr Bueso [Wed, 12 Oct 2011 03:18:12 +0000 (23:18 -0400)]
lib,strutils: share parse_range()
This function is currently only being used by partx(8), but it's handy and
generic enough that we can use it elsewhere as well.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Dave Reisner [Tue, 11 Oct 2011 18:27:47 +0000 (14:27 -0400)]
include/loopdev.h: add missing function prototype
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Karel Zak [Tue, 11 Oct 2011 14:41:34 +0000 (16:41 +0200)]
docs: update TODO
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 11 Oct 2011 10:23:23 +0000 (12:23 +0200)]
lscpu: add columns description to help, fix header for parsable output
Signed-off-by: Karel Zak <kzak@redhat.com>
Heiko Carstens [Mon, 10 Oct 2011 08:59:44 +0000 (10:59 +0200)]
lscpu: man page update
Rather large man page update which adds more information.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Heiko Carstens [Mon, 10 Oct 2011 08:59:43 +0000 (10:59 +0200)]
chcpu: man page update
Move chcpu man page to section 8 (admin commands) where it belongs.
Also update the contents of the man page.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Heiko Carstens [Mon, 10 Oct 2011 08:59:42 +0000 (10:59 +0200)]
lscpu: add s390 kvm test case
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Heiko Carstens [Mon, 10 Oct 2011 08:59:40 +0000 (10:59 +0200)]
lscpu: fix typo in help text
Add missing 'n' in help text for extended output line.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Heiko Carstens [Mon, 10 Oct 2011 08:59:39 +0000 (10:59 +0200)]
lscpu: switch Yes/No output to lower case
Some people complained about the first letter of Yes/No as seen in the
online and configured column in the human readabe output being a capital
letter instead of the expected lower case letter.
So let's try to make everbody happy and convert them to lower case.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Karel Zak [Tue, 11 Oct 2011 09:26:31 +0000 (11:26 +0200)]
mountpoint: support symbolic and relative paths
Reported-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 11 Oct 2011 09:14:31 +0000 (11:14 +0200)]
Revert "mountpoint: refactor exit path"
This change is unnecessary, we can use libmount stuff for everything.
This reverts commit
b16b56ec55507b6b83e0d35e3cefeb16367f3363 .
Dave Reisner [Mon, 10 Oct 2011 23:14:15 +0000 (19:14 -0400)]
mountpoint: refactor exit path
There's only one condition for which we declare success, but many for
failure. Initialize rc as failure and set to success on this single
condition. In all cases, jump to a label to exit instead of exiting
immediately. This will be used later on to ease cleanup of any heap
allocations.
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 11 Oct 2011 08:47:44 +0000 (10:47 +0200)]
mountpoint: fallback on stat when /proc isn't mounted
Reported-by: <dreisner@archlinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Dave Reisner [Sun, 9 Oct 2011 03:31:50 +0000 (23:31 -0400)]
mountpoint: return dev_t from dir_to_device
The string returned from this function was never of much use other than
to stat the path when the user requested a major:minor pair beyond the
true/false exit. Save some processing and directly returning the dev_t
on success, and an impossible value on failure.
[kzak@redhat.com: - use 0 as dir_to_device() return value on failure]
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Signed-off-by: Karel Zak <kzak@redhat.com>
Sami Kerola [Wed, 5 Oct 2011 13:37:48 +0000 (15:37 +0200)]
lsblk: inform about depencency to /sys/dev/block
The lsblk depends on /sys/dev/block/ symlinks, which appeared in
kernel 2.6.27. Users with old, or non-sysfs configured, kernel
got ealier message
lsblk: md0: failed to initialize sysfs handler
lsblk: xvda: failed to initialize sysfs handler
[...]
that I found a little too difficult to understand. This patch will
change the message to
lsblk: failed to access sysfs directory: /sys/dev/block: No such file or directory
and informs in manual page what could be reason to that.
[kzak@redhat.com: - use access() rather than opendir()]
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Sat, 1 Oct 2011 13:33:53 +0000 (15:33 +0200)]
build-sys: check scanf %ms modifier
Without the check libmount builds on systems that has older than 2.7
glibc are silently unsuccessful. The missing %ms modifier will, at
least, result on such system missing output of findmnt and lsblk
commands. If either %ms or %as modifiers are present the libmount
build is disabled.
Based on patch from: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>