]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
18 months agotest: Remove flaky test comments
Daan De Meyer [Sun, 5 May 2024 19:32:49 +0000 (21:32 +0200)] 
test: Remove flaky test comments

These two tests don't seem to fail in CI, so let's remove the comments
about flakyness.

18 months agotest: Always shutdown on test success in mkosi
Daan De Meyer [Sun, 5 May 2024 09:38:09 +0000 (11:38 +0200)] 
test: Always shutdown on test success in mkosi

When we want to get an interactive shell in a test that fails because
of a race condition, we might need to run the test a few times with
--repeat before it fails. However, currently, when -i is used, the VM
needs to be shut down manually each time before the next run can start.

Let's always shut down the VM if the test succeeds so that --repeat can
be used with -i to run the test until it fails and then get an interactive
shell in the VM.

18 months agotest: Use MESON_TEST_ITERATION if available
Daan De Meyer [Fri, 3 May 2024 08:57:50 +0000 (10:57 +0200)] 
test: Use MESON_TEST_ITERATION if available

This allows running the same test multiple times concurrently with
meson's --repeat option. Proposed upstream but not yet merged:
https://github.com/mesonbuild/meson/pull/13177.

18 months agotest: Pass through test matching environment variables to the mkosi VM
Daan De Meyer [Fri, 3 May 2024 08:27:58 +0000 (10:27 +0200)] 
test: Pass through test matching environment variables to the mkosi VM

18 months agotest: Only set environment variable if integration tests are enabled.
Daan De Meyer [Thu, 2 May 2024 18:21:29 +0000 (20:21 +0200)] 
test: Only set environment variable if integration tests are enabled.

If we set it to '0' if integration tests are not enabled then we can't
enable them from the command line since environment from meson takes
priority over environment variables from the command line.

We also rename the related variables to avoid conflicts with the
existing integration_tests variable.

18 months agomkosi: Add dependency to system image on minimal-base
Daan De Meyer [Sun, 5 May 2024 20:22:03 +0000 (22:22 +0200)] 
mkosi: Add dependency to system image on minimal-base

The output is included as an extra tree so it should be a dependency,
even if it is pulled in transitively via minimal-0 and minimal-1
already.

18 months agomkosi: Install dbus policy required by TEST-23-UNIT-FILE
Daan De Meyer [Sun, 5 May 2024 19:19:26 +0000 (21:19 +0200)] 
mkosi: Install dbus policy required by TEST-23-UNIT-FILE

Co-authored-by: Richard Maw <richard.maw@codethink.co.uk>
18 months agomkosi: Remove /etc/default/keyboard if it exists
Daan De Meyer [Sun, 5 May 2024 18:46:59 +0000 (20:46 +0200)] 
mkosi: Remove /etc/default/keyboard if it exists

Required to make TEST-73-LOCALE pass on Ubuntu.

18 months agomkosi: Make sure tmp.mount is not messed with on Debian/Ubuntu
Daan De Meyer [Sun, 5 May 2024 13:03:37 +0000 (15:03 +0200)] 
mkosi: Make sure tmp.mount is not messed with on Debian/Ubuntu

We want /tmp to be a tmpfs so let's hack the debian packaging to
make sure that's the case until the debian packaging is fixed to
make /tmp a tmpfs for UPSTREAM=1 builds.

18 months agomkosi: Install stress
Daan De Meyer [Sun, 5 May 2024 08:25:12 +0000 (10:25 +0200)] 
mkosi: Install stress

Required for TEST-55-OOMD. Not available on opensuse.

18 months agomkosi: Install veritysetup
Daan De Meyer [Sat, 4 May 2024 10:46:11 +0000 (12:46 +0200)] 
mkosi: Install veritysetup

Only missing on CentOS/Fedora/OpenSUSE as in Arch/Debian/Ubuntu it's
part of the cryptsetup package which we already install.

Required for TEST-58-REPART.

18 months agomkosi: Install dig
Daan De Meyer [Sat, 4 May 2024 10:18:31 +0000 (12:18 +0200)] 
mkosi: Install dig

Required for TEST-75-RESOLVED

18 months agomkosi: Install knot
Daan De Meyer [Sat, 4 May 2024 10:18:10 +0000 (12:18 +0200)] 
mkosi: Install knot

Required for TEST-75-RESOLVED

18 months agomkosi: Use /etc/nsswitch.conf from repo in mkosi image
Daan De Meyer [Fri, 3 May 2024 10:57:29 +0000 (12:57 +0200)] 
mkosi: Use /etc/nsswitch.conf from repo in mkosi image

18 months agomkosi: Disable ext4's orphan_file feature for centos images
Daan De Meyer [Fri, 3 May 2024 10:56:50 +0000 (12:56 +0200)] 
mkosi: Disable ext4's orphan_file feature for centos images

Not supported by e2fsck from centos. We also disable building repart
from source in CI as running it from the build directory means repart
will run mkfs.ext4 from the host which doesn't know about the orphan_file
feature causing it to fail.

18 months agomkosi: Enable udev debug logging in CI
Daan De Meyer [Thu, 2 May 2024 14:38:31 +0000 (16:38 +0200)] 
mkosi: Enable udev debug logging in CI

It's very useful to debug race conditions with loop devices, so let's
enable the logging now that it goes to the journal and not to the
console.

18 months agomkosi: Move sbsigntools to CentOS/Fedora shared configuration
Daan De Meyer [Wed, 1 May 2024 07:37:09 +0000 (09:37 +0200)] 
mkosi: Move sbsigntools to CentOS/Fedora shared configuration

sbsigntools was added to EPEL 9.

18 months agomkosi: Drop glibc-langpack-en from Fedora specific packages
Daan De Meyer [Wed, 1 May 2024 07:36:17 +0000 (09:36 +0200)] 
mkosi: Drop glibc-langpack-en from Fedora specific packages

It's already added in the CentOS/Fedora shared configuration.

18 months agomkosi: Install dfuzzer on CentOS/Fedora images
Daan De Meyer [Wed, 1 May 2024 07:35:28 +0000 (09:35 +0200)] 
mkosi: Install dfuzzer on CentOS/Fedora images

Required for TEST-21-DFUZZER.

18 months agomkosi: Insist on KVM, VSOCK and TPM by default
Daan De Meyer [Fri, 3 May 2024 12:15:55 +0000 (14:15 +0200)] 
mkosi: Insist on KVM, VSOCK and TPM by default

By default mkosi will not run VMs with these features if they're not
available, but since various stuff in systemd makes use of these, let's
fail loudly if any of these are not available by default in systemd.

Users can still override these defaults locally if they wish.

18 months agomkosi: Update to latest
Daan De Meyer [Fri, 3 May 2024 12:13:39 +0000 (14:13 +0200)] 
mkosi: Update to latest

18 months agotest: Formatting fixes
Daan De Meyer [Thu, 2 May 2024 06:52:50 +0000 (08:52 +0200)] 
test: Formatting fixes

18 months agomeson: Add missing spdx line
Daan De Meyer [Sun, 5 May 2024 08:39:22 +0000 (10:39 +0200)] 
meson: Add missing spdx line

18 months agomeson: Test installation fixes
Daan De Meyer [Sat, 4 May 2024 13:08:02 +0000 (15:08 +0200)] 
meson: Test installation fixes

Let's use the new follow_symlinks flag instead on newer meson to.
We also switch back to copying symlinks instead of following them
and add an exclude for 25-default.link which becomes dangling when
installed and recreate it manually instead.

18 months agomeson: Set up git submodule update on post checkout as well
Daan De Meyer [Fri, 3 May 2024 15:44:49 +0000 (17:44 +0200)] 
meson: Set up git submodule update on post checkout as well

18 months agomeson: Remove --debug from mkosi arguments
Daan De Meyer [Fri, 3 May 2024 12:10:24 +0000 (14:10 +0200)] 
meson: Remove --debug from mkosi arguments

The exit status issue for which we introduced this was fixed so
let's remove --debug again to make the meson output less verbose.

18 months agoMerge pull request #32588 from CodethinkLabs/mkosi-selinux
Luca Boccassi [Sat, 4 May 2024 18:48:55 +0000 (20:48 +0200)] 
Merge pull request #32588 from CodethinkLabs/mkosi-selinux

Add TEST-06-SELINUX to mkosi integration tests

18 months agoman/run0: Describe environment variables set (#32622)
Thayne McCombs [Sat, 4 May 2024 11:06:16 +0000 (05:06 -0600)] 
man/run0: Describe environment variables set (#32622)

* man/run0: Describe environment variables set

18 months agotest: replace Europe/Kiev with Europe/Kyiv
Frantisek Sumsal [Thu, 2 May 2024 18:40:10 +0000 (20:40 +0200)] 
test: replace Europe/Kiev with Europe/Kyiv

As the former is deprecated and might not be available (i.e. on Ubuntu
Noble it's only available after installing the tzdata-legacy package).

18 months agojournal: Serialize __MONOTONIC_TIMESTAMP metadata field as well
Daan De Meyer [Fri, 3 May 2024 12:49:00 +0000 (14:49 +0200)] 
journal: Serialize __MONOTONIC_TIMESTAMP metadata field as well

Otherwise the forwarded journals won't have any monotonic timestamps.

18 months agotest: Enable TEST-06-SELINUX testing with mkosi 32588/head
Richard Maw [Tue, 30 Apr 2024 16:39:52 +0000 (17:39 +0100)] 
test: Enable TEST-06-SELINUX testing with mkosi

18 months agomkosi: Disable selinux labelling and install policy in initramfs
Richard Maw [Tue, 30 Apr 2024 16:23:02 +0000 (17:23 +0100)] 
mkosi: Disable selinux labelling and install policy in initramfs

It is necessary to install the selinux policy in the initramfs
so that userland is entered with the correct label.

SELinuxRelabel defaults to auto, which will skip if the relabelling
command is not installed and will treat failure to relabel as non-fatal.

We can't force it on because root privileges are required if the labels
don't exist on the host system and we would like to be able to
cross-build from other distributions.

Since we are already committed to relabelling on first boot
there is no value in even trying to label.

18 months agotest: Integrate custom selinux relabelling unit with firstboot
Richard Maw [Fri, 5 Apr 2024 16:47:17 +0000 (17:47 +0100)] 
test: Integrate custom selinux relabelling unit with firstboot

18 months agotest: Skip TEST-06-SELINUX early if not on fedora/centos
Richard Maw [Tue, 30 Apr 2024 17:02:51 +0000 (18:02 +0100)] 
test: Skip TEST-06-SELINUX early if not on fedora/centos

Other distributions may be able to install selinux
but they are not expected to use it.

The distribution is tested rather than whether selinux is enabled
because it is expected to work on CentOS and Fedora
and we want it to fail noisily.

18 months agomkosi: Fix particle profile
Richard Maw [Fri, 3 May 2024 10:05:26 +0000 (11:05 +0100)] 
mkosi: Fix particle profile

The sbsign and ukify part was moved into a finalize script
rather than a postinst.chroot script so was using host tools
instead of just-built.

18 months agobuild(deps): bump pkg/debian from `9a5adf2` to `f550017`
dependabot[bot] [Fri, 3 May 2024 09:44:49 +0000 (09:44 +0000)] 
build(deps): bump pkg/debian from `9a5adf2` to `f550017`

Bumps pkg/debian from `9a5adf2` to `f550017`.

---
updated-dependencies:
- dependency-name: pkg/debian
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
18 months agoman: improve documentation about using resource-control options
anphir [Fri, 3 May 2024 08:34:05 +0000 (10:34 +0200)] 
man: improve documentation about using resource-control options

According to the documentation in systemd.resource-control(5),
resource-control options may be used in mount, scope, service,
slice, socket and swap units.
While e.g. systemd.service(5) includes that information,
documentation for some other units does not.

The most problematic example is systemd.slice(5).
Its documentation states a slice unit may only contain [Install]
and [Unit] sections, while actually it may contain also a [Slice]
section with options from systemd.resource-control(5).
units/user/app.slice is an example of a slice unit having a [Slice]
section.

18 months agotest: drop --tpm2-public-key= from TEST-70
Luca Boccassi [Thu, 2 May 2024 21:29:05 +0000 (22:29 +0100)] 
test: drop --tpm2-public-key= from TEST-70

Fixes test failure

Follow-up for 03e3b2672bb6c242c445ee8c02ae7d23dbfcf87d

19 months agonspawn, vmspawn, run0: add env var for turning off background tinting
Lennart Poettering [Thu, 2 May 2024 15:07:51 +0000 (17:07 +0200)] 
nspawn, vmspawn, run0: add env var for turning off background tinting

Some people are just sad, sad lost souls who don't like even the tiniest
ray of color in their life. Let's add an env var knob for allowing them
to turn the background tinting off, to drive the last bit of color from
their life so that they can stay in their grey grey life.

19 months agojournal: explicitly sync namespaced journals before stopping socket units
Yu Watanabe [Wed, 1 May 2024 21:18:52 +0000 (06:18 +0900)] 
journal: explicitly sync namespaced journals before stopping socket units

Otherwise, if a service unit that requests LogNamespace= stopped before
systemd-journald@.service is started, logs generated by the service will be
lost, as systemd-journald@.socket is stopped and
systemd-journald@.service will never started.

To prevent the issue, let's introduce another implicit dependency to
a oneshot service that explicitly synchronizes a namespaced journal file
when the log namespace is not needed anymore.

Fixes #32604.

19 months agovmspawn,man: move the varlistentry for -D into a variablelist
Sam Leonard [Thu, 2 May 2024 16:32:49 +0000 (17:32 +0100)] 
vmspawn,man: move the varlistentry for -D into a variablelist

This is so that systemd.directives picks up the -D argument as being
supported by vmspawn.

19 months agotree-wide: fix type confusion around parsing JSON booleans
Lennart Poettering [Thu, 2 May 2024 13:25:34 +0000 (15:25 +0200)] 
tree-wide: fix type confusion around parsing JSON booleans

Sometimes we store them in a tristate, sometimes in C stdbool booleans.
Sometimes we fucked up picking the right parsing function however. Fix
that.

19 months agonews: refer to ForwardToSocket instead of ForwardAddress
Sam Leonard [Thu, 2 May 2024 16:41:49 +0000 (17:41 +0100)] 
news: refer to ForwardToSocket instead of ForwardAddress

19 months agoupdate TODO
Lennart Poettering [Thu, 2 May 2024 16:16:59 +0000 (18:16 +0200)] 
update TODO

19 months agocryptenroll: disable loading public key if --tpm2-public-key= is empty
Sam Leonard [Fri, 26 Apr 2024 12:35:05 +0000 (13:35 +0100)] 
cryptenroll: disable loading public key if --tpm2-public-key= is empty

19 months agolibfido2-util: fix a regression in the pre-flight mechanism
Kamil SzczÄ™k [Sat, 27 Apr 2024 11:43:35 +0000 (13:43 +0200)] 
libfido2-util: fix a regression in the pre-flight mechanism

The recently merged PR #32295 introduced support for the credProtect
extension, but in doing so, it broke the discoverability of credentials
by setting the policy to FIDO_CRED_PROT_UV_REQUIRED for UV-less,
PIN-protected credentials. This policy would require us to pass the PIN
to the token in the pre-flight request to be able to discover it,
which defeats the purpose of pre-flight requests as they're supposed
to be non-interactive.

This commit restricts the usage of credProtect to UV credentials only.

19 months agobuild(deps): bump pkg/arch from `dd7aff4` to `b13e94a`
dependabot[bot] [Thu, 2 May 2024 09:45:15 +0000 (09:45 +0000)] 
build(deps): bump pkg/arch from `dd7aff4` to `b13e94a`

Bumps pkg/arch from `dd7aff4` to `b13e94a`.

---
updated-dependencies:
- dependency-name: pkg/arch
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
19 months agoimportctl: fix flag checking against wrong variable
Antonio Alvarez Feijoo [Thu, 2 May 2024 09:53:18 +0000 (11:53 +0200)] 
importctl: fix flag checking against wrong variable

Fixes 67c7ee11afb5ff703c3ca8e390c8360140298a0f

19 months agoMerge pull request #32592 from yuwata/journal-timestamp
Luca Boccassi [Thu, 2 May 2024 11:57:40 +0000 (13:57 +0200)] 
Merge pull request #32592 from yuwata/journal-timestamp

journal: several timestamp cleanups and improvements

19 months agoMerge pull request #32609 from systemd/dependabot/github_actions/github/super-linter-6
Frantisek Sumsal [Thu, 2 May 2024 08:16:40 +0000 (10:16 +0200)] 
Merge pull request #32609 from systemd/dependabot/github_actions/github/super-linter-6

build(deps): bump github/super-linter from 5.0.0 to 6

19 months agoci: point Super-Linter to the new upstream 32609/head
Frantisek Sumsal [Thu, 2 May 2024 07:53:43 +0000 (09:53 +0200)] 
ci: point Super-Linter to the new upstream

Looks like since [0] the Super-Linter repo was moved to
super-linter/super-linter and github/super-linter is just a fork, so
let's update the reference accordingly.

[0] https://github.com/github/super-linter/commit/59fac7946c4891bb4867ebb4ffdb05c32fac3cf4

19 months agoci: explicitly disable multi status for Super-Linter
Frantisek Sumsal [Thu, 2 May 2024 07:45:02 +0000 (09:45 +0200)] 
ci: explicitly disable multi status for Super-Linter

The multi status feature requires $GITHUB_TOKEN, and since [0] it
defaults to true. Since we don't need it, let's explicitly disable the
feature.

[0] https://github.com/super-linter/super-linter/commit/e6e6e1fa5f60e15d7e9b89248bb0809bea1c17e9

19 months agopo: update Italian translation (#32621)
Daniele Medri [Thu, 2 May 2024 06:55:17 +0000 (08:55 +0200)] 
po: update Italian translation (#32621)

19 months agoMerge pull request #32617 from yuwata/journal-sync
Mike Yuan [Thu, 2 May 2024 05:39:16 +0000 (13:39 +0800)] 
Merge pull request #32617 from yuwata/journal-sync

journald: wait for journal files fsync()ed on Synchronize() varlink method

19 months agocore/selinux-access: use empty_to_na where appropriate
Mike Yuan [Mon, 29 Apr 2024 13:21:07 +0000 (21:21 +0800)] 
core/selinux-access: use empty_to_na where appropriate

19 months agologs-show: adjust source timestamp with header timestamp 32592/head
Yu Watanabe [Tue, 30 Apr 2024 20:12:12 +0000 (05:12 +0900)] 
logs-show: adjust source timestamp with header timestamp

Previously, _SOURCE_REALTIME_TIMESTAMP was only used for realtime
timestamp, and _SOURCE_MONOTONIC_TIMESTAMP was for monotonic.

This make these journal field used more aggressively. If we need
realtime timestamp, but an entry has only _SOURCE_MONOTONIC_TIMESTAMP,
then now realtime timestamp is calculated based on
_SOURCE_MONOTONIC_TIMESTAMP and the header dual timestamp.
Similary, monotonic timestamp is obtained from
_SOURCE_REALTIME_TIMESTAMP and the header dual timestamp.

This should change shown timestamps not so much in most cases, but may
be improve the situation such as #32492.

19 months agologs-show: make output_timestamp_realtime() only take realtime timestamp
Yu Watanabe [Tue, 30 Apr 2024 20:03:01 +0000 (05:03 +0900)] 
logs-show: make output_timestamp_realtime() only take realtime timestamp

No functional change, just refactoring and preparation for later
commits.

19 months agosd-journal: verify monotonic timestamp before assigning result
Yu Watanabe [Tue, 30 Apr 2024 18:31:25 +0000 (03:31 +0900)] 
sd-journal: verify monotonic timestamp before assigning result

Previously, ret_boot_id was assigned even when the function failed due
to an invalid monotonic timestamp stored for a journal entry.

19 months agojournal: use STRLEN() and xsprintf()
Yu Watanabe [Wed, 1 May 2024 20:40:00 +0000 (05:40 +0900)] 
journal: use STRLEN() and xsprintf()

No functional change, just refactoring.

19 months agojournald-audit: set _SOURCE_REALTIME_TIMESTAMP= field in server_dispatch_message()
Yu Watanabe [Tue, 30 Apr 2024 06:55:22 +0000 (15:55 +0900)] 
journald-audit: set _SOURCE_REALTIME_TIMESTAMP= field in server_dispatch_message()

No functional change, just refactoring.

19 months agohwdb: Add mapping for Samsung GalaxyBook - 550X (#32616)
Saliba-san [Wed, 1 May 2024 19:54:32 +0000 (16:54 -0300)] 
hwdb: Add mapping for Samsung GalaxyBook - 550X (#32616)

- Kernel: linux-6.8.8-arch
- systemd: 255.5-3-arch
- Laptop: Samsung GalaxyBook - NP550XDA-KF1BR

This is the solution to a problem with the Samsung GalaxyBook in which some Media keys,
when pressed and released, get stuck as if they are hold.

19 months agoMerge pull request #32595 from bluca/old_docs
Mike Yuan [Wed, 1 May 2024 19:45:00 +0000 (03:45 +0800)] 
Merge pull request #32595 from bluca/old_docs

Remove outdated documents

19 months agojournald: wait for journal files fsync()ed on Synchronize() varlink method 32617/head
Yu Watanabe [Wed, 1 May 2024 19:08:50 +0000 (04:08 +0900)] 
journald: wait for journal files fsync()ed on Synchronize() varlink method

Otherwise, we may not be able to read newer journal entries even after
'journalctl --sync' is called.

Closing #32539.

19 months agojournald: make several functions static
Yu Watanabe [Wed, 1 May 2024 18:56:35 +0000 (03:56 +0900)] 
journald: make several functions static

19 months agoresolved: validate authentic insecure delegation to CNAME
Ronan Pigott [Tue, 30 Apr 2024 20:19:14 +0000 (13:19 -0700)] 
resolved: validate authentic insecure delegation to CNAME

If the parent zone uses a non-opt-out method that provides authenticated
negative DS replies, we still can't expect signatures from the child
zone. sd-resolved was using the authenticated status of the DS reply to
require signatures for CNAMEs, even though it had already proved that no
signature exists.

Fixes: 47690634f157 ("resolved: don't request the SOA for every dns label")
19 months agoresolved: probe for dnssec support in allow-downgrade mode
Ronan Pigott [Wed, 1 May 2024 05:15:18 +0000 (22:15 -0700)] 
resolved: probe for dnssec support in allow-downgrade mode

Previously, sd-resolved unnecessarily requested SOA records for each dns
label in the query, even though they are not needed for the chain of
trust. Since 47690634f157, only the necessary records are queried when
validating.

This is actually a problem in allow-downgrade mode, since we will no
longer attempt a query for a record that we know is signed a priori, and
will therefore never update our belief about the state of dnssec support
in the recursive resolver.

Rectify this by reintroducing a query for the root zone SOA in the
allow-downgrade case, specifically to test that the resolver attaches
the RRSIGs which we know must exist.

Fixes: 47690634f157 ("resolved: don't request the SOA for every dns label")
19 months agoMerge pull request #32613 from arthurzam/bash-v256
Luca Boccassi [Wed, 1 May 2024 18:27:32 +0000 (20:27 +0200)] 
Merge pull request #32613 from arthurzam/bash-v256

More shell-completions work

19 months agoshell-completion: add bash completion for systemd-vmspawn 32613/head
Arthur Zamarin [Wed, 1 May 2024 16:17:40 +0000 (19:17 +0300)] 
shell-completion: add bash completion for systemd-vmspawn

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
19 months agoshell-completion: add missing args to zsh resolvectl
Arthur Zamarin [Sat, 27 Apr 2024 19:26:12 +0000 (22:26 +0300)] 
shell-completion: add missing args to zsh resolvectl

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
19 months agoshell-completion: add missing args to bash resolvectl
Arthur Zamarin [Sat, 27 Apr 2024 19:00:18 +0000 (22:00 +0300)] 
shell-completion: add missing args to bash resolvectl

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
19 months agoshell-completion: add missing args to bash systemd-analyze
Arthur Zamarin [Sat, 27 Apr 2024 17:54:40 +0000 (20:54 +0300)] 
shell-completion: add missing args to bash systemd-analyze

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
19 months agoreboot-util: Add some basic validation on reboot arguments
Daan De Meyer [Wed, 1 May 2024 08:28:34 +0000 (10:28 +0200)] 
reboot-util: Add some basic validation on reboot arguments

Let's only accept valid ASCII and put a size limit on reboot arguments.

19 months agoMerge pull request #32611 from DaanDeMeyer/qdisc
Yu Watanabe [Wed, 1 May 2024 15:51:31 +0000 (00:51 +0900)] 
Merge pull request #32611 from DaanDeMeyer/qdisc

network/tc: Avoid concurrent set modification in tclass_drop()/qdisc_drop()

19 months agonetwork/tc: Avoid concurrent set modification in tclass_drop()/qdisc_drop() 32611/head
Daan De Meyer [Wed, 1 May 2024 12:41:41 +0000 (14:41 +0200)] 
network/tc: Avoid concurrent set modification in tclass_drop()/qdisc_drop()

With the current algorithm, we can end up removing entries from the
qdisc/tclass sets while having multiple open iterators over the sets at
various positions which leads to assertion failures in the hashmap logic
as it's only safe to remove the "current" entry.

To avoid the problem, let's split up marking and dropping of tclasses
and qdiscs. First, we recursively iterate tclasses/qdiscs and mark all
that need to be removed. Next, we iterate once over tclasses and qdiscs
and remove all marked entries.

Fixes 632d321050f58fe1b5bed7cfe769d212377c0301

19 months agotest-network: Make source directory optional
Daan De Meyer [Wed, 1 May 2024 14:11:56 +0000 (16:11 +0200)] 
test-network: Make source directory optional

19 months agotest: Follow symlinks when copying with rsync
Daan De Meyer [Wed, 1 May 2024 14:10:48 +0000 (16:10 +0200)] 
test: Follow symlinks when copying with rsync

We have e.g. 25-default.link in test-network/ which becomes a broken
symlink when installed so let's not copy the symlinks but follow them
instead so they don't become broken.

19 months agobuild(deps): bump redhat-plumbers-in-action/differential-shellcheck
dependabot[bot] [Wed, 1 May 2024 09:42:34 +0000 (09:42 +0000)] 
build(deps): bump redhat-plumbers-in-action/differential-shellcheck

Bumps [redhat-plumbers-in-action/differential-shellcheck](https://github.com/redhat-plumbers-in-action/differential-shellcheck) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/redhat-plumbers-in-action/differential-shellcheck/releases)
- [Changelog](https://github.com/redhat-plumbers-in-action/differential-shellcheck/blob/main/docs/CHANGELOG.md)
- [Commits](https://github.com/redhat-plumbers-in-action/differential-shellcheck/compare/c15070885a82a2c93db8a765d332c38c50dde8b3...52bab0caa5249d6acd8bcd5bc7a68e69ac9319f9)

---
updated-dependencies:
- dependency-name: redhat-plumbers-in-action/differential-shellcheck
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
19 months agobuild(deps): bump redhat-plumbers-in-action/gather-pull-request-metadata
dependabot[bot] [Wed, 1 May 2024 09:42:34 +0000 (09:42 +0000)] 
build(deps): bump redhat-plumbers-in-action/gather-pull-request-metadata

Bumps [redhat-plumbers-in-action/gather-pull-request-metadata](https://github.com/redhat-plumbers-in-action/gather-pull-request-metadata) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/redhat-plumbers-in-action/gather-pull-request-metadata/releases)
- [Commits](https://github.com/redhat-plumbers-in-action/gather-pull-request-metadata/compare/69c703f376018c1a41c8ccce21dc2e16a79f3324...17821d3bc27c1efed339595898c2e622accc5a1b)

---
updated-dependencies:
- dependency-name: redhat-plumbers-in-action/gather-pull-request-metadata
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
19 months agoMerge pull request #32610 from YHNdnzj/install-have-modification
Luca Boccassi [Wed, 1 May 2024 12:58:43 +0000 (14:58 +0200)] 
Merge pull request #32610 from YHNdnzj/install-have-modification

core/dbus-manager: mark unit file state as outdated only if some changes succeeded

19 months agocore/dbus-manager: mark unit file state as outdated only if 32610/head
Mike Yuan [Wed, 1 May 2024 09:30:35 +0000 (17:30 +0800)] 
core/dbus-manager: mark unit file state as outdated only if
some changes succeeded

Follow-up for a82b8b3dc80619c3275ad8180069289b411206d0

We don't need to invalidate the unit file state
if all operations failed.

Also, emit UnitFilesChanged signal as long as
some operations succeeded.

19 months agobuild(deps): bump pkg/arch from `6a2bc57` to `dd7aff4`
dependabot[bot] [Wed, 1 May 2024 09:22:36 +0000 (09:22 +0000)] 
build(deps): bump pkg/arch from `6a2bc57` to `dd7aff4`

Bumps pkg/arch from `6a2bc57` to `dd7aff4`.

---
updated-dependencies:
- dependency-name: pkg/arch
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
19 months agoshared/install: use FOREACH_ARRAY for install_changes_have_modification
Mike Yuan [Wed, 1 May 2024 09:30:21 +0000 (17:30 +0800)] 
shared/install: use FOREACH_ARRAY for install_changes_have_modification

19 months agobuild(deps): bump github/super-linter from 5.0.0 to 6
dependabot[bot] [Wed, 1 May 2024 09:42:38 +0000 (09:42 +0000)] 
build(deps): bump github/super-linter from 5.0.0 to 6

Bumps [github/super-linter](https://github.com/github/super-linter) from 5.0.0 to 6.
- [Release notes](https://github.com/github/super-linter/releases)
- [Changelog](https://github.com/github/super-linter/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/super-linter/compare/45fc0d88288beee4701c62761281edfee85655d7...4e51915f4a812abf59fed160bb14595c0a38a9e7)

---
updated-dependencies:
- dependency-name: github/super-linter
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
19 months agoshared/install: reduce variable scope
Mike Yuan [Wed, 1 May 2024 09:35:04 +0000 (17:35 +0800)] 
shared/install: reduce variable scope

19 months agosystemctl: fix log message when glob patterns passed to disable command and friends
Yu Watanabe [Wed, 1 May 2024 06:14:37 +0000 (15:14 +0900)] 
systemctl: fix log message when glob patterns passed to disable command and friends

Fixes #32599.

19 months agosystemctl: Implement --wait for kill command
Daan De Meyer [Tue, 30 Apr 2024 20:03:00 +0000 (22:03 +0200)] 
systemctl: Implement --wait for kill command

TEST-26-SYSTEMCTL is racy as we call systemctl is-active immediately
after systemctl kill. Let's implement --wait for systemctl kill and
use it in TEST-26-SYSTEMCTL to avoid the race.

19 months agoMerge pull request #32540 from DaanDeMeyer/mkosi
Daan De Meyer [Wed, 1 May 2024 07:04:49 +0000 (09:04 +0200)] 
Merge pull request #32540 from DaanDeMeyer/mkosi

mkosi: Enable more integration tests

19 months agocore/exec-credential: update comment
Yu Watanabe [Wed, 1 May 2024 06:57:55 +0000 (15:57 +0900)] 
core/exec-credential: update comment

19 months agoman/run0: fix typo (missing "by")
Mike Yuan [Wed, 1 May 2024 06:43:32 +0000 (14:43 +0800)] 
man/run0: fix typo (missing "by")

19 months agocore: Fix file descriptor leak
Daan De Meyer [Wed, 1 May 2024 01:14:45 +0000 (03:14 +0200)] 
core: Fix file descriptor leak

19 months agodocs: move information from AUTOPKGTEST.md to test/README.testsuite and delete it 32595/head
Luca Boccassi [Wed, 1 May 2024 00:29:09 +0000 (01:29 +0100)] 
docs: move information from AUTOPKGTEST.md to test/README.testsuite and delete it

This is not information that needs to be published on systemd.io as it's
purely internal, so the README is enough

19 months agodocs: drop outdated documents about os-release and cgroupsv1
Luca Boccassi [Tue, 30 Apr 2024 16:34:43 +0000 (17:34 +0100)] 
docs: drop outdated documents about os-release and cgroupsv1

cgroupv1 is deprecated, and os-release has a fully fledged manpage

19 months agopo: Translated using Weblate (Slovenian)
Martin Srebotnjak [Tue, 30 Apr 2024 20:36:08 +0000 (22:36 +0200)] 
po: Translated using Weblate (Slovenian)

Currently translated at 14.8% (35 of 235 strings)

Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/sl/
Translation: systemd/main

19 months agotest: Add disabled mkosi tests to meson.build 32540/head
Daan De Meyer [Mon, 29 Apr 2024 12:29:21 +0000 (14:29 +0200)] 
test: Add disabled mkosi tests to meson.build

Makes it easier to track which ones still need to be fixed.

19 months agotest: Enable more mkosi integration tests
Richard Maw [Thu, 18 Apr 2024 14:31:56 +0000 (15:31 +0100)] 
test: Enable more mkosi integration tests

19 months agotest: Bump mkosi integration test timeout to 1800 seconds
Daan De Meyer [Mon, 29 Apr 2024 14:01:57 +0000 (16:01 +0200)] 
test: Bump mkosi integration test timeout to 1800 seconds

Same timeout as the bash framework.

19 months agotest: Make journal storage configurable per test and make persistent for TEST-09...
Daan De Meyer [Tue, 30 Apr 2024 17:06:00 +0000 (19:06 +0200)] 
test: Make journal storage configurable per test and make persistent for TEST-09-JOURNAL

Also fix a bug in the logic since it's 'volatile' and not 'runtime'.

19 months agotest: Drop /usr overlay workaround
Daan De Meyer [Tue, 30 Apr 2024 14:12:35 +0000 (16:12 +0200)] 
test: Drop /usr overlay workaround

/usr is not erofs anymore in the mkosi images so let's drop the
workaround where we mount a writable tmpfs on top of /usr.

19 months agoRevert "TEST-25-IMPORT: Skip if importctl not installed"
Daan De Meyer [Tue, 30 Apr 2024 14:14:54 +0000 (16:14 +0200)] 
Revert "TEST-25-IMPORT: Skip if importctl not installed"

This reverts commit dcb17e3295dfce1a9a9f4fb648c4750c05d3c46d.

importctl is now correctly installed on opensuse, so no need for
this workaround anymore.

19 months agoTEST-71-HOSTNAME: Ignore error from reset-failed
Daan De Meyer [Tue, 30 Apr 2024 12:47:48 +0000 (14:47 +0200)] 
TEST-71-HOSTNAME: Ignore error from reset-failed

On OpenSUSE the systemd-hostnamed does not fail and is unloaded which
causes reset-failed to fail. So let's ignore any errors from reset-failed
to make the test more robust.