Andrew Bartlett [Fri, 3 Feb 2012 04:06:48 +0000 (15:06 +1100)]
smbwrapper: Remove smbwrapper
There are now many better ways to access a remote SMB filesystem,
which do not rely on LD_PRELOAD and the associated dangers. FUSE,
gvfs and the CIFS VFS are all much better options which do not require
knowing every possible libc entry point that can deal with a file
descriptor.
As an example of the maintainence that would be required to keep this
going, recent changes to deal with thread races and close-on-exec have
resulted in dup3(), but this isn't currently mapped. While this would
not be hard to add, it illistrates why it is better to move to an
interface designed for this task.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Feb 9 01:58:24 CET 2012 on sn-devel-104
Andrew Bartlett [Wed, 25 Jan 2012 22:23:23 +0000 (09:23 +1100)]
s3-build: remove EXEEXT from Makefiles
As far as I am aware, we do not actually build on any platforms that
require this. The last Stratos VOS release on
ftp://ftp.stratus.com/vos/samba/samba.html was 3.0.5
s4:join python code - perform a fallback password set operation over libnet
Windows 2000 DCs allow LDAP password set operations only with the help of SSL.
Given the fact that this technique is hard to setup it is easier to use SAMR
over "libnet".
"local" is always False, so simply remove it and the if statement
checking its value.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Feb 6 23:27:48 CET 2012 on sn-devel-104
Ira Cooper [Sat, 4 Feb 2012 00:47:18 +0000 (16:47 -0800)]
s3-popt: Fix configure.developer builds on Solairs.
alloca.h needs to be included, or the build complains the implicit
definition of alloca.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Feb 4 03:27:42 CET 2012 on sn-devel-104
Jeremy Allison [Sat, 4 Feb 2012 00:37:41 +0000 (16:37 -0800)]
Ensure when setting a POSIX ACL, that the uid for a
SMB_ACL_USER_OBJ ACE (the owner ACE entry) has a duplicate
permission entry as an SMB_ACL_USER, and a gid for a
SMB_ACL_GROUP_OBJ ACE (the primary group ACE entry) also has
a duplicate permission entry as an SMB_ACL_GROUP. If not,
then if the ownership or group ownership of this file or
directory gets changed, the user or group can lose their
access.
Matthieu Patou [Sat, 28 Jan 2012 00:12:52 +0000 (16:12 -0800)]
s3-nmbd: don't discard DGRAM frames from local addresses when we are a DC
Winbind use netbios to locate the DC, if samba is also a DC then nmbd
receive request from Winbind that are from a local address, those
requests must not be discarded otherwise winbind can't find the DC and
won't try another method.
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Fri Feb 3 11:09:29 CET 2012 on sn-devel-104
Amitay Isaacs [Fri, 3 Feb 2012 01:04:32 +0000 (12:04 +1100)]
selftest: Fix the exit code of make test when run in buildfarm
When make test is run in buildfarm environment (RUN_FROM_BUILD_FARM=1),
last process in make test pipeline is subunit-filter. This subunit-filter
is responsible for converting failure test result to xfail for known
failures. While converting failures to xfail, it sets exitcode=1. If
this is the last process in the pipeline make test fails, which is
the observed behavior in buildfarm.
In autobuild, there is additional process in the pipeline format-subunit
which processes the output of subunit-filter and correctly terminates
with exit code=0. The buildfarm make test failure is fixed by adding
extra filter-subunit in the pipeline, as the extra filter-subunit
exits correctly with exit code=0.
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Fri Feb 3 07:00:04 CET 2012 on sn-devel-104
Andrew Tridgell [Thu, 2 Feb 2012 01:36:44 +0000 (12:36 +1100)]
build: fixed a link order problem
this fixes a problem found by obnox where the -L path for CUPS was put
before the path to internal libraries. The install path for CUPS
happened to be the same as for a old system libtevent, which meant we
linked against the old tevent instead of the correct one from our
private library paths.
The problem was that we were adding the -L paths directly to the
ldflags. The waf core code (in ccroot.py) only adds more paths if they
are not there already. So by adding it in ldflags it was not added at
the end of the list. The fix is just to not do the -L processing in
wafsamba and let the waf core do it in the right order
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Feb 2 06:54:42 CET 2012 on sn-devel-104
Rusty Russell [Thu, 2 Feb 2012 01:06:49 +0000 (11:36 +1030)]
tdb2: add --disable-tdb2
I thought you could --disable-tdb2=false, apparently not! Thanks
Michael Adam...
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Thu Feb 2 03:43:08 CET 2012 on sn-devel-104
Christof Schmitt [Thu, 15 Dec 2011 20:53:48 +0000 (13:53 -0700)]
smbtorture: Do not leak child processes when exiting
When some child processes could not be created, smbtorture would exit
and leave the successfully started child processes running. Add a loop
to kill the existing child processes for this case.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Feb 2 01:35:27 CET 2012 on sn-devel-104
This change has been causing regular segfaults in the build farm since
it was applied. I also think it may be unnecessary as
dreplsrv_refresh_partitions() should already be achieving the same
thing (removing stale replication targets).
I think the segfaults were caused by freeing an in-flight DSA, but I
have been unable to reproduce it outside of the build farm
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Feb 1 07:49:42 CET 2012 on sn-devel-104