Andrew Bartlett [Fri, 25 Feb 2011 09:34:07 +0000 (20:34 +1100)]
heimdal_build omit #line statments to allow valgrind to work again
The lex/yacc files were generated on Fedora 14, and have empty
filenames in #line declarations. I don't know why this is, but it
seems best just to omit the #line statements.
This is what was causing Valgrind on Fedora not to run on Samba
binaries and programs linked to Samba libraries.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 25 11:46:56 CET 2011 on sn-devel-104
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Feb 25 11:01:31 CET 2011 on sn-devel-104
Jonathan Nieder [Sun, 2 Jan 2011 08:40:09 +0000 (02:40 -0600)]
s3-param: Make "rlimit_max below minimum Windows limit" notification less scary
The fix to bug #6837 results in messages from testparm that look
like a misconfiguration even though they aren't:
rlimit_max: rlimit_max (8192) below minimum Windows limit (16384)
Apply a slight change in wording ("increasing rlimit_max to minimum
Windows limit") to make it clearer that the user has done nothing
wrong. (Similarly for sysctl_max.)
Reported-by: Miguel Medalha <miguelmedalha@sapo.pt> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 25 03:56:40 CET 2011 on sn-devel-104
Jeremy Allison [Fri, 25 Feb 2011 00:04:09 +0000 (16:04 -0800)]
Ensure we don't return an incorrect access mask.
From the Microsoft test suite @ Connectathon:
Test Case: TestSuite_ScenarioNo009GrantedAccessTestS0
File created with access = 0x7 (Read, Write, Delete)
Query Info on file returns 0x87 (Read, Write, Delete, Read Attributes)
s4:dynconfig: fix segfault in the set_dyn_*() functions
We should not try to call free on a const string (the default one).
Now we make sure that the dyn_* variable is never NULL
and only allocated if it's not the default value.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Feb 24 12:29:56 CET 2011 on sn-devel-104
Christian Ambach [Tue, 22 Feb 2011 14:45:44 +0000 (15:45 +0100)]
s3:libsmb only log a dead connection if it was not closed
in case the cli was closed before (e.g. via a dropped ip message)
it can be expected that the read here returns with an error and so
we should not log that a connection is dead when it was closed before
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 23 16:51:03 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 23 Feb 2011 14:26:38 +0000 (15:26 +0100)]
s3: Fix 64-bit errors
Casting those variables will lead to sscanf believing that it sees pointers to
unsigned longs. These might be 64 bit long, thus sscanf will overwrite memory
it should not overwrite. Assigning the vars later is okay, there we get
automatic type conversion. C can be nasty ...
as the autorid module relies on a stable minimum uid/gid value
and rangesize, it now saves the values used at first successful start
and refuses to work if these values get changed in smb.conf later.
Changing the values after the first mapping was done will result
in unpredictable behaviour.
Another check covers the maximum uid value. If this gets decreased
later and domain range mappings already exist that would result
in uid values higher than the new uid value, initialization will
be aborted
Jeremy Allison [Wed, 23 Feb 2011 00:38:42 +0000 (16:38 -0800)]
Fix bug found against the new Mac client @ Connectathon. Mac clients
don't open with FILE_WRITE_ATTRIBUTES when just doing a write, so updating
the write time on close fails as smb_set_file_time() now (correctly) checks
for FILE_WRITE_ATTRIBUTES in the access_mask before allowing client time
update. This is an internal time update being done on a close, not a handle-based
client request.
Andrew Tridgell [Tue, 22 Feb 2011 03:10:38 +0000 (14:10 +1100)]
build: created samba-util-common library
this library will contain files that can be built in common between s3
and s4. Both samba-util and samba-util3 depend on it.
Currently this library needs to be marked as allow_undefined_symbols,
in order to allow s4 to build it. We can remove that flag once we have
all the needed symbols in common
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
s4:torture/rpc/netlogon.c - fix two build warnings by casts
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Feb 22 11:45:49 CET 2011 on sn-devel-104
Andrew Bartlett [Tue, 22 Feb 2011 02:37:06 +0000 (13:37 +1100)]
selftest the raw.mux test is flaky:
TESTING MULTIPLEXED LOCK/LOCK/UNLOCK
establishing a lock
the second lock will conflict with the first
this will too, but we'll unlock while waiting
unlock the first range
recv the async reply
async lock took 265.40 msec
failed to trigger early lock retry
UNEXPECTED(error): samba3.posix_s3.raw.mux.mux
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Feb 22 07:09:07 CET 2011 on sn-devel-104
These variables, of type struct auth_serversupplied_info were poorly
named when added into 2001, and in good consistant practice, this has
extended all over the codebase in the years since.
The structure is also not ideal for it's current purpose. Originally
intended to convey the results of the authentication modules, it
really describes all the essential attributes of a session. This
rename will reduce the volume of a future patch to replaced these with
a struct auth_session_info, with auth_serversupplied_info confined to
the lower levels of the auth subsystem, and then eliminated.
(The new structure will be the output of create_local_token(), and the
change in struct definition will ensure that this is always run, populating
local groups and privileges).
Andrew Bartlett
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Tridgell [Mon, 21 Feb 2011 23:47:27 +0000 (10:47 +1100)]
build: enhanced the symbolcheck code
we can now work out why a binary needs a library, and we can find all
the duplicate symbols (we currently have 1087 symbols defined in more
than one place in Samba).
projects / thirdparty / samba.git / log
