]>
git.ipfire.org Git - thirdparty/asterisk.git/log
Matthew Nicholson [Mon, 9 May 2011 14:09:38 +0000 (14:09 +0000)]
Make indicate/control frames WRITE events on framehooks. Also, if a framehook
returns a non-control frame, don't forward it to the channel.
(closes issue #19251)
Reported by: irroot
Patches:
(modified) framehook_indicate.patch2 uploaded by irroot (license 52)
Tested by: irroot
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318142
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sat, 7 May 2011 23:35:37 +0000 (23:35 +0000)]
res_config_curl: fix a crash with static realtime.
(closes issue #18413)
Reported by: jmls
Patches:
20101202__issue18413.diff.txt uploaded by tilghman (license 14)
Tested by: jmls
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318057
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sat, 7 May 2011 23:24:18 +0000 (23:24 +0000)]
chan_iax2: Don't overwrite port found with an SRV lookup.
(closes issue #17291)
Reported by: jcovert
Patches:
chan_iax2.c.1.8.3-srvlookup-corrected.patch uploaded by jcovert (license 551)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@318055
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 21:49:01 +0000 (21:49 +0000)]
Use the right variable to print the time in a debug message.
The original patch also increased some buffer sizes, but that was already
done in this version.
(closes issue #17034)
Reported by: sysreq
Patches:
asterisk-issue-17034.patch uploaded by sysreq (license 1009)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317969
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 21:38:54 +0000 (21:38 +0000)]
Fix some more "set but unused" compiler warnings.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317967
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Fri, 6 May 2011 21:06:55 +0000 (21:06 +0000)]
Fixes missing colon from To/From headers in RTCP manager events.
(closes issue #18221)
Reported by: clegall_proformatique
Patches:
18221_1.patch uploaded by ebroad (license 878)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317918
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 21:06:33 +0000 (21:06 +0000)]
Fix calculation of free RAM to make minmemfree option work.
(closes issue #17124)
Reported by: loic
Patches:
pbx_c.diff uploaded by loic (license 1020)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317917
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 20:01:16 +0000 (20:01 +0000)]
chan_sip: Destroy variables on a sip_pvt before copying vars from the sip_peer.
Don't duplicate variables on the sip_pvt. Just reset the variable list each
time.
(closes issue #19202)
Reported by: wdoekes
Patches:
issue19202_destroy_challenged_invite_chanvars.patch uploaded by wdoekes (license 717)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317867
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 19:46:49 +0000 (19:46 +0000)]
chan_sip: fix a deadlock in check_rtp_timeout.
Don't block doing silly deadlock avoidance. Just return and try again later.
The funciton gets called often enough that it's fine. Also, this change was
already made in trunk.
(closes issue #18791)
Reported by: irroot
Patches:
chan_sip.rtptimeout.patch uploaded by irroot (license 52)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317865
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 19:35:00 +0000 (19:35 +0000)]
URI encode less characters in the RPID and Contact headers.
If this change causes any problems, we will need to backport the more extensive
uri encoding and decoding handling changes that are in trunk/1.10.
(closes issue #18686)
Reported by: wolfgang
Patches:
quick-and-dirty.patch uploaded by wdoekes (license 717)
Tested by: wdoekes, devellow, wolfgang, mav3rick
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317861
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Fri, 6 May 2011 19:31:50 +0000 (19:31 +0000)]
pbx_lua autoservice fixes
Don't start an autoservice in pbx_lua if pbx_lua already started one and don't
stop one if we didn't start one. Also start and stop the autoservice when
transferring control from and to the pbx.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317858
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 19:24:11 +0000 (19:24 +0000)]
Fix a crash in the MySQL() application.
This code was not handling channel datastores safely. The channel
must be locked.
(closes issue #17964)
Reported by: wuwu
Patches:
issue17964_addon_1.6.2_svn.patch uploaded by seanbright (license 71)
Tested by: wuwu
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317837
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 6 May 2011 19:14:39 +0000 (19:14 +0000)]
Add a new sipfriends.sql for MySQL that has more fields in it.
(closes issue #16399)
Reported by: pabelanger
Patches:
sipfriends.sql.v3 uploaded by pabelanger (license 224)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317805
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 6 May 2011 16:19:18 +0000 (16:19 +0000)]
Fix SIP connected line updates.
This patch fixes a couple SIP connected line update problems:
1) The connected line needs to be updated when the initial INVITE is sent
if there is a peer callerid configured. Previously, the connected line
information did not get reported until the call was connected so SIP could
not report connected line information in ringing or progress messages.
2) The connected line should not be updated on initial connect if there is
no connected line information. Previously, all it did was wipe out any
default preset CONNECTEDLINE information set by the dialplan with empty
strings.
(closes issue #18367)
Reported by: GeorgeKonopacki
Patches:
issue18367_v1.8.patch uploaded by rmudgett (license 664)
Tested by: rmudgett
Review: https://reviewboard.asterisk.org/r/1199/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317670
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 6 May 2011 08:18:53 +0000 (08:18 +0000)]
Merged revisions 317575 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r317575 | twilson | 2011-05-06 01:04:17 -0700 (Fri, 06 May 2011) | 13 lines
Merged revisions 317574 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r317574 | twilson | 2011-05-06 00:55:21 -0700 (Fri, 06 May 2011) | 6 lines
Re-fix queue round-robin
This part of the change for r315596 was incorrect. No bridge occurs
when doing a roundrobin dial and no one answers, so this code shouldn't
have been removed.
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317584
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 23:46:54 +0000 (23:46 +0000)]
If the configure script runs, force a rebuild of menuselect-tree.
Some contents in the menuselect tree are dependent on configure script
parameters, namely --enable-dev-mode.
(closes issue #17219)
Reported by: Nick_Lewis
Patches:
issue_17219.rev1.txt uploaded by russell (license 2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317530
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 23:15:53 +0000 (23:15 +0000)]
Fix some more realtime MySQL schema issues.
(closes issue #18537)
Reported by: denzs
Patches:
sipfriends.sql.svndiff uploaded by denzs (license 1182)
queue_log.sql.svndiff uploaded by denzs (license 1182)
meetme.sql.svndiff uploaded by denzs (license 1182)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317486
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 23:12:35 +0000 (23:12 +0000)]
Fix some errors in sample MySQL realtime schema files.
(closes issue #18915)
Reported by: Dovid
Patches:
sipfriends.patch uploaded by Dovid (license 652)
meetme.patch uploaded by Dovid (license 652)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317484
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 23:00:55 +0000 (23:00 +0000)]
Don't lose cdr_syslog config on a reload.
(closes issue #18679)
Reported by: enegaard
Patches:
issue18679_seanbright.patch uploaded by seanbright (license 71)
Tested by: enegaard
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317480
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 22:53:45 +0000 (22:53 +0000)]
Fix some consistency issues with jitterbuffer config.
Store the defaults noted in the sample config files in the jitterbuffer config
data structure. This makes the CLI commands that output these settings show
the right thing. Also only show the settings that are relevant in the settings
CLI commands, based on which jitterbuffer is selected and whether it's enabled.
(closes issue #19083)
Reported by: rgagnon
Patches:
issue-19083-trunk-r313139.diff uploaded by rgagnon (license 1202)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317478
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 22:47:57 +0000 (22:47 +0000)]
Add a datastore fixup to fix a pbx_lua crash.
(closes issue #19055)
Reported by: jamhed
Patches:
lua_datastore_fixup1.diff uploaded by mnicholson (license 96)
Tested by: mnicholson, jamhed
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317476
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 22:36:33 +0000 (22:36 +0000)]
Fix more "set but unused" warnings.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317474
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 22:11:19 +0000 (22:11 +0000)]
Only display inband DTMF warning if inband DTMF detection is enabled.
(closes issue #18901)
Reported by: irroot
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317429
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 21:58:45 +0000 (21:58 +0000)]
Fix potential memory leak, and use of uninitialized memory.
(closes issue #16476)
Reported by: junky
Patches:
M16476.diff uploaded by junky (license 177)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317427
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 21:53:13 +0000 (21:53 +0000)]
Add missing ActioID handling to Events action.
(closes issue #18949)
Reported by: edersohe
Patches:
0018949 .patch uploaded by edersohe (license 1228)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317425
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 5 May 2011 20:25:52 +0000 (20:25 +0000)]
Don't duplicate our data on the stack and just use the MYSQL_ROW directly.
With large result sets we were blowing out the stack.
(closes issue #19090)
Reported by: mickecarlsson
Patches:
issue19090_trunk_svn.patch uploaded by seanbright (license 71)
Tested by: mickecarlsson
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317370
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 19:55:58 +0000 (19:55 +0000)]
Increase buffer size to be PATH_MAX for a path.
(closes issue #19239)
Reported by: byronclark
Patches:
queue_announce_length.patch uploaded by byronclark (license 1200)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317336
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Thu, 5 May 2011 19:09:13 +0000 (19:09 +0000)]
Resolves a deadlock that occurs during sip_new
This is based on an uncommitted patch by jpeeler for the issue. Instead of
relocking and then unlocking the channel though, we keep the lock on the channel
until we are finished doing what we need to the channel.
(closes issue #18441)
Reported by: Alric
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317283
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 18:39:44 +0000 (18:39 +0000)]
Merged revisions 317255 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r317255 | russell | 2011-05-05 13:29:53 -0500 (Thu, 05 May 2011) | 22 lines
Merged revisions 317211 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r317211 | russell | 2011-05-05 13:20:29 -0500 (Thu, 05 May 2011) | 15 lines
chan_sip: fix broken realtime peer count, fix memory leak
This patch addresses two bugs in chan_sip:
1) The count of realtime peers and users was off. The increment checked the
value of the caching option, while the decrement did not.
2) Add a missing regfree() for a regex.
(closes issue #19108)
Reported by: vrban
Patches:
missing_regfree.patch uploaded by vrban (license 756)
sip_object_counter.patch uploaded by vrban (license 756)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317281
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 5 May 2011 18:37:09 +0000 (18:37 +0000)]
Restore branch-1.6.2-merged and branch-1.6.2-blocked properties.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317280
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Thu, 5 May 2011 18:02:52 +0000 (18:02 +0000)]
Set SO_KEEPALIVE on SIP TCP sockets so that they eventually go away when a peer
abruptly disappears. This mostly occurs after a successful registration.
(closes issue #17544)
Reported by: marcelloceschia
Patches:
(modified) tcptls.patch uploaded by st (license 907)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317196
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Thu, 5 May 2011 15:04:24 +0000 (15:04 +0000)]
Merged revisions 317102 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r317102 | lmadsen | 2011-05-05 10:54:46 -0400 (Thu, 05 May 2011) | 8 lines
Disable console colourization inside safe_asterisk checks.
(closes issue #19213)
Reported by: lefoyer
Patches:
issue19213_strip_color_in_safe_asterisk-svn.patch uploaded by wdoekes (license 717)
Tested by: wdoekes, lefoyer
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317104
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Thu, 5 May 2011 12:27:56 +0000 (12:27 +0000)]
Remove unused directory and clear up some documentation.
(closes issue #19193)
Reported by: bchia
Patches:
cel-csv.diff uploaded by lathama (license 1028)
Tested by: lathama, Marquis42
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317058
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 5 May 2011 02:30:45 +0000 (02:30 +0000)]
Use the correct HTTP method when generating our digest, otherwise we always fail.
When calculating the 'A2' portion of our digest for verification, we need the
HTTP method that is currently in use. Unfortunately our mapping function was
incorrect, resulting in invalid hashes being generated and, in turn, failures
in authentication.
(closes issue #18598)
Reported by: ksn
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316919
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 5 May 2011 02:25:20 +0000 (02:25 +0000)]
Look at the correct buffer for our digest info instead of an empty one.
(issue #18598)
Reported by: ksn
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316918
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 5 May 2011 02:23:28 +0000 (02:23 +0000)]
Make sure that tcptls_session is properly initialized.
(issue #18598)
Reported by: ksn
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316917
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Alexandr Anikin [Wed, 4 May 2011 20:50:18 +0000 (20:50 +0000)]
Fix trivial bug in ooSocket.c codes
Revert condition for result code of
ast_gethostbyname
(closes issue #19185)
Reported by: dswartz
Patches:
issue19185-patch uploaded by may213 (license 454)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316874
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 4 May 2011 18:51:40 +0000 (18:51 +0000)]
Wait for leader with Music On Hold allows crosstalk between participants.
Parenthesis in the wrong position. Regression from issue #14365 when
expanding conference flags to use 64 bits.
(closes issue #18418)
Reported by: MrHanMan
Tested by: rmudgett
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316831
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Wed, 4 May 2011 16:15:32 +0000 (16:15 +0000)]
Merged revisions 316708 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r316708 | seanbright | 2011-05-04 12:10:59 -0400 (Wed, 04 May 2011) | 15 lines
Merged revisions 316707 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r316707 | seanbright | 2011-05-04 12:08:50 -0400 (Wed, 04 May 2011) | 8 lines
If sox fails when processing a voicemail, don't delete the original file.
(closes issue #18111)
Reported by: sysreq
Patches:
issue18111_trunk.patch uploaded by seanbright (license 71)
Tested by: seanbright
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316709
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Wed, 4 May 2011 14:35:05 +0000 (14:35 +0000)]
Only return a single error via AMI when requesting a forbidden action.
(closes issue #19216)
Reported by: oej
Patches:
issue19216-1.8-r316204.patch uploaded by seanbright (license 71)
Tested by: seanbright
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316663
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Wed, 4 May 2011 14:25:03 +0000 (14:25 +0000)]
Merged revisions 316644 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r316644 | dvossel | 2011-05-04 09:23:39 -0500 (Wed, 04 May 2011) | 9 lines
Fixes one-way-audio when chanspy activated with the 'o' option
(closes issue #18382)
Reported by: jkister
Patches:
0001-Bugfix-18382-one-way-audio-when-chanspy-activated.patch.txt uploaded by malin (license )
Tested by: firstsip, Greenlightcrm, malin, wdoekes, boroda, dvossel
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316650
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Wed, 4 May 2011 13:44:41 +0000 (13:44 +0000)]
Merged revisions 316616 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r316616 | dvossel | 2011-05-04 08:40:41 -0500 (Wed, 04 May 2011) | 12 lines
Fixes session-timers=refuse not being enforced for *caller*
During handle_request_invite, the session timer mode was retrieved from
a cached variable. This patch forces a peer lookup of the session timer
mode in the case of an incoming invite.
(closes issue #18804)
Reported by: wdoekes
Patches:
issue18804_session_timer_refuse_caller.patch uploaded by wdoekes (license 717)
issue_18804_v2.diff uploaded by dvossel (license 671)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316617
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Wed, 4 May 2011 02:34:01 +0000 (02:34 +0000)]
Merged revisions 316475 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r316475 | seanbright | 2011-05-03 22:23:01 -0400 (Tue, 03 May 2011) | 10 lines
Honor the C option to MeetMe when L is passed.
This fixes a case that r304773 and friends missed.
(closes issue #17317)
Reported by: var
Patches:
meetme-continue-on-l_16218.diff uploaded by var (license 1227)
Tested by: seanbright
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316476
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 4 May 2011 00:12:25 +0000 (00:12 +0000)]
Escape column names in case they contain illegal characters ('-') or reserved words.
(closes issue #19063)
Reported by: festr
Patches:
patch uploaded by festr (license 443)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316429
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 3 May 2011 22:13:31 +0000 (22:13 +0000)]
Use htons() instead of ntohs() in some places.
(closes issue #19200)
Reported by: wdoekes
Patches:
issue19200-trunk.patch uploaded by wdoekes (license 717)
issue19200-1.8.x.patch uploaded by wdoekes (license 717)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316336
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 3 May 2011 22:05:59 +0000 (22:05 +0000)]
Fixes framehook segfault on indicate
(closes issue #19215)
Reported by: irroot
Patches:
framehook_indicate.patch uploaded by irroot (license 52)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316334
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 3 May 2011 21:41:11 +0000 (21:41 +0000)]
Resolve another warning.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316331
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 3 May 2011 21:37:59 +0000 (21:37 +0000)]
Merged revisions 316329 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r316329 | dvossel | 2011-05-03 16:29:55 -0500 (Tue, 03 May 2011) | 17 lines
Merged revisions 316328 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r316328 | dvossel | 2011-05-03 16:27:59 -0500 (Tue, 03 May 2011) | 10 lines
Fixes chan_local crashs in local_fixup()
Thanks OEJ for tracking down the issue and submitting the patch.
(closes issue #19053)
Reported by: oej
Tested by: oej
Review: https://reviewboard.asterisk.org/r/1158/
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316330
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 3 May 2011 19:55:49 +0000 (19:55 +0000)]
Fix a bunch of compiler warnings generated by gcc 4.6.0.
Most of these are -Wunused-but-set-variable, but there were a few others
mixed in here, as well.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316265
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 3 May 2011 19:18:30 +0000 (19:18 +0000)]
The dahdi_hangup() call does not clean up the channel fully.
After dahdi_hangup() has supposedly hungup an ISDN channel there is still
traffic on the S0-bus because the channel was not cleaned up fully.
Shuffled the hangup code to include some missing cleanup. Also fixed some
code formatting in the area. I think the primary missing clean up code
was the call to tone_zone_play_tone() to turn off any active tones on the
channel.
(closes issue #19188)
Reported by: jg1234
Patches:
issue19188_v1.8.patch uploaded by rmudgett (license 664)
Tested by: jg1234
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316224
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 3 May 2011 18:59:06 +0000 (18:59 +0000)]
Never put the Require: timer header in an Invite.
This has already been discussed and should have been resolved earlier. View
revsion 285565's log for more information about why it is important to not
put timer in the Require header.
(closes issue #18704)
Reported by: mfrager
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316217
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 3 May 2011 18:49:48 +0000 (18:49 +0000)]
Fixes a random crash (NULL reference) in res_odbc.c.
(closes issue #19180)
Reported by: pruiz
Patches:
tmp.diff uploaded by pruiz (license 1152)
Tested by: pruiz, seanbright
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316215
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Tue, 3 May 2011 18:17:36 +0000 (18:17 +0000)]
If we aren't interested in events, don't generate the FullyBooted event on AMI login.
(closes issue #19089)
Reported by: bklang
Patches:
issue19089-1.8-r316204.patch uploaded by seanbright (license 71)
Tested by: seanbright
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316206
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tzafrir Cohen [Tue, 3 May 2011 10:57:16 +0000 (10:57 +0000)]
Re-fix bashism in ./configure: s/let/$(( ))/
A forward-port in r278985 accidentally re-introduced issue 17485. Fixing
it. Thanks to Jilles Tjoelker for the good report.
(closes issue #17485)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316193
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 2 May 2011 19:09:55 +0000 (19:09 +0000)]
Merged revisions 316093 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r316093 | tilghman | 2011-05-02 14:04:36 -0500 (Mon, 02 May 2011) | 8 lines
More possible crashes based upon invalid inputs.
(closes issue #18161)
Reported by: wdoekes
Patches:
20110301__issue18161.diff.txt uploaded by tilghman (license 14)
Tested by: wdoekes
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@316094
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Wed, 27 Apr 2011 19:14:27 +0000 (19:14 +0000)]
Merged revisions 315893 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315893 | mnicholson | 2011-04-27 14:03:05 -0500 (Wed, 27 Apr 2011) | 21 lines
Merged revisions 315891 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315891 | mnicholson | 2011-04-27 13:57:56 -0500 (Wed, 27 Apr 2011) | 14 lines
Fix our compliance with RFC 3261 section 18.2.2.
This change optimizes the free_via() function and removes some redundant null
checking. It also fixes compliance with RFC 3261 section 18.2.2 by always using
the port specified in the Via header for routing responses (even when maddr is
not set). Also the htons() function is now used when setting the port.
Additional documentation comments have been added in various places to make the
logic in the code clearer.
(closes issue #18951)
Reported by: jmls
Patches:
issue18951_set_proper_port_from_via.patch uploaded by wdoekes (license 717) (modified)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315894
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 27 Apr 2011 15:55:48 +0000 (15:55 +0000)]
Set the copyright year to 2011 in the startup message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315810
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Wed, 27 Apr 2011 12:36:17 +0000 (12:36 +0000)]
Enable Russian core sound selection in menuselect.
(closes issue #18724)
Reported by: pbxware
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315765
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Tue, 26 Apr 2011 22:56:19 +0000 (22:56 +0000)]
Merged revisions 315672 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315672 | twilson | 2011-04-26 15:52:25 -0700 (Tue, 26 Apr 2011) | 18 lines
Merged revisions 315671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315671 | twilson | 2011-04-26 15:47:56 -0700 (Tue, 26 Apr 2011) | 11 lines
Make sure unregistering a peer unlinks it from the peer container
Instead of mostly copying the code from expire_register, just use the function
that "does the right thing".
(closes issue #16033)
Reported by: kkm
Patches:
016033-tilgman-fixed-refcount.diff uploaded by kkm (license 888)
Tested by: kkm, tilghman, twilson
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315673
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 26 Apr 2011 22:14:31 +0000 (22:14 +0000)]
The 'e' special extension fails to trigger in at least two cases.
The 'e' extension is a fall back for the 'i', 't', or 'T' extensions if
any of them do not exist. Many of the places the 'e' extension was
supposed to be invoked fail because the priority was set wrong. There
were two places where the 'e' extension was not even checked for fall
back.
* Made invoke the 'e' extension similarly to the previous 'i', 't', or 'T'
extension check and added the 'e' extension as a fall back to the two
missing locations.
* Prioritized and optimized some hangup tests associated with the 'e'
extension.
(closes issue #19136)
Reported by: kshumard
Tested by: rmudgett
Review: https://reviewboard.asterisk.org/r/1196/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315645
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Tue, 26 Apr 2011 21:39:01 +0000 (21:39 +0000)]
Merged revisions 315643 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315643 | twilson | 2011-04-26 14:27:44 -0700 (Tue, 26 Apr 2011) | 25 lines
Merged revisions 315596 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315596 | twilson | 2011-04-26 14:16:10 -0700 (Tue, 26 Apr 2011) | 18 lines
Allow transfer loops without allowing forwarding loops
We try to avoid the situation where two phones may be forwarded to each other
causing an infinite loop by storing each dialed interface in a channel
datastore and checking the list before dialing out. This works, but currently
breaks situations like A calls B, A transfers B to C, B transfers C to A, and A
transfers C to B. Since human interaction is happening here and not an
automated forwarding loop, it should be allowed.
This patch removes the dialed_interfaces datastore when a call is bridged (a
suggestion from the brilliant mmichelson). If a call is being bridged, it
should be safe to assume that we aren't stuck in a loop.
Since we are now handling this is the bridge code, the previous attempts at
handling it in app_dial and app_queue are removed.
Review: https://reviewboard.asterisk.org/r/1195/
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315644
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 26 Apr 2011 19:32:50 +0000 (19:32 +0000)]
Merged revisions 315502 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315502 | tilghman | 2011-04-26 14:22:52 -0500 (Tue, 26 Apr 2011) | 21 lines
Merged revisions 315501 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315501 | tilghman | 2011-04-26 14:18:46 -0500 (Tue, 26 Apr 2011) | 14 lines
Fix the bounds-checking code.
The code that set the bit within the select bitfield was correct, but the
bounds-checking code was not. The change to that line uses the new _bitsize
macro for clarity. Also, FD_ZERO macro did not zero-out anything but the
first word of the bitfield, so this could have caused problems with modules
using that macro with the expanded bitfield.
(closes issue #18773)
Reported by: jamicque
Patches:
20110423__issue18773.diff.txt uploaded by tilghman (license 14)
Tested by: chris-mac
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315503
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 26 Apr 2011 18:00:34 +0000 (18:00 +0000)]
Add missing set of name valid flag when dialing.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315452
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 26 Apr 2011 17:40:23 +0000 (17:40 +0000)]
chan_local: resolve a deadlock.
This patch resolves a fairly complex deadlock that can occur with the
combination of chan_local and a dialplan switch, such as dynamic realtime
extensions, which pulls autoservice into the picture when doing a dialplan
lookup.
(closes issue #18818)
Reported by: nic
Patches:
issue18818.patch uploaded by jthurman (license 614)
18818.v1.txt uploaded by russell (license 2)
Tested by: nic, jthurman, kterzi, steve-howes, sysreq, IshMalik
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315446
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Tue, 26 Apr 2011 02:18:50 +0000 (02:18 +0000)]
Merged revisions 315393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r315393 | pabelanger | 2011-04-25 22:17:43 -0400 (Mon, 25 Apr 2011) | 7 lines
Add back CLI command 'dialplan save'
(closes issue #19140)
Reported by: lmadsen
Patches:
__20110419_dialplan_save.patch.txt uploaded by lmadsen (license 10)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315394
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 25 Apr 2011 21:49:00 +0000 (21:49 +0000)]
When using MGCP realtime gateway definitions, random crashes occur.
Fixed incorrect linked list node removal for realtime gateways.
(closes issue #18291)
Reported by: nahuelgreco
Patches:
dangling-pointers-when-pruning.patch uploaded by nahuelgreco (license 162)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315349
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Mon, 25 Apr 2011 19:37:32 +0000 (19:37 +0000)]
Merged revisions 315258 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315258 | russell | 2011-04-25 14:31:44 -0500 (Mon, 25 Apr 2011) | 17 lines
Merged revisions 315257 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315257 | russell | 2011-04-25 14:28:41 -0500 (Mon, 25 Apr 2011) | 10 lines
Be more flexible with unknown chunks in wav files.
This patch makes format_wav ignore unknown chunks instead of erroring
out on them.
(closes issue #18306)
Reported by: jhirsch
Patches:
wav_skip_unknown_blocks.diff uploaded by jhirsch (license 1156)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315259
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Mon, 25 Apr 2011 19:04:28 +0000 (19:04 +0000)]
Merged revisions 315212 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r315212 | russell | 2011-04-25 14:00:24 -0500 (Mon, 25 Apr 2011) | 7 lines
Don't link non-cached realtime peers into the peers_by_ip container.
(closes issue #18924)
Reported by: wdoekes
Patches:
issue18924_uncached_realtime_peers_leak-1.6.2.17.patch uploaded by wdoekes (license 717)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315213
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Mon, 25 Apr 2011 07:14:32 +0000 (07:14 +0000)]
Merged revisions 315052 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r315052 | alecdavis | 2011-04-25 19:11:12 +1200 (Mon, 25 Apr 2011) | 16 lines
Merged revisions 315051 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r315051 | alecdavis | 2011-04-25 19:06:29 +1200 (Mon, 25 Apr 2011) | 11 lines
chan_local:check_bridge() misplaced misplaced ast_mutex_unlock
if !p->chan->_bridge->_softhangup path isn't followed, brigde remains locked.
(closes issue #19176)
Reported by: alecdavis
Patches:
bug19176.diff.txt uploaded by alecdavis (license 585)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315053
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Fri, 22 Apr 2011 22:59:18 +0000 (22:59 +0000)]
chan_dahdi: Can't return to normal ring after distinctive ring on FXS
clear a previous distinctivering pattern before each new call
(closes issue #18985)
Reported by: bromont
Patches:
bug18985.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis, bromont
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@315001
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Fri, 22 Apr 2011 21:20:08 +0000 (21:20 +0000)]
Merged revisions 314958 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r314958 | mnicholson | 2011-04-22 15:49:45 -0500 (Fri, 22 Apr 2011) | 17 lines
Merged revisions 311203,314908 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r311203 | mnicholson | 2011-03-17 14:14:37 -0500 (Thu, 17 Mar 2011) | 4 lines
Don't hold the pvt lock while streaming a file.
ABE-2756
........
r314908 | mnicholson | 2011-04-22 15:01:48 -0500 (Fri, 22 Apr 2011) | 4 lines
Prevent the login thread and the app threads from using the asterisk channel at the same time.
ABE-2756
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314959
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 22 Apr 2011 14:02:23 +0000 (14:02 +0000)]
Merged revisions 314778 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r314778 | russell | 2011-04-22 08:58:03 -0500 (Fri, 22 Apr 2011) | 11 lines
Initialize buffers in getvar and getvarfull.
Initialize the buffers used to hold the result from GET VARIABLE or
GET VARIABLE FULL. The bug report shows func_read returning garbage in
the result. It assumed that the buffer passed in was initialized, like many
other functions do. In the more common code path (through the dialplan), it
is initialized, so just initialize it here too.
(closes issue #19050)
Reported by: johnz
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314780
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Tzafrir Cohen [Fri, 22 Apr 2011 13:59:43 +0000 (13:59 +0000)]
Fix a few typos (shown by Lintian)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314779
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 22 Apr 2011 13:35:59 +0000 (13:35 +0000)]
Recorded merge of revisions 314776 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r314776 | russell | 2011-04-22 08:35:22 -0500 (Fri, 22 Apr 2011) | 10 lines
Fix handling of some call parking config options.
This patch adjusts the handling of some call parking config options to fix some
issues that have already been addressed in 1.8 and trunk.
(closes issue #19167)
Reported by: bluecrow76
Patches:
asterisk-1.6.2.17.2-fix-build-parkinglot-parked-AST_FEATURE_FLAGS.diff uploaded by bluecrow76 (license 270)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314777
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Thu, 21 Apr 2011 22:38:44 +0000 (22:38 +0000)]
Correct DAHDIShowChannels XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314732
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Thu, 21 Apr 2011 18:24:05 +0000 (18:24 +0000)]
Merged revisions 314620 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r314620 | mnicholson | 2011-04-21 13:22:19 -0500 (Thu, 21 Apr 2011) | 20 lines
Merged revisions 314607 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r314607 | mnicholson | 2011-04-21 13:19:21 -0500 (Thu, 21 Apr 2011) | 14 lines
Added limits to the number of unauthenticated sessions TCP based protocols are allowed to have open simultaneously. Also added timeouts for unauthenticated sessions where it made sense to do so.
Unrelated, the manager interface now properly checks if the user has the "system" privilege before executing shell commands via the Originate action.
AST-2011-005
AST-2011-006
(closes issue #18787)
Reported by: kobaz
(related to issue #18996)
Reported by: tzafrir
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314628
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Thu, 21 Apr 2011 00:23:04 +0000 (00:23 +0000)]
Merged revisions 314549 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r314549 | twilson | 2011-04-20 17:17:34 -0700 (Wed, 20 Apr 2011) | 6 lines
Don't allocate more space than necessary for a sip_pkt
This extra allocation is a hold-over from when pkt->data was a
character array. Now that it is an allocated string, just allocate
enough for the sip_pkt.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314550
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 20 Apr 2011 16:54:02 +0000 (16:54 +0000)]
AST_CONTROL_XXX comment changes.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314417
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 20 Apr 2011 05:25:15 +0000 (05:25 +0000)]
Initialize track pointer
ast_reentrancy_init checks to see if it is NULL before initializing with calloc
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314358
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Tue, 19 Apr 2011 15:42:10 +0000 (15:42 +0000)]
Use SSLv23_client_method instead of old SSLv2 only.
(closes issue #19095)
(closes issue #19138)
Reported by: tzafrir
Patches:
no_ssl2.diff uploaded by tzafrir (license 46)
Tested by: russell, chazzam
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314251
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Tue, 19 Apr 2011 14:28:15 +0000 (14:28 +0000)]
Merged revisions 314205 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r314205 | lmadsen | 2011-04-19 09:27:50 -0500 (Tue, 19 Apr 2011) | 6 lines
Remove duplicate documentation from func_channel.c
(closes issue #18970)
Reported by: IgorG
Patches:
func_channel.c.doc.diff uploaded by IgorG (license 20)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314206
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Tue, 19 Apr 2011 14:24:25 +0000 (14:24 +0000)]
Merged revisions 314202 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r314202 | lmadsen | 2011-04-19 09:23:39 -0500 (Tue, 19 Apr 2011) | 7 lines
Update seconds to milliseconds in ast_verb output.
(closes issue #19084)
Reported by: smurfix
Patches:
app_dial.patch uploaded by smurfix (license 547)
Tested by: lmadsen, smurfix
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314203
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 18 Apr 2011 16:10:10 +0000 (16:10 +0000)]
The AsyncAGI command loop is lax in the value it returns for the return status.
* Return correct status: SUCCESS/FAILED/HANGUP. Previously, abnormal
exits from the command loop such as hangup would return SUCCESS.
* The "asyncagi break" command now returns SUCCESS and is now the only way
to break the command loop with that status. Previously, it returned
FAILED.
* The AMI event AsyncAGI End is no longer sent if the AsyncAGI Start event
is not sent. Previously, this happened because of an error setting up the
AGI pipes.
* All executed AGI commands now get an AsyncAGI Exec result event.
Previously, if the command returned failure (because of hangup), the
command loop just exited with FAILURE and did not send the AsyncAGI Exec
result event.
* Makes sure that the channel frame queue is empty on hangup.
Review: https://reviewboard.asterisk.org/r/1183/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314069
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 18 Apr 2011 16:02:12 +0000 (16:02 +0000)]
Unclear code in app_dial.c.
Make code formatting clear.
(closes issue #19134)
Reported by: oej
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314068
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 18 Apr 2011 15:23:45 +0000 (15:23 +0000)]
Remove the need for deadlock avoidance in chan_sip do_monitor.
Deadlock avoidance between the sip pvt and the pvt->owner is
very difficult. Now that channel's are ao2 objects, this complication
is no longer necessary. It turns out the pvt's msg queue only
exists because of deadlock avoidance (when deadlock avoidance fails
msgs were added to a queue to be processed later), so this goes away as well.
The technique used in the new sip_lock_pvt_full() function should
be used as a template for replacing all locations where deadlock
avoidance occurs between a channel tech_pvt and the pvt's owner.
My hope is that this will begin a reversal of the invalid channel
driver locking architecture we have been using for so long.
This patch also resolves an issue where the pvt->owner gets
unlocked during processing the msg queue.
(closes issue #18690)
Reported by: dvossel
Review: https://reviewboard.asterisk.org/r/1182/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314067
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 18 Apr 2011 13:41:06 +0000 (13:41 +0000)]
sip codec negotiation of dynamic rtp payloads error fix
This patch fixes how chan_sip handles dynamic rtp payload types
it does not understand. At the moment if a dynamic payload's mime
type does not match one we understand, the payload does not get
removed from our payload table. As a result of this, the payload
is set to whatever dynamic codec we use internally for that payload
number on outgoing INVITES. This is incorrect.
This patch fixes this by properly checking the rtpmap set function's
return code to make sure it was found. The function can return both
-1 and -2 depending on the source of the mismatch. We were just
checking -1 explicitly.
Review: https://reviewboard.asterisk.org/r/1169/
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@314017
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Fri, 15 Apr 2011 15:08:05 +0000 (15:08 +0000)]
Merged revisions 313859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r313859 | jrose | 2011-04-15 09:58:37 -0500 (Fri, 15 Apr 2011) | 10 lines
Fix a Tab Completion bug that occurs due to multiple matches on a substring.
Makes word_match function in cli.c repeat a search for a command string until
a proper match is found or the string is searched to the last point.
(closes issue #17494)
Reported by: ffossard
Review: https://reviewboard.asterisk.org/r/1180/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313860
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Thu, 14 Apr 2011 20:59:56 +0000 (20:59 +0000)]
Leftover debug messages unconditionally sent to the console.
Executing Dial(DAHDI/1/
18475551212 ,300,) with the echotraining config
option enabled outputs the following debug messages unconditionally:
Dialing T1847555121 on 1
Dialing www2w on 1
* Made debug messages in my_dial_digits() normal debug messages that do
not get output unless enabled.
* Reworded some debug messages in my_dial_digits() to be clearer.
* Replace strncpy() with ast_copy_string() in my_dial_digits() which does
the same job better.
(closes issue #18847)
Reported by: vmikhelson
Tested by: rmudgett
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313780
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 13 Apr 2011 22:52:47 +0000 (22:52 +0000)]
Revert flushing stale AsyncAGI commands from -r313615.
It looks like it was intentional to leave any commands or in-flight
commands in the queue in case Async AGI is run again on the call.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313700
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 13 Apr 2011 17:47:43 +0000 (17:47 +0000)]
Miscellaneous AGI diagnostic message cleanup and code optimization.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313658
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 13 Apr 2011 17:18:49 +0000 (17:18 +0000)]
* Add missing channel lock to handle_cli_agi_add_cmd().
* Flush any Async AGI commands left over from earlier Async AGI control of
the call.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313615
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 13 Apr 2011 16:31:50 +0000 (16:31 +0000)]
Merged revisions 313579 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r313579 | rmudgett | 2011-04-13 11:29:49 -0500 (Wed, 13 Apr 2011) | 48 lines
Merged revisions 313545 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r313545 | rmudgett | 2011-04-13 11:21:24 -0500 (Wed, 13 Apr 2011) | 41 lines
Asterisk does not hangup a channel after endpoint hangs up.
If the call that the dialplan started an AGI script for is hungup while
the AGI script is in the middle of a command then the AGI script is not
notified of the hangup. There are many AGI Exec commands that this can
happen with. The reported applications have been: Background, Wait, Read,
and Dial. Also the AGI Get Data command.
* Don't wait on the Asterisk channel after it has hung up. The channel is
likely to never need servicing again.
* Restored the AGI script's ability to return the AGI_RESULT_HANGUP value
in run_agi(). It previously only could return AGI_RESULT_SUCCESS or
AGI_RESULT_FAILURE after the DeadAGI and AGI applications were merged.
(closes issue #17954)
Reported by: mn3250
Patches:
issue17954_v1.8.patch uploaded by rmudgett (license 664)
issue17954_v1.6.2.patch uploaded by rmudgett (license 664)
issue17954_v1.4.patch uploaded by rmudgett (license 664)
Tested by: rmudgett
JIRA SWP-2171
(closes issue #18492)
Reported by: devmod
Tested by: rmudgett
JIRA SWP-2761
(closes issue #18935)
Reported by: nvitaly
Tested by: astmiv, rmudgett
JIRA SWP-3216
(closes issue #17393)
Reported by: siby
Tested by: rmudgett
JIRA SWP-2727
Review: https://reviewboard.asterisk.org/r/1165/
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313588
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 12 Apr 2011 22:35:53 +0000 (22:35 +0000)]
Bring the dumpchan application inline with "core show channel".
* Added fields that are in "core show channel" to dumpchan output.
* Fixed reuse of formatbuf before the previous string stored there was
used by snprintf. All output strings now have their own buffer.
* Adjusted the buffer sizes to not be so abusive of the stack now that
there are more buffers.
Change requested by oej.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313517
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Tue, 12 Apr 2011 18:47:05 +0000 (18:47 +0000)]
fixing stupid mistake with putting code before variable declaration
........
Merged revisions 313435 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r313432 | jrose | 2011-04-12 13:12:29 -0500 (Tue, 12 Apr 2011) | 14 lines
reload Chan_dahdi memory leak caused by variables
chan_dahdi reloading with variables set via setvar in chan_dahdi.conf would
stay in the dahdi_pvt structs for individual channels (causing them to just
continue adding the new ones to the list) and also there was a memory leak
causes by the conf objects. This patch resolves both of these by using
ast_variables_destroy during the loading process.
(closes issue #17450)
Reported by: nahuelgreco
Patches:
patch.diff uploaded by jrose (license 1225)
Tested by: tilghman, jrose
Review: https://reviewboard.asterisk.org/r/1170/
........
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313436
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Tue, 12 Apr 2011 18:25:48 +0000 (18:25 +0000)]
Merged revisions 313432 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r313432 | jrose | 2011-04-12 13:12:29 -0500 (Tue, 12 Apr 2011) | 14 lines
reload Chan_dahdi memory leak caused by variables
chan_dahdi reloading with variables set via setvar in chan_dahdi.conf would
stay in the dahdi_pvt structs for individual channels (causing them to just
continue adding the new ones to the list) and also there was a memory leak
causes by the conf objects. This patch resolves both of these by using
ast_variables_destroy during the loading process.
(closes issue #17450)
Reported by: nahuelgreco
Patches:
patch.diff uploaded by jrose (license 1225)
Tested by: tilghman, jrose
Review: https://reviewboard.asterisk.org/r/1170/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313434
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 11 Apr 2011 23:08:02 +0000 (23:08 +0000)]
Frames from the inbound channel should go to all outbound channels in app_dial.c.
In app_dial.c:wait_for_answer() frames from the inbound channel should be
sent to all outbound channels instead of only if there is just one
outbound channel.
Control frames like AST_CONTROL_CONNECTED_LINE need to be passed to all of
the the outbound channels. This can happen if a blond transfer is done by
a remote switch on the inbound channel.
JIRA AST-443
JIRA SWP-2730
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313369
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 11 Apr 2011 23:03:02 +0000 (23:03 +0000)]
Backport a restructuring change from trunk to make the next change stand out.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313368
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 11 Apr 2011 22:27:25 +0000 (22:27 +0000)]
Added "Connected Line ID" and "Connected Line ID Name" to "core show channel" output.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313366
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Mon, 11 Apr 2011 19:36:40 +0000 (19:36 +0000)]
Merged revisions 313278 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r313278 | lmadsen | 2011-04-11 14:33:03 -0500 (Mon, 11 Apr 2011) | 14 lines
Merged revisions 313277 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r313277 | lmadsen | 2011-04-11 14:30:20 -0500 (Mon, 11 Apr 2011) | 6 lines
Fix detection of OpenSSL 1.0
(closes issue #19093)
Reported by: tzafrir
Patches:
detect_openssl_10.diff uploaded by tzafrir (license 46)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313279
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 11 Apr 2011 15:40:30 +0000 (15:40 +0000)]
Merged revisions 313189 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r313189 | rmudgett | 2011-04-11 10:32:53 -0500 (Mon, 11 Apr 2011) | 32 lines
Merged revisions 313188 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r313188 | rmudgett | 2011-04-11 10:27:52 -0500 (Mon, 11 Apr 2011) | 25 lines
Stuck channel using FEATD_MF if caller hangs up at the right time.
The cause was actually a caller hanging up just at the end of the Feature
Group D DTMF tones that setup the call. The reason for this is a "guard
timer" that's implemented using ast_safe_sleep(100). If the caller
happens to hang up AFTER the final tone of the DTMF string but BEFORE the
end of that ast_safe_sleep(), then ast_safe_sleep() will return non-zero.
This causes the code to bounce to the end of ss_thread(), but it does NOT
tear down the call properly.
This should be a rare occurrence because the caller has to hang up at
EXACTLY the right time. Nonetheless, it was happening quite regularly on
the reporter's system. It's not easily reproducible, unless you purposely
increase the guard-time to 2000 or more. Once you do that, you can
reproduce it every time by watching the DTMF debug and hanging up just as
it ends.
Simply add an ast_hangup() before goto quit.
(closes issue #15671)
Reported by: jcromes
Patches:
issue15671.patch uploaded by pabelanger (license 224)
Tested by: jcromes
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@313190
65c4cc65 -6c06-0410-ace0-
fbb531ad65f3