]> git.ipfire.org Git - thirdparty/curl.git/log
thirdparty/curl.git
5 years agocopyright: fix year ranges
Daniel Stenberg [Thu, 5 Nov 2020 07:22:10 +0000 (08:22 +0100)] 
copyright: fix year ranges

Follow-up from 4d2f8006777

5 years agoHISTORY: the new domain
Daniel Stenberg [Wed, 4 Nov 2020 13:03:01 +0000 (14:03 +0100)] 
HISTORY: the new domain

5 years agocurl.se: new home
Daniel Stenberg [Wed, 4 Nov 2020 13:02:01 +0000 (14:02 +0100)] 
curl.se: new home

Closes #6172

5 years agoKNOWN_BUGS: FTPS with Schannel times out file list operation
Daniel Stenberg [Wed, 4 Nov 2020 22:56:12 +0000 (23:56 +0100)] 
KNOWN_BUGS: FTPS with Schannel times out file list operation

Reported-by: bobmitchell1956 on github
Closes #5284

5 years agoKNOWN_BUGS: SMB tests fail with Python 2
Daniel Stenberg [Wed, 4 Nov 2020 22:48:56 +0000 (23:48 +0100)] 
KNOWN_BUGS: SMB tests fail with Python 2

Reported-by: Jay Satiro
Closes #5983

5 years agoKNOWN_BUGS: LDAPS with NSS is slow
Daniel Stenberg [Wed, 4 Nov 2020 22:43:43 +0000 (23:43 +0100)] 
KNOWN_BUGS: LDAPS with NSS is slow

Reported-by: nosajsnikta on github
Closes #5874

5 years agotravis: use ninja-build for CMake builds
Sergei Nikulov [Wed, 14 Oct 2020 10:19:35 +0000 (13:19 +0300)] 
travis: use ninja-build for CMake builds

Added package ninja-build to environment
Use ninja to speed up CMake builds

Closes #6077

5 years agortsp: error out on empty Session ID, unified the code
Harry Sintonen [Tue, 3 Nov 2020 14:55:58 +0000 (16:55 +0200)] 
rtsp: error out on empty Session ID, unified the code

5 years agortsp: fixed the RTST Session ID mismatch in test 570
Harry Sintonen [Tue, 3 Nov 2020 10:29:40 +0000 (12:29 +0200)] 
rtsp: fixed the RTST Session ID mismatch in test 570

Closes #6161

5 years agortsp: fixed Session ID comparison to refuse prefix
Harry Sintonen [Tue, 3 Nov 2020 01:36:56 +0000 (03:36 +0200)] 
rtsp: fixed Session ID comparison to refuse prefix

Closes #6161

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Tue, 3 Nov 2020 15:46:04 +0000 (16:46 +0100)] 
RELEASE-NOTES: synced

(forgot to update the list of contributors)

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Tue, 3 Nov 2020 15:41:59 +0000 (16:41 +0100)] 
RELEASE-NOTES: synced

5 years agocurlver: bumped to 7.74.0
Daniel Stenberg [Tue, 3 Nov 2020 07:22:54 +0000 (08:22 +0100)] 
curlver: bumped to 7.74.0

5 years agohsts: add read/write callbacks
Daniel Stenberg [Mon, 2 Nov 2020 22:17:01 +0000 (23:17 +0100)] 
hsts: add read/write callbacks

- read/write callback options
- man pages for the 4 new setopts
- test 1915 verifies the callbacks

Closes #5896

5 years agohsts: add support for Strict-Transport-Security
Daniel Stenberg [Mon, 2 Nov 2020 22:17:01 +0000 (23:17 +0100)] 
hsts: add support for Strict-Transport-Security

- enable in the build (configure)
- header parsing
- host name lookup
- unit tests for the above
- CI build
- CURL_VERSION_HSTS bit
- curl_version_info support
- curl -V output
- curl-config --features
- CURLOPT_HSTS_CTRL
- man page for CURLOPT_HSTS_CTRL
- curl --hsts (sets CURLOPT_HSTS_CTRL and works with --libcurl)
- man page for --hsts
- save cache to disk
- load cache from disk
- CURLOPT_HSTS
- man page for CURLOPT_HSTS
- added docs/HSTS.md
- fixed --version docs
- adjusted curl_easy_duphandle

Closes #5896

5 years agoCI/tests: enable test target on TravisCI for CMake builds
Sergei Nikulov [Wed, 14 Oct 2020 07:00:00 +0000 (10:00 +0300)] 
CI/tests: enable test target on TravisCI for CMake builds

Added test-nonflaky target to CMake builds

Disabled test 1139 because the cmake build doesn't create docs/curl.1

Closes #6074

5 years agotool_debug_cb: do not assume zero-terminated data
Daniel Stenberg [Tue, 3 Nov 2020 07:14:46 +0000 (08:14 +0100)] 
tool_debug_cb: do not assume zero-terminated data

Follow-up to d70a5b5a0f5e3

5 years agosendf: move the verbose-check into Curl_debug
Daniel Stenberg [Mon, 2 Nov 2020 16:34:04 +0000 (17:34 +0100)] 
sendf: move the verbose-check into Curl_debug

Saves us from having the same check done everywhere.

Closes #6159

5 years agotravis: use valgrind when running tests for debug builds
Daniel Stenberg [Sun, 1 Nov 2020 22:26:04 +0000 (23:26 +0100)] 
travis: use valgrind when running tests for debug builds

Except the non-x86 and sanitizer builds

Closes #6154

5 years agoheader.d: fix syntax mistake
Daniel Stenberg [Mon, 2 Nov 2020 09:31:02 +0000 (10:31 +0100)] 
header.d: fix syntax mistake

follow-up from 1144886f38fd0

5 years agognutls: fix memory leaks (certfields memory wasn't released)
Harry Sintonen [Sun, 1 Nov 2020 21:32:15 +0000 (23:32 +0200)] 
gnutls: fix memory leaks (certfields memory wasn't released)

Closes #6153

5 years agotests: add missing global_init/cleanup calls
Daniel Stenberg [Mon, 2 Nov 2020 07:26:40 +0000 (08:26 +0100)] 
tests: add missing global_init/cleanup calls

Without the cleanup call in these test files, the mbedTLS backend leaks
memory.

Closes #6156

5 years agotool_operate: --retry for HTTP 408 responses too
Daniel Stenberg [Sun, 1 Nov 2020 23:04:22 +0000 (00:04 +0100)] 
tool_operate: --retry for HTTP 408 responses too

This was inadvertently dropped from the code when the parallel support
was added.

Regression since b88940850 (7.66.0)

Reviewed-by: Jay Satiro
Closes #6155

5 years agohttp: pass correct header size to debug callback for chunked post
Daniel Stenberg [Fri, 30 Oct 2020 10:29:22 +0000 (11:29 +0100)] 
http: pass correct header size to debug callback for chunked post

... when the chunked framing was added, the size of the "body part" of
the data was calculated wrongly so the debug callback would get told a
header chunk a few bytes too big that would also contain the first few
bytes of the request body.

Reported-by: Dirk Wetter
Ref: #6144
Closes #6147

5 years agoheader.d: mention the "Transfer-Encoding: chunked" handling
Daniel Stenberg [Fri, 30 Oct 2020 11:05:47 +0000 (12:05 +0100)] 
header.d: mention the "Transfer-Encoding: chunked" handling

Ref: #6144
Closes #6148

5 years agoacinclude: detect manually set minimum macos/ipod version
Daniel Stenberg [Thu, 29 Oct 2020 09:01:42 +0000 (10:01 +0100)] 
acinclude: detect manually set minimum macos/ipod version

... even if set in the CC or IPHONEOS/MACOSX_DEPLOYMENT_TARGET
variables.

Reported-by: hamstergene on github
Fixes #6138
Closes #6140

5 years agotests: fix some http/2 tests for older versions of nghttpx
Jay Satiro [Thu, 29 Oct 2020 04:06:27 +0000 (00:06 -0400)] 
tests: fix some http/2 tests for older versions of nghttpx

- Add regex that strips http/2 server header name to those http/2 tests
  that don't already have it.

- Improve that regex in all http/2 tests.

Tests 358 and 359 were failing for me before this change on a system
that uses an older version of nghttpx which includes its version number
in the server header.

Closes https://github.com/curl/curl/pull/6139

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Thu, 29 Oct 2020 23:21:38 +0000 (00:21 +0100)] 
RELEASE-NOTES: synced

5 years agoconfigure: use pkgconfig to find openSSL when cross-compiling
Cristian Morales Vega [Thu, 29 Oct 2020 17:14:49 +0000 (17:14 +0000)] 
configure: use pkgconfig to find openSSL when cross-compiling

This reverts 736a40fec (November 2004), which doesn't explain why it was
done.

Closes #6145

5 years agotool_operate: bail out proper on errors for parallel setup
Daniel Stenberg [Wed, 28 Oct 2020 10:00:31 +0000 (11:00 +0100)] 
tool_operate: bail out proper on errors for parallel setup

... otherwise for example trying to upload a missing file just causes a
loop.

Reported-by: BrumBrum on hackerone
Closes #6141

5 years agoCMake: make BUILD_TESTING dependent option
Sergei Nikulov [Tue, 13 Oct 2020 20:37:15 +0000 (23:37 +0300)] 
CMake: make BUILD_TESTING dependent option

CMake will now handle BUILD_TESTING depending on PERL_FOUND and
CURL_DISABLE_TESTING

Ref: #6036
Closes #6072

5 years agolibssh2: fix transport over HTTPS proxy
Daniel Stenberg [Mon, 26 Oct 2020 10:10:49 +0000 (11:10 +0100)] 
libssh2: fix transport over HTTPS proxy

The fix in #6021 was not enough. This fix makes sure SCP/SFTP content
can also be transfered over a HTTPS proxy.

Fixes #6113
Closes #6128

5 years agocurl.1: add an "OUTPUT" section at the top of the manpage
Daniel Stenberg [Mon, 26 Oct 2020 22:38:52 +0000 (23:38 +0100)] 
curl.1: add an "OUTPUT" section at the top of the manpage

Explain the basic concepts behind curl output.

Inspired by #6124

Closes #6134

5 years agomailmap: set Viktor Szakats's email
Daniel Stenberg [Wed, 28 Oct 2020 10:10:54 +0000 (11:10 +0100)] 
mailmap: set Viktor Szakats's email

5 years agoruntests: show keywords when no tests ran
Daniel Stenberg [Mon, 26 Oct 2020 07:58:05 +0000 (08:58 +0100)] 
runtests: show keywords when no tests ran

To help out future debugging, runtests now outputs the list of keywords
when it fails because no tests ran.

Ref: #6120
Closes #6126

5 years agoCURLOPT_DNS_USE_GLOBAL_CACHE.3: fix typo
Jay Satiro [Mon, 26 Oct 2020 21:08:26 +0000 (17:08 -0400)] 
CURLOPT_DNS_USE_GLOBAL_CACHE.3: fix typo

Reported-by: Rui LIU
Closes https://github.com/curl/curl/issues/6131

5 years agorange.d: fix typo
Jay Satiro [Mon, 26 Oct 2020 21:12:15 +0000 (17:12 -0400)] 
range.d: fix typo

Follow-up to 15ae039 from earlier today.

5 years agoCI/github: work-around for brew breakage on macOS
Daniel Stenberg [Mon, 26 Oct 2020 12:10:29 +0000 (13:10 +0100)] 
CI/github: work-around for brew breakage on macOS

... and make it use OpenSSL 1.1 properly

Fixes #6130
Closes #6129

5 years agorange.d: clarify that curl will not parse multipart responses
José Joaquín Atria [Mon, 26 Oct 2020 09:36:16 +0000 (09:36 +0000)] 
range.d: clarify that curl will not parse multipart responses

Closes #6127
Fixes #6124

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Mon, 26 Oct 2020 08:27:29 +0000 (09:27 +0100)] 
RELEASE-NOTES: synced

5 years agolibssh2: fix build with disabled proxy support
Baruch Siach [Mon, 26 Oct 2020 04:56:49 +0000 (06:56 +0200)] 
libssh2: fix build with disabled proxy support

Build breaks because the http_proxy field is missing:

vssh/libssh2.c:3119:10: error: 'struct connectdata' has no member named 'http_proxy'

Regression from #6021, shipped in curl 7.73.0

Closes #6125

5 years agoalt-svc: enable by default
Daniel Stenberg [Sun, 25 Oct 2020 22:08:54 +0000 (23:08 +0100)] 
alt-svc: enable by default

Remove CURLALTSVC_IMMEDIATELY, which was never implemented/supported.

alt-svc support in curl is no longer considered experimental

Closes #5868

5 years agoCI/appveyor: remove (unused) runtests.pl -b option
Daniel Stenberg [Sun, 25 Oct 2020 11:07:00 +0000 (12:07 +0100)] 
CI/appveyor: remove (unused) runtests.pl -b option

5 years agotool_help: make "output" description less confusing
Emil Engler [Thu, 22 Oct 2020 15:23:36 +0000 (17:23 +0200)] 
tool_help: make "output" description less confusing

Currently the description of "output" is misleading when comparing it
"verbose".

Closes #6118

5 years agoCI/appveyor: disable test 571 in two cmake builds
Daniel Stenberg [Thu, 22 Oct 2020 17:36:24 +0000 (19:36 +0200)] 
CI/appveyor: disable test 571 in two cmake builds

...  they're simply too flaky there.

Closes #6119

5 years agocmake: set the unicode feature in curl-config on Windows
Daniel Stenberg [Thu, 22 Oct 2020 12:49:19 +0000 (14:49 +0200)] 
cmake: set the unicode feature in curl-config on Windows

... if built that way. To make it match curl -V output.

Reviewed-by: Marcel Raad
Closes #6117

5 years agolibssh2: require version 1.0 or later
Daniel Stenberg [Thu, 22 Oct 2020 10:29:21 +0000 (12:29 +0200)] 
libssh2: require version 1.0 or later

... and simplify the code accordingly. libssh2 version 1.0 was released
in April 2009.

Closes #6116

5 years agoKNOWN_BUGS: mention the individual cmake issues
Daniel Stenberg [Wed, 21 Oct 2020 06:25:19 +0000 (08:25 +0200)] 
KNOWN_BUGS: mention the individual cmake issues

... to make them easier to refer to and address separately and
one-by-one.

5 years agoCMake: store IDN2 information in curl_config.h
Daniel Stenberg [Tue, 20 Oct 2020 08:29:53 +0000 (10:29 +0200)] 
CMake: store IDN2 information in curl_config.h

This allows the build to enable IDN properly and it makes test 1014
happier.

Ref: #6074
Closes #6108

5 years agoCMake: call the feature unixsockets without dash
Daniel Stenberg [Tue, 20 Oct 2020 08:28:01 +0000 (10:28 +0200)] 
CMake: call the feature unixsockets without dash

... so that curl-config gets correct and makes test 1014 happy!

Ref: #6074
Closes #6108

5 years agoCI/travis: add brotli and zstd to the libssh2 build
Daniel Stenberg [Mon, 19 Oct 2020 09:13:05 +0000 (11:13 +0200)] 
CI/travis: add brotli and zstd to the libssh2 build

... to make sure such tests are run with valgrind. Suppress the zstd
valgrind warnings we get with version 1.3.3 on Ubuntu 18.04 (for debug
and non-debug builds).

Closes #6105

5 years agoruntests: revert the mistaken edit of $CURL
Daniel Stenberg [Mon, 19 Oct 2020 09:50:08 +0000 (11:50 +0200)] 
runtests: revert the mistaken edit of $CURL

Regression from c4693adc62

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Mon, 19 Oct 2020 07:14:47 +0000 (09:14 +0200)] 
RELEASE-NOTES: synced

5 years agocurl_url_set.3: fix typo in the RETURN VALUE section
Daniel Stenberg [Sun, 18 Oct 2020 21:02:57 +0000 (23:02 +0200)] 
curl_url_set.3: fix typo in the RETURN VALUE section

Reported-by: Basuke Suzuki
Fixes #6102

5 years agopackages/OS400: make the source code-style compliant
Daniel Stenberg [Thu, 15 Oct 2020 08:07:00 +0000 (10:07 +0200)] 
packages/OS400: make the source code-style compliant

... and make sure 'make checksrc' in the root dir also verifies the
packages/OS400 sources.

Closes https://github.com/curl/curl/pull/6085

5 years agoos400: Sync libcurl API options
Jay Satiro [Thu, 15 Oct 2020 07:32:30 +0000 (03:32 -0400)] 
os400: Sync libcurl API options

This fixes the OS400 build and also an incorrect entry for
CURLINFO_APPCONNECT_TIME_T where it was treated as
CURLINFO_STARTTRANSFER_TIME_T.

Reported-by: Jon Rumsey
Fixes https://github.com/curl/curl/issues/6083
Closes https://github.com/curl/curl/pull/6084

5 years agoCURLOPT_NOBODY.3: fix typo
Daniel Stenberg [Fri, 16 Oct 2020 21:01:55 +0000 (23:01 +0200)] 
CURLOPT_NOBODY.3: fix typo

Reported-by: Basuke Suzuki
Fixes #6097

5 years agoCI/azure: improve on flakiness by avoiding libtool wrappers
Marc Hoersken [Mon, 12 Oct 2020 04:23:25 +0000 (06:23 +0200)] 
CI/azure: improve on flakiness by avoiding libtool wrappers

Install curl binaries into MinGW bin folder and use that
for the tests in order to avoid libtool wrapper binaries.

The libtool wrapper binaries (not scripts) on Windows seem
to be one of the possible causes for the following issues:

1. Process output can be lost in the wrapper process chain.
2. Killing the wrapper process does not kill the actual one.

Derived from #5904
Closes #6049

5 years agoCURLOPT_URL.3: clarify SCP/SFTP URLs are for uploads as well
Daniel Stenberg [Fri, 16 Oct 2020 13:36:01 +0000 (15:36 +0200)] 
CURLOPT_URL.3: clarify SCP/SFTP URLs are for uploads as well

5 years agoCURLOPT_TCP_NODELAY.3: fix comment in example code
Zenju [Fri, 16 Oct 2020 12:44:34 +0000 (14:44 +0200)] 
CURLOPT_TCP_NODELAY.3: fix comment in example code

Closes #6096

5 years agoopenssl: acknowledge SRP disabling in configure properly
Daniel Stenberg [Thu, 15 Oct 2020 20:56:13 +0000 (22:56 +0200)] 
openssl: acknowledge SRP disabling in configure properly

Follow-up to 68a513247409

Use a new separate define that is the combination of both
HAVE_OPENSSL_SRP and USE_TLS_SRP: USE_OPENSSL_SRP

Bug: https://curl.haxx.se/mail/lib-2020-10/0037.html

Closes #6094

5 years agohttp3: fix two build errors, silence warnings
Viktor Szakats [Fri, 16 Oct 2020 07:15:48 +0000 (07:15 +0000)] 
http3: fix two build errors, silence warnings

* fix two build errors due to mismatch between function
  declarations and their definitions
* silence two mismatched signs warnings via casts

Approved-by: Daniel Stenberg
Closes #6093

5 years agoMakefile.m32: add support for HTTP/3 via ngtcp2+nghttp3
Viktor Szakats [Fri, 16 Oct 2020 07:15:19 +0000 (07:15 +0000)] 
Makefile.m32: add support for HTTP/3 via ngtcp2+nghttp3

Approved-by: Daniel Stenberg
Closes #6092

5 years agotool_operate: fix compiler warning when --libcurl is disabled
Daniel Stenberg [Thu, 15 Oct 2020 20:57:27 +0000 (22:57 +0200)] 
tool_operate: fix compiler warning when --libcurl is disabled

Closes #6095

5 years agochecksrc: warn on empty line before open brace
Daniel Stenberg [Thu, 15 Oct 2020 13:30:55 +0000 (15:30 +0200)] 
checksrc: warn on empty line before open brace

... and fix a few occurances

Closes #6088

5 years agourlapi: URL encode a '+' in the query part
Daniel Stenberg [Thu, 15 Oct 2020 10:22:27 +0000 (12:22 +0200)] 
urlapi: URL encode a '+' in the query part

... when asked to with CURLU_URLENCODE.

Extended test 1560 to verify.
Reported-by: Dietmar Hauser
Fixes #6086
Closes #6087

5 years agolibcurl.pc: make it relocatable
Cristian Morales Vega [Sun, 11 Oct 2020 22:46:53 +0000 (23:46 +0100)] 
libcurl.pc: make it relocatable

It supposes when people specify the libdir/includedir they do it to
change where under prefix/exec_prefix it should be, not to make it
independent of prefix/exec_prefix.

Closes #6061

5 years agoruntests: return error if no tests ran
Daniel Stenberg [Wed, 7 Oct 2020 22:13:07 +0000 (00:13 +0200)] 
runtests: return error if no tests ran

... and make TESTFAIL stand out a little better by adding newlines
before and after.

Reported-by: Marc Hörsken
Issue: #6052
Closes #6053

5 years agodocs/FEATURE: convert to markdown
Daniel Stenberg [Tue, 13 Oct 2020 15:34:40 +0000 (17:34 +0200)] 
docs/FEATURE: convert to markdown

... and clean it up a bit.

Closes #6067

5 years agostrerror: use 'const' as the string should never be modified
Philipp Klaus Krause [Tue, 13 Oct 2020 16:35:50 +0000 (18:35 +0200)] 
strerror: use 'const' as the string should never be modified

Closes #6068

5 years agoconnect: repair build without ipv6 availability
Jay Satiro [Thu, 15 Oct 2020 06:47:49 +0000 (02:47 -0400)] 
connect: repair build without ipv6 availability

Assisted-by: Daniel Stenberg
Reported-by: Tom G. Christensen
Fixes https://github.com/curl/curl/issues/6069
Closes https://github.com/curl/curl/pull/6071

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Thu, 15 Oct 2020 10:52:34 +0000 (12:52 +0200)] 
RELEASE-NOTES: synced

Started over for the journey to next release.

5 years agosrc/tool_filetime: disable -Wformat on mingw for this file
Daniel Stenberg [Thu, 15 Oct 2020 08:14:10 +0000 (10:14 +0200)] 
src/tool_filetime: disable -Wformat on mingw for this file

With gcc 10 on mingw we otherwise get this warning:

 error: ISO C does not support the 'I' printf flag [-Werror=format=]

Fixes #6079
Closes #6082

5 years agotest122[12]: remove these two tests
Daniel Stenberg [Wed, 14 Oct 2020 21:49:00 +0000 (23:49 +0200)] 
test122[12]: remove these two tests

... and remove the objnames scripts they tested. They're not used for
anything anymore so testing them serves no purpose!

Reported-by: Marc Hörsken
Fixes #6080
Closes #6081

5 years agoRELEASE-NOTES: synced curl-7_73_0
Daniel Stenberg [Sun, 11 Oct 2020 21:49:49 +0000 (23:49 +0200)] 
RELEASE-NOTES: synced

for 7.73.0

5 years agoTHANKS: from 7.73.0 and .mailmap fixes
Daniel Stenberg [Sun, 11 Oct 2020 21:51:21 +0000 (23:51 +0200)] 
THANKS: from 7.73.0 and .mailmap fixes

5 years agomailmap: fixups of some contributors
Daniel Stenberg [Fri, 4 Sep 2020 13:28:49 +0000 (15:28 +0200)] 
mailmap: fixups of some contributors

5 years agoprojects/build-wolfssl.bat: fix the copyright year range
Daniel Stenberg [Wed, 14 Oct 2020 05:49:57 +0000 (07:49 +0200)] 
projects/build-wolfssl.bat: fix the copyright year range

5 years agoCI/tests: fix invocation of tests for CMake builds
Sergei Nikulov [Mon, 12 Oct 2020 19:44:37 +0000 (22:44 +0300)] 
CI/tests: fix invocation of tests for CMake builds

Update appveyor.yml to set env variable TFLAGS and run tests
Remove curly braces due to CMake error (${TFLAGS} -> $TFLAGS)
Move testdeps build to build step (per review comments)

Reviewed-by: Marc Hörsken
Closes #6066
Fixes #6052

5 years agotests/server/util.c: fix support for Windows Unicode builds
Marc Hoersken [Tue, 13 Oct 2020 18:23:40 +0000 (20:23 +0200)] 
tests/server/util.c: fix support for Windows Unicode builds

Detected via #6066
Closes #6070

5 years agostrerror: Revert to local codepage for Windows error string
Jay Satiro [Tue, 13 Oct 2020 07:22:55 +0000 (03:22 -0400)] 
strerror: Revert to local codepage for Windows error string

- Change get_winapi_error() to return the error string in the local
  codepage instead of UTF-8 encoding.

Two weeks ago bed5f84 fixed get_winapi_error() to work on xbox, but it
also changed the error string's encoding from local codepage to UTF-8.

We return the local codepage version of the error string because if it
is output to the user's terminal it will likely be with functions which
expect the local codepage (eg fprintf, failf, infof).

This is essentially a partial revert of bed5f84. The support for xbox
remains but the error string is reverted back to local codepage.

Ref: https://github.com/curl/curl/pull/6005

Reviewed-by: Marcel Raad
Closes #6065

5 years agoCI/tests: use verification curl for test reporting APIs
Marc Hoersken [Mon, 12 Oct 2020 04:52:40 +0000 (06:52 +0200)] 
CI/tests: use verification curl for test reporting APIs

Avoid using our own, potentially installed, curl for
the test reporting APIs in case it is broken.

Reviewed-by: Daniel Stenberg
Preparation for #6049
Closes #6063

5 years agowindows: fix comparison of mismatched types warning
Viktor Szakats [Mon, 12 Oct 2020 10:18:53 +0000 (10:18 +0000)] 
windows: fix comparison of mismatched types warning

clang 10, mingw-w64:
```
vtls/openssl.c:2917:33: warning: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long')
      [-Wsign-compare]
              if(GetLastError() != CRYPT_E_NOT_FOUND)
                 ~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~
```

Approved-by: Daniel Stenberg
Closes #6062

5 years agosrc/Makefile.m32: fix undefined curlx_dyn_* errors
Viktor Szakats [Sun, 11 Oct 2020 19:30:45 +0000 (19:30 +0000)] 
src/Makefile.m32: fix undefined curlx_dyn_* errors

by linking `lib/dynbuf.c` when building a static curl binary.
Previously this source file was only included when building
a dynamic curl binary. This was likely possibly because no
functions from the `src/Makefile.inc` / `CURLX_CFILES` sources
were actually required for a curl tool build. This has
recently changed with the introduction of `curlx_dyn_*()`
memory functions and their use by the tool sources.

Closes #6060

5 years agoHISTORY: curl verifies SSL certs by default since version 7.10
Daniel Stenberg [Fri, 9 Oct 2020 15:29:33 +0000 (17:29 +0200)] 
HISTORY: curl verifies SSL certs by default since version 7.10

5 years agoruntests.pl: use $LIBDIR variable instead of hardcoded path
Marc Hoersken [Wed, 7 Oct 2020 19:53:26 +0000 (21:53 +0200)] 
runtests.pl: use $LIBDIR variable instead of hardcoded path

Reviewed-by: Daniel Stenberg
Closes #6051

5 years agochecksrc: detect // comments on column 0
Daniel Stenberg [Wed, 7 Oct 2020 07:11:03 +0000 (09:11 +0200)] 
checksrc: detect // comments on column 0

Spotted while working on #6045

Closes #6048

5 years agombedtls: add missing header when defining MBEDTLS_DEBUG
Frederik Wedel-Heinen [Tue, 6 Oct 2020 08:41:28 +0000 (10:41 +0200)] 
mbedtls: add missing header when defining MBEDTLS_DEBUG

Closes #6045

5 years agocurl: make sure setopt CURLOPT_IPRESOLVE passes on a long
Daniel Stenberg [Sun, 4 Oct 2020 21:05:21 +0000 (23:05 +0200)] 
curl: make sure setopt CURLOPT_IPRESOLVE passes on a long

Previously, it would pass on a define (int) which could make libcurl
read junk as a value - which prevented the CURLOPT_IPRESOLVE option to
"take". This could then make test 2100 do two DoH requests instead of
one!

Fixes #6042
Closes #6043

5 years agoRELEASE-NOTES: synced
Daniel Stenberg [Mon, 5 Oct 2020 06:33:44 +0000 (08:33 +0200)] 
RELEASE-NOTES: synced

5 years agoscripts/release-notes.pl: don't "embed" $ in format string for printf()
Daniel Stenberg [Mon, 5 Oct 2020 06:29:28 +0000 (08:29 +0200)] 
scripts/release-notes.pl: don't "embed" $ in format string for printf()

... since they might contain %-codes that mess up the output!

5 years agobuild-wolfssl: fix build with Visual Studio 2019
M.R.T [Fri, 2 Oct 2020 02:18:36 +0000 (05:48 +0330)] 
build-wolfssl: fix build with Visual Studio 2019

Closes https://github.com/curl/curl/pull/6033

5 years agoruntests: add %repeat[]% for test files
Daniel Stenberg [Sat, 3 Oct 2020 22:03:02 +0000 (00:03 +0200)] 
runtests: add %repeat[]% for test files

... and use this new keywords in all the test files larger than 50K to reduce
their sizes and make them a lot easier to read and understand.

Closes #6040

5 years ago--help: move two options from the misc category
Emil Engler [Sat, 3 Oct 2020 07:13:34 +0000 (09:13 +0200)] 
--help: move two options from the misc category

The cmdline opts delegation and suppress-connect-headers
fit better into auth and proxy rather than misc.

Follow-up to aa8777f63febc
Closes #6038

5 years agodocs/opts: fix typos in two manual pages
Samanta Navarro [Sat, 3 Oct 2020 11:51:02 +0000 (11:51 +0000)] 
docs/opts: fix typos in two manual pages

Closes #6039

5 years agoldap: reduce the amount of #ifdefs needed
Daniel Stenberg [Fri, 2 Oct 2020 09:18:21 +0000 (11:18 +0200)] 
ldap: reduce the amount of #ifdefs needed

Closes #6035

5 years agoruntests: provide curl's version string as %VERSION for tests
Daniel Stenberg [Fri, 2 Oct 2020 11:45:24 +0000 (13:45 +0200)] 
runtests: provide curl's version string as %VERSION for tests

... so that we can check HTTP requests for User-Agent: curl/%VERSION

Update 600+ test cases accordingly.

Closes #6037

5 years agochecksrc: warn on space after exclamation mark
Daniel Stenberg [Fri, 2 Oct 2020 08:58:52 +0000 (10:58 +0200)] 
checksrc: warn on space after exclamation mark

Closes #6034

5 years agotest1465: verify --libcurl with binary POST data
Daniel Stenberg [Thu, 1 Oct 2020 22:12:41 +0000 (00:12 +0200)] 
test1465: verify --libcurl with binary POST data

5 years agoruntests: allow generating a binary sequence from hex
Daniel Stenberg [Thu, 1 Oct 2020 22:11:13 +0000 (00:11 +0200)] 
runtests: allow generating a binary sequence from hex