]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 months agotypos in pair_tokenize.c
Alan T. DeKok [Sat, 28 Feb 2026 15:36:21 +0000 (10:36 -0500)] 
typos in pair_tokenize.c

3 months agoset type for talloc_strdup() and friends
Alan T. DeKok [Sat, 28 Feb 2026 14:31:23 +0000 (09:31 -0500)] 
set type for talloc_strdup() and friends

The talloc string functions set the type of the string to the
string contents.  Which makes it very difficult to do type checking
on them.  As such, we wrap the various functions in ones which set
the name to something reasonable.

3 months agodon't pass "const" to talloc functions
Alan T. DeKok [Sat, 28 Feb 2026 14:25:40 +0000 (09:25 -0500)] 
don't pass "const" to talloc functions

3 months agosecret may be NULL, and make code more consistent
Alan T. DeKok [Sat, 28 Feb 2026 14:24:49 +0000 (09:24 -0500)] 
secret may be NULL, and make code more consistent

3 months agoparent filename off of thread, not inst
Alan T. DeKok [Sat, 28 Feb 2026 14:18:02 +0000 (09:18 -0500)] 
parent filename off of thread, not inst

3 months agouse correct attribute for duplicate checks
Alan T. DeKok [Sat, 28 Feb 2026 13:48:21 +0000 (08:48 -0500)] 
use correct attribute for duplicate checks

3 months agowarn if they're using a secret other than 'radsec' for TLS.
Alan T. DeKok [Sat, 28 Feb 2026 13:45:59 +0000 (08:45 -0500)] 
warn if they're using a secret other than 'radsec' for TLS.

@todo - also when we do DTLS, the secret should be different.
And when ALPN is used, we don't have a secret

3 months agoclean up on failure.
Alan T. DeKok [Sat, 28 Feb 2026 13:42:13 +0000 (08:42 -0500)] 
clean up on failure.

which doesn't matter in practice, as we don't dynamically read
users files.  But it's good practice

3 months agoclean up on corner case of failure
Alan T. DeKok [Sat, 28 Feb 2026 13:41:46 +0000 (08:41 -0500)] 
clean up on corner case of failure

and use "goto fail" in more places, to ensure a common cleanup
path

3 months agotypo in name match
Alan T. DeKok [Sat, 28 Feb 2026 13:37:35 +0000 (08:37 -0500)] 
typo in name match

3 months agoincrement count as per docs
Alan T. DeKok [Sat, 28 Feb 2026 13:36:58 +0000 (08:36 -0500)] 
increment count as per docs

3 months agodon't leak FDs on corner cases
Alan T. DeKok [Sat, 28 Feb 2026 13:35:40 +0000 (08:35 -0500)] 
don't leak FDs on corner cases

3 months agotypos
Alan T. DeKok [Sat, 28 Feb 2026 13:30:05 +0000 (08:30 -0500)] 
typos

3 months agomulti-thread fail is different from single-thread fail
Alan T. DeKok [Sat, 28 Feb 2026 13:28:19 +0000 (08:28 -0500)] 
multi-thread fail is different from single-thread fail

3 months agoclean up on error, and insert into list only on success
Alan T. DeKok [Sat, 28 Feb 2026 13:26:42 +0000 (08:26 -0500)] 
clean up on error, and insert into list only on success

3 months agoremove duplicate code, and tweak order of existing code to match
Alan T. DeKok [Sat, 28 Feb 2026 13:22:50 +0000 (08:22 -0500)] 
remove duplicate code, and tweak order of existing code to match

3 months agofix various bugs in unit_test_map
Alan T. DeKok [Sat, 28 Feb 2026 13:18:30 +0000 (08:18 -0500)] 
fix various bugs in unit_test_map

3 months agodon't re-alloc memory, and always close fp on exit
Alan T. DeKok [Sat, 28 Feb 2026 13:14:25 +0000 (08:14 -0500)] 
don't re-alloc memory, and always close fp on exit

3 months agofix typo - don't call init twice
Alan T. DeKok [Sat, 28 Feb 2026 13:12:32 +0000 (08:12 -0500)] 
fix typo - don't call init twice

3 months agoadd tests for corner cases of keywords
Alan T. DeKok [Fri, 27 Feb 2026 23:40:13 +0000 (18:40 -0500)] 
add tests for corner cases of keywords

3 months agocheck extensions, too
Alan T. DeKok [Fri, 27 Feb 2026 22:39:48 +0000 (17:39 -0500)] 
check extensions, too

3 months agotypo - use & instead of modulo
Alan T. DeKok [Fri, 27 Feb 2026 22:36:29 +0000 (17:36 -0500)] 
typo - use & instead of modulo

3 months agotypo in error messages
Alan T. DeKok [Fri, 27 Feb 2026 22:33:31 +0000 (17:33 -0500)] 
typo in error messages

3 months agotrack memory with talloc
Alan T. DeKok [Fri, 27 Feb 2026 22:30:11 +0000 (17:30 -0500)] 
track memory with talloc

TBH, this module should either be discarded, or re-written from
scratch.  It's pretty terrible

3 months agoadd tests for cf_util, etc.
Alan T. DeKok [Fri, 27 Feb 2026 22:20:10 +0000 (17:20 -0500)] 
add tests for cf_util, etc.

3 months agovarious bug fixes for tmpl_dcursor.c
Alan T. DeKok [Fri, 27 Feb 2026 22:19:39 +0000 (17:19 -0500)] 
various bug fixes for tmpl_dcursor.c

don't return freed pointer

3 months agominor fixes to rlm_eap
Alan T. DeKok [Fri, 27 Feb 2026 22:03:35 +0000 (17:03 -0500)] 
minor fixes to rlm_eap

3 months agouse SBUFF_CHAR_CLASS instead of UINT8_MAX + 1
Alan T. DeKok [Fri, 27 Feb 2026 21:56:09 +0000 (16:56 -0500)] 
use SBUFF_CHAR_CLASS instead of UINT8_MAX + 1

and fix a few issues where it wasn't using the "+ 1"

3 months agoadd tmpl tests
Alan T. DeKok [Fri, 27 Feb 2026 16:35:41 +0000 (11:35 -0500)] 
add tmpl tests

to avoid regressions, and sanity check the code.

3 months agocomplain on invalid input
Alan T. DeKok [Fri, 27 Feb 2026 20:24:14 +0000 (15:24 -0500)] 
complain on invalid input

3 months agoreturn on failure
Alan T. DeKok [Fri, 27 Feb 2026 20:20:38 +0000 (15:20 -0500)] 
return on failure

3 months agouse correct variable
Alan T. DeKok [Fri, 27 Feb 2026 20:18:17 +0000 (15:18 -0500)] 
use correct variable

3 months agovarious bug fixes in password.c
Alan T. DeKok [Fri, 27 Feb 2026 20:15:34 +0000 (15:15 -0500)] 
various bug fixes in password.c

3 months agomore error checks for OOM, etc.
Alan T. DeKok [Fri, 27 Feb 2026 20:07:34 +0000 (15:07 -0500)] 
more error checks for OOM, etc.

3 months agovarious bug fixes in connection.c
Alan T. DeKok [Fri, 27 Feb 2026 19:59:35 +0000 (14:59 -0500)] 
various bug fixes in connection.c

reset processing_signals on freed, instead of returning.
otherwise it's locked forever.

leave one-shot watchers enabled until they're finished, otherwise
connection_deferred_signal_process() will access a freed watcher

allow more states in the handlers, as they're all valid.

3 months agoreturn error on OOM
Alan T. DeKok [Fri, 27 Feb 2026 16:33:47 +0000 (11:33 -0500)] 
return error on OOM

3 months agoFree connected dynamic client parents when their idle time expires
Nick Porter [Fri, 27 Feb 2026 15:02:16 +0000 (15:02 +0000)] 
Free connected dynamic client parents when their idle time expires

Without this, the "parent" client which is built when a connected
dynamic client is first created never expires, so the client is never
reloaded.

3 months agoadd missing enum.
Alan T. DeKok [Fri, 27 Feb 2026 13:36:08 +0000 (08:36 -0500)] 
add missing enum.

Why not just set TRUNK_CONN_ALL = ~0?

3 months agotypos and use dlist API properly
Alan T. DeKok [Fri, 27 Feb 2026 13:31:53 +0000 (08:31 -0500)] 
typos and use dlist API properly

3 months agofix typos
Alan T. DeKok [Fri, 27 Feb 2026 13:11:04 +0000 (08:11 -0500)] 
fix typos

3 months agoquiet static analysis
Alan T. DeKok [Fri, 27 Feb 2026 13:09:09 +0000 (08:09 -0500)] 
quiet static analysis

3 months agoNeed inline for always_inline to work
Nick Porter [Fri, 27 Feb 2026 10:52:56 +0000 (10:52 +0000)] 
Need inline for always_inline to work

3 months agovarious tweaks to tmpl_tokenize.c
Alan T. DeKok [Fri, 27 Feb 2026 00:59:52 +0000 (19:59 -0500)] 
various tweaks to tmpl_tokenize.c

3 months agocheck for !fips here, too
Alan T. DeKok [Fri, 27 Feb 2026 00:43:54 +0000 (19:43 -0500)] 
check for !fips here, too

3 months agotypo
Alan T. DeKok [Fri, 27 Feb 2026 00:36:33 +0000 (19:36 -0500)] 
typo

3 months agodocs-v4: moved network security best practices page to `Introduction >> Best Practices`.
nolade [Thu, 26 Feb 2026 21:49:52 +0000 (16:49 -0500)] 
docs-v4: moved network security best practices page to `Introduction >> Best Practices`.

3 months agodocs-v4: Added more details to Developer >> Contributing section including git comman...
nolade [Thu, 26 Feb 2026 21:25:26 +0000 (16:25 -0500)] 
docs-v4: Added more details to Developer >> Contributing section including git commands, PR submisssions. Rearranged hierarchy, added subsections, and formatted accordingly to style guide.

3 months agodocs-v4: Correct nav link for `unlang >> List of Data Types`
nolade [Thu, 26 Feb 2026 22:24:20 +0000 (17:24 -0500)] 
docs-v4: Correct nav link for `unlang >> List of Data Types`

3 months agocorrect check for FIPS mode, and re-init free list
Alan T. DeKok [Thu, 26 Feb 2026 15:05:59 +0000 (10:05 -0500)] 
correct check for FIPS mode, and re-init free list

when changing digest functions, we have to clear and re-initialize
the free list, otherwise the contexts are associated with the
wrong ctx_free() function.

3 months agobetter error messages
Alan T. DeKok [Thu, 26 Feb 2026 20:58:04 +0000 (15:58 -0500)] 
better error messages

when local variables are defined in the wrong place

3 months agovarious bug fixes in map.c
Alan T. DeKok [Thu, 26 Feb 2026 20:43:32 +0000 (15:43 -0500)] 
various bug fixes in map.c

don't leak, and make "-=" work a bit better

3 months agovarious bug fixes in rlm_mschap
Alan T. DeKok [Thu, 26 Feb 2026 19:31:37 +0000 (14:31 -0500)] 
various bug fixes in rlm_mschap

3 months agoset result, too
Alan T. DeKok [Thu, 26 Feb 2026 18:48:55 +0000 (13:48 -0500)] 
set result, too

3 months agomore checks for corner cases and invalid data
Alan T. DeKok [Thu, 26 Feb 2026 18:46:33 +0000 (13:46 -0500)] 
more checks for corner cases and invalid data

3 months agotypo
Alan T. DeKok [Thu, 26 Feb 2026 18:34:05 +0000 (13:34 -0500)] 
typo

3 months agoremove PID file on error, too
Alan T. DeKok [Thu, 26 Feb 2026 18:29:43 +0000 (13:29 -0500)] 
remove PID file on error, too

3 months agostatus checks can expire, too
Alan T. DeKok [Thu, 26 Feb 2026 15:51:45 +0000 (10:51 -0500)] 
status checks can expire, too

3 months agoadd more checks and complaints
Alan T. DeKok [Thu, 26 Feb 2026 15:49:11 +0000 (10:49 -0500)] 
add more checks and complaints

3 months agoremove old from htrie, too
Alan T. DeKok [Thu, 26 Feb 2026 15:39:41 +0000 (10:39 -0500)] 
remove old from htrie, too

3 months agovarious bug fixes to pair functions
Alan T. DeKok [Thu, 26 Feb 2026 15:09:54 +0000 (10:09 -0500)] 
various bug fixes to pair functions

check for memory allocation failure, tweak macros, etc.

3 months agouse hyphens
Alan T. DeKok [Thu, 26 Feb 2026 13:45:02 +0000 (08:45 -0500)] 
use hyphens

3 months agouse consistent formatting for copyright notices
Alan T. DeKok [Thu, 26 Feb 2026 13:42:24 +0000 (08:42 -0500)] 
use consistent formatting for copyright notices

3 months agoadd slab tests for commit 331aa05
Alan T. DeKok [Thu, 26 Feb 2026 13:41:01 +0000 (08:41 -0500)] 
add slab tests for commit 331aa05

and use TEST_ASSERT instead of TEST_CHECK + if (!foo) return

3 months agoloop only while we have 4 bytes in the buffer
Alan T. DeKok [Thu, 26 Feb 2026 13:23:36 +0000 (08:23 -0500)] 
loop only while we have 4 bytes in the buffer

3 months agofix order of %ull vs %ul
Alan T. DeKok [Thu, 26 Feb 2026 13:21:45 +0000 (08:21 -0500)] 
fix order of %ull vs %ul

3 months agofix typo
Alan T. DeKok [Thu, 26 Feb 2026 13:18:59 +0000 (08:18 -0500)] 
fix typo

3 months agoremove test content
Alan T. DeKok [Thu, 26 Feb 2026 13:18:43 +0000 (08:18 -0500)] 
remove test content

3 months agovarious bug fixes in EAP
Alan T. DeKok [Thu, 26 Feb 2026 13:05:16 +0000 (08:05 -0500)] 
various bug fixes in EAP

3 months agoeck for rare failure on init
Alan T. DeKok [Thu, 26 Feb 2026 13:09:49 +0000 (08:09 -0500)] 
eck for rare failure on init

3 months agohoist failure check before setting destructor
Alan T. DeKok [Thu, 26 Feb 2026 13:07:31 +0000 (08:07 -0500)] 
hoist failure check before setting destructor

3 months agoalways save a copy of u->packet
Alan T. DeKok [Wed, 25 Feb 2026 22:13:03 +0000 (17:13 -0500)] 
always save a copy of u->packet

3 months agoavoid strlcpy(), and use memcpy() instead
Alan T. DeKok [Wed, 25 Feb 2026 21:33:58 +0000 (16:33 -0500)] 
avoid strlcpy(), and use memcpy() instead

3 months agocheck return code of function
Alan T. DeKok [Wed, 25 Feb 2026 21:28:43 +0000 (16:28 -0500)] 
check return code of function

3 months agocheck for IP in pcap receive path
Alan T. DeKok [Wed, 25 Feb 2026 21:23:22 +0000 (16:23 -0500)] 
check for IP in pcap receive path

3 months agoproduce correct error message, using the configured length
Alan T. DeKok [Wed, 25 Feb 2026 21:20:27 +0000 (16:20 -0500)] 
produce correct error message, using the configured length

3 months agovarious bug fixes in rlm_unix
Alan T. DeKok [Wed, 25 Feb 2026 21:19:08 +0000 (16:19 -0500)] 
various bug fixes in rlm_unix

3 months agopass remaining data, to avoid repeated strlen()
Alan T. DeKok [Wed, 25 Feb 2026 21:16:00 +0000 (16:16 -0500)] 
pass remaining data, to avoid repeated strlen()

3 months agotweaks to comments and assertions
Alan T. DeKok [Wed, 25 Feb 2026 21:14:42 +0000 (16:14 -0500)] 
tweaks to comments and assertions

3 months agovarious bug fixes in winbind
Alan T. DeKok [Wed, 25 Feb 2026 21:12:54 +0000 (16:12 -0500)] 
various bug fixes in winbind

3 months agomore checks for malformed vendor options
Alan T. DeKok [Wed, 25 Feb 2026 21:09:31 +0000 (16:09 -0500)] 
more checks for malformed vendor options

3 months agofree buffer on all error paths
Alan T. DeKok [Wed, 25 Feb 2026 21:08:13 +0000 (16:08 -0500)] 
free buffer on all error paths

3 months agoalways unlock. Fixes CID #1681712
Alan T. DeKok [Wed, 25 Feb 2026 20:48:43 +0000 (15:48 -0500)] 
always unlock.  Fixes CID #1681712

3 months agoAssert if slab elements are not released correctly
Arran Cudbard-Bell [Thu, 26 Feb 2026 00:51:36 +0000 (17:51 -0700)] 
Assert if slab elements are not released correctly

3 months agoattr.by_num is redundant and can be removed
Arran Cudbard-Bell [Wed, 25 Feb 2026 22:30:10 +0000 (15:30 -0700)] 
attr.by_num is redundant and can be removed

3 months agoallow dict.attr.by_oid to operate with foreign protocols
Arran Cudbard-Bell [Wed, 25 Feb 2026 22:00:32 +0000 (15:00 -0700)] 
allow dict.attr.by_oid to operate with foreign protocols

3 months agoRemove unused argument in dict function
Arran Cudbard-Bell [Wed, 25 Feb 2026 22:00:12 +0000 (15:00 -0700)] 
Remove unused argument in dict function

3 months agoonly remove it if it's in the dedup tree
Alan T. DeKok [Wed, 25 Feb 2026 19:18:40 +0000 (14:18 -0500)] 
only remove it if it's in the dedup tree

3 months agoadd assertion to quiet static analyser
Alan T. DeKok [Wed, 25 Feb 2026 18:35:41 +0000 (13:35 -0500)] 
add assertion to quiet static analyser

3 months agoremove old entry from dedup tree
Alan T. DeKok [Wed, 25 Feb 2026 18:31:58 +0000 (13:31 -0500)] 
remove old entry from dedup tree

3 months agoparse *= and /=. Update tests to match
Alan T. DeKok [Wed, 25 Feb 2026 18:18:11 +0000 (13:18 -0500)] 
parse *= and /=.  Update tests to match

3 months agotweak error messages to produce actual error string
Alan T. DeKok [Wed, 25 Feb 2026 18:03:22 +0000 (13:03 -0500)] 
tweak error messages to produce actual error string

3 months agovarious typos in tacacs
Alan T. DeKok [Wed, 25 Feb 2026 15:50:24 +0000 (10:50 -0500)] 
various typos in tacacs

3 months agomake tcp respect max_attributes and require_ma
Alan T. DeKok [Wed, 25 Feb 2026 15:47:16 +0000 (10:47 -0500)] 
make tcp respect max_attributes and require_ma

and also make it handle partial reads

3 months agoallow packet_list_recv() to return error
Alan T. DeKok [Wed, 25 Feb 2026 15:15:31 +0000 (10:15 -0500)] 
allow packet_list_recv() to return error

so that we can close TCP sockets

3 months agovarious bug fixes in the RADIUS protocol handler
Alan T. DeKok [Wed, 25 Feb 2026 15:11:04 +0000 (10:11 -0500)] 
various bug fixes in the RADIUS protocol handler

largely in things for radclient, or proposed code that isn't
used.

3 months agoreset flag on free all
Alan T. DeKok [Wed, 25 Feb 2026 14:05:44 +0000 (09:05 -0500)] 
reset flag on free all

3 months agofix typos
Alan T. DeKok [Wed, 25 Feb 2026 12:29:13 +0000 (07:29 -0500)] 
fix typos

3 months agocheck correct field
Alan T. DeKok [Wed, 25 Feb 2026 02:07:57 +0000 (21:07 -0500)] 
check correct field

3 months agofix typo in comparison
Alan T. DeKok [Wed, 25 Feb 2026 02:01:42 +0000 (21:01 -0500)] 
fix typo in comparison

3 months agoclose FPs on errors
Alan T. DeKok [Wed, 25 Feb 2026 01:54:19 +0000 (20:54 -0500)] 
close FPs on errors