Nick Mathewson [Fri, 26 Dec 2008 17:35:12 +0000 (17:35 +0000)]
Document the pk operation count fields in rephist.c, and move them into a struct for clarity, and change their type to what we actually want to cast them to.
Nick Mathewson [Fri, 26 Dec 2008 17:35:08 +0000 (17:35 +0000)]
Add more missing documentation, and correct an error in container.c documentation: Don't introduce two parameters called n when you're calling an algorithm O(n).
Nick Mathewson [Wed, 24 Dec 2008 02:38:07 +0000 (02:38 +0000)]
Use the literal parse of an address in dns_resolve_impl if parsing the address as an ipv4 or ipv6 address _succeeded_. Not if it failed. Bug introduced in r17707 (post 0.2.1.8-alpha), and found by xiando.
Nick Mathewson [Mon, 22 Dec 2008 16:37:20 +0000 (16:37 +0000)]
Documentation and conformance for WRA_* returns.
shahn: "Add some documentation for the WRA_* family of functions, also make
sure that (hopefully) all functions that return was_router_added_t
don't return ints directly and that they don't refer to integers in
their documentation anymore."
Nick Mathewson [Mon, 22 Dec 2008 16:22:04 +0000 (16:22 +0000)]
Partially apply bug 891 parch from forest: check EXTEND cell address against real_addr, not addr. I have questions about the rest of the patch: see the flyspray entry.
Roger Dingledine [Mon, 22 Dec 2008 09:10:06 +0000 (09:10 +0000)]
some windows users are outraged that tor refuses to work even
when their clock and date are correct, if their timezone is
totally wrong. now we at least tell them.
Roger Dingledine [Mon, 22 Dec 2008 06:25:49 +0000 (06:25 +0000)]
the default should not be the notify the poster, unless something
more extreme happens. the default should be to be quiet unless
something more extreme happens.
at least, this doesn't generate complaints anymore. perhaps that
means it is working better? :)
Roger Dingledine [Mon, 22 Dec 2008 06:21:28 +0000 (06:21 +0000)]
fix a fun bug on r17656 that was making us send HTTP/1.0 404 as
the message body, no matter the message headers, when answering
a descriptor or extrainfo post request.
Nick Mathewson [Fri, 19 Dec 2008 18:52:00 +0000 (18:52 +0000)]
Move in-addr.arpa parsing and generation into address.c, and simplify the code that does it elsewhere. Incidentally, this lets exit servers answer requests for ip6.arpa addresses.
Nick Mathewson [Thu, 18 Dec 2008 17:19:04 +0000 (17:19 +0000)]
Replace calls to time(NULL) that occur on the order of once per read, one per write, or once per cell with calls to a function that looks at a cached value of time. This is tricksy to benchmark, since it will only help on systems where time() is a syscall and syscalls are relatively slow.
Nick Mathewson [Thu, 18 Dec 2008 16:11:03 +0000 (16:11 +0000)]
Remove fixed xxx020s; downgrade unfixed ones.
(The unfixed ones are being downgraded to regular XXXs mainly on the rationale that they don't seem to be exploding Tor, and they were apparently not showstoppers for 0.2.0.x-final.)
Nick Mathewson [Thu, 18 Dec 2008 04:45:47 +0000 (04:45 +0000)]
Avoid nop call to control_event_or_authdir_new_descriptor that makes coverity think we are dereferencing a null pointer. It is safe, I think, but entirely too clever for our own good.
Nick Mathewson [Wed, 17 Dec 2008 22:58:14 +0000 (22:58 +0000)]
Rename ServerDNSAllowBrokenResolvConf to ServerDNSAllowBrokenConfig.
(Many users have no idea what a resolv.conf is, and shouldn't be forced to learn. The old option will keep working for now.)
Also, document it.
Roger Dingledine [Wed, 17 Dec 2008 22:32:17 +0000 (22:32 +0000)]
Clip the MaxCircuitDirtiness config option to a minimum of 10
seconds. Warn the user if lower values are given in the
configuration. Bugfix on 0.1.0.1-rc. Patch by Sebastian.
Clip the CircuitBuildTimeout to a minimum of 30 seconds. Warn the
user if lower values are given in the configuration. Bugfix on
0.1.1.17-rc. Patch by Sebastian.
Nick Mathewson [Mon, 15 Dec 2008 21:17:53 +0000 (21:17 +0000)]
Don't extend circuits over noncanonical connections with mismatched addresses.
Also, refactor the logic to check whether we will use a connection or
launch a new one into a new function.
Roger Dingledine [Sun, 14 Dec 2008 19:40:56 +0000 (19:40 +0000)]
When a stream at an exit relay is in state "resolving" or
"connecting" and it receives an "end" relay cell, the exit relay
would silently ignore the end cell and not close the stream. If
the client never closes the circuit, then the exit relay never
closes the TCP connection. Bug introduced in Tor 0.1.2.1-alpha;
reported by "wood".