Günther Deschner [Tue, 23 Nov 2004 01:05:31 +0000 (01:05 +0000)]
r3918: Allow to set OWNER- and GROUP-entries while setting security descriptors
with smbcacls and using with the -S or -M switch. Fixes #404 and #2076.
Jeremy Allison [Sat, 20 Nov 2004 21:24:52 +0000 (21:24 +0000)]
r3895: Fix for bug #2045. May also fix other timestamp bugs with Excel
(Volker please test). Setting a last write timestamp from Windows
overrides any subsequent write timestamp changes and must be immediately
seen by and findfirst/findnexts. This is a racy solution, but should
work most of the time. This may also fix #1061, not sure.
Jeremy.
Volker Lendecke [Fri, 19 Nov 2004 12:11:13 +0000 (12:11 +0000)]
r3873: The semantics of the parameter 'printcap name' are a bit tricky. I had seen
the effect that I could not list printers with smbclient -L. I have cups
libraries but no running cups server, so remove_stale_printers() removed all
my printer definitions from the share list. So I said 'printing = bsd' but it
still would not work.
This happened because init_globals() would initialize Globals.szPrintcapname
to "cups", and the explicit 'printing = bsd' did not reset it. 'printing=bsd'
can't reset it, as this might overwrite an explicit setting. Thus I separated
the lp_printcapname into a function of its own, looking at
Globals.szPrintcapname and subsequently at sDefault.iPrinting.
Please revisit, there are just too many cases to cover.
Jeremy Allison [Thu, 18 Nov 2004 22:46:04 +0000 (22:46 +0000)]
r3867: Fix from david.hu@hp.com - make a copy of an incoming message
rather than indirecting into it as a struct (may not be on an
even byte boundary). Bug #2052.
Jeremy.
Volker Lendecke [Thu, 18 Nov 2004 15:44:01 +0000 (15:44 +0000)]
r3850: I get the impression that some developers here are using gcc 3.4. This one
only warns you about possibly uninitialized variables if you have at least
-O1.
Volker Lendecke [Thu, 18 Nov 2004 12:19:16 +0000 (12:19 +0000)]
r3844: Attempt to get the build farm in line. Some systems seem to have defined
rewinddir as a macro and don't like the construct to call a function pointer
called rewinddir. Work around by renaming the function pointer...
Jeremy Allison [Wed, 17 Nov 2004 21:05:47 +0000 (21:05 +0000)]
r3823: Fix bug reported by Tom Dickson <tdickson@inostor.com> with
follow symlinks = no reporting an incorrect error when it should
be access denied.
Jeremy.
Jeremy Allison [Wed, 17 Nov 2004 20:05:31 +0000 (20:05 +0000)]
r3819: Updated config.guess/config.sub from
ftp://ftp.gnu.org/pub/gnu/config/config.guess
ftp://ftp.gnu.org/pub/gnu/config/config.sub
as requested in bugid #2048.
Jeremy.
Jeremy Allison [Wed, 17 Nov 2004 18:56:48 +0000 (18:56 +0000)]
r3816: Added fn to remove an ACL from a file. Now need client code to test this.
How do the share mask/modes fit into this code... Need to think about this.
Jeremy.
Volker Lendecke [Wed, 17 Nov 2004 15:56:47 +0000 (15:56 +0000)]
r3811: Believe it or not, but this patch seems to be necessary. If someone sets a
folder icon in the start menu and saves the profile on a samba server, after
logging in again this setting is gone. Why is this? The folder for which the
icon is set must have the read only flag set. If it is not set, the
desktop.ini file (the file containing the icon reference) inside that folder
is ignored.
lp_profile_acls is a hack for such a situation, so overload this parameter
with another profile-related hack.
Jeremy Allison [Wed, 17 Nov 2004 01:35:35 +0000 (01:35 +0000)]
r3794: Added set posix acl functionality into the UNIX extensions code.
One part missing - delete file acl (to be added asap). No client
code yet, also needs testing with valgrind.
Jeremy.
Gerald Carter [Tue, 16 Nov 2004 03:27:19 +0000 (03:27 +0000)]
r3778: BUG 2023: patch from Buchan Milne <bgmilne@mandrake.org> fix mandrake packaging for Samba 3.0.9 -- still need to review this libsmbclient install location
Jeremy Allison [Mon, 15 Nov 2004 23:03:37 +0000 (23:03 +0000)]
r3776: Fix for bug #2038 from Johann Hanne <jhml@gmx.net>. Don't check
for no groups after every lookup - move check to the end as we should
only fail if all lookups fail.
Jeremy.
Volker Lendecke [Mon, 15 Nov 2004 13:18:12 +0000 (13:18 +0000)]
r3758: Increase a debug level. This error condition can actually happen in real life
if you have several competing winbinds that might get a lag due to
replication.
Jim McDonough [Sun, 14 Nov 2004 03:12:46 +0000 (03:12 +0000)]
r3727: Update from Rob Foehl (rwf@loonybin.net):
Try modifying printer before adding it,since add logic appends ObjectClass to mods, which caused a contraint violation when modifying an already published printer.
Also cleanup the check_published_printers() logic when verifying published status on startup.
Jeremy Allison [Fri, 12 Nov 2004 23:42:12 +0000 (23:42 +0000)]
r3713: Implementation of get posix acls in UNIX extensions. Passes valgrind.
Need to add printout functions in client and set posix acl in server.
SteveF - take a look at this for the cifsfs client !
Once this is working and tested the next step is to write this up for
the UNIX extensions spec. documents.
Jeremy.
Volker Lendecke [Fri, 12 Nov 2004 15:49:47 +0000 (15:49 +0000)]
r3705: Nobody has commented, so I'll take this as an ack...
abartlet, I'd like to ask you to take a severe look at this!
We have solved the problem to find the global groups a user is in twice: Once
in auth_util.c and another time for the corresponding samr call. The attached
patch unifies these and sends them through the passdb backend (new function
pdb_enum_group_memberships). Thus it gives pdb_ldap.c the chance to further
optimize the corresponding call if the samba and posix accounts are unified by
issuing a specialized ldap query.
The parameter to activate this ldapsam behaviour is
Volker Lendecke [Fri, 12 Nov 2004 15:30:51 +0000 (15:30 +0000)]
r3704: Implement a cache get saves the result of a pdb_getsampwnam for later
retrieval by pdb_getsampwsid. This solves our problem that we do lots of calls
to LDAP during a typical XP login. XP does a lookupnames, then an openuser and
some queryinfo stuff. Lookupnames triggers the initial getsampwnam, and all
the subsequent ones make us call getsampwsid. This patch gets this down to one
call to LDAP.
Yes, a more "correct" way would be to stick the information to the open user
handle, but this one is simpler and saves the LDAP roundtrip for the openuser
call.
Jeremy Allison [Wed, 10 Nov 2004 23:43:52 +0000 (23:43 +0000)]
r3674: Stefan Esser <s.esser@e-matters.de> pointed out that the max data
value is only valid on the initial trans/trans2/nttrans request,
so if there are secondary requests we can't read it from them. Read
it from the initial request and pass as a parameter for those functions
that need it.
Jeremy.
Jeremy Allison [Tue, 9 Nov 2004 22:49:28 +0000 (22:49 +0000)]
r3642: Extend vfs to add seekdir/telldir/rewinddir. Yes I know I have to
fix the modules too... First step in fixing out large directories
problem.
Jeremy.
Volker Lendecke [Fri, 5 Nov 2004 23:34:00 +0000 (23:34 +0000)]
r3566: Completely replace the queryuseraliases call. The previous implementation does
not exactly match what you would expect.
XP workstations during login actually do this, so we should better become a
bit more correct. The LDAP query issued is not really fully optimal, but it is
a lot faster and more correct than what was there before. The change in
passdb.h makes it possible that queryuseraliases is done with a single ldap
query.
Volker Lendecke [Fri, 5 Nov 2004 22:53:35 +0000 (22:53 +0000)]
r3563: During a typical logon a modern workstation makes a lot of anonymous session
setups on its way to open a pipe. This gets rid of many round-trips to the
LDAP server during logon by setting up the server_info_guest once and not
asking the LDAP server and nss every time. Make sure that the ldap connection
is reopened in the child. (I did not look at the sql backends.)
Volker Lendecke [Fri, 5 Nov 2004 21:55:21 +0000 (21:55 +0000)]
r3561: Since we have tdb_reopen_all() after all forks, the local_pid logic is not
correct anymore. If we actually open the tdb before the fork, we end up
opening the tdb twice. Jerry, jra, this also happens in the locking and
printing subsystems. You might want to check it there (not that it actually
happens right now, but this gave me some confusion lately...).
Jeremy Allison [Thu, 4 Nov 2004 23:56:23 +0000 (23:56 +0000)]
r3535: Tidy up error reporting. Memory leak with MIT krb5 1.3.5 turns
out to be in the kerberos libraries, not in Samba. Now to test
with Heimdal.
Jeremy