utmpdump: cleanup file descriptor usage

 - don't support --follow for stdin at all
 - inotify based implementation closes the file, so don't close it in
   main() again

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: encourage users not to follow stdin

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

utmpdump: use inotify to when following file

Co-Author: Karel Zak <kzak@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>

utmpdump: fixes based on static analysis [cppcheck]

[utmpdump.c:82]: (style) The function 'unspace' is never used
[utmpdump.c:131]: (style) The scope of the variable 't' can be reduced
[utmpdump.c:167]: (warning) scanf without field width limits can crash with huge input data

[kzak@redhat.com: - don't use scanf field width limits for integers]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

fix buffer overrun in some calls to sscanf

Reported-by: Sergei Antonov <saproj@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: white space fix

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

docs: clean up utmpdump.1 manual

Align with Documentation/howto-man-page.txt

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Conflicts:

login-utils/utmpdump.1

libblkid: cleanup _attribute__ usage

Merge branch 'master' of https://github.com/dankamongmen/util-linux

docs: mention the required mount options for journaled version 2 quota

docs: add quota mount option support description for ext2

utmpdump: document optional filename argument

Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>

findmnt: fix typo in manpage

Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>

build-sys: ensure BUILD_CFDISK is always defined

This avoids an error when configuring without ncurses:

configure: error: conditional "BUILD_CFDISK" was never defined.
Usually this means the macro was only invoked conditionally.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

docs: remove unused config/texinfo.tex

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: fix typos found by misspellings

The tool misspellings (https://github.com/lyda/misspell-check)
detected several typos. Command used:

  $ git ls-files | grep -v ^po/ | misspellings -f -

* Documentation/releases/v2.18-ReleaseNotes: Fix typo in news entry.
* NEWS: Likewise.
* config/texinfo.tex: Fix typo in comments.
* libmount/src/context.c: Fix typo in comment.
* libmount/src/fs.c: Likewise.
* login-utils/login.c: Likewise.
* login-utils.su.1: Fix typo in man page.
* sys-utils/chcpu.c: Fix typo in error message.

Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>

build-sys: add -Wredundant-decls

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: support separate libintl

Addresses: https://github.com/karelzak/util-linux/pull/13
Reported-by: Ben Walton <bwalton@artsci.utoronto.ca>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: always use default $(LDADD)

The global variable $(LDADD) is always used if program_LDADD is
not specified. Let's use $LDADD everywhere to avoid exceptions for
people who need to specify global $LDADD.

Signed-off-by: Karel Zak <kzak@redhat.com>

use proper printf format spec %lu

use memcpy() to cope with possible misalignment

properly check for ansi c99 vsnprint truncation

use GCC format __attribute__ on sprinf

hwclock: don't set time for --systz

Not sure why, but the current --systz uses non-NULL timeval for
settimeofday(). It means that build-in kernel warp clock mechanism is
not used and the system time is always modified.

The built-in kernel implementation allows to move the clock by
timezone only for very first settimeofday() call.

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: use xalloc.h, minor coding style changes

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: cleanup usage()

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: add long options

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: use err.h stuff

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: add NLS and closestream support

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: remove dead code

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: remove libc5 support

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: cleanup comments, funcs definition lines

Signed-off-by: Karel Zak <kzak@redhat.com>

utmpdump: new command, merge from sysvinit

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: add TID column

just in case we read from more mountinfo files.

For example get mountpoint from the current namespace which is invisible
for initd (PID=1):

 # unsahre -m bash
 # mount /dev/sdb /mnt/test
 # echo $$
 30070

 # findmnt -n -o TARGET,TID,SOURCE --task 1 --task $$ | \
      sort -u --key=1,1 | awk ' ($2 != 1) { print $0 }'

 /mnt/test                  30070 /dev/sdb

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: save task ID for mountinfo tiles

Add new function mnt_fs_get_tid() to get task ID for the given filesystem.

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: add --task <tid> option

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: don't use tree-like output if more -F options specified

Signed-off-by: Karel Zak <kzak@redhat.com>

findmnt: add FSROOT column

Provide this separately in an unambiguous format, mainly to avoid the
need for scripts to parse the source of a btrfs subvol or bind mount.

Signed-off-by: Dave Reisner <dreisner@archlinux.org>

swapon: fix typo

Reported-by: Manan Tuli <mt_void@yahoo.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add note about non-recursive build-sys

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add sd-daemon.h to Makemodule.am

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add pager.h to Makemodule.am

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: fix swaplabel

Reported-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: create static uuid_generate_*.3 files

It seems more simple to create small three files with man page links
than generate the files on the fly.

Note that the libuuid/man directory is not in builddir by default so
you have to create proper directory and then create the man pages...
too complex task for this three tiny files.

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: enable libmount and libblkid docs

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: cleanup .gitignore files

 - move all binaries to top-level .gitignore
 - remove unnecessary */.gitignore files

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert lib/ to libcommon.la

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: remove include-Makefile.am

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: rename fdisk -> fdisks/, convert to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert tests/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move partx to disk-utils/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert disk-utils/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move getopt to misc-utils/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert misc-utils/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: move hwclock to sys-utils/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert sys-utils/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

tools: cleanup config-gen.d

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: cleanup mount stuff in configure.am

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add UL_CONFLICTS_BUILD m4 macro

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: (old) remove hybrid libmount code

The hybrid version with old mount and new mtab management from
libmount is not more supported.

Only two versions are supported:

  1/ old mount in mount-deprecated/, --enable-deprecated-mount

  2/ new sys-utils/mount.c, enabled by default

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: default to new sys-utils/mount.c, add --enable-deprecated-mount

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: (old) remove mtab lock test

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert mount/ to module, rename to mount-deprecated/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert login-utils/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert term-utils/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert text-utils/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert libmount/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert libblkid/ to module

 - create module
 - remove unused libblkid/src/tst_types.c test

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert libuuid/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert schedutils/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: define per-test -DTEST_PROGRAM in lib/

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert lib/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: convert include/ to module

Signed-off-by: Karel Zak <kzak@redhat.com>

build-system: enable automake subdir-objects

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: ignore .dirstamp file

Signed-off-by: Karel Zak <kzak@redhat.com>

whereis: cleanup man page, add note about $PATH

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=835211
Signed-off-by: Karel Zak <kzak@redhat.com>

tunelp: check fstat return code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: check sysfs_read_u64 return code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

swaplabel: check blkid_probe_lookup_value() result [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

script: remove unused code

Signed-off-by: Karel Zak <kzak@redhat.com>

agetty: more robust debug() macro, check ioctl result [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lsblk: check ioctl result [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add lscpu test for box with 64 CPUs

Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                64
On-line CPU(s) list:   0-63
Thread(s) per core:    2
Core(s) per socket:    8
Socket(s):             4
Vendor ID:             GenuineIntel
...

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/loopdev: use warn_unused_result forimportant functions

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/sysfs: use warn_unused_result for sysfs_init()

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/mangle: fix a memory leak in the test case

Marek reported there is a memory leak in lib/mangle.c

  CC       mangle.o
mangle.c:160:9: warning: Memory is never released; potential leak of memory pointed to by 'ss'

This patch fixes it.

Reported-by: Marek Otahal <markotahal@gmail.com>
Cc: Karel Zak <kzak@redhat.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>

lib/sysfs: check if cxt->dir_path is NULL in sysfs_readlink()

cxt->dir_path could be NULL, for example, when sysfs_init() fails,
check this before calling readlink()/readlink_at().

Cc: Karel Zak <kzak@redhat.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>

fdisk: add some debug messages

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: use memset() rather than bzero()

Signed-off-by: Karel Zak <kzak@redhat.com>

fdisk: API: add geometry

Add device geometry to the fdisk API. While it maintains traditional behaviour, the cylinders
are changed to sector_t instead of unsigned int in order to avoid dealing with truncated cylinders.
A new helper is added to compute the amount of cylinders based on the heads and sectors - if a user passed
-H or -S to the program, it must call this function to update the corresponding values.

This patch passes regression tests.

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: mark dos compatibility/CHS options deprecated in manpage

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: sun: remove unused function

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: sgi: remove unused function

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: sgi: remove unused code

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: tests: update oddinput test

Adding mbr to the API breaks this test, specifically when reading the first 512 bytes
of the MBR, update the expected output for oddinput.toosmall. Also let the test create
and remove the test file instead of having it in the expected directory.

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: API: add mbr

This patch adds to the fdisk API the relevant logic to buffers that have MBR. This also serves for
future GPT support for the protective MBR. All labels have been updated to have access to the cxt
structure for the corresponding buffer.

An important observation is that SGI no longer uses the standard qsort(3) function to sort partitions,
as it needs access to cxt. To address this, a heap sort implementation from the kernel was added to
the label code and adapted to fdisk.

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: API: add topology debug

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

fdisk: extend comments for fdisk_new_context()

Signed-off-by: Davidlohr Bueso <dave@gnu.org>

lsblk: fix usage, improve exclude/include lists parsing

Reported-by: Bernhard Voelker <mail@bernhard-voelker.de>
Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: improve ifdef HAVE_LIBSELINUX stuff

Signed-off-by: Karel Zak <kzak@redhat.com>