]> git.ipfire.org Git - thirdparty/sqlite.git/log
thirdparty/sqlite.git
9 years agoClang can define _MSC_VER in some circumstances; therefore, check for Clang first. ctimeCompiler
mistachkin [Sat, 28 May 2016 00:13:21 +0000 (00:13 +0000)] 
Clang can define _MSC_VER in some circumstances; therefore, check for Clang first.

FossilOrigin-Name: 3f710bc3617691fa7432a24f1410d4651ca181b6

9 years agoCheck for Clang before GCC.
mistachkin [Fri, 27 May 2016 21:13:43 +0000 (21:13 +0000)] 
Check for Clang before GCC.

FossilOrigin-Name: 7c2cd4b05f88a759bdf72d3a249db5984fd7105d

9 years agoRemove surplus quotation marks from the COMPILER= compile_options setting for Clang.
mistachkin [Fri, 27 May 2016 20:30:02 +0000 (20:30 +0000)] 
Remove surplus quotation marks from the COMPILER= compile_options setting for Clang.

FossilOrigin-Name: 5c966f200018043f5258eb03e043bb25c7766131

9 years agoRemove surplus quotation marks from the COMPILER= compile_options setting
drh [Fri, 27 May 2016 19:34:29 +0000 (19:34 +0000)] 
Remove surplus quotation marks from the COMPILER= compile_options setting
for GCC.

FossilOrigin-Name: 664c132dabe4a871d5c39c11b339f871ca3a5d31

9 years agoAdd basic compiler information to the results of 'PRAGMA compile_options'.
mistachkin [Fri, 27 May 2016 18:09:45 +0000 (18:09 +0000)] 
Add basic compiler information to the results of 'PRAGMA compile_options'.

FossilOrigin-Name: d734e2df40d95da74ce0c8dd2da1c14033cad8bb

9 years agoImprovements to WHERE-clause debug tracing. Show TK_MATCH expressions and
drh [Fri, 27 May 2016 12:30:20 +0000 (12:30 +0000)] 
Improvements to WHERE-clause debug tracing.  Show TK_MATCH expressions and
show more details on WhereTerm traces.

FossilOrigin-Name: 71087c12bc75a82f5d1051600a442ef6efc5e899

9 years agoFix Lemon so that it actually works with -DYYSTACKDEPTH=0.
drh [Fri, 27 May 2016 04:10:47 +0000 (04:10 +0000)] 
Fix Lemon so that it actually works with -DYYSTACKDEPTH=0.

FossilOrigin-Name: a9be4c2d56d08fea2cd1aab20b19092a45ef7620

9 years agoFix the Lemon-generated parser so that it compiles with -DYYSTACKDEPTH=0.
drh [Fri, 27 May 2016 01:07:18 +0000 (01:07 +0000)] 
Fix the Lemon-generated parser so that it compiles with -DYYSTACKDEPTH=0.
It does compile now, but there are subtle issues still.

FossilOrigin-Name: 28d439f816d2fa5263e1c4ddecf3bf1ac2dd6549

9 years agoAdd a new OP_SeekRowid opcode, that combines the functions of OP_MustBeInt
drh [Thu, 26 May 2016 20:56:38 +0000 (20:56 +0000)] 
Add a new OP_SeekRowid opcode, that combines the functions of OP_MustBeInt
and OP_NotExists.  This makes the code slightly smaller and faster.

FossilOrigin-Name: ffe80a1bfa014943a614fc6993c1749b9bfec4c1

9 years agoAdd the libvers.c tool in the tool/ subdirectory.
drh [Wed, 25 May 2016 18:53:39 +0000 (18:53 +0000)] 
Add the libvers.c tool in the tool/ subdirectory.

FossilOrigin-Name: 2a41f098b2f0523b3d7e6eba6ae91cc0d30752df

9 years agoEnhance Lemon and the parser template so that it can once again build parsers
drh [Tue, 24 May 2016 18:55:08 +0000 (18:55 +0000)] 
Enhance Lemon and the parser template so that it can once again build parsers
that have no unreachable branches.

FossilOrigin-Name: 41fd46e2962ba9a1e1f6867567499d1f6f5b8372

9 years agoMinor change to the walcrash4.test module so that it works when
drh [Tue, 24 May 2016 18:50:41 +0000 (18:50 +0000)] 
Minor change to the walcrash4.test module so that it works when
SQLITE_DEFAULT_WAL_SYNCHRONOUS is set to something other than 2.

FossilOrigin-Name: 61e239bc4310eff172e1e50d51522ecc75dd997e

9 years agoFix an obscure problem with transactions written in "PRAGMA synchronous=full" mode...
dan [Tue, 24 May 2016 16:20:51 +0000 (16:20 +0000)] 
Fix an obscure problem with transactions written in "PRAGMA synchronous=full" mode on systems that do not support POWERSAFE_OVERWRITE causing an xSync() call to be omitted if the last frame written by a transaction is aligned to a sector boundary. This means that if a power failure or OS crash occurs very soon after such a transaction is committed, it may be lost following system recovery.

FossilOrigin-Name: 37de3eab67f12ae1ce5bc8d5e541c64fc6b1fd80

9 years agoImprovements to the initialization of the push-down automoton for the
drh [Tue, 24 May 2016 00:40:54 +0000 (00:40 +0000)] 
Improvements to the initialization of the push-down automoton for the
Lemon-generated parser.  Smaller and faster.

FossilOrigin-Name: 3b28b68e232060f8b2fe2fe6fa478280da2006ff

9 years agoUse a pointer to the top of the stack rather than an index into the stack
drh [Mon, 23 May 2016 21:56:24 +0000 (21:56 +0000)] 
Use a pointer to the top of the stack rather than an index into the stack
in the Lemon-generated parser template, for about 6.6% parser performance gain.

FossilOrigin-Name: 3c2a770549d5bb65fcd6cc684e0a0ae6d641ac68

9 years agoAvoid a minor error message when running RTREE without an sqlite_stat1 table.
drh [Mon, 23 May 2016 19:02:58 +0000 (19:02 +0000)] 
Avoid a minor error message when running RTREE without an sqlite_stat1 table.

FossilOrigin-Name: 276e92f5b4c1ee49eabb738b24d73d7af90fb13c

9 years agoFix the rtreeG.test test case. tree-stat1-fix
drh [Mon, 23 May 2016 18:27:07 +0000 (18:27 +0000)] 
Fix the rtreeG.test test case.

FossilOrigin-Name: 9589e9377118efc356c73ea1aab2d7e6c2f7fc36

9 years agoFix RTREE so that it does not run queries against the sqlite_stat1 if that
drh [Mon, 23 May 2016 18:12:04 +0000 (18:12 +0000)] 
Fix RTREE so that it does not run queries against the sqlite_stat1 if that
table does not exist.

FossilOrigin-Name: 48526a2fe5373e3d19e8b813cc8a342d6b7c9c3d

9 years agoRemove an extra "finish_test" from the end of rtreeC.test.
drh [Mon, 23 May 2016 18:06:51 +0000 (18:06 +0000)] 
Remove an extra "finish_test" from the end of rtreeC.test.

FossilOrigin-Name: bfbb6dd84b5e1335e1eae857a03fa33a71fd67a5

9 years agoImprove the error messages generated by the rtree module when a constraint fails.
dan [Mon, 23 May 2016 16:16:13 +0000 (16:16 +0000)] 
Improve the error messages generated by the rtree module when a constraint fails.

FossilOrigin-Name: 3ad2531efb64b7c53b777ddf3681203217052b32

9 years agoLemon enhancement: avoid unnecessary reduce actions that convert one
drh [Mon, 23 May 2016 16:15:02 +0000 (16:15 +0000)] 
Lemon enhancement: avoid unnecessary reduce actions that convert one
non-terminal into another but have no side effects.

FossilOrigin-Name: a86e782ad1aa6f5a8b2c54f9dcf0fa61960843f3

9 years agoFix comment typos and improve clarity of presention in Lemon. The output
drh [Mon, 23 May 2016 14:24:31 +0000 (14:24 +0000)] 
Fix comment typos and improve clarity of presention in Lemon.  The output
should be identical.

FossilOrigin-Name: b91a5b8297756289d45c8fce0d3399c253517eb0

9 years agoUpdate the configure script with additional hints on the location of
drh [Mon, 23 May 2016 00:10:58 +0000 (00:10 +0000)] 
Update the configure script with additional hints on the location of
tclConfig.sh, hints needed by the latest versions of Xcode.

FossilOrigin-Name: 90411a28168f6dacf08242a25bed7d6269041417

9 years agoMore tweaks to improve the performance of the insert logic, slightly.
drh [Sat, 21 May 2016 23:25:29 +0000 (23:25 +0000)] 
More tweaks to improve the performance of the insert logic, slightly.

FossilOrigin-Name: dec1307581216e01ad508ffe4455b957e3356654

9 years agoSimplify the sqlite3BtreeInsert() interface by gathering the five arguments
drh [Sat, 21 May 2016 20:03:42 +0000 (20:03 +0000)] 
Simplify the sqlite3BtreeInsert() interface by gathering the five arguments
describing the content to be inserted into the new BtreePayload structure, and
thus reducing the number of parameters from eight to four.

FossilOrigin-Name: 55f348cdd24c7812ea4b63345514764b69f64dc8

9 years agoRemove some unused legacy code from the btree insert logic.
drh [Sat, 21 May 2016 19:10:21 +0000 (19:10 +0000)] 
Remove some unused legacy code from the btree insert logic.

FossilOrigin-Name: 2ce1166717ac3c0cec37b2f6d70d8359fbaefc71

9 years agoYet another minor size reduction and performance increase in the b-tree
drh [Sat, 21 May 2016 12:29:04 +0000 (12:29 +0000)] 
Yet another minor size reduction and performance increase in the b-tree
insert logic.

FossilOrigin-Name: 1dbaf7a119edc5150a5d4be1b72f652a574e5bc5

9 years agoSmall size reduction and performance increase in the sqlite3BtreeInsert()
drh [Sat, 21 May 2016 11:23:26 +0000 (11:23 +0000)] 
Small size reduction and performance increase in the sqlite3BtreeInsert()
logic.

FossilOrigin-Name: 656aa1ecf5129ae43c56a990e95038b5d8cbdcee

9 years agoAdd the shell-script used for routine performance testing.
drh [Sat, 21 May 2016 00:45:54 +0000 (00:45 +0000)] 
Add the shell-script used for routine performance testing.

FossilOrigin-Name: 8e366f18f5bbd594390e7b091083e99639de324e

9 years agoAdd a simple TCL script for summing cachegrind information for each VDBE
drh [Fri, 20 May 2016 23:51:14 +0000 (23:51 +0000)] 
Add a simple TCL script for summing cachegrind information for each VDBE
opcdoe.

FossilOrigin-Name: 96cf821b6a69e2e8df33271b7bb674bd12a1ef7b

9 years agoAnother optimization on the OP_Column opcode.
drh [Fri, 20 May 2016 21:40:11 +0000 (21:40 +0000)] 
Another optimization on the OP_Column opcode.

FossilOrigin-Name: 1765672c2599eb03d39c52cd2dc32ea1e5ee069e

9 years agoFix typo in comment.
mistachkin [Fri, 20 May 2016 20:58:30 +0000 (20:58 +0000)] 
Fix typo in comment.

FossilOrigin-Name: 9db8f2147339ba519c4ec32e34068e9f4a25e099

9 years agoSlight performance improvement in the OP_Column opcode.
drh [Fri, 20 May 2016 19:51:28 +0000 (19:51 +0000)] 
Slight performance improvement in the OP_Column opcode.

FossilOrigin-Name: 5c157474391f90f24e8867c77fbc6564c7955ecc

9 years agoRemove the sqlite3PagerClearCache() routine, which does not accomplish anything
drh [Fri, 20 May 2016 18:09:01 +0000 (18:09 +0000)] 
Remove the sqlite3PagerClearCache() routine, which does not accomplish anything
useful.

FossilOrigin-Name: f250166bb3c1b0c58e703b334825cf6210758fda

9 years agoPerformance optimization and size reduction on the freeP4() routine.
drh [Fri, 20 May 2016 15:53:47 +0000 (15:53 +0000)] 
Performance optimization and size reduction on the freeP4() routine.

FossilOrigin-Name: 4dc56e8684e0c74fb311c7f0ef1c367da8c7bf70

9 years agoIncrease the version number to 3.14.0 since we are already making significant
drh [Fri, 20 May 2016 15:24:14 +0000 (15:24 +0000)] 
Increase the version number to 3.14.0 since we are already making significant
code changes.

FossilOrigin-Name: 1a0d05765fa2e69ccd4c98782cf9f5c5b2897719

9 years agoUse sqlite3VdbeAddOp0() to code OP_Expire, to save a few bytes.
drh [Fri, 20 May 2016 15:15:07 +0000 (15:15 +0000)] 
Use sqlite3VdbeAddOp0() to code OP_Expire, to save a few bytes.

FossilOrigin-Name: 3d55d24dcb27f07d1e645738ee4707e4df923036

9 years agoOptimizations to link list merge sort code in vdbesort.c, pcache.c, and
drh [Fri, 20 May 2016 14:54:54 +0000 (14:54 +0000)] 
Optimizations to link list merge sort code in vdbesort.c, pcache.c, and
rowset.c.  Resulting binaries are 10 bytes smaller and use 0.03% fewer CPU
cycles.

FossilOrigin-Name: 9033afbb31b28a8ad6856ac1f773d8e83bc9ec1c

9 years agoFor queries with both ORDER BY and LIMIT, if the rows of the inner loop are
drh [Fri, 20 May 2016 14:11:37 +0000 (14:11 +0000)] 
For queries with both ORDER BY and LIMIT, if the rows of the inner loop are
emitted in ORDER BY order and the LIMIT has been reached, then optimize by
exiting the inner loop and continuing with the next cycle of the first outer
loop.

FossilOrigin-Name: 559733b09e9630fac9d9318a7ecbaba9134e9160

9 years agoSet the NULLEQ flag on the sequence counter comparison in the ORDER BY LIMIT orderby-limit
drh [Fri, 20 May 2016 13:44:58 +0000 (13:44 +0000)] 
Set the NULLEQ flag on the sequence counter comparison in the ORDER BY LIMIT
optimization, to avoid coverage complaints about not testing the NULL case.

FossilOrigin-Name: ed1b30dc932a7c03e173b130c5f55f9989c7e0b4

9 years agoAutoconf configure.ac adjustment to try to get it to look for both editline
drh [Fri, 20 May 2016 12:22:16 +0000 (12:22 +0000)] 
Autoconf configure.ac adjustment to try to get it to look for both editline
and readline automatically.

FossilOrigin-Name: 645bd696dfd86d8c93080f6ebfddbc9639ec088b

9 years agoA few simple test cases for the ORDER BY LIMIT optimization.
drh [Fri, 20 May 2016 00:21:42 +0000 (00:21 +0000)] 
A few simple test cases for the ORDER BY LIMIT optimization.

FossilOrigin-Name: 08849eab0f6ef29eaf6d2ce9c692de9b953dbd27

9 years agoAppears to work now. Needs test cases, more comments, and code optimization.
drh [Thu, 19 May 2016 22:40:04 +0000 (22:40 +0000)] 
Appears to work now.  Needs test cases, more comments, and code optimization.

FossilOrigin-Name: 990fe50c9182f74c9b54a12602c4c30d891273e6

9 years agoIn a query with both ORDER BY and LIMIT, if the inner loop satisfies the
drh [Thu, 19 May 2016 22:13:37 +0000 (22:13 +0000)] 
In a query with both ORDER BY and LIMIT, if the inner loop satisfies the
ORDER BY then try to cut short each invocation of the inner loop once the
LIMIT has been satisfied.  This check-in is a partial implementation only.

FossilOrigin-Name: 852d1eda6ecca1171f6ed800b06f5b4854672002

9 years agoFixup comments on wctrlFlags value definitions.
drh [Thu, 19 May 2016 19:31:30 +0000 (19:31 +0000)] 
Fixup comments on wctrlFlags value definitions.

FossilOrigin-Name: 58b516e8c0b00a41bc0364eab267bc2ecb9efeff

9 years agoClean up the WHERE_* macros used for the wctrlFlags parameter on the
drh [Thu, 19 May 2016 18:56:33 +0000 (18:56 +0000)] 
Clean up the WHERE_* macros used for the wctrlFlags parameter on the
sqlite3WhereBegin() interface, freeing up some bits to be used for other things.

FossilOrigin-Name: d01305841da94b2d47e32744802f69525bf590df

9 years agoOptimization marks in vdbe.c. No logic changes.
drh [Thu, 19 May 2016 17:51:19 +0000 (17:51 +0000)] 
Optimization marks in vdbe.c.  No logic changes.

FossilOrigin-Name: cf2737415aff7de7e133da174b645324c99d5758

9 years agoPerformance improvement in the OP_Column opcode.
drh [Thu, 19 May 2016 16:58:42 +0000 (16:58 +0000)] 
Performance improvement in the OP_Column opcode.

FossilOrigin-Name: 4737cadc414c5f6d256fcceacb19d80d66a8c8e7

9 years agoAdd test cases to test some fts3/4 edge case behaviour surrounding the '*' character.
dan [Thu, 19 May 2016 16:21:30 +0000 (16:21 +0000)] 
Add test cases to test some fts3/4 edge case behaviour surrounding the '*' character.

FossilOrigin-Name: 1f577e1f08159aeaaf19a7020d9004dd6103d57b

9 years agoSmall size reduction and performance improvement in the OP_Column opcode.
drh [Thu, 19 May 2016 11:12:43 +0000 (11:12 +0000)] 
Small size reduction and performance improvement in the OP_Column opcode.

FossilOrigin-Name: 0d7730611be974162d9a064a041957d04d55b6d3

9 years agoAdd the "scrub" utility program that simultaneously backs-up a live database
drh [Wed, 18 May 2016 21:03:27 +0000 (21:03 +0000)] 
Add the "scrub" utility program that simultaneously backs-up a live database
and erases all deleted content.

FossilOrigin-Name: c981ab2a4771f8c5e95e2e85e37a02a4bd0e36ee

9 years agoOmit the unnecessary WHERE_REOPEN_IDX flag in the WHERE interface.
drh [Wed, 18 May 2016 21:01:27 +0000 (21:01 +0000)] 
Omit the unnecessary WHERE_REOPEN_IDX flag in the WHERE interface.

FossilOrigin-Name: 915416d15f43c4e1d3afa8121bb6fa09f9f67e30

9 years agoVersion 3.13.0 version-3.13.0
drh [Wed, 18 May 2016 10:57:30 +0000 (10:57 +0000)] 
Version 3.13.0

FossilOrigin-Name: fc49f556e48970561d7ab6a2f24fdd7d9eb81ff2

9 years agoEnhance the scrub utility program so that it does a FULL checkpoint prior to scrub-backup
drh [Tue, 17 May 2016 21:17:51 +0000 (21:17 +0000)] 
Enhance the scrub utility program so that it does a FULL checkpoint prior to
starting the backup, to ensure that the database file content matches what needs
to be backed up without having to look at the WAL file.

FossilOrigin-Name: ab1c5ce50f139070d7a322f43132a93c8af2ed68

9 years agoMerge the latest changes from trunk.
drh [Tue, 17 May 2016 17:11:21 +0000 (17:11 +0000)] 
Merge the latest changes from trunk.

FossilOrigin-Name: 5021dfe1f3f723a5938d547a0308f1d63103702d

9 years agoDo not run snapshot_fault.test as part of the inmemory_journal permutation.
dan [Mon, 16 May 2016 14:35:15 +0000 (14:35 +0000)] 
Do not run snapshot_fault.test as part of the inmemory_journal permutation.

FossilOrigin-Name: 995c084bde44e678facc5f5d95a2335ce61e57b0

9 years agoDisable shell.exe test cases for UTF8 filenames as they do not work on MinGW.
drh [Mon, 16 May 2016 11:55:09 +0000 (11:55 +0000)] 
Disable shell.exe test cases for UTF8 filenames as they do not work on MinGW.

FossilOrigin-Name: 386bcbba8ed733ee84958e6bd6e9d33c150e6c18

10 years agoImprovements to a comment in the pcache.c file. No changes to code.
drh [Fri, 13 May 2016 17:22:33 +0000 (17:22 +0000)] 
Improvements to a comment in the pcache.c file.  No changes to code.

FossilOrigin-Name: b369980f0c4550a9034833caa2c7c85d6030f5ff

10 years agoRemove the unused PGHDR_NEED_READ flag. Add invariant checking (during
drh [Fri, 13 May 2016 15:22:06 +0000 (15:22 +0000)] 
Remove the unused PGHDR_NEED_READ flag.  Add invariant checking (during
SQLITE_DEBUG builds only) for the PgHdr object.

FossilOrigin-Name: 771c5411e9ebcad00fb4b97556b519488284b87b

10 years agoClarification of the pagerFlushOnCommit() logic.
drh [Fri, 13 May 2016 12:12:38 +0000 (12:12 +0000)] 
Clarification of the pagerFlushOnCommit() logic.

FossilOrigin-Name: 3401d9dcdbec390564574e8d2972c944c204e025

10 years agoFix pager_end_transaction() to ensure that a ROLLBACK does not clobber
drh [Fri, 13 May 2016 11:50:00 +0000 (11:50 +0000)] 
Fix pager_end_transaction() to ensure that a ROLLBACK does not clobber
unwritten pages in a TEMP file pcache.

FossilOrigin-Name: 9495d33879221c1821331dc72c61a6a3d182f526

10 years agoAdditional debugging and tracing logic for pcache.c, turned off by default
drh [Fri, 13 May 2016 04:24:25 +0000 (04:24 +0000)] 
Additional debugging and tracing logic for pcache.c, turned off by default
using an "#if 0".

FossilOrigin-Name: 32a62e3bd46cf58586617d3f8b1a971c91df205e

10 years agoDisable ALWAYS and NEVER when compiled with SQLITE_MUTATION_TEST.
drh [Thu, 12 May 2016 19:17:09 +0000 (19:17 +0000)] 
Disable ALWAYS and NEVER when compiled with SQLITE_MUTATION_TEST.

FossilOrigin-Name: 24d9fbc1d0f99b90577ecd6edcd3bc1abc76633f

10 years agoSimplification of the sqlite3FaultSim() call inside of
drh [Thu, 12 May 2016 19:05:35 +0000 (19:05 +0000)] 
Simplification of the sqlite3FaultSim() call inside of
sqlite3PagerCommitPhaseOne().

FossilOrigin-Name: 1b0f4cc362cda1dc175aa363ae4e612b7d1164c3

10 years agoAdd an assert in pager.c to confirm that pPager->tempFile is always true
drh [Thu, 12 May 2016 18:38:45 +0000 (18:38 +0000)] 
Add an assert in pager.c to confirm that pPager->tempFile is always true
for in-memory databases.

FossilOrigin-Name: 3fd71092063bf1d30e03cf2497ea9c57b3ec82eb

10 years agoAdd extra OPTIMIZATION-IF-FALSE comments where required to pcache.c.
dan [Thu, 12 May 2016 17:06:04 +0000 (17:06 +0000)] 
Add extra OPTIMIZATION-IF-FALSE comments where required to pcache.c.

FossilOrigin-Name: 9d55b8f541de43deb82d460d32005fd62f5430b2

10 years agoFor in-memory databases, it does not matter if pcache entries are marked
drh [Thu, 12 May 2016 12:08:48 +0000 (12:08 +0000)] 
For in-memory databases, it does not matter if pcache entries are marked
"clean" or "writable".

FossilOrigin-Name: 06c1e27ca868f247f8c27b03eb19aac004f28650

10 years agoRemove an unnecessary call to sqlite3PcacheMakeClean() inside of the ROLLBACK
drh [Thu, 12 May 2016 12:01:20 +0000 (12:01 +0000)] 
Remove an unnecessary call to sqlite3PcacheMakeClean() inside of the ROLLBACK
logic.

FossilOrigin-Name: 0dc50d9915cd88916229ca5c3834de82fa16f017

10 years agoAdd a missing OPTIMIZATION-IF-FALSE comment to pcache.c.
dan [Thu, 12 May 2016 09:48:23 +0000 (09:48 +0000)] 
Add a missing OPTIMIZATION-IF-FALSE comment to pcache.c.

FossilOrigin-Name: bc202e5b418d5a57bfc766883c4417c94829d96e

10 years agoFor in-memory databases, it does not matter if pcache entries are marked pager-dev
drh [Wed, 11 May 2016 23:54:14 +0000 (23:54 +0000)] 
For in-memory databases, it does not matter if pcache entries are marked
"clean" or "writable".

FossilOrigin-Name: ad601c7962a60a11699cf31f1faee09b95d5c710

10 years agoRemove a redundant condition from pcache.c. Add an OPTIMIZATION-IF-TRUE comment to...
dan [Wed, 11 May 2016 20:03:23 +0000 (20:03 +0000)] 
Remove a redundant condition from pcache.c. Add an OPTIMIZATION-IF-TRUE comment to another condition that requires it.

FossilOrigin-Name: 3bfd2621d13b4f842f3af6d35519653f4eb8cad7

10 years agoRemove some a small amount of redundant code related to PCache.pSynced from pcache.c.
dan [Wed, 11 May 2016 15:41:15 +0000 (15:41 +0000)] 
Remove some a small amount of redundant code related to PCache.pSynced from pcache.c.

FossilOrigin-Name: 9cc8cad78fdfe044ad6726ebfe6909c1e242fa55

10 years agoDo not reset the page cache when a rollback journal truncate fails, as doing
drh [Wed, 11 May 2016 12:47:46 +0000 (12:47 +0000)] 
Do not reset the page cache when a rollback journal truncate fails, as doing
so can cause loss of information for an in-memory TEMP file.

FossilOrigin-Name: 345ce1c9f64f2a424663b4dfcbe4586d9df7bff6

10 years agoAlways truncate, rather than persist, the rollback journal of a TEMP database.
drh [Wed, 11 May 2016 11:04:17 +0000 (11:04 +0000)] 
Always truncate, rather than persist, the rollback journal of a TEMP database.

FossilOrigin-Name: 42fb6f1e99a6c31889819a0302679d598dc0ab1b

10 years agoAdd pcache tracing macros. Off by default. Requires changing an "#if 0"
drh [Wed, 11 May 2016 10:57:04 +0000 (10:57 +0000)] 
Add pcache tracing macros.  Off by default.  Requires changing an "#if 0"
and recompiling to enable.

FossilOrigin-Name: d9313d19c75a62f558b3df6b15595b15bbfa0b62

10 years agoAdd another test case to temptable3.test.
dan [Tue, 10 May 2016 20:16:43 +0000 (20:16 +0000)] 
Add another test case to temptable3.test.

FossilOrigin-Name: 223640243efc52c14bb2bb540833a2a624eaa41a

10 years agoFix a problem in sqlite3PagerMovepage() when working on a temp table for which
drh [Tue, 10 May 2016 20:03:08 +0000 (20:03 +0000)] 
Fix a problem in sqlite3PagerMovepage() when working on a temp table for which
pages have been spilled.

FossilOrigin-Name: 20cf8811caf705b482be100baecb3ef72aee2d5a

10 years agoFixes to requirements marks. No changes to code.
drh [Mon, 9 May 2016 23:11:47 +0000 (23:11 +0000)] 
Fixes to requirements marks.  No changes to code.

FossilOrigin-Name: 79ecd0ef20c12198e950a730871444a980a0f1b2

10 years agoEnhancements to test/sort5.test so that it works with SEE.
drh [Mon, 9 May 2016 22:35:06 +0000 (22:35 +0000)] 
Enhancements to test/sort5.test so that it works with SEE.

FossilOrigin-Name: 8a39c8ee49e6e80c83613546cf328801c80b7c4d

10 years agoRemove some forgotten debugging lines from test/sort5.test.
drh [Mon, 9 May 2016 22:32:18 +0000 (22:32 +0000)] 
Remove some forgotten debugging lines from test/sort5.test.

FossilOrigin-Name: f5875489810101c13a7917bde86e6a23b088e386

10 years agoOmit the unnecessary WHERE_REOPEN_IDX flag in the WHERE interface. dev
drh [Mon, 9 May 2016 19:58:56 +0000 (19:58 +0000)] 
Omit the unnecessary WHERE_REOPEN_IDX flag in the WHERE interface.

FossilOrigin-Name: da94a6e0ebacad8f235dcd653a25474327f26137

10 years agoUpdate a comment in fts5.h. No changes to code.
dan [Mon, 9 May 2016 19:03:42 +0000 (19:03 +0000)] 
Update a comment in fts5.h. No changes to code.

FossilOrigin-Name: 14e53d0e2f62d82ae1d64a72fd9711548e3bf5ea

10 years agoFix the FTS5 xQueryPhrase() API function so that it recognizes column filters.
dan [Mon, 9 May 2016 18:05:44 +0000 (18:05 +0000)] 
Fix the FTS5 xQueryPhrase() API function so that it recognizes column filters.

FossilOrigin-Name: 48505cde05d74748454dc135d4ec25954ecf020e

10 years agoMake the sqlite3DeleteTable() routine smaller and faster.
drh [Sat, 7 May 2016 12:15:34 +0000 (12:15 +0000)] 
Make the sqlite3DeleteTable() routine smaller and faster.

FossilOrigin-Name: d75140b851a34a5eb66041e294e421628efbc5ba

10 years agoFix typo in the intpkey-17.2 test.
drh [Sat, 7 May 2016 12:15:15 +0000 (12:15 +0000)] 
Fix typo in the intpkey-17.2 test.

FossilOrigin-Name: a45fda657d987f5c923d141584841a6c62dfb504

10 years agoSimplification to the logic used to decide between OP_Seek and OP_NotExists.
drh [Fri, 6 May 2016 20:23:12 +0000 (20:23 +0000)] 
Simplification to the logic used to decide between OP_Seek and OP_NotExists.
Use OP_NotExists for both DELETE and UPDATE.

FossilOrigin-Name: 3a695263183303e3f64eb2320752d0fdef53eaf2

10 years agoCorrections to comments on the whereScanInit() interface.
drh [Fri, 6 May 2016 18:47:23 +0000 (18:47 +0000)] 
Corrections to comments on the whereScanInit() interface.

FossilOrigin-Name: ab7ab415d19524f6c3901e474d3a154f55d28530

10 years agoFor DELETE operations, make sure that seeks on the main table are not
drh [Fri, 6 May 2016 16:49:54 +0000 (16:49 +0000)] 
For DELETE operations, make sure that seeks on the main table are not
deferred, since if they are and none of the indexes reference columns of
the table, the seek might never occur until the OP_Delete opcode, which is
too late.  Fix for ticket [16c9801ceba49].

FossilOrigin-Name: 93a2bace5704f7ecad56541a6b3e06a88f7f393f

10 years agoFix an error in main.mk causing testfixture to use individual fts5 source code files...
dan [Fri, 6 May 2016 16:30:34 +0000 (16:30 +0000)] 
Fix an error in main.mk causing testfixture to use individual fts5 source code files instead of fts5.c.

FossilOrigin-Name: 933a1c818c1d1ccec8680e1ba87f2cbe37cc9f7d

10 years agoIn the WHERE generator, when building code for a DELETE operation, make sure ticket-16c9801ce
drh [Fri, 6 May 2016 16:06:59 +0000 (16:06 +0000)] 
In the WHERE generator, when building code for a DELETE operation, make sure
that seeks to the main table are not deferred.
This is a better fix for the [16c9801ceba49] bug than the previous.

FossilOrigin-Name: 150dd09ebd7b17234a79e1811a0fae8b0a7a40d5

10 years agoFix a bug in sqlite_analyzer causing it report (slightly) incorrect values for the...
dan [Fri, 6 May 2016 15:16:02 +0000 (15:16 +0000)] 
Fix a bug in sqlite_analyzer causing it report (slightly) incorrect values for the number of entries in indexes or WITHOUT ROWID tables.

FossilOrigin-Name: dc37750d4e87d0c529785adceeebd838b8f8591d

10 years agoDo not scan indexes that have the integer primary key as their left-most
drh [Fri, 6 May 2016 11:31:10 +0000 (11:31 +0000)] 
Do not scan indexes that have the integer primary key as their left-most
column.  This fixes the crash of ticket [16c9801ceba] but it seems like
the wrong fix.  More investigation needed.

FossilOrigin-Name: 50312273ffaf1bd4bfdc73865fa0b19166968429

10 years agoAdditional error reporting. Open the source database read/write so that
drh [Thu, 5 May 2016 23:59:22 +0000 (23:59 +0000)] 
Additional error reporting.  Open the source database read/write so that
it can delete the WAL file when done.

FossilOrigin-Name: d2efd3c176f0eba2d78105f0bb3161db38bd4bab

10 years agoWorking when run against sqlite.fossil.
drh [Thu, 5 May 2016 23:39:30 +0000 (23:39 +0000)] 
Working when run against sqlite.fossil.

FossilOrigin-Name: b0bd9dd6255be161ea289ba6caa3fbd568128f62

10 years agoFinished implementation compiles, but untested.
drh [Thu, 5 May 2016 23:09:57 +0000 (23:09 +0000)] 
Finished implementation compiles, but untested.

FossilOrigin-Name: aeb88bdf6fe9e5839b1503ab5740b27bc09d4842

10 years agoInitial check-in of the "scrub.exe" utility program prototype. Not yet
drh [Thu, 5 May 2016 17:15:23 +0000 (17:15 +0000)] 
Initial check-in of the "scrub.exe" utility program prototype.  Not yet
fully functional.  In particular, no scrubbing is done.

FossilOrigin-Name: bdf2ec77d1542d4e9b68218f558710a3efc15823

10 years agoRenumber internal constants in the printf() implemention for a small
drh [Thu, 5 May 2016 11:53:12 +0000 (11:53 +0000)] 
Renumber internal constants in the printf() implemention for a small
performance improvement.

FossilOrigin-Name: 69d11447f4b1a8c536c3b6573d2a3419da870412

10 years agoDisable the session extension API if SQLITE_ENABLE_SESSION is not defined.
drh [Wed, 4 May 2016 21:06:21 +0000 (21:06 +0000)] 
Disable the session extension API if SQLITE_ENABLE_SESSION is not defined.

FossilOrigin-Name: 71af9ac165ac02272f4886f69bd9ab4770fd7bb6

10 years agoFix typo in comment. No changes to code.
mistachkin [Wed, 4 May 2016 19:04:20 +0000 (19:04 +0000)] 
Fix typo in comment.  No changes to code.

FossilOrigin-Name: 6c43ba1c8753a4029e127078652f265c408a01c0

10 years agoOnly disable the one-pass DELETE optimization if the WHERE clause contains
drh [Wed, 4 May 2016 14:45:30 +0000 (14:45 +0000)] 
Only disable the one-pass DELETE optimization if the WHERE clause contains
a correlated subquery.  Uncorrelated subqueries are allowed.  This is a
refinement of check-in [3f221f592a9a1] that is the fix for
ticket [dc6ebeda9396087].

FossilOrigin-Name: aae389692a2ed2cc92151d51fb2cd5a16921c469