]>
git.ipfire.org Git - thirdparty/systemd.git/log
Jérémy Rosen [Tue, 3 Dec 2019 14:33:22 +0000 (15:33 +0100)]
Be more strict about what can be an Alias for template and instances
* Templates can only use other templates as alisases
* Template instances can use templates or things that expand with an
instance name
Lennart Poettering [Mon, 26 Aug 2019 10:06:53 +0000 (12:06 +0200)]
man: add man page for sd_bus_message_sensitive()
Topi Miettinen [Tue, 17 Dec 2019 13:47:37 +0000 (15:47 +0200)]
shared/dropin: fix assert for invalid drop-in
Don't try to show top level drop-in for non-existent units or when trying to
instantiate non-instantiated units:
$ systemctl cat nonexistent@.service
Assertion 'name' failed at src/shared/dropin.c:143, function unit_file_find_dirs(). Aborting.
$ systemctl cat systemd-journald@.service
Assertion 'name' failed at src/shared/dropin.c:143, function unit_file_find_dirs(). Aborting.
Yu Watanabe [Wed, 18 Dec 2019 02:17:59 +0000 (11:17 +0900)]
Merge pull request #14370 from poettering/homed-preparation-misc
four smaller preparation patches from the homed PR
Yu Watanabe [Wed, 18 Dec 2019 02:16:17 +0000 (11:16 +0900)]
Merge pull request #14369 from poettering/pkcs11-cryptsetup-followup
PKCS#11 cryptsetup support followup
Dimitri John Ledkov [Fri, 13 Dec 2019 23:22:51 +0000 (23:22 +0000)]
initrd: make udev cleanup service confict trigger and settle too
Otherwise, systemd-udev-trigger|settle.service that ran in the initrd may
ramain active, and never re-run again from the system root.
This is observed by forexample examining ESP with udevadm info, which in the
initrd has all the ID_* variables, and none of them in fully booted system.
Lennart Poettering [Tue, 28 May 2019 12:18:49 +0000 (14:18 +0200)]
varlink: add varlink_close_unref() helper
Lennart Poettering [Tue, 16 Apr 2019 16:44:28 +0000 (18:44 +0200)]
chown-recursive: add fd based API
Lennart Poettering [Sun, 23 Dec 2018 18:31:29 +0000 (19:31 +0100)]
chown-recursive: move src/core/chown-recursive.[ch] → src/shared/
We want to use it outside of the core, hence let's moved it to the
shared code directory.
Lennart Poettering [Fri, 22 Nov 2019 11:42:27 +0000 (12:42 +0100)]
basic: add quota-util.[ch] with some helpers for the Linux quotactl() API
Lennart Poettering [Tue, 17 Dec 2019 17:40:46 +0000 (18:40 +0100)]
cryptsetup-pkcs11: just return zero on success, no need to return anything else
Lennart Poettering [Tue, 17 Dec 2019 17:40:26 +0000 (18:40 +0100)]
cryptsetup-pkcs11: line break some overly long lines
Lennart Poettering [Tue, 17 Dec 2019 17:39:53 +0000 (18:39 +0100)]
cryptsetup-pkcs11: refuse keys above 16MiB size
Lennart Poettering [Tue, 17 Dec 2019 17:39:12 +0000 (18:39 +0100)]
man: tweaks to the crypttab(5) man page
cvoinf [Mon, 9 Dec 2019 22:28:09 +0000 (23:28 +0100)]
hwdb: assume all Medion Akoya E-models have the same matrix
Since up to now all known Akoya E* models have the same Matrix, we assume all
other Akoya E* models work the same.
Lennart Poettering [Tue, 17 Dec 2019 10:24:02 +0000 (11:24 +0100)]
man: whitespace fix
Lennart Poettering [Tue, 17 Dec 2019 16:30:55 +0000 (17:30 +0100)]
man: we support growing xfs too these days
Lennart Poettering [Tue, 17 Dec 2019 10:22:17 +0000 (11:22 +0100)]
time-util: deal with systems where userspace has 64bit time_t but kernel does not
Fixes: #14362
Lennart Poettering [Tue, 17 Dec 2019 14:30:32 +0000 (15:30 +0100)]
Merge pull request #14267 from poettering/pkcs11-cryptsetup
just the pkcs11 hookup for classic cryptsetup (/etc/crypttab) split out of the homed PR
Yu Watanabe [Tue, 17 Dec 2019 14:30:10 +0000 (23:30 +0900)]
Merge pull request #14337 from yuwata/network-tc-fq-more
network: tc: introduce more FQ settings
Anita Zhang [Tue, 17 Dec 2019 09:08:04 +0000 (01:08 -0800)]
[import] fix stdin/stdout pipe behavior in import/export tar/raw
The code existed in machinectl to use stdin/stdout if the path for
import/export tar/raw was empty or dash (-) but a check to
`fd_verify_regular` in importd prevented it from working.
Update the check instead to explicitly check for regular file or
pipe/fifo.
Fixes #14346
Yu Watanabe [Tue, 17 Dec 2019 14:10:46 +0000 (23:10 +0900)]
Merge pull request #14352 from yuwata/sd-netlink-tiny-fixes
sd-netlink: tiny fixes
Yu Watanabe [Tue, 17 Dec 2019 14:10:08 +0000 (23:10 +0900)]
Merge pull request #14208 from poettering/json-homed-prepare
json bits from homed PR
Jan Alexander Steffens (heftig) [Sat, 14 Dec 2019 22:13:17 +0000 (23:13 +0100)]
hwdb: Add Bluetooth-attached Logitech MX Master
Except for the product IDs, the original MX Master appears identical to
the MX Master 2S.
Zbigniew Jędrzejewski-Szmek [Tue, 17 Dec 2019 11:13:47 +0000 (12:13 +0100)]
Merge pull request #14360 from yuwata/udev-alternative-names-policy
udev: introduce AlternativeNamesPolicy= setting
Bart Willems [Mon, 16 Dec 2019 15:45:59 +0000 (16:45 +0100)]
systemctl: show what verbs support --dry-run in the help page
Signed-off-by: Bart Willems <bwillems@protonmail.com>
Lennart Poettering [Tue, 17 Dec 2019 09:34:43 +0000 (10:34 +0100)]
Merge pull request #14241 from keszybz/resume-timeout
Bump resume timeout to infinity
Yu Watanabe [Mon, 16 Dec 2019 09:42:25 +0000 (18:42 +0900)]
sd-netlink: add a whitespce between cast operator and variable
Yu Watanabe [Mon, 16 Dec 2019 09:40:36 +0000 (18:40 +0900)]
sd-netlink: make netlink_container_parse() takes size_t for rt_len
And use another unsigned short variable for RTA_OK() macro.
Yu Watanabe [Mon, 16 Dec 2019 15:30:38 +0000 (00:30 +0900)]
network: set AlternativeNamesPolicy= in 99-default.link
Yu Watanabe [Mon, 16 Dec 2019 14:44:42 +0000 (23:44 +0900)]
udev: introduce AlternativeNamesPolicy= setting
Yu Watanabe [Tue, 17 Dec 2019 06:32:22 +0000 (15:32 +0900)]
udev: do not fail if kernel does not support alternative names
Yu Watanabe [Tue, 17 Dec 2019 06:04:14 +0000 (15:04 +0900)]
Merge pull request #14339 from keszybz/invalid-enablement-logs
Small enhancements to logs for enabling of invalid units
Yu Watanabe [Mon, 16 Dec 2019 10:47:48 +0000 (19:47 +0900)]
random-util: call initialize_srand() after fork()
Anita Zhang [Tue, 17 Dec 2019 02:08:04 +0000 (18:08 -0800)]
Merge pull request #14351 from yuwata/util-constify-strv-xxx
util: constify arguments of strv_xxx()
Yu Watanabe [Tue, 17 Dec 2019 02:01:35 +0000 (11:01 +0900)]
udev: extend the length of ID_NET_NAME_XXX= to ALTIFNAMSIZ
Lennart Poettering [Mon, 16 Dec 2019 11:07:06 +0000 (12:07 +0100)]
efivars: properly NUL terminate EFI variables when reading
A follow-up for
35b9eb0a72b6254568a294f0ebd011da20958a64 .
Thomas Haller [Sun, 15 Dec 2019 14:50:43 +0000 (15:50 +0100)]
basic/tmpfile: avoid maybe-uninitialized warning in mkostemp_safe()
The variable is always initialized, but the compiler might not notice
that. With gcc-9.2.1-1.fc31:
$ CFLAGS='-Werror=maybe-uninitialized -Og' meson build
$ ninja -C build
[...]
../src/basic/tmpfile-util.c: In function ‘mkostemp_safe’:
../src/basic/tmpfile-util.c:76:12: error: ‘fd’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
76 | if (fd < 0)
| ^
Zbigniew Jędrzejewski-Szmek [Fri, 13 Dec 2019 18:30:00 +0000 (19:30 +0100)]
Zbigniew Jędrzejewski-Szmek [Fri, 13 Dec 2019 18:25:50 +0000 (19:25 +0100)]
shared/install: log syntax error for invalid DefaultInstance=
Ideally, we would want to report this over back over dbus. But that is pretty hard,
because the unitfile parsing logic doesn't provide any feedback.
systemd-analyze verify also doesn't notice the issue, because it doesn't look
at the [Install] section at all. Let's print a message in the logs at least.
Benjamin Dahlhoff [Sat, 14 Dec 2019 16:48:06 +0000 (17:48 +0100)]
Added Trekstor Primetab S11B
Yu Watanabe [Mon, 16 Dec 2019 09:06:33 +0000 (18:06 +0900)]
Merge pull request #14354 from poettering/link-fix
two trivial doc fixes
Lennart Poettering [Mon, 16 Dec 2019 08:50:02 +0000 (09:50 +0100)]
docs: CSS files should not be executable
Lennart Poettering [Mon, 16 Dec 2019 08:49:51 +0000 (09:49 +0100)]
github: use systemd.io links in issue template
Lennart Poettering [Mon, 16 Dec 2019 08:27:46 +0000 (09:27 +0100)]
Merge pull request #14261 from keszybz/loop-utils-and-efivars
Fixes for networkd, shared/loop-util, basic/efivars
Lennart Poettering [Mon, 16 Dec 2019 08:24:02 +0000 (09:24 +0100)]
Merge pull request #14196 from keszybz/gpt-auto-generator-debugging
gpt-auto-generator debugging
Lennart Poettering [Mon, 16 Dec 2019 08:15:23 +0000 (09:15 +0100)]
Merge pull request #14350 from yuwata/network-udev-altnames-support
network, udev: add altname support
Yu Watanabe [Mon, 16 Dec 2019 06:51:04 +0000 (15:51 +0900)]
util: constify arguments of strv_xxx()
Yu Watanabe [Sun, 15 Dec 2019 19:37:00 +0000 (04:37 +0900)]
test-network: pass environment variables to networkctl
Yu Watanabe [Sun, 15 Dec 2019 19:17:57 +0000 (04:17 +0900)]
test-network: add a test case for netdev altname
Yu Watanabe [Sun, 15 Dec 2019 19:27:27 +0000 (04:27 +0900)]
networkctl: show alternative names
Yu Watanabe [Sun, 15 Dec 2019 13:46:19 +0000 (22:46 +0900)]
network: make Name= in [Match] support alternative names of interfaces
Yu Watanabe [Sun, 15 Dec 2019 14:21:18 +0000 (23:21 +0900)]
udev: support AlternativeName= setting in .link file
Yu Watanabe [Sun, 15 Dec 2019 14:01:54 +0000 (23:01 +0900)]
util: introduce ifname_valid_full()
Yu Watanabe [Sun, 15 Dec 2019 12:48:12 +0000 (21:48 +0900)]
test: add a test for sd_netlink_message_{append,read}_strv()
Yu Watanabe [Sun, 15 Dec 2019 12:47:21 +0000 (21:47 +0900)]
sd-netlink: introduce sd_netlink_message_append_strv()
Yu Watanabe [Sun, 15 Dec 2019 12:32:25 +0000 (21:32 +0900)]
sd-netlink: introduce sd_netlink_message_read_strv()
The combination of sd_netlink_message_enter_container() and
sd_netlink_message_read_string() only reads the last element if the attribute is
duplicated, such a situation easily happens for IFLA_ALT_IFNAME.
The function introduced here reads all matched attributes.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Dec 2019 19:58:59 +0000 (20:58 +0100)]
shared/loop-util: spin on open() returning ENOENT too
https://github.com/systemd/systemd/pull/14261#discussion_r355001559
Zbigniew Jędrzejewski-Szmek [Fri, 6 Dec 2019 11:13:34 +0000 (12:13 +0100)]
basic/efivars: do not return EIO if an efivar read is shorten than fstat size
On my machine stat returns size 22, but only 20 bytes are read:
openat(AT_FDCWD, "/sys/firmware/efi/efivars/LoaderTimeInitUSec-
4a67b082 -0a4c-41cf-b6c7-
440b29bb8c4f ", O_RDONLY|O_NOCTTY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=22, ...}) = 0
read(3, "\6\0\0\0", 4) = 4
read(3, "7\0001\0001\0003\0005\0002\0007\0\0\0", 18) = 16
Failed to read LoaderTimeInitUSec: Input/output error
Let's just accept that the kernel is returning inconsistent results.
It seems to happen two only two variables on my machine:
/sys/firmware/efi/efivars/LoaderTimeInitUSec-
4a67b082 -0a4c-41cf-b6c7-
440b29bb8c4f
/sys/firmware/efi/efivars/LoaderTimeMenuUSec-
4a67b082 -0a4c-41cf-b6c7-
440b29bb8c4f
so it might be related to the way we write them.
Zbigniew Jędrzejewski-Szmek [Fri, 6 Dec 2019 10:55:20 +0000 (11:55 +0100)]
shared/efi-loader: add some debugging statements
Should make it easier to figure out why some operations fail...
Zbigniew Jędrzejewski-Szmek [Fri, 6 Dec 2019 10:35:57 +0000 (11:35 +0100)]
shared/loop-util: spin on LOOP_CTL_REMOVE
If we call LOOP_CLR_FD and LOOP_CTL_REMOVE too rapidly, the kernel cannot deal
with that (5.3.13-300.fc31.x86_64 running on dual core
Intel(R) Core(TM) i7-6500U CPU @ 2.50GHz).
$ sudo strace -eioctl build/test-dissect-image /tmp/foobar3.img
ioctl(3, TCGETS, 0x7ffcee47de20) = -1 ENOTTY (Inappropriate ioctl for device)
ioctl(4, LOOP_CTL_GET_FREE) = 9
ioctl(5, LOOP_SET_FD, 3) = 0
ioctl(5, LOOP_SET_STATUS64, {lo_offset=0, lo_number=0, lo_flags=LO_FLAGS_READ_ONLY|LO_FLAGS_AUTOCLEAR|LO_FLAGS_PARTSCAN, lo_file_name="", ...}) = 0
ioctl(5, BLKGETSIZE64, [
299999744 ]) = 0
ioctl(5, CDROM_GET_CAPABILITY, 0) = -1 EINVAL (Invalid argument)
ioctl(5, BLKSSZGET, [512]) = 0
Waiting for device (parent + 0 partitions) to appear...
Found root partition, writable of type btrfs at #-1 (/dev/block/7:9)
ioctl(5, LOOP_CLR_FD) = 0
ioctl(3, LOOP_CTL_REMOVE, 9) = -1 EBUSY (Device or resource busy)
Failed to remove loop device: Device or resource busy
This seems to be clear race condition, and attaching strace is generally enough
to "win" the race. But even with strace attached, we will fail occasionally.
Let's wait a bit and retry. With the wait, on my machine, the second attempt
always succeeds:
...
Found root partition, writable of type btrfs at #-1 (/dev/block/7:9)
ioctl(5, LOOP_CLR_FD) = 0
ioctl(3, LOOP_CTL_REMOVE, 9) = -1 EBUSY (Device or resource busy)
ioctl(3, LOOP_CTL_REMOVE, 9) = 9
+++ exited with 0 +++
Without the wait, all 64 attempts will occasionally fail.
Zbigniew Jędrzejewski-Szmek [Fri, 6 Dec 2019 10:10:10 +0000 (11:10 +0100)]
shared/loop-util: fix error handling in loop_device_make_full()
The function no longer returns the fd. This complicated semantics, because it
wasn't clear what holds the ownership: the return value or the output
parameter. There were no users of the fd in the return value, so let's
simplify things conceptually and only return the fd once.
Reduce the scope of variables.
LOOP_CLR_FD was called on the wrong fd. Let's use a cleanup function to make
this automatic and reduce chances of a mixup in the future.
CID
1408498 .
Yu Watanabe [Sun, 15 Dec 2019 11:57:51 +0000 (20:57 +0900)]
sd-netlink: support IFLA_PROP_LIST and IFLA_ALT_IFNAME attributes
Yu Watanabe [Sun, 15 Dec 2019 11:25:25 +0000 (20:25 +0900)]
linux: update headers
Jin Park [Sun, 15 Dec 2019 03:10:51 +0000 (12:10 +0900)]
Add Acer Spin 1 SP111-33 to sensor hwdb
Hans de Goede [Fri, 13 Dec 2019 12:01:02 +0000 (13:01 +0100)]
hwdb: Add accel orientation quirk for Thundersoft TST168 tablet
Add a quirk to fix the accelerometer orientation on the Thundersoft
TST168 tablet.
Yu Watanabe [Fri, 13 Dec 2019 12:12:41 +0000 (21:12 +0900)]
test-network: add a test case for new FQ settings
Zbigniew Jędrzejewski-Szmek [Fri, 13 Dec 2019 17:36:29 +0000 (18:36 +0100)]
shared/install: provide a nicer error message for invalid WantedBy=/Required= values
$ build/systemctl --user cat badinstall
# /home/zbyszek/.config/systemd/user/badinstall.service
[Service]
ExecStart=true
[Install]
WantedBy=asdf
$ build/systemctl --user enable badinstall
Failed to enable unit: "asdf" is not a valid unit name.
Fixes #4209.
Zbigniew Jędrzejewski-Szmek [Fri, 13 Dec 2019 17:42:54 +0000 (18:42 +0100)]
shared/install: remove duplicated check
install_info_add() does the exact same check.
Yu Watanabe [Fri, 13 Dec 2019 11:55:33 +0000 (20:55 +0900)]
network: tc: add more settings for FQ
Lennart Poettering [Thu, 12 Dec 2019 16:05:21 +0000 (17:05 +0100)]
nspawn: fix overlay with automatic temporary tree
This makes --overlay=+/foobar::/foobar work again, i.e. where the middle
parameter is left out. According to the documentation this is supposed
to generate a temporary writable work place in the midle. But it
apparently never did. Weird.
Tobias Bernard [Fri, 13 Dec 2019 11:01:59 +0000 (12:01 +0100)]
Merge pull request #14333 from poettering/markdown-header-fixes
docs: make sure there's only one # markdown header in each file
Lennart Poettering [Fri, 13 Dec 2019 10:56:08 +0000 (11:56 +0100)]
docs: make sure there's only one # markdown header in each file
@bertob wants us to be strict here, and only have one "#" header per
markdown file, and use "##" (or "###", …) for all others. Interestingly,
we mostly got this right already, but this fixes a few cases where this
wasn't correct.
Lennart Poettering [Thu, 12 Dec 2019 13:18:26 +0000 (14:18 +0100)]
blockdev-util: rework get_block_device()
Let's open the specified path once, and use the same fd for all lookups.
Also, don't check for btrfs twice.
The behaviour remains unmodified.
Yu Watanabe [Fri, 13 Dec 2019 09:33:04 +0000 (18:33 +0900)]
Merge pull request #13915 from ddstreet/ipv6_mtu
Set ipv6 mtu after link-up or device mtu change
Yu Watanabe [Fri, 13 Dec 2019 02:09:36 +0000 (11:09 +0900)]
Merge pull request #14320 from yuwata/network-tc-fq_codel-more
network: tc: introduce more FQ-CoDel settings
Lennart Poettering [Thu, 12 Dec 2019 23:05:38 +0000 (00:05 +0100)]
Merge pull request #14269 from DaanDeMeyer/enable-mounts-on-root
nspawn: Enable specifying root as the mount target directory.
Daan De Meyer [Thu, 12 Dec 2019 19:18:37 +0000 (20:18 +0100)]
nspawn-mount: Use FLAGS_SET to check flags.
Daan De Meyer [Sat, 7 Dec 2019 11:43:39 +0000 (12:43 +0100)]
nspawn: Only bind-mount directory when necessary.
Daan De Meyer [Sat, 7 Dec 2019 10:59:59 +0000 (11:59 +0100)]
nspawn-mount: Remove unused parameters
Daan De Meyer [Fri, 6 Dec 2019 21:45:14 +0000 (22:45 +0100)]
nspawn: Enable specifying root as the mount target directory.
Fixes #3847.
Christian Ehrhardt [Thu, 12 Dec 2019 12:37:27 +0000 (13:37 +0100)]
test: increase qemu timeout for TEST-08 and TEST-09
These tests two have shown to be flaky in Ubuntu test infrastructure,
but got more reliable with increased timeouts of 300 seconds each.
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Shengjing Zhu [Sun, 8 Dec 2019 19:00:01 +0000 (03:00 +0800)]
nspawn: allow combination of private-network and network-namespace-path
Fixes: #14289
Lennart Poettering [Thu, 12 Dec 2019 16:52:09 +0000 (17:52 +0100)]
Merge pull request #14321 from yuwata/network-generator-14319
network-generator: allow empty hostname
Yu Watanabe [Thu, 12 Dec 2019 09:22:09 +0000 (18:22 +0900)]
test-network: add a test case for the new settings of FQ-CoDel
Yu Watanabe [Thu, 12 Dec 2019 08:25:29 +0000 (17:25 +0900)]
network: tc: support more attributes for FQ-CoDel
Yu Watanabe [Thu, 12 Dec 2019 12:16:38 +0000 (21:16 +0900)]
Merge pull request #14305 from ssahani/tc-fq
network tc: inroduce FQ - Fair Queue traffic policing
Yu Watanabe [Thu, 12 Dec 2019 10:02:25 +0000 (19:02 +0900)]
test: add a test case for network-generator
Yu Watanabe [Thu, 12 Dec 2019 10:01:21 +0000 (19:01 +0900)]
network-generator: allow empty hostname
Fixes #14319.
Yu Watanabe [Thu, 12 Dec 2019 07:29:23 +0000 (16:29 +0900)]
test-network: add a test case for FQ
Susant Sahani [Wed, 11 Dec 2019 09:52:51 +0000 (10:52 +0100)]
network tc: inroduce FQ - Fair Queue traffic policing
Please see http://man7.org/linux/man-pages/man8/tc-fq.8.html
Yu Watanabe [Thu, 12 Dec 2019 08:04:06 +0000 (17:04 +0900)]
Merge pull request #14308 from poettering/man-naming-scheme-typo
superficial fixes to network naming docs
Yu Watanabe [Thu, 12 Dec 2019 07:21:49 +0000 (16:21 +0900)]
sd-netlink: add attributes for FQ
Yu Watanabe [Thu, 12 Dec 2019 06:55:11 +0000 (15:55 +0900)]
Merge pull request #14309 from yuwata/network-tc-vtable
network: tc: introduce QDiscVTable
Anita Zhang [Wed, 11 Dec 2019 21:49:01 +0000 (13:49 -0800)]
Merge pull request #14307 from poettering/unicode-fuckup
locale-util: drop weird invisible unicode codepoints accidentally ins…
Anita Zhang [Wed, 11 Dec 2019 21:35:22 +0000 (13:35 -0800)]
Merge pull request #14317 from poettering/hwdb-indent-fix
hwdb: trivial indentation fix
Lennart Poettering [Tue, 10 Dec 2019 20:30:39 +0000 (21:30 +0100)]
locale-util: drop weird invisible unicode codepoints accidentally inserted in comment
Lennart Poettering [Wed, 11 Dec 2019 20:35:33 +0000 (21:35 +0100)]
hwdb: trivial indentation fix
Tobias Bernard [Wed, 11 Dec 2019 16:19:14 +0000 (17:19 +0100)]
minor: avoid double title
The logo and H1 were clashing a bit
Tobias Bernard [Wed, 11 Dec 2019 16:01:46 +0000 (17:01 +0100)]
docs: make it pretty
Add custom Jekyll theme, logo, webfont and .gitignore
FIXME: the markdown files have some H1 headers which need to be replaced
with H2